> Fine with me. I've been busy with other things and waiting for you and
> Alan to decide what should be done for the reset stuff anway :-)
>
> So Alan, do you think we should add something or do you think that just
> reading altstat like ata_pause does is good enough ?
Reading altstat is unnecce
On Fri, 2007-05-25 at 00:41 -0400, Jeff Garzik wrote:
> Sorry, to be clear I would not want to change the core code to bang
> AltStatus in the middle of the SRST twiddles...
>
> The core code only fails (in theory) for PATA+MMIO cases, and the
> easiest fix should be to read some innocuous vendo
Benjamin Herrenschmidt wrote:
On Fri, 2007-05-25 at 00:26 -0400, Jeff Garzik wrote:
Just replace the ata_std_softreset() call with code that does MMIO
flushes on a safe register?
Yeah well... if just reading altstatus is enough, I don't see the point
of doing anything MMIO-dependant or whateve
On Fri, 2007-05-25 at 00:26 -0400, Jeff Garzik wrote:
> Just replace the ata_std_softreset() call with code that does MMIO
> flushes on a safe register?
Yeah well... if just reading altstatus is enough, I don't see the point
of doing anything MMIO-dependant or whatever. I can just add reading of
Benjamin Herrenschmidt wrote:
On Thu, 2007-05-24 at 23:33 -0400, Jeff Garzik wrote:
I moved the sil680 MMIO changes from 'upstream' (queued for 2.6.23) to
a
side branch 'sil680-mmio'.
To be clear, I am still quite interested in the patch (w/ the reset
fix), but I did not want to delay other
On Thu, 2007-05-24 at 23:33 -0400, Jeff Garzik wrote:
> I moved the sil680 MMIO changes from 'upstream' (queued for 2.6.23) to
> a
> side branch 'sil680-mmio'.
>
> To be clear, I am still quite interested in the patch (w/ the reset
> fix), but I did not want to delay other unrelated stuff that w
I moved the sil680 MMIO changes from 'upstream' (queued for 2.6.23) to a
side branch 'sil680-mmio'.
To be clear, I am still quite interested in the patch (w/ the reset
fix), but I did not want to delay other unrelated stuff that was about
to be queued into #upstream.
The patch will still app