Gaston, Jason D wrote:
At this time, I don't have any way to test those particular DeviceID's
and I know that the AHCI mode DeviceID works by using the class code
support. So, I would like to just leave them at they are, if that is
ok.
Fine by me... Overall I'll follow vendor's best advice
Alan Cox wrote:
You'd have to add the drain data on error hack first, right now we will
reset in that case (which for one or two devices has another problem in
that it won't clear a stuck FIFO)
Nod. There was nothing ever wrong with Mark's drain patch, I just never
saw a solid justification
Matthew Wilcox wrote:
Can you tell me a bit more about these drivers? Would it be possible to
convert them to one host/many channels, which would give us the exclusion
we want?
As a tangent, I would prefer a more natural representation than
current, where there is a 1-1 correspondence
):
ata_piix: disallow UDMA 133 on ICH5 ICH7
Jeff Garzik (4):
[libata] pdc_adma: convert to new exception handling (EH) framework
[libata] Remove -irq_ack() hook, and ata_dummy_irq_on()
[libata] Remove -port_disable() hook
[libata] ata_piix: Use more-robust form of array
Tejun Heo wrote:
dev-horkage should be cleared over device hotunplug/plug. Clear it
in ata_dev_init().
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-core.c |1 +
1 file changed, 1 insertion(+)
applied
-
To unsubscribe from this list: send the line unsubscribe
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/libata-core.c |1 +
drivers/ata/pata_it821x.c |4
drivers/ata/pata_via.c | 14 +++---
Bartlomiej Zolnierkiewicz wrote:
Please pull from:
master.kernel.org:/pub/scm/linux/kernel/git/bart/ide-2.6.git/
to receive the following updates:
drivers/ata/pata_ali.c |7 ++
drivers/ide/Kconfig|4 +-
drivers/ide/ide-iops.c |3 +-
Kantor Zsolt wrote:
HDIO_DRIVE_TASKFILE is not supported in libata ? and if not then which was the
last version of
libata that supported the HDIO_DRIVE_TASKFILE command in which kernel ?
libata has never supported HDIO_DRIVE_TASKFILE.
You want to use SG_IO.
Jeff
-
To unsubscribe
Shaohua Li wrote:
ACPI spec (ver 3.0a, p289) requires IDE power on/off executes ACPI _PSx
methods. As recently most PATA drivers use libata, this patch adds _PSx
method support in libata. ACPI spec doesn't mention if SATA requires the
same _PSx method, but executing _PSx for SATA should be ok I
Kantor Zsolt wrote:
Can be executed a SG_IO command for a ATA hard drive ? because I have tried
everything. I have
Yes.
supported or SG_IO which is not working like HDIO_DRIVE_TASKFILE
SG_IO requires a vastly different format than HDIO_DRIVE_TASKFILE. Read
the sg documentation, and
Andrew Morton wrote:
Begin forwarded message:
Date: Fri, 07 Sep 2007 12:57:14 -0500
From: Sumanth J.V [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Subject: Spurious completions during NCQ
I keep seeing this message a few times a day on my box.
ata1.00: exception Emask 0x2 SAct 0x18 SErr 0x0
Mark Lord wrote:
Jeff Garzik wrote:
Mark Lord wrote:
Ditto for selecting transfer modes.
Waiting on one thing AFAICS:
ability to drain/idle all ports +
issue a command on one port +
resume normal parallel port operation
SET FEATURES - XFER MODE is special in that it requires
Tejun Heo wrote:
[cc'ing Albert and linux-ide]
Alan Cox wrote:
/from the media. */
+ if (qc-nbytes 2048)
+ return -EOPNOTSUPP;
+
/* No ATAPI DMA in smart mode */
if (itdev-smart)
return -EOPNOTSUPP;
This looks like a gross hack. Aren't you supposed to
Alan Cox wrote:
Purely a stylistic issue currently but best done while I notice it.
Signed-off-by: Alan Cox [EMAIL PROTECTED]
diff -u --exclude-from /usr/src/exclude --new-file --recursive
linux.vanilla-2.6.23rc6-mm1/drivers/ata/pata_acpi.c
linux-2.6.23rc6-mm1/drivers/ata/pata_acpi.c
---
Alan Cox wrote:
Signed-off-by: Alan Cox [EMAIL PROTECTED]
applied first two chunks to #upstream-fixes
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Alan Cox wrote:
Code moved to ioread/iowrite but the comment didn't
Also note a posting issue
Signed-off-by: Alan Cox [EMAIL PROTECTED]
diff -u --exclude-from /usr/src/exclude --new-file --recursive
linux.vanilla-2.6.23rc6-mm1/drivers/ata/libata-sff.c
Fixes from Alan, PCI IDs from ATI/AMD.
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/ahci.c| 10 ++
drivers/ata/libata-core.c |4
: Jeff Garzik [EMAIL PROTECTED]
Date: Thu Sep 20 16:31:47 2007 -0400
[libata] blacklist Maxtor*BANC* using new wildcard blacklist matching
Support the use of '*' in model_num and model_rev entries
in ata_device_blacklist[].
Based largely on David Milburn's libata-core
Alan Cox wrote:
Signed-off-by: Alan Cox [EMAIL PROTECTED]
applied
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Alan Cox wrote:
Some iomap functions were still using readl/writel and friends which
happens to work on most platforms but is not correct.
Signed-off-by: Alan Cox [EMAIL PROTECTED]
applied
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to
Alan Cox wrote:
In theory this isn't needed. In practice it seems to matter now and then
and was also done by the old IDE DMA layer.
Signed-off-by: Alan Cox [EMAIL PROTECTED]
applied a modified version (attached)
commit 8dcab000d7a3b114a3434129d1d6437263835c87
Author: Jeff Garzik [EMAIL
Alan Cox wrote:
- Fix those which require a word is checked for validity
- Note limits on version information with ancient ATA
- Correct EIDE dword_io check ready for adding 32bit PIO
Signed-off-by: Alan Cox [EMAIL PROTECTED]
any update on this?
I definitely agree we should be checking the
Alan Cox wrote:
This will allow us to handle the tape drive problems Mark Lord reported
Signed-off-by: Alan Cox [EMAIL PROTECTED]
According to information I have received, some ATA (and possibly ATAPI?)
devices intentionally return some data in these cases. In the case of
certain ATA
Jason Gaston wrote:
This patch removes some incorrect formatting spaces and replaces them with tabs.
Signed-off-by: Jason Gaston [EMAIL PROTECTED]
applied
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info
Tejun Heo wrote:
Move ata_id_n_sectors() upward right below ata_id_c_string(). This is
to accomodate later changes.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-core.c | 30 +++---
1 files changed, 15 insertions(+), 15 deletions(-)
applied 1-3
Tejun Heo wrote:
Reimplement port_map handling such that
1. Non-zero PORTS_IMPL value is always examined and used if consistent
with cap.n_ports.
2. When PI and cat.n_ports are inconsistent, honor cap.n_ports and
force port_map to be ((1 cap.n_ports) - 1).
3. There were two separate
Tejun Heo wrote:
Make ata_dev_try_classify() take a pointer to ata_device instead of
ata_port/port_number combination for consistency and add @present
argument. @present indicates whether the device seems present during
reset. It's the result of TF access during softreset and link
onlineness
Jason Gaston wrote:
Resend trying to remove 8-bit characters in the email.
This patch adds the Intel Tolapai RAID controller DID's for SATA support.
Signed-off-by: Jason Gaston [EMAIL PROTECTED]
--- linux-2.6.23-rc4/drivers/ata/ahci.c.orig2007-08-27 18:32:35.0
-0700
+++
Alan Cox wrote:
Ok this is a different approach to handling it - knowing it is an off by
one so we can handle the drive if clipped
Signed-off-by: Alan Cox [EMAIL PROTECTED]
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.23rc1-mm1/drivers/ata/libata-core.c
Shaohua Li wrote:
ACPI spec (ver 3.0a, p289) requires IDE power on/off executes ACPI _PSx
methods. As recently most PATA drivers use libata, this patch adds _PSx
method support in libata. ACPI spec doesn't mention if SATA requires the
same _PSx method, but executing _PSx for SATA should be ok I
Matthew Garrett wrote:
Modern laptops with hotswap bays still tend to utilise a PATA interface
on a SATA bridge, generally with the host controller in some legacy
emulation mode rather than AHCI. This means that the existing hotplug
code in libata is unable to work. The ACPI specification
[EMAIL PROTECTED] wrote:
From: Kuan Luo [EMAIL PROTECTED]
Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA
controller. NCQ function is disable by default, you can enable it with
'swncq=1'. NCQ will be turned off if the drive is Maxtor on MCP51 or MCP55
rev 0xa2 platform.
commit a6d5ac6a3a1cfbed2a045928bbadd5285f1df084
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Fri Sep 21 05:07:19 2007 -0400
[libata] SCSI: support INQUIRY page 89h (ATA info page)
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
drivers/ata/libata-scsi.c | 82
commit 8a7a20fb60d9746ec68a876aade1f14c4f2b7b46
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Fri Sep 21 06:23:42 2007 -0400
[libata] Slightly improved no-op REQUEST SENSE, SEND DIAGNOSTIC
A few pedantic apps care about missing or lame mandatory SCSI
commands, so
Alan Cox wrote:
REQUEST SENSE -- as we autosense, R.S. just returns zeroes
SEND DIAGNOSTIC -- our default (no-op) self-test succeeds, all
other requests for testing fail.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
Acked-by: Alan Cox [EMAIL PROTECTED
As per SAT (sans removable devices)...
commit 09d9637c413406cf63f0e1efb364411ac8a9243c
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Fri Sep 21 07:09:36 2007 -0400
[libata] SCSI: simple TEST UNIT READY simulation
It's trivial to ping the device, and that's a much more sane
commit ee67edb0e7701f8ae9114692837a8bbee9f99a35
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Fri Sep 21 07:26:08 2007 -0400
[libata] SCSI: improve FORMAT UNIT; minor code cleanups
* SAT specifies that FORMAT UNIT should be translated into a series
of READ and WRITE commands
commit 14052d9ba16b826e4bc79db4b2b77e451faf0b01
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Fri Sep 21 07:54:49 2007 -0400
[libata] SCSI: clean up R/W recovery mode page
Clear ARRE, we don't do auto-reallocation on reads, just on writes.
Also, hardcode the size
James Bottomley wrote:
On Fri, 2007-09-21 at 05:48 -0400, Jeff Garzik wrote:
commit a6d5ac6a3a1cfbed2a045928bbadd5285f1df084
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Fri Sep 21 05:07:19 2007 -0400
[libata] SCSI: support INQUIRY page 89h (ATA info page)
Signed-off-by: Jeff
Alan Cox wrote:
On Thu, 20 Sep 2007 16:47:16 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
Alan Cox wrote:
In theory this isn't needed. In practice it seems to matter now and then
and was also done by the old IDE DMA layer.
Signed-off-by: Alan Cox [EMAIL PROTECTED]
applied a modified version
James Bottomley wrote:
On Fri, 2007-09-21 at 05:48 -0400, Jeff Garzik wrote:
commit a6d5ac6a3a1cfbed2a045928bbadd5285f1df084
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Fri Sep 21 05:07:19 2007 -0400
[libata] SCSI: support INQUIRY page 89h (ATA info page)
Signed-off-by: Jeff
Ditched ATAPI, fixed a bug, a few clean-ups and fixmes taken care of.
commit a1c69f03a85fe6fa1b7f2f3726dd7205eb68a328
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Fri Sep 21 20:38:03 2007 -0400
[libata] SCSI: support INQUIRY page 89h (ATA info page)
Signed-off-by: Jeff Garzik
Jeff Garzik wrote:
+ memcpy(pbuf[8], ATA , 8);
+ ata_id_string(args-id, pbuf[16], ATA_ID_PROD, 16);
+ ata_id_string(args-id, pbuf[32], ATA_ID_FW_REV, 4);
And I just checked in a fix that changes the above to reflect the SCSI
simulator's vendor/product/version (linux
Kristen Carlson Accardi wrote:
On Tue, 25 Sep 2007 01:12:32 +0200
roel [EMAIL PROTECTED] wrote:
#define ata_id_cdb_intr(id)(((id)[0] 0x60) == 0x20)
+#define ata_id_has_hipm(id)\
+ ( (((id)[76] != 0x) ((id)[76] != 0x)) \
+ ((id)[76] (1 9)) )
Peer Chen wrote:
Add the ahci controller legacy mode support to sata_nv.
Move the DIDs of legacy mode from ahci.c to sata_nv.c
The patch base on kernel 2.6.23-rc8
Signed-off-by: Peer Chen [EMAIL PROTECTED]
I don't understand why these are being moved?
If an interface can be driven via the
Peer Chen wrote:
We have three mode for one controller - IDE/RAID/AHCI, we want sata_nv being
load when user select the IDE mode in BIOS, load ahci driver if RAID/AHCI being
selected, which will verify if our legacy mode work well and have additional
option if there is any
bug for the ahci
Raz wrote:
Is there a way to know whether a disk is sata 1 2 or 3 ?
That is a marketing invention.
At a technical level, there is no such thing as sata 1, 2, or 3.
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL
Robert Hancock wrote:
ATA spec says The device shall return command aborted if the device
does not support the Power Management feature set. Whereas TEST UNIT
READY is required for SCSI. It seems the SAT authors didn't consider
this case.
Dumb me -- I misread that as mandatory.
Berck E. Nash wrote:
Jeff Garzik wrote:
Once the blame has been squared fixed upon me :) you can use git-bisect
to locate the precise change that broke your setup.
Okay, here's the problem:
268fe6f9f15551be9abedd44a237392675d529d5 is first bad commit
commit
Tejun Heo wrote:
sis_66_set_dmamode() also handles early UDMA100 (SIS630 ET) but is
missing udma timing value for UDMA100. According to sis5513, this
should be 0x8000. This caused UDMA100 device to fail on pata_sis till
it downgrades to UDMA66 while it works fine on sis5513 at UDMA100.
Tejun Heo wrote:
When PCIX_IRQ_WOC is used, sil24 has an inherent race condition
between clearing IRQ pending and reading IRQ status. If IRQ pending
is cleared after reading IRQ status, there's possibility of lost IRQ.
If IRQ pending is cleared before reading IRQ status, spurious IRQs
will
Here's one thing that jumps out at me, reviewing the PMP patchset:
PMP reads and writes require polling, which is not something we should
impose upon the design. Conversations with a port multiplier are
fundamentally packetized, and modern controllers treat these just like
the bazillion
Jeff Garzik wrote:
Just like the Linux kernel MM platform API presents 3 levels of page
table entries, even when the hardware may only have 2, libata high level
API _must_ be implemented as 100% asynchronous event driven API.
To be more clear, non-taskfile packets/commands should
Tejun Heo wrote:
Update AN support in preparation of PMP support.
* s/ata_id_has_AN/ata_id_has_atapi_AN/
* add AN enabled reporting during configuration
* add err_mask to AN configuration failure reporting
* update LOCKING comment for ata_scsi_media_change_notify()
* check whether ATA dev is
Tejun Heo wrote:
The SATA_PATA_SHARING register doesn't have anything to do with the
SATA part of the controller. It indicates whether an extern SATA PHY
is attached to the PATA part of the controller and if so how it is
wired. As the PATA part is driven by pata_via, sata_via has no reason
to
Tejun Heo wrote:
In ata_set_max_sectors(), the highest nibble in LBA28 mode was
missing. This made drives sized between 8G and 128G with HPA turned
on to be resized to under 8G. Fix it.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
This one fixes my dumb mistake.
drivers/ata/libata-core.c
Berck E. Nash wrote:
Jeff Garzik wrote:
Does the attached patch change behavior at all? You should be able to
apply it on top of libata-dev.git#upstream or -mm.
Still broken, dmesg with ATA_DEBUG defined, attached.
Great, this will be useful output. It will probably be a couple days
Alan Cox wrote:
It converts several macros to inline functions (encouraged), and also
illustrates a nice, clean way of testing an ID word's validity.
[obviously the final implementation varies, depending on that ID word's
history]
Its in -mm and I thought you put a copy in your tree after I
Satyam Sharma wrote:
Hi,
On Thu, 20 Sep 2007, Alan Cox wrote:
On Thu, 20 Sep 2007 14:13:15 +0100
[EMAIL PROTECTED] (Mel Gorman) wrote:
PPC64 building allmodconfig fails to compile drivers/ata/pata_scc.c . It
doesn't show up on other arches because this driver is specific to the
Zoltan Boszormenyi wrote:
Hi,
Jeff Garzik írta:
[EMAIL PROTECTED] wrote:
From: Kuan Luo [EMAIL PROTECTED]
Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA
controller. NCQ function is disable by default, you can enable it with
'swncq=1'. NCQ will be turned off
*/
+writel(HOST_AHCI_EN, mmio + HOST_CTL);
+(void) readl(mmio + HOST_CTL); /* flush */
applied the attached patch, inspired by yours.
commit 5fca365d6109b51cfeb3515ca660cd2dc6e8822c
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Wed Sep 26 00:02:41 2007 -0400
[libata] AHCI: enable AHCI
Would it also be possible for you to send along 'hdparm --Istdout'
output for your config disk thingy, /dev/sdd ?
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/pata_sis.c |3 ++-
drivers/ata/sata_sil24.c | 16
2 files changed, 14 insertions(+), 5
Zoltan Boszormenyi wrote:
Jeff Garzik írta:
Zoltan Boszormenyi wrote:
Hi,
Jeff Garzik írta:
[EMAIL PROTECTED] wrote:
From: Kuan Luo [EMAIL PROTECTED]
Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA
controller. NCQ function is disable by default, you can enable
Alan Cox wrote:
On Wed, 26 Sep 2007 00:03:19 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
Peer Chen wrote:
According to the description of section 5.2.2.1 and 10.1.2 of AHCI
specification rev1_1/rev1_2, GHC.HR shall only be set to ¡®1¡¯
by software when GHC.AE is set to ¡®1¡¯.
Signed-off
Alan Cox wrote:
NAK - mmio is an iomap so writel and readl are the wrong things to use
The patch is consistent with the rest of the driver.
You are welcome to submit a patch to convert ahci to using ioremap.
You could just flip the relevant function to use ioread while you are
tidying it up,
Alan Cox wrote:
On Wed, 26 Sep 2007 10:33:28 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
Alan Cox wrote:
NAK - mmio is an iomap so writel and readl are the wrong things to use
The patch is consistent with the rest of the driver.
You are welcome to submit a patch to convert ahci to using
Kuan Luo wrote:
hi,
i saw the below changes from
http://git.kernel.org/?p=linux/kernel/git/jgarzik/libata-dev.git;a=commi
tdiff;h=5a5a9e1890b8260686218a68862d880daee1a817
[libata] sata_nv: Clean up ATA_FLAG_NCQ usage; bit test micro-opt
@@ -622,7 +622,9 @@ static const struct ata_port_info
Kuan Luo wrote:
Jeff Garzik wrote:
Kuan Luo wrote:
hi,
i saw the below changes from
http://git.kernel.org/?p=linux/kernel/git/jgarzik/libata-dev.g
it;a=commi
tdiff;h=5a5a9e1890b8260686218a68862d880daee1a817
[libata] sata_nv: Clean up ATA_FLAG_NCQ usage; bit test micro-opt
@@ -622,7
Tejun Heo wrote:
Alan Cox wrote:
I think there have been enough cases where this draining was necessary.
IIRC, ata_piix was involved in those cases, right? If so, can you
please submit a patch which applies this only to affected controllers?
I don't feel too confident about applying this to
Tejun Heo wrote:
Jeff Garzik wrote:
[--snip--]
There, even the concept of port is fluid, and the libata EH model of
freezing and thawing a port (with the desired irq-off result) just
doesn't fit the hardware.
Well, the current model was developed while struggling with the first
generation PMP
Tejun Heo wrote:
Jeff Garzik wrote:
Is this NACK on the patchset or can we update PMP access later?
Sorry, yes, it is a NAK: polling should not be requirement.
I considered making multi-protocol -qc_issue() a requirement too, but
that seemed like it might delay things too much. But consider
Alan Cox wrote:
Aieee... Another merge delay. I wish the review process proceeded a bit
swifter. The patchset has been around literally for years now and
submitted for review six times if I have the take number right. :-(
Agreed - thats one reason I stick everything in -mm. Its taking
Alan Cox wrote:
This doesn't affect Tejun or anyone else really, but going through -mm
tends to gum up the works. Your patches wind up not applying to
libata#upstream, in which case they get dropped and I assume Andrew or
someone will resend usable versions.
Its the only way to get testing
Mark Lord wrote:
Jeff Garzik wrote:
..
As such, polling is simply an outmoded concept. It does not make
sense on new hardware, and forcing design decisions down that path
only lead to a cascade of similar design decisions -- pmp_read polling
being just one example of such a result
Martin Michlmayr wrote:
* Alan Cox [EMAIL PROTECTED] [2007-09-28 11:14]:
I need this patch for IDE and PATA to work on my MIPS Cobalt.
Yoichi's original patch and explanation can be found at
http://lkml.org/lkml/2007/8/23/411
I've no idea why it hasn't been applied unless nobody is quite sure
May Cheung wrote:
Hi Jeff,
We're currently using 2.6.10 and tries to bring up an HP box which has ICH9.
The earliest libata patch available for ICH9 support seems to be 2.6.19.
The libata directory and file structures between 2.6.10 and 2.6.19 are quite
different.
Is there anyway we can
Tejun Heo wrote:
Alan Cox wrote:
Restore the support for handling drives that report one sector too many
(ie SCSI not ATA style). This worked before the HPA update but was
removed in that process
Signed-off-by: Alan Cox [EMAIL PROTECTED]
Acked-by: Tejun Heo [EMAIL PROTECTED]
diff -u
Alan Cox wrote:
Drain up to 512 words from host/bridge FIFO on stuck DRQ HSM violation,
rather than just getting stuck there forever.
Why 512 words ?
Though I have queued Mark's patch to be applied, my gut feeling would
lean towards a single DRQ block, rather than 512.
Martin Michlmayr wrote:
* Jeff Garzik [EMAIL PROTECTED] [2007-09-28 06:23]:
Yoichi's original patch and explanation can be found at
http://lkml.org/lkml/2007/8/23/411
I've no idea why it hasn't been applied unless nobody is quite sure who
owns it. As a PCI fix I guess Greg does (and drop
Alan Cox wrote:
Jeff, seeing as Tejun's commitment is never in doubt here,
I really believe we should go with the existing PMP patchset
for 2.6.24 (unless the respin happens quickly enough).
This functionality is way overdue, and we shouldn't be impeding it
as long as we have been.
I would
Mark Lord wrote:
Jeff Garzik wrote:
Alan Cox wrote:
This doesn't affect Tejun or anyone else really, but going through
-mm tends to gum up the works. Your patches wind up not applying to
libata#upstream, in which case they get dropped and I assume Andrew
or someone will resend usable
(my last response only addressed -mm)
Mark Lord wrote:
I believe the point was that getting things into libata is glacial
IMHO would say that there are two causes of that:
1) I am sometimes slow in merging, part of which is my own fault, and I
can only promise to try and do better there.
Andrew Morton wrote:
On Fri, 28 Sep 2007 23:29:44 -0400 Jeff Garzik [EMAIL PROTECTED] wrote:
(my last response only addressed -mm)
Mark Lord wrote:
I believe the point was that getting things into libata is glacial
IMHO would say that there are two causes of that:
1) I am sometimes slow
Alan Cox wrote:
Nobody commented when I asked for review earlier so it must be ok 8)
Lets stick it in -mm to be sure
Signed-off-by: Alan Cox [EMAIL PROTECTED]
applied to libata-dev.git#for-testing
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a
Dave Jones wrote:
'noacpi' isn't a standalone parameter, give it its prefix.
Signed-off-by: Dave Jones [EMAIL PROTECTED]
applied
(though in general we should not list module parameters here, I am OK
with this one)
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
Tejun Heo wrote:
* The firmware version of ST3160812AS is 3.ADJ no 3.AD.
* Add several entries from various sources.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-core.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/libata-core.c
David Milburn wrote:
Blacklist HITACHI HDS7250SASUN500G and HITACHI HDS7225SBSUN250G
drives using wildcard matching.
Signed-off-by David Milburn [EMAIL PROTECTED]
---
libata-core.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/libata-core.c
Mark Lord wrote:
I think this original patch still applies cleanly on at least 2.6.23-rc7.
Drain up to 512 words from host/bridge FIFO on stuck DRQ HSM violation,
rather than just getting stuck there forever.
Signed-off-by: Mark Lord [EMAIL PROTECTED]
---
--- old/drivers/ata/libata-sff.c
Paolo Ornati wrote:
On Sun, 30 Sep 2007 15:29:08 +0100
Alan Cox [EMAIL PROTECTED] wrote:
Seagate Barracuda ST380817AS has troubles with NCQ. For example,
unpacking a tarball on an XFS filesystem gives this:
ata1.00: exception Emask 0x0 SAct 0x1 SErr 0x0 action 0x2 frozen
ata1.00: cmd
Paolo Ornati wrote:
On Sun, 30 Sep 2007 11:05:17 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
I have this problem only with XFS, and even with XFS it goes away
mounting with nobarrier...
This last is an interesting datapoint.
I wonder if libata has a generic problem with NCQ + FLUSH CACHE
Paolo Ornati wrote:
On Sun, 30 Sep 2007 11:43:38 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
it isn't supported here:
sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
Did you actually try my suggestion?
Yes (libata.fua=1 is ok I think, or it should
Mark Lord wrote:
Linux kernel development is supposed to happen incrementally nowadays.
Get a nice working solution in place, and then enhance/tune it.
It's not about enhancing and tuning.
It's about me (and/or James B) having to __undo__ the current code, just
to get things working on an
Daniel Schroeder wrote:
i am stuck with 2.6.22.1 because this is the latest version of your PMP
patchset...this is perfectly working but i can not apply these set
against newer versions of the kernel...could you update your homepage or
post a howto/message/link for instructions to get the
Bartlomiej Zolnierkiewicz wrote:
* Convert cmd64x, hpt366 and pdc202xx_old host drivers to use
pci_resource_start(hwif-pci_dev, 4) instead of hwif-dma_master.
Before using pci_resource_start(), the code should check
pci_resource_len() to ensure it is the appropriate size.
It would be very
Olof Johansson wrote:
Hi,
I just pulled out my Marvell 7042 SATA controller here to give it a spin
and noticed that it no longer worked (i.e. init segvs when loading from
it), etc. 2.6.22 is fine.
Bisecting (just the file drivers/ata/sata_mv.c) resulted in
Tejun Heo wrote:
Jeff Garzik wrote:
Mark Lord wrote:
Linux kernel development is supposed to happen incrementally nowadays.
Get a nice working solution in place, and then enhance/tune it.
It's not about enhancing and tuning.
It's about me (and/or James B) having to __undo__ the current code
Sergei Shtylyov wrote:
Bartlomiej Zolnierkiewicz wrote:
Stop abusing ide_lock lock (switch to a private locking).
Fixes same issue as fixed by Alan Cox in atiixp host driver with
commit 6c5f8cc33eb2e10b6ab788bbe259fc142a068627.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Mark Lord wrote:
Jeff Garzik wrote:
Tejun Heo wrote:
Jeff Garzik wrote:
Mark Lord wrote:
Linux kernel development is supposed to happen incrementally nowadays.
Get a nice working solution in place, and then enhance/tune it.
It's not about enhancing and tuning.
It's about me (and/or James B
Alan Cox wrote:
On Mon, 01 Oct 2007 17:12:03 +0400
Sergei Shtylyov [EMAIL PROTECTED] wrote:
Hello.
Alan Cox wrote:
Nobody commented when I asked for review earlier so it must be ok 8)
It's not that I've seen this before
so it must be ok 8)
Not by me at least, so let me NAK
1001 - 1100 of 1579 matches
Mail list logo
