I'm about to disappear (virtually) through Friday for vacation.
Tejun Heo has agreed to collect libata bug fix patches in my absence.
Thanks!
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Tejun Heo wrote:
Jeff Garzik wrote:
I wouldn't push it out unless it looked OK in my browser.
But overall I tend to dislike wikis. They enable collaboration, but
tend to be uniformly ugly, cumbersome, and CPU intensive.
Besides collaboration, one thing I like about wikis is that updating
Tejun Heo wrote:
These are upstream patches I collected while Jeff is away. Thanks.
* workaround for ATAPI tape drives
* detection/suspend workarounds for several laptops
* ICH8/9 port_enable fix
ata_piix controller ID reorganization is included to ease the fixes.
Please pull from
Alan Cox wrote:
Signed-off-by: Alan Cox [EMAIL PROTECTED]
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.24-rc2-mm1/drivers/ata/pata_ali.c
linux-2.6.24-rc2-mm1/drivers/ata/pata_ali.c
--- linux.vanilla-2.6.24-rc2-mm1/drivers/ata/pata_ali.c 2007-11-16
Tejun Heo wrote:
sil24 unnecessarily used LIBATA_MAX_PRD and ATAPI sg table was short
by one entry which might cause very obscure problems. This patch
updates sg table sizing such that
* One full page is used for PRB + sg table. On 4k page,
this results in 253 sg's.
* Make ATAPI sg block
Tejun Heo wrote:
Hello,
This is the second take of update-EH-speed-down-logic patchset.
Changes from the last take[1] are...
* Updated to apply build against the current linus#master. Recently
committed error-passthhrough-for-non-IO-command change broke build
with this patchset applied.
Alan Cox wrote:
Without the valid bits at least one set of TSScorp drives report 0 in
word 93 for PATA 40 wire, which we (and the specs) say actually means
SATA. (The SATA version seems to report 80 wire...)
Signed-off-by: Alan Cox [EMAIL PROTECTED]
SATA version on what controller? Have you
Tejun Heo wrote:
From: Thomas Rohwer [EMAIL PROTECTED]
ICH8M on apple macbook pro occasionally locks up completely during PCS
initialization if ports other than the first one are enabled. Add a
separate controller ID and only enable the first port.
tj: commit description added and patch
Tejun Heo wrote:
Finding out matching transfer mode from ACPI GTM values is useful for
other purposes too. Separate out the function and timing tables from
pata_acpi::pacpi_discover_modes().
Other than checking shared-configuration bit after doing
ata_acpi_gtm() in pacpi_discover_modes() which
Jeff Garzik wrote:
Tejun Heo wrote:
xfer_mask is unsigned int not unsigned long. Change -mode_filter to
take and return unsigned int.
While at it, rename @adev of ata_pci_default_filter() to @dev for
consistency.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-sff.c
Brian King wrote:
The following three patches convert ipr to use the new libata EH APIs.
In the process of doing this, I first looked into implementing this
in a similar manner to how libata SAS is done today, which is hooking
into target_alloc/target_destroy to allocate/delete sata ports. While
Tejun Heo wrote:
ICH8 and 9 use two SFF controllers to show 6 SATA ports. The first
controllre hosts the first 4 ports while the second one hosts the last
2. The PCS register of the first controller encompasses the first
four ports or all six ports depending on configuration while PCS of
the
Tejun Heo wrote:
Hello,
This patchset cleans up and improves PATA timing related code and fix
pata_amd transfer mode selection on top of the improvements. This
patchset contains the following tweleve patches.
0001-ata_generic-unindent-loop-in-generic_set_mode.patch
Tejun Heo wrote:
xfer_mask is unsigned int not unsigned long. Change -mode_filter to
take and return unsigned int.
While at it, rename @adev of ata_pci_default_filter() to @dev for
consistency.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-sff.c |5 +++--
Alan Cox wrote:
Lots of work needed to bring it up to scratch but it does work so you can
now use the card. That makes it at least useful, especially as the other
cardbus cards are usually INIC162x which aren't yet supported well.
Signed-off-by: Alan Cox [EMAIL PROTECTED]
applied #upstream
Alan Cox wrote:
Hopefully there is a better long term solution but for now lets favour
reliability.
Signed-off-by: Alan Cox [EMAIL PROTECTED]
applied #upstream-fixes
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More
Alan Cox wrote:
I believe this version meets all Sergei's objections
Correct the logic for when we issue a set features for transfer mode
- If the device has IORDY and the controller has IORDY - set the mode
- If the device has IORDY and the controller does not - turn IORDY off
- If neither
Tejun Heo wrote:
There are two bugs in disabled port handling.
* test in PORT_PATA0 is reversed
* -prereset should return -ENOENT for disabled ports not 0
The first bug makes the PATA channel considered disabled but the
second bug saves the day by returning 0. The net result is that cable
is
Sergei Shtylyov wrote:
Since writing to two reserved bits ain't much of a housekeeping, I think it's
time we get rid of the custom error handler in this driver. ;-)
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]
---
Oops, somehow I've managed to send a stale patch, without a version
Robert Hancock wrote:
Based on a quick look at sata_mv it appears it sets a 64-bit DMA mask
unconditionally, but for non-ATA_PROT_DMA commands (which includes all
ATAPI), it just falls back to ata_qc_issue_prot which issues via the
legacy SFF interface and can only handle 32-bit addressing. So
Alan Cox wrote:
Jeff said he preferred that the SFF tf_load followed the spec and we
documented that anyone who needed different overrode it, rather than it
using the -check_status methods. No driver relies on the current behaviour.
Signed-off-by: Alan Cox [EMAIL PROTECTED]
diff -u --new-file
Alan Cox wrote:
Signed-off-by: Alan Cox [EMAIL PROTECTED]
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.24-rc2-mm1/drivers/ata/pata_pcmcia.c
linux-2.6.24-rc2-mm1/drivers/ata/pata_pcmcia.c
--- linux.vanilla-2.6.24-rc2-mm1/drivers/ata/pata_pcmcia.c
Alan Cox wrote:
Should use ioread* as discussed previously
Signed-off-by: Alan Cox [EMAIL PROTECTED]
applied to #upstream-fixes, after s/ahci/ata_piix/ in subject line
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More
Alan Cox wrote:
And next time I'll be able to find the ata tape spec easily...
Signed-off-by: Alan Cox [EMAIL PROTECTED]
applied #upstream-fixes
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Alan Cox wrote:
Signed-off-by: Alan Cox [EMAIL PROTECTED]
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.24-rc2-mm1/drivers/ata/pata_hpt37x.c
linux-2.6.24-rc2-mm1/drivers/ata/pata_hpt37x.c
--- linux.vanilla-2.6.24-rc2-mm1/drivers/ata/pata_hpt37x.c
Tejun Heo wrote:
For intel ones, ahci unconditionally OR'd 0xf to PCS. This isn't
correct for the following cases.
* ich6/7m's which only implement P0 and P2 (0xf works fine tho)
* ich8/9's which have six ports and needs 0x3f to enable all ports
This patch updates PCS programming such
Tejun Heo wrote:
ata_acpi_gtm_xfermask() as separated out from pacpi_discover_modes()
has various bugs. Fix them.
* The wrong comparison operator is used when finding for matching
cycle resulting totally bogus result.
* With the comparion operator fixed, boundary condtion handling is
Tejun Heo wrote:
Move piix_pata_mwdma to top, rename ich9_2port_sata to ich8_2port_sata
for consistency and use automatically incremented values instead of
assigning fixed values to ease adding new controller IDs.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
applied to #tj-upstream-fixes.
Tejun Heo wrote:
None of the drives I have follows what the standard says about
transfer chunk size. Of the four SATA and six PATA ATAPI devices
tested, four ignore transfer chunk size completely and the ones which
honor it don't behave according to the spec when it's odd.
According to the
sonic zhang wrote:
INT status can be OR.
Signed-off-by: Sonic Zhang [EMAIL PROTECTED]
---
drivers/ata/pata_bf54x.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
applied
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to
ATA_HORKAGE_STUCK_ERR for ATAPI tape drives
Gabriel C (1):
pata_sis.c: Add Packard Bell EasyNote K5305 to laptops
Jeff Garzik (1):
pata_ali: trim trailing whitespace (fix checkpatch complaints)
Mark Lord (1):
libata-scsi: be tolerant of 12-byte ATAPI commands in 16-byte CDBs
This has been bubbling on my brain for a while. I blathered on about
this on IRC to Tejun, but figured I might as well post it here and get
it archived.
In general, I think we should adopt a flexible or loose model for
acking interrupts on SFF controllers.
(a) whenever we are in bus-idle
Mark Lord wrote:
Jeff Garzik wrote:
This has been bubbling on my brain for a while. I blathered on about
this on IRC to Tejun, but figured I might as well post it here and get
it archived.
In general, I think we should adopt a flexible or loose model for
acking interrupts on SFF
Mark Lord wrote:
Jeff: This fix (one I reissue it) should go upstream for 2.6.24, if
possible.
Fine by me...
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Alan Cox wrote:
In general, I think we should adopt a flexible or loose model for
acking interrupts on SFF controllers.
Agreed - especially as the IRQ is often essentially the drive output not
under any kind of sane control of ours.
Good point (I had not thought of looking at it that way).
Alan Cox wrote:
DMA alignment is host restriction so I think it belongs to ata_host if
we ever need it. Do you know of any controller which require such
thing? No need to add complexity when it's not necessary.
If we ever get the blasted inic162x working then that appears to have
some
Mark Lord wrote:
Alan Cox wrote:
DMA alignment is host restriction so I think it belongs to ata_host if
we ever need it. Do you know of any controller which require such
thing? No need to add complexity when it's not necessary.
If we ever get the blasted inic162x working then that appears
Tejun Heo wrote:
Alan Cox wrote:
polling for media change which involves reading maybe a few tens of
bytes. The overhead of doing those using PIO wouldn't be too much more
than the cost of writing CDBs out. It would help more if we can cut
down the number of commands used for testing media
Mark Lord wrote:
SATA port multipliers (think, hub) permit multiple drives
to be active simultaneously.
Quite true, although the host controller could artificially limit this,
giving the user a mistaken impression of their port multiplier being
limited to one-command-per-N-drives.
/nit
Saeed Bishara wrote:
From: Saeed Bishara [EMAIL PROTECTED]
use sstatus instead status.
Signed-off-by: Saeed Bishara [EMAIL PROTECTED]
---
drivers/ata/sata_mv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index
Kristoffer Nyborg Gregertsen wrote:
Several fixes for the AVR32 PATA driver:
* Updated to use new AVR32 SMC timing API. This removes the need for magic
constants in signal timing.
* Removed the ATA_FLAG_PIO_POLLING, the driver should use interrupts.
* Removed .port_disable and .irq_ack as
Tejun Heo wrote:
Protocol and CDB allocation size field are important in determining
what went wrong with ATAPI commands. Report them on failure.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
This one is for #upstream-fixes. Thanks.
nod, applied
-
To unsubscribe from this list: send the
Mark Lord wrote:
sata_mv: Fix broken Marvell 7042 support.
The Marvell 7042 chip is more or less the same as the 6042 internally,
but sports a PCIe bus. Despite having identical SATA cores, the 7042
does differ from its PCI bus counterparts in placment and layout of
certain bus related
Tejun Heo wrote:
From: Peter Schwenke [EMAIL PROTECTED]
Add more toshiba laptops to broken suspend list. This is from OSDL
bugzilla bug 7780.
tj: re-formatted patch and added description and SOB.
Signed-off-by: Peter Schwenke [EMAIL PROTECTED]
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
Tejun Heo wrote:
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 5eb5983..8d5cd16 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -5969,7 +5946,7 @@ void ata_qc_issue(struct ata_queued_cmd *qc)
*/
WARN_ON(ap-ops-error_handler
Tejun Heo wrote:
Move ata_set_mode() to libata-eh.c. ata_set_mode() is surely an EH
action and will be more tightly coupled with the rest of error
handling. Move it to libata-eh.c.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Does this mean SET FEATURES - XFER MODE via SG_IO will be possible
Tejun Heo wrote:
It's very likely that the configured data transfer mode is the wrong
one if device fails data transfers right after initial data transfer
mode configuration (including NCQ on/off and xfermode). libata EH
needs to speed down fast before upper layers give up on probing.
This
Anton Vorontsov wrote:
Hi all,
Here is the second spin of the OF-platform PATA driver and
related patches.
Changes since RFC:
- nuked drivers/ata/pata_platform.h;
- powerpc bits: proper localbus node added.
Thanks for the previous review! This time I'm collecting acks,
don't be shy to give
Tejun Heo wrote:
Area for DFLAGs which are cleared on INIT is full. Extend it by 8
bits.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
include/linux/libata.h |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
applied 1-8 to #upstream
-
To unsubscribe from this list: send the
Tejun Heo wrote:
Cable detection on NV PATA hosts isn't implemented and the CBLID-
cable isn't wired according to the sepc either, so both host-side and
generic drive-side cable detections are broken. Till now,
nv_cable_detect() relied on peeking BIOS and ACPI configurations to
upgrade to 80C
Tejun Heo wrote:
Make pdc_atapi_pkt() use values from qc-tf instead of creating its
own. This is to ease future ATAPI handling changes.
DONT APPLY YET
---
Mikael, would this work? Values other than lbam and lbah remain the
same. Does sata_promise have strict requirements for lbam and lbah?
Kristen Carlson Accardi wrote:
Enclosure Management via LED
This patch implements Enclosure Management via the LED protocol as specified
in AHCI specification.
Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED]
---
This revision makes the change to the comment requested by Mark Lord,
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/ata_piix.c| 28 +++
drivers/ata/libata-core.c |8 +++--
drivers/ata/libata-eh.c | 42
Tejun Heo wrote:
ata_id_to_dma_mode() isn't quite generic. The function is basically
privately implemented ata_id_xfermask() combined with hardcoded mode
printing and configuration which are specific to ata_generic.
Kill the function and open code it in generic_set_mode() using generic
Tejun Heo wrote:
Unindent loop body in generic_set_mode(). This is to ease future
change.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/ata_generic.c | 31 ---
1 files changed, 16 insertions(+), 15 deletions(-)
applied 1-12 to #upstream, with
Mark Lord wrote:
I am below novice when it comes to git:
$ git-pull --update-head-ok --tags
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
Warning: No merge candidate found because value of config option
branch.master.merge does not match any remote branch
Mark Lord wrote:
The BIOS on the Highpoint RR 2300 *corrupts* the GRUB image,
so GRUB won't boot for me there. I actually have to re-install
GRUB after each attempt so that the drive is usable again
with the onboard Intel (ahci) ports.
So one then wonders exactly what the Highpoint BIOS is
Greg Freemyer wrote:
On Dec 2, 2007 10:07 PM, Philip Langdale [EMAIL PROTECTED] wrote:
Hi all,
At least for my hardware (MCP55), the sata controller supports MSI
and it seems that turning it on is as simple as inserting the call
to pci_enable_msi - after that it Just Works(tm).
Are there any
Mark Lord wrote:
Mark Lord wrote:
Philip Langdale wrote:
Hi all,
At least for my hardware (MCP55), the sata controller supports MSI
and it seems that turning it on is as simple as inserting the call
to pci_enable_msi - after that it Just Works(tm).
Are there any gotchas that I'm missing?
Mark Lord wrote:
Also, I'm not sure I understand why there's a need for the new sata_mv.h
file ?
The embedded platform includes that, similar to
include/linux/pata_platform.h.
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to
Neil Brown wrote:
I've been looking at use BIO_RW_FAILFAST in md/raid to improve
handling of some error cases.
This is particularly significant for the DASD driver (s390 specific).
I believe it uses optic fibre to connect to the drives. When one of
these paths is unplugged, IO requests will
Robert Hancock wrote:
We need to run any DMA command with result taskfile requested in ADMA mode
when the port is in ADMA mode, otherwise it may try to use the legacy DMA engine
in ADMA mode which is not allowed. Enforce this with BUG_ON() since data
corruption could potentially result if this
,
and advise users to configure BIOS JBOD volumes instead,
which don't appear to suffer from this problem.
Signed-off-by: Mark Lord [EMAIL PROTECTED]
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
drivers/ata/sata_mv.c |9 +
1 file changed, 9 insertions
peerchen wrote:
Add the device IDs of legacy mode of MCP79 AHCI controller to ahci.c
The patch base on kernel 2.6.24-rc3
Signed-off-by: Peer Chen [EMAIL PROTECTED]
applied #upstream-fixes
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to
Alan Cox wrote:
Without the valid bits at least one set of TSScorp drives report 0 in
word 93 for PATA 40 wire, which we (and the specs) say actually means
SATA. (The SATA version seems to report 80 wire...)
Signed-off-by: Alan Cox [EMAIL PROTECTED]
diff -u --new-file --recursive
Tejun Heo wrote:
Make pdc_atapi_pkt() use values from qc-tf instead of creating its
own. This is to ease future ATAPI handling changes.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Cc: Mikael Pettersson [EMAIL PROTECTED]
---
Okay, Mikael says it's good for trying out. Please add this one to
Tejun Heo wrote:
Separate controller IDs into a separate enum as Jeff requested.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/ata_piix.c | 32 +---
1 file changed, 17 insertions(+), 15 deletions(-)
applied
-
To unsubscribe from this list: send
Tejun Heo wrote:
While updating lbam/h for ATAPI commands, atapi_eh_request_sense() was
left out. Update it.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-eh.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/libata-eh.c
Tejun Heo wrote:
Depending on how many bytes are transferred as a unit, PIO data
tranasfer may consume more bytes than requested. Knowing how much
data is consumed is necessary to determine how much is left for
draining. This patch update -data_xfer such that it returns the
number of consumed
Tejun Heo wrote:
With atapi_request_sense() converted to use sg, there's no user of
non-sg interface. Kill non-sg interface.
* ATA_QCFLAG_SINGLE and ATA_QCFLAG_SG are removed. ATA_QCFLAG_DMAMAP
is used instead. (this way no LLD change is necessary)
* qc-buf_virt is removed.
*
Tejun Heo wrote:
qc-nbytes doesn't include extra buffers setup by libata core layer
and my be odd. This patch adds qc-dma_nbytes which includes any
extra buffers setup by libata core layer and is guaranteed to be
aligned on 4 byte boundary.
This value is to be used to program the host
Tejun Heo wrote:
ATAPI devices come with plethora of bugs and many ATA controllers have
trouble dealing with odd byte DMA transfers. The problem is currently
somewhat masked by not allowing DMA transfers if the transfer size
isn't aligned to 16 bytes plus partial masking in problematic LLDs.
Alan Cox wrote:
setup and it821x fixes can go to mainstream for 2.6.25 I think - no bad
reports yet.
BTW so we don't duplicate work right now I'm working on a full DMA engine
based driver for the INIC162x. Dunno if I'll ever get it to work as the
docs are a bit minimal but we shall see.
-
To
Olof Johansson wrote:
[POWERPC] Move electra-ide support over to new pata_of_platform framework
Move electra-ide glue over to the new pata_of_platform framework, and
add the quirks needed to that driver.
Signed-off-by: Olof Johansson [EMAIL PROTECTED]
---
I'll remove the electra-ide stuff
Jeff Garzik wrote:
Some BIOS writer probably thought that was a good idea, but maybe not
for Linus.
er, s/Linus/Linux/
:)
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org
Jeff Garzik wrote:
ata1: failed to recover some devices, retrying in 5 secs
ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 300)
ata1.00: ACPI cmd b1/c1:00:00:00:00:a0 failed (Emask=0x1 Stat=0x51
Err=0x04)
ata1.00: ACPI on devcfg failed the second time, disabling (errno=-5)
ata1.00
Robert Hancock wrote:
This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode
on systems with memory located above 4GB. We need to delay setting the 64-bit
DMA mask until the PRD table and padding buffer are allocated so that they don't
get allocated above 4GB and break
Maciej Rutecki wrote:
http://www.unixy.pl/maciek/download/kernel/2.6.24-rc4/dmidecode.txt.gz
Thanks.
And may I presume that booting with libata module option 'noacpi=1'
fixes the problem?
noacpi=1 kernel command line or module parameters?
First, no change:
Tejun Heo wrote:
Jeff Garzik wrote:
IMO s/buflen/len/ causes needless patch noise, and makes this harder review
Separating out s/buflen/len/ to a separate patch seemed silly yet I
wanted to renamed it. :-P
If you want to kill it, I'll kill the renaming. If you want it in a
separate patch
On Thu, Dec 06, 2007 at 12:13:18AM +0900, Tejun Heo wrote:
Alan Cox wrote:
It eventually has to end up in -rc. If not for 2.6.25-rc1 is too early,
we can put it in #testing and put it into #upstream later.
Nobody cares about libata git trees. If you want some initial test
coverage put
Mark Lord wrote:
To do so, requires that we perhaps do a similar capacity truncation
in sata_mv, but only if we see a metadata block at the expected location
(because a Legacy mode drive will use the *real* capacity,
placing the metadata in the 9th sector instead.
Definitely _not_. This is a
Mark Lord wrote:
Jeff Garzik wrote:
Mark Lord wrote:
To do so, requires that we perhaps do a similar capacity truncation
in sata_mv, but only if we see a metadata block at the expected location
(because a Legacy mode drive will use the *real* capacity,
placing the metadata in the 9th sector
Mark Lord wrote:
Jeff Garzik wrote:
Mark Lord wrote:
To do so, requires that we perhaps do a similar capacity truncation
in sata_mv, but only if we see a metadata block at the expected location
(because a Legacy mode drive will use the *real* capacity,
placing the metadata in the 9th sector
Tejun Heo wrote:
Hello, all.
This has been going on for quite some time now but I finally succeeded
to reproduce the problem and find out what has been going on. It
wasn't drive's or controller's fault. The spurious completion
detection logic was wrong which makes all of this my fault. :-)
Mark Lord wrote:
Jeff Garzik wrote:
...
If you pop the BIOS chip or plug the card into a non-x86 box (or any
of several other alternatives), the problem is likely to go away.
..
Yeah, I was hoping for a removable BIOS chip, but it's soldered in place.
And that's not a solution for most
Notable: kill spurious NCQ completion detection
libata disabling command queueing (aka NCQ) based on some hueristics for
detection device brokenness that ultimately turned out to be broken.
Remove the broken hueristic and turn NCQ back on for all the wrongfully
maligned hard drives.
Tejun Heo wrote:
From: Peter Schwenke [EMAIL PROTECTED]
Add Toshiba Tecra M4 to broken suspend list. This is from OSDL
bugzilla bug 7780.
Signed-off-by: Peter Schwenke [EMAIL PROTECTED]
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/ata_piix.c |7 +++
1 files changed, 7
Tejun Heo wrote:
Spurious NCQ completion detection implemented in ahci was incorrect.
On AHCI receving and processing FISes and raising interrupts are not
interlocked and spurious interrupts are expected.
For example, if an interrupt occurs while interrupt handler is running
and the running
Tejun Heo wrote:
ICH6 R/Ms share PCI ID between piix and ahci modes and we've been
allowing ahci to attach regardless of how BIOS configured it.
However, enabling AHCI mode when the controller is in combined mode
can result in unexpected behavior. Don't attach if the controller is
in combined
Orion Poplawski wrote:
Not sure what the latest status of sata_mv hotplug should be, but it
seems close. I'm currently running 2.6.24-0.81.rc4.git7.fc9 with a
MV88SX5081. Pulled a couple drives and re-added. One device got
re-added, but the other did not. It seems like I got the system to
[EMAIL PROTECTED] wrote:
From: Tejun Heo [EMAIL PROTECTED]
xfer_mask is unsigned int not unsigned long. Change -mode_filter to
take and return unsigned int.
While at it, rename @adev of ata_pci_default_filter() to @dev for
consistency.
[EMAIL PROTECTED]: fix types]
Signed-off-by: Tejun Heo
Tejun Heo wrote:
* No internal function uses const ata_port. Drop const from @ap.
* Make ata_acpi_stm() copy @stm before using it and change @stm to
const.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-acpi.c |7 ---
include/linux/libata.h|4 ++--
2
Tejun Heo wrote:
* No internal function uses const ata_port. Drop const from @ap.
* Make ata_acpi_stm() copy @stm before using it and change @stm to
const.
for the record, I -would- use const ata_port where feasible; its just so
rarely feasible, since members of that struct are often
Tejun Heo wrote:
Interestingly, sata_sil raises spurious interrupts if it's coupled
with Sil SATA_PATA bridge. Currently, sata_sil interrupt handler is
strict about spurious interrupts and freezes the port when it occurs.
This patch makes it more forgiving.
* On SATA PHY event interrupt,
Tejun Heo wrote:
link-eh_info.serror is used to cache SError for controllers which
need it cleared from interrupt handler to clear IRQ. It also should
be cleared after reset just like SError itself.
Make ata_std_postreset() clear link-eh_info.serror too and update
sata_sil such that it doesn't
Tejun Heo wrote:
Like ST380817AS / 3.42, ST3160023AS / 3.42 times out commands if NCQ
is used. Blacklist it. This is reported by Matheus Izvekov in the
following thread.
http://thread.gmane.org/gmane.linux.ide/24202
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Cc: Matheus Izvekov [EMAIL
Tejun Heo wrote:
While updating lbam/h for ATAPI commands, atapi_eh_request_sense() was
left out. Update it.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
This patch is from improve-ATAPI-data-xfer patchset pending for
#upstream.
drivers/ata/libata-eh.c |4 ++--
1 file changed, 2
Tejun Heo wrote:
With ATAPI transfer chunk size properly programmed, libata PIO HSM
should be able to handle full spurious data chunks. Also, it's a good
idea to suppress trailing data warning for misc ATAPI commands as
there can be many of them per command - for example, if the chunk size
is
Tejun Heo wrote:
Tejun Heo wrote:
This is the second take of improve-ACPI-corner-case-handling patchset
and contains the following ten patches.
Jeff, this patchset can also be pulled from the following git tree.
master.kernel.org:/pub/scm/linux/kernel/git/tj/libata-dev.git acpi-fixes
In 2.6.24, we turned on ACPI support in libata. This is needed in order
to support suspend/resume and BIOS passworded drives, but it inevitably
brought with it a host of new regressions -- which is what happens
anytime you blindly accept ATA commands the BIOS has decided to toss
your way. :)
1301 - 1400 of 1579 matches
Mail list logo
