Tejun Heo wrote:
libata used two separate sets of variables to record request size and
current offset for ATA and ATAPI. This is confusing and fragile.
This patch replaces qc-nsect/cursect with qc-nbytes/curbytes and
kills them. Also, ata_pio_sector() is updated to use bytes for
qc-cursg_ofs
Tejun Heo wrote:
Driver for Initio 162x SATA controllers. ATA r/w, ATAPI r, hotplug
and suspend/resume work. ATAPI w (recording, that is) broken. Feel
free to fix it, but be warned, this controller is weird.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
* Modified as advised by Jeff.
*
Mark Lord wrote:
On Wednesday 03 January 2007 01:01, Mark Lord wrote:
..
This patch isn't really needed, but it might provide an out
just in case somebody has some really non-compliant hardware
out there someday.
Add a boot/module parameter for libata to force the ATA_16
SCSI opcode to not be
Mikael Pettersson wrote:
This patch (against libata #upstream + the ATAPI cleanup patch)
reimplements sata_promise's ATAPI support to format ATAPI DMA
commands as normal packets, and to issue them via the hardware's
normal packet machinery.
It turns out that the only reason for issuing ATAPI
Tejun Heo wrote:
Some uli controllers have stuck SIMPLEX bit which can't be cleared
with ata_pci_clear_simplex(), but the controller is capable of doing
DMAs on both channels simultaneously. Ignore it.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
diff --git a/drivers/ata/sata_uli.c
Tejun Heo wrote:
libata EH ignores port-wide actions in per-dev action mask. However,
device resume requests EH_SOFTRESET using per-dev action mask. Under
certain circumstances, this results in not resetting frozen port after
resuming which causes failure of all commands.
This patch allows
Tejun Heo wrote:
libata didn't used to init qc-dma_dir to any specific value on qc
initialization and command translation path didn't set qc-dma_dir if
the command doesn't need data transfer. This made non-data commands
to have random qc-dma_dir.
This usually doesn't cause problem because LLDs
Mikael Pettersson wrote:
Here's a cleanup for yesterday's sata_promise ATAPI patch:
- add and use a symbolic constant for the altstatus register
- check return status from ata_busy_wait()
- add missing newline in a warning printk()
- update comment in pdc_issue_atapi_pkt_cmd() to clarify
that
Olof Johansson wrote:
Hi,
With the following patch, my HighPoint 2310 with a Marvell 88SX7042 on
it seems to work OK.
The controller only has 4 ports, with MV_FLAG_DUAL_HC it seems to init 8
ports and fails miserably at probe time. There are no other devices mapped
to that chip, maybe it was
Tejun Heo wrote:
Darrick J. Wong wrote:
Tejun Heo wrote:
sd doesn't stop (unload head) on shutdown. This behavior is necessary
for multi initiator cases. Unloading head by powering off stresses
the drive and sometimes produces distinct clunking noise which
apparently disturbs users
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
Documentation/DocBook/libata.tmpl |2 +-
drivers/ata/libata-eh.c |4
drivers/ata/sata_mv.c |5
Oddbjørn Kvalsund wrote:
Hi,
I recently purchased a Gigabyte i-Ram GC Ramdisk after reading some
quite impressive reviews online. Getting the card up and running
connected to a ST Lab A-223 Serial ATA PCI Card (sil3114 using sata_sil)
with kernel 2.6.19.1 was quite easy, thanks guys!
Access
Alan wrote:
What sort of problems ? I've got an iRAM here for debugging/testing
courtesy of a company using them and the one I have seems to pass all the
testing I've thrown at it.
Out of curiosity, are you using one of the sticks from the [quite
limited] Gigabyte-approved RAM list?
Tejun Heo wrote:
As with JMicron controllers, ULi M5288 sets interface fatal error bit
on device error including ATAPI CC. This makes libata hardreset the
port on ATAPI CC thus making it impossible to use. Ignore interface
fatal error bit on ULi M5288. This fixes bugzilla bug #7837.
All fixes for ugly bugs and/or regressions.
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/ahci.c| 39 +++
ASUS A6K/A6U
Jeff Garzik (2):
[libata] trim trailing whitespace
[libata] sata_vsc: build fix after PCI MSI feature addition
Mikael Pettersson (5):
sata_promise: TX2plus PATA support
sata_promise: ATAPI support
sata_promise: ATAPI cleanup
sata_promise: issue ATAPI
Akira Iguchi wrote:
Two IRQ calls are added in ata_port_operations.
- irq_on() is used to enable interrupts.
- irq_ack() is used to acknowledge a device interrupt.
And there are additional function declarations which are
used in pata_scc.c.
Signed-off-by: Kou Ishizaki [EMAIL PROTECTED]
Akira Iguchi wrote:
The real benefits from identifying a common case is to inline
the code for it. So the fact that the common case is still a
full-blown function call here and not inline code means that
there's much less benefit from rewriting an indirect call as
an if/indirect/direct sequence.
Akira Iguchi wrote:
This is the patch for PATA controller of Celleb.
It depends on the previous add another IRQ calls patch.
Because this driver needs special taskfile accesses, there is
a copy of ata_std_softreset(). ata_dev_try_classify() is exported
so that it can be used in this function.
Tejun Heo wrote:
- /* ignore interim PIO setup fis interrupts */
- if (ata_tag_valid(ap-active_tag) (status PORT_IRQ_PIOS_FIS))
- return;
+ if ((status PORT_IRQ_D2H_REG_FIS)
+ !(pp-seen_status PORT_IRQ_D2H_REG_FIS)) {
+
Mark Lord wrote:
Jeff Garzik wrote:
Tejun Heo wrote:
'hdparm -I' doesn't work with ATAPI devices and sg_sat is not widely
spread yet leaving no easy way to access ATAPI IDENTIFY data.
Implement HDIO_GET_IDENTITY such that at least 'hdparm -i' works.
Signed-off-by: Tejun Heo [EMAIL PROTECTED
Alan wrote:
On Thu, 25 Jan 2007 20:29:47 +0900
Tejun Heo [EMAIL PROTECTED] wrote:
PIO xfermask limits should be shared by all devices on the same
channel to avoid violating device selection timing. libata used to
NAK, this is totally wrong
+ /* PIO xfermask limits are shared by all
Sergei Shtylyov wrote:
Now, the site seems to have 2 versions of the PCI-648/9 specs. :-)
I looked into those in specs/sii and noted that PCI-648 spec was newer
than mine, but PCI-649 was older.
It's probably a good idea to put all the CMD/SiI files in the single
directory, so there's no
Tejun Heo wrote:
vt6420 completely loses its ability to raise IRQ for ATAPI devices if
ATA_NIEN is diddled with in -freeze. Further investigation is
necessary to determine whether this problem is shared on other
controllers but it doesn't seem to be at this point.
Make vt6420's -freeze only
Tejun Heo wrote:
We're still seeing a lot of issues with NCQ implementation in drive
firmwares. Sprious FISes during NCQ command phase occur on many
drives and some of them seem potentially dangerous (at least to me).
Until we find the solution, spurious messages can give us more info.
Improve
Tejun Heo wrote:
+ const u32 *f = pp-rx_fis + RX_FIS_SDB;
+
+ ata_port_printk(ap, KERN_INFO, Spurious SDB FIS during NCQ
+ issue=0x%x SAct=0x%x FIS=%08x:%08x%s\n,
+ readl(port_mmio + PORT_CMD_ISSUE),
+
Mark Lord wrote:
What happened to ATA Passthru command support for ATAPI?
On Jan 19 in message [EMAIL PROTECTED] you were asked to
send a patch that applies successfully to #upstream.
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a
Greg KH wrote:
From: Greg Kroah-Hartman [EMAIL PROTECTED]
It seems that the ata_piix driver has two duplicate ids, one of them
with a different 'private' field in it, which was never being used due
to the match for the device happening on an earlier entry.
This patch removes the duplicates, if
Akira Iguchi wrote:
Dear everyone.
Thank you for many useful comments.
This is the latest patchset for the PATA controller of Celleb.
This patchset consists of
[1] add another IRQ calls (core and headers)
[2] add another IRQ calls (libata drivers)
[3] PATA driver for Celleb
And patch[3]
This is the first cut at converting sata_mv to new EH.
It builds, but is untested.
Done:
- freeze, thaw
- hardreset
- prereset, software: intentionally not implemented
Not yet done:
- initiate EH from interrupt handler. Right now the whack it
old error handling remains, when an error is seen
Tejun Heo wrote:
Fix endianness in spurious interrupt message.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
applied to #upstream-fixes
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Tejun Heo wrote:
Call ata_bmdma_irq_clear() directly instead of through
ap-ops-irq_clear() according to libata style guideline.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
applied to #upstream-fixes
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message
90% resend from yesterday. Added a few more fixes.
If you pulled the previous submission, that's ok, git history will still
be correct (it's appended, not rebased).
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
Tejun Heo wrote:
ap-id is logcial port ID which is unique among all ATA ports and
doesn't have anything to do with hardware port index. ap-port_no is
the hardware port index and thus should be used when clearing IRQ mask
in ahci_thaw().
This problem has been spotted by Jeff Garzik [EMAIL
Alan wrote:
Were it not for the PATA and interrupt storm bits, I would say that
Marvell 6145 works with a simple PCI ID addition.
The 6101 driver should drive the 6145 pata port via the legacy registers
They cannot co-exist, unfortunately.
Jeff
-
To unsubscribe from this list:
Sergei Shtylyov wrote:
Fix PIO mode 1 overclocked taskfile transfers -- probably a typo carried over
from drivers/ide/pci/siimage.c where I've found it by documentation check...
drivers/ata/pata_sil680.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Signed-off-by: Sergei Shtylyov
Robert Hancock wrote:
Applies to 2.6.20-rc6.
---
libata's SCSI translation for the SCSI START STOP UNIT command with the
START bit clear (i.e. stopping the drive) appears to be incorrect. It
sends an ATA STANDBY command with the time period set to 0, which the
code comment says means now,
Robert Hancock wrote:
Jeff Garzik wrote:
* Include the patch inline rather than as an attachment. Even a
text/plain attachment is very difficult to review and quote in popular
email programs.
Jeff
I'd love to, but unfortunately nobody seems to have come up with a way
of doing
Gary Hade wrote:
Some of my random thoughts:
There does appear to be this invalid assumption that 0xFF status
always implies device-not-present. The status register access
restrictions in ATA/ATAPI-7 V1 5.14.2 include the statement The
contents of this register, except for BSY, shall be
Tejun Heo wrote:
[The previous replay mysteriously didn't include Eric in To:, sorry,
quoting whole message here.]
Tejun Heo wrote:
Hello, Eric.
Eric D. Mudama wrote:
Per Jeff's suggestion, this patch rearranges the info printed for ATA
drives into dmesg to add the full ATA firmware revision
Jose Alberto Reguero wrote:
This work for kernel 2.6.20-rc6
First apply this patch:
http://marc.theaimsgroup.com/?l=linux-idem=116986924301674w=2
Then apply the patch attached.
Comments:
The Marvell 88SE6121 has three ports (0,1,2). The PATA port is port 2. (PATA
port for 6141 is port 4).
Tejun Heo wrote:
devres change moved iomap.o from obj-$(CONFIG_GENERIC_IOMAP) to lib-y
making it not linked if no in-kernel driver uses it. Fix it.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
applied
BTW can you update your scripts to email [EMAIL PROTECTED] ? That's the
primary email
Eric D. Mudama wrote:
Per Jeff's suggestion, this patch rearranges the info printed for ATA
drives into dmesg to add the full ATA firmware revision and model
information, while keeping the output to 2 lines.
Signed-off-by: Eric D. Mudama [EMAIL PROTECTED]
---
This extra information is helpful
Tejun Heo wrote:
Alan wrote:
Some SATA controllers use 0xff to indicate empty port. This seldomly
matters as we have the almighty SStatus register to check device
presence (there is a bug regarding this, patch pending).
This GoVault drive fails because ata_piix doesn't have SCR while using
Tejun Heo wrote:
Also, you can avoid that by configuring aliases to the thunderbird
account. It's in account setting - Manage Identities. Thungerbird is
pretty neat. :-)
Already done that, it doesn't seem to work :/
If you ever see [EMAIL PROTECTED] in a From line, that's
Thunderbird
Luca Tettamanti wrote:
Hi Jeff, linux-ide,
I'm having troubles with libata and UDF on RW media. See below.
Il Tue, Jan 30, 2007 at 09:42:34PM +0100, Jan Engelhardt ha scritto:
On Jan 30 2007 21:36, Luca Tettamanti wrote:
Il Tue, Jan 30, 2007 at 09:02:20PM +0100, Jan Engelhardt ha scritto:
Tejun Heo wrote:
Implement device resource management, in short, devres. A device
ACK patches 1-7. Applied patches 1-6 (with some remaining pata_platform
damage) to #upstream.
Please examine the resulting damage, and resend patch #7, plus any
missing bits
Jeff
-
To
Alan wrote:
@@ -5142,6 +5174,20 @@
status = ata_chk_status(ap);
if (unlikely(status ATA_BUSY))
goto idle_irq;
+
+ if (unlikely(qc-tf.command == ATA_CMD_SET_FEATURES
+ qc-tf.feature == SETFEATURES_XFER)) {
+ /* Let the timings
Mark Lord wrote:
Eric D. Mudama wrote:
Actually, it's possibly worse, since each failure in libata will
generate 3-4 retries. With existing ATA error recovery in the drives,
that's about 3 seconds per retry on average, or 12 seconds per
failure. Multiply that by the number of blocks past
Tejun Heo wrote:
SCSI always uses the smallest command it can use, so we're safe. Most
other commands are issued directly from the userland and it's their
responsibility not to feed disallowed commands to a device (or we need
more advanced filter). Anyways, this has never been guaranteed
Mark Lord wrote:
Tejun Heo wrote:
Anyways, this has never been guaranteed because
the limit is host wide.
But until very very recently, host wide meant just a single device
for libata. I was just assuming we did all of the fiddling to ensure
a minimal value there for some real reason.
But,
Tejun Heo wrote:
Jeff Garzik wrote:
Mark Lord wrote:
For example, I think all existing ATAPI drives only speak 12-byte packet
protocols, and so if we tell SCSI we're good for 16-byte, then won't the
SCSI layer suddenly start sending us READ_16 and the like?
Speaking strictly about the device
Tejun Heo wrote:
Well, it's not any worse than what we're currently doing. We don't set
Agreed... but that doesn't make it the /right/ thing to do ;-)
The logic behind the current code, which limits to the maximum size
allowed by an attached device on the port, is mainly to leverage the
James Bottomley wrote:
But you're requesting code changes in the SCSI layer because of this
incorrect usage. max_cdb is supposed to be the *host* limit. The mid
layer finds out and respects device limits separately from this.
I never requested any such thing.
Jeff
-
To unsubscribe
It's amazing how poorly we have programmed PIIX, for the lifespan of
Linux...
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Alan wrote:
I don't have the hardware combination to test this one so would
appreciate people testing it before it goes anywhere further
I wonder if sata_promise PATA support needs this too?
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to
Tejun Heo wrote:
For all JMicrons except for 361 and 368, AHCI mode enable bits in the
Control(1) should be set. This used to be done in both ahci and
pata_jmicron but while moving programming to PCI quirk, it was removed
from ahci part while still left in pata_jmicron.
The implemented JMicron
[EMAIL PROTECTED] wrote:
BTW: In function ata_dev_set_mode in libata_core.c the variable err_mask is not
initialized (line 2386). I changed that and initialized err_mask with 0, but
that did'nt solve my problem. I did'nt expect to :-)
It's initialized prior to its first use, by a call to
Alan wrote:
Looks like you should use ata_busy_wait() here, rather than reproducing
the same code again.
It waits in 10uS chunks while 1uS chunks were used in the workaround.
Could indeed do that once I know the fix is right. While I'm at it the
ata_busy_wait kerneldoc is borked so here's a
Tejun Heo wrote:
devres updates for pata_platform were dropped while merging devres
patches due to merge conflict. This is the updated version.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
applied 1-2
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a
Brian and Tejun's patches fix really ugly bugs, Alan's are of less
importance
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/libata-core.c |1 +
Linus Torvalds wrote:
On Fri, 2 Feb 2007, Jeff Garzik wrote:
pata_atiixp: propogate cable detection hack from drivers/ide to the new
driver
It's prop*a*gate.
Damn.
Linus some speling mistaeks drive me wild Torvalds
Those UK types don't know how to spell tons
Alan wrote:
Well we can certainly do some of that if ACPI is present and active. In
particular since _GTM will give us current modes allowing for hotplug and
post BIOS boot kexec etc it ought to be safe to do Tejun's hack that way.
We could even probe UDMA3+ capable devices by doing _STM to a
Tejun Heo wrote:
Follow the old SRST rule and delay 150ms between completion of
hardreset and status checking. Debouncing delay should usually cover
this but debounce duration could be shorter than 150ms under certain
circumstances.
Usefulness depends on host controller implementation but it
Tejun Heo wrote:
* Hardreset must not exit without actually performing reset regardless
of link status. We're resetting the link after all.
* Minor message update.
* 150ms delay is meaningful iff link is online after reset is
complete.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
Alan wrote:
People are getting confused about which drivers to enable for PATA PIIX
type devices. Change the ATA_PIIX line and help to make it clearer.
Signed-off-by: Alan Cox [EMAIL PROTECTED]
applied
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a
Alan wrote:
IORDY and IORDY enable/disable flags.
Signed-off-by: Alan Cox [EMAIL PROTECTED]
applied
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Sergei Shtylyov wrote:
[Cr*p, forgot both the sign-off and cut-off! :-)]
MPIIX has only single channel IDE which can be configured for either primary or
secondary legacy I/O ports and IRQ. So, get rid of the unneeded second probe
entry in mpiix_init_one() and of the invalid (but unused anyway)
Alan wrote:
If we are doing a PIO setup for a CFA card and it blows up with a device
error then assume it is an older CFA card which doesn't support this
rather than failing the device out of existance.
Stands seperate to the quieting patch but that is obviously useful with
this change.
Michal Piotrowski wrote:
Hi Jeff,
What does this mean?
ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata1.00: cmd c8/00:08:67:40:68/00:00:00:00:00/e3 tag 0 cdb 0x0 data 4096 in
res 40/00:01:00:4f:c2/00:00:00:00:00/00 Emask 0x4 (timeout)
ata1: soft resetting port
Mikael Pettersson wrote:
This patch fixes an oversight which caused sata_promise to
not perform cable detection on the TX2plus chips' PATA ports.
Signed-off-by: Mikael Pettersson [EMAIL PROTECTED]
---
This patch adds yet another is-PATA-or-SATA? check, but it's in a
cold path so shouldn't
Williams, Dan J wrote:
When I fire up 2.6.20 with an iq3124h I get:
ata1: SATA max UDMA/133 cmd 0xC8822200 ctl 0xC889 bmdma 0xC8822270
irq 25
ata2: SATA max UDMA/133 cmd 0xC8822400 ctl 0xC8822429 bmdma 0xC8822470
irq 25
ata3: SATA max UDMA/133 cmd 0xC8822600 ctl 0xC8822629 bmdma 0xC8822670
Benjamin Herrenschmidt wrote:
2.6.20 has been released and (I think) it is the time of merge-window
for 2.6.21. I want this patch to be merged at this time.
Please tell me if there are anything I should do.
FYI, Jeff, we have merged the rest of the celleb platform support in the
2.6.21 merge
Robert Hancock wrote:
It's curious that only the post-cache-flush command is having issues,
and normal NCQ operation seems fine. Maybe it's related to that tag 0
being reused repeatedly?
If you take cache flush out of the equation, what happens when NCQ is
enabled with a queue depth of 1 (to
Florin Andrei wrote:
(I'm not subscribed to linux-ide)
I've two almost identical systems (slightly different CPUs) that use SiI
3114 for SATA and RAID.
One of them was installed a while ago with Fedora Core 5 (kernel
2.6.15-1.2054_FC5smp) and whoever installed it was able to turn on
Alan wrote:
Currently we don't report PIO/DMA information in the case we are using
firmware mode setup by drivers, or where the value is meaningless. Even
when we don't know the mode, or the mode is meaningless it would be nice
to report PIO or DMA and to keep stylistic consistency. For MW/UDMA
Mikael Pettersson wrote:
This patch fixes an oversight which caused sata_promise to
not perform cable detection on the TX2plus chips' PATA ports.
Signed-off-by: Mikael Pettersson [EMAIL PROTECTED]
---
This patch adds yet another is-PATA-or-SATA? check, but it's in a
cold path so shouldn't
Olaf Hering wrote:
The hald media changed polling does really confuse things.
Noone knows why the delays are needed, but they give us access to the CD.
An udelay(50) will give reliable access to the drive, but there is still
one (or more) EH reset. The drive works without EH resets with
Jeremy Higdon wrote:
On Wed, Feb 07, 2007 at 09:29:28AM -0500, Dailey, Nate wrote:
The attached patch modifies drivers/ata/sata_vsc.c to only set the cache
line size to 0x80 if the default value is zero. Apparently zero isn't
allowed due to a bug in the chip, but I've found performance is much
Robin H. Johnson wrote:
No, that's not a correct assertion. We can only say that device-mapper
is being used somehow. It could be LVM, EVMS2, dmraid, or a few other
things.
When using the stock open source ATA drivers, of those DM-related actors
only dmraid can claim support for Sil 3114
Robert Hancock wrote:
ADMA-capable controllers provide a bit in the status register that appears
to indicate that the controller detected an SError condition. Update
sata_nv
to detect this and trigger error handling in order to handle the fault.
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
The pile that was waiting for post-conference, largely bug fixes.
As mentioned in the last push, were two other push points planned for
2.6.21:
1) merge libata support for ACPI
2) Remove ugly combined mode hacks in libata-sff and pci/quirks, now
that old-IDE and libata have the necessary
Jeff Garzik wrote:
--- a/include/linux/ata.h
+++ b/include/linux/ata.h
@@ -352,7 +352,7 @@ static inline int ata_drive_40wire(const u16 *dev_id)
{
if (ata_id_major_version(dev_id) = 5 ata_id_is_sata(dev_id))
return 0; /* SATA */
- if (dev_id[93] 0x4000
Linus Torvalds wrote:
On Thu, 15 Feb 2007, Jeff Garzik wrote:
diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig
index db185f3..d51f0f1 100644
--- a/arch/ia64/Kconfig
+++ b/arch/ia64/Kconfig
@@ -22,6 +22,7 @@ config IA64
config 64BIT
bool
+ select ATA_NONSTANDARD if ATA
Tejun Heo wrote:
Hello,
Robert Hancock wrote:
[--correct summary snipped--]
Given the above, what I'm proposing to do is:
-Remove the blacklisting of Maxtor BANC1G10 firmware for FUA. If we
need to FUA-blacklist any drives this should likely be added to the
existing horkage mechanism we now
Zhang, Yanmin wrote:
On Thu, 2007-02-08 at 20:19 -0500, Jeff Garzik wrote:
Zhang, Yanmin wrote:
If an ATA drive uses legacy mode, ata driver will choose 14 and 15 as the
fixed irq number. On ia64 platform, such numbers are GSI and should be converted
to irq vector.
Below patch against kernel
Robert Hancock wrote:
Tobias Diedrich wrote:
Possibly a known issue:
After resume pata_amd drops from UDMA/33 to PIO on my system.
Reloading the module puts both attached optical drives (master and
slave) back to UDMA/33.
AFAICS simplex DMA is claimed by other device, disabling DMA seems
to
Olaf Hering wrote:
Change the default for the built-in IDE on p610/p615/p630 from
ide to libata. libata has better error handling and the drive can
recover when hald does its CD media polling.
Signed-off-by: Olaf Hering [EMAIL PROTECTED]
---
arch/powerpc/configs/ppc64_defconfig |4 ++--
= ATA_TMOUT_INTERNAL / HZ;
module_param(ata_probe_timeout, int, 0444);
MODULE_PARM_DESC(ata_probe_timeout, Set ATA probing timeout (seconds));
+int noacpi;
+module_param(noacpi, int, 0444);
+MODULE_PARM_DESC(noacpi, Disables the use of ACPI in suspend/resume when
set);
+
MODULE_AUTHOR(Jeff Garzik
Tejun Heo wrote:
Make ata_down_xfermask_limit() accept @sel instead of @force_pio0.
@sel selects how the xfermask limit will be adjusted. The following
selectors are defined.
* ATA_DNXFER_PIO: only speed down PIO
* ATA_DNXFER_DMA: only speed down DMA, don't cause transfer mode
Tejun Heo wrote:
SDB FIS containing spurious NCQ completions is a clear protocol
violation. Currently, only some Maxtors with early firmware revisions
are showing this problem. Those firmwares have other NCQ related
problems including buggy NCQ error reporting and occasional lock up
after NCQ
Akira Iguchi wrote:
This is the patch for PATA controller of Celleb.
This driver uses the managed iomap (devres).
Because this driver needs special taskfile accesses, there is
a copy of ata_std_softreset(). ata_dev_try_classify() is exported
so that it can be used in this function.
Mark Lord wrote:
I was trying to use HDIO_DRIVE_TASK for something today,
and discovered that the libata implementation does not copy
over the upper four LBA bits from args[6].
This is serious, as any tools using this ioctl would have their
commands applied to the wrong sectors on the drive,
Tejun Heo wrote:
Separate out ata_ncq_enabled().
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-core.c |4 +---
include/linux/libata.h| 15 +++
2 files changed, 16 insertions(+), 3 deletions(-)
applied 1-3
-
To unsubscribe from this list: send the
Tejun Heo wrote:
libata used disable pdev only on PM_EVENT_SUSPEND while re-enable pdev
unconditionally. This was okay before ref-counted pdev enable update
but it now makes the pdev pinned after swsusp cycle (enabled twice but
disabled only once) and devres sanity check whines about it.
Fix
Magnus Damm wrote:
libata: Remove duplicate dma blacklist entry
The exact same entry is already present.
Signed-off-by: Magnus Damm [EMAIL PROTECTED]
---
Applies to 2.6.20-git14.
applied
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to
Tejun Heo wrote:
ata_port has two different id fields - id and port_no. id is
system-wide 1-based unique id for the port while port_no is 0-based
host-wide port number. The former is primarily used to identify the
ATA port to the user in printk messages while the latter is used in
various
Tejun Heo wrote:
ata_probe_ent_alloc() had a temporary hack such that devm_kzalloc()
was used for allocation if devres had been previously initialized on
the device; otherwise, plain kzalloc() was used. This was to make the
code useable from both the old and devres-aware libata drivers during
Alan wrote:
Deleting the ata_pci_clear_simplex() call, then adding
ATA_FLAG_IGN_SIMPLEX to the ata_port_info info[] array, is also worth
trying.
I think I know what is going on here. Firstly the simplex bits
need re-clearing on a resume. On my todo list now I'm back
If the bit does not
Robert Hancock wrote:
Some debug output in the ADMA error_handler function was removed recently,
but it may be useful in certain cases, like NCQ commands timing out. Add it
back in, but make it a bit more intelligent so that it only prints if
command(s) are active and only prints the CPBs for
301 - 400 of 1579 matches
Mail list logo
