Re: [pptp-devel] RFC: required patch to pptp 1.0.3 for israeli adsl service

2001-11-14 Thread mulix
attached is a revised patch for bezeq support, relative to current pptp cvs. bezeq support is now a run time mechanism, via a --quirks=BEZEQ_ISRAEL switch. for this, i implemented a general quirks mechanism, which allows overriding the out_call_rqst packet construction, start_ctrl_conn packet cons

Re: [pptp-devel] RFC: required patch to pptp 1.0.3 for israeli adsl service

2001-11-14 Thread Thomas Quinot
Le 2001-11-13, Dani Arbel écrivait : > with other ISPs using the same equipment. On the other hand, once > implemented, the pptp is not fully compatible with the RFC . Maybe it > would make sense to make a #define per ADSL modem that is bugy. Yep, or some sort of 'quirk table' as is commonly fou

Re: [pptp-devel] RFC: required patch to pptp 1.0.3 for israeli adsl service

2001-11-14 Thread Shaul Karl
> > With Alcatel modems, I found a bug in the unit for ISDN lines. The fix > (refering to ver. 1.0.1 of pptp )is > actualy trivial and will not make the code non rfc complient. I will see > if it is at all neede for the current version. > What does ISDN has to do with ADSL? I mean, as far as

Re: [pptp-devel] RFC: required patch to pptp 1.0.3 for israeli adsl service

2001-11-13 Thread Rein Klazes
On Tue, 13 Nov 2001 00:04:19 +0200 (IST), you wrote: > +#else /* PPTP_BEZEQ_ISRAEL is defined */ > +{ > + PPTP_HEADER_CTRL(PPTP_OUT_CALL_RQST), > + 0, /* hton16(call->callid) */ > + 0, /* hton16(call->sernum) */ I don't understand why you need this: call->callid and call->ser

Re: [pptp-devel] RFC: required patch to pptp 1.0.3 for israeli adsl service

2001-11-13 Thread Rein Klazes
On Tue, 13 Nov 2001 11:31:28 +0200 (IST), you wrote: > > - I'm wondering if the #define should be something other than Bezeq. > > Have you heard if any other implementations need this change? Have you > > any idea what software or hardware Bezeq is using to deliver ADSL? > > > > Bezeq

Re: [pptp-devel] RFC: required patch to pptp 1.0.3 for israeli adsl service

2001-11-13 Thread mulix
On Tue, 13 Nov 2001, James Cameron wrote: > G'day mulix, good day, james. > Thank you for your patch to pptp that adds support for Bezeq. thank you for maintaining pptp and thanks to the original author, for writing it. > - I'm wondering if the #define should be something other than Bezeq. >

Re: [pptp-devel] RFC: required patch to pptp 1.0.3 for israeli adsl service

2001-11-13 Thread Dani Arbel
James, As one of the people that were involved in integrating support for Bezeq ADSL I would like to answer one of your questions. On Tue, 13 Nov 2001, James Cameron wrote: > G'day mulix, > > - I'm wondering if the #define should be something other than Bezeq. > Have you heard if any other imple

Re: [pptp-devel] RFC: required patch to pptp 1.0.3 for israeli adsl service

2001-11-13 Thread James Cameron
G'day mulix, Thank you for your patch to pptp that adds support for Bezeq. I'm the pptp-client project administrator, or release engineer, and I've taken on the job in the past few months. My comments on your patch follow: - I'm wondering if the #define should be something other than Bezeq. H