Re: [RFC/RFT 1/5] Input: implement proper locking in input core

2007-07-23 Thread Dmitry Torokhov
Hi Jeff, On Tuesday 24 July 2007 01:35, Jeff Garzik wrote: > > spin_lock_irq() should generally be avoided. > > In cases like the first case -- input_repeat_key() -- you are making > incorrect assumptions about the state of interrupts. The other cases > are probably ok, but in general spin_l

Re: [RFC/RFT 1/5] Input: implement proper locking in input core

2007-07-23 Thread Jeff Garzik
Dmitry Torokhov wrote: +static void input_repeat_key(unsigned long data) +{ + struct input_dev *dev = (void *) data; - change_bit(code, dev->key); + spin_lock_irq(&dev->event_lock); [...] +void input_inject_event(struct input_handle *handle, + unsigned int

[RFC/RFT 3/5] Input: tsdev - implement proper locking

2007-07-23 Thread Dmitry Torokhov
Input: tsdev - implement proper locking Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/input/tsdev.c | 392 +++--- 1 files changed, 278 insertions(+), 114 deletions(-) Index: work/drivers/input/tsdev.c

[RFC/RFT 0/5] Input locking patches

2007-07-23 Thread Dmitry Torokhov
Hi everyone, I finally managed to put together some patches implementing locking in input core and main input handles. Please look over them and give them a spin. -- Dmitry

[RFC/RFT 1/5] Input: implement proper locking in input core

2007-07-23 Thread Dmitry Torokhov
Input: implement proper locking in input core Also add some kerneldoc documentation to input.h Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/input/input.c | 656 -- include/linux/input.h | 112 +++- 2 files changed, 585 inse

[RFC/RFT 4/5] Input: mousedev - implement proper locking

2007-07-23 Thread Dmitry Torokhov
Input: mousedev - implement proper locking Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/input/mousedev.c | 736 +-- 1 files changed, 464 insertions(+), 272 deletions(-) Index: work/drivers/input/mousedev.c ==

[RFC/RFT 2/5] evdev - implement proper locking

2007-07-23 Thread Dmitry Torokhov
Input: evdev - implement proper locking Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/input/evdev.c | 719 +- 1 files changed, 476 insertions(+), 243 deletions(-) Index: work/drivers/input/evdev.c

[RFC/RFT 5/5] Input: joydev - implement proper locking

2007-07-23 Thread Dmitry Torokhov
Input: joydev - implement proper locking Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/input/joydev.c | 745 - 1 files changed, 493 insertions(+), 252 deletions(-) Index: work/drivers/input/joydev.c ==

Re: [PATCH][08/37] Clean up duplicate includes in drivers/input/

2007-07-23 Thread Dmitry Torokhov
On Saturday 21 July 2007 11:02, Jesper Juhl wrote: > Hi, > > This patch cleans up duplicate includes in > drivers/input/ > Applied to for-linus branch of input tree, thank you. -- Dmitry

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-23 Thread Dmitry Torokhov
On Sunday 22 July 2007 08:51, Geert Uytterhoeven wrote: > On Sun, 22 Jul 2007, Dmitry Torokhov wrote: > > On Saturday 21 July 2007 04:27, Geert Uytterhoeven wrote: > > > On Fri, 20 Jul 2007, Dmitry Torokhov wrote: > > > > I am OK with adding a new header file. I was just saying that placing > > > >

[PATCH] usbhid: add ASUS LCM to the blacklist

2007-07-23 Thread Christian Lamparter
Some of ASUS' notebooks (e.g G Series) include a tiny oled display, which is attached to an internal USB bus. Unfortunatly the device reports a wrong DeviceDescriptor and is therefore identified as a HID device... Signed-off-by: Christian Lamparter <[EMAIL PROTECTED]> CC: linux-input@atrey.karli

[PATCH]: Add command-line option to i8042 to completely disable it

2007-07-23 Thread Chris Lalancette
(I tried to send this patch to linux-input@, but it seems to be currently having some problems, so I'm going directly to LKML). Certain (broken) pieces of South Bridge hardware will respond to i8042_read_status() on boot with 0x0, despite there not being a real i8042 controller hooked up in the so