Re: [PATCH] HP Jornada 7xx keyboard support

2007-07-21 Thread Kristoffer Ericson
On Sun, 22 Jul 2007 01:29:08 -0400 Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > Hi Kristoffer, > > On Saturday 21 July 2007 20:48, Kristoffer Ericson wrote: > > Greetings, > > > > You got the description text before right?. > > > > Here's the signoff line: > > signed-off-by: Kristoffer Ericson

Re: [PATCH] HP Jornada 7xx keyboard support

2007-07-21 Thread Dmitry Torokhov
Hi Kristoffer, On Saturday 21 July 2007 20:48, Kristoffer Ericson wrote: > Greetings, > > You got the description text before right?. > > Here's the signoff line: > signed-off-by: Kristoffer Ericson <[EMAIL PROTECTED]> > I must say I am really pissed off. The code that you send not only was ne

Re: [PATCH] HP Jornada 7xx keyboard support

2007-07-21 Thread Kristoffer Ericson
Greetings, You got the description text before right?. Here's the signoff line: signed-off-by: Kristoffer Ericson <[EMAIL PROTECTED]> On Fri, 20 Jul 2007 16:36:02 -0400 "Dmitry Torokhov" <[EMAIL PROTECTED]> wrote: > On 7/21/07, Kristoffer Ericson <[EMAIL PROTECTED]> wrote: > > #try 4: > > > > I

Re: [PATCH] HP Jornada 7xx keyboard support

2007-07-20 Thread Dmitry Torokhov
On 7/21/07, Kristoffer Ericson <[EMAIL PROTECTED]> wrote: #try 4: Ive changed the error handling so it only should release stuff it actually had aquired. Looks good, thank you. Can I please get a "signed-off-by:" form you so I can apply it to the input tree? -- Dmitry

Re: [PATCH] HP Jornada 7xx keyboard support

2007-07-20 Thread Kristoffer Ericson
#try 4: Ive changed the error handling so it only should release stuff it actually had aquired. Best wishes Kristoffer diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig index c97d5eb..4a77c87 100644 --- a/drivers/input/keyboard/Kconfig +++ b/drivers/input/keyboard/Kc

Re: [PATCH] HP Jornada 7xx keyboard support

2007-07-20 Thread Dmitry Torokhov
Hi Kristoffer, On 7/18/07, Kristoffer Ericson <[EMAIL PROTECTED]> wrote: Try #2 Thanks for feedback, Ive tried a different approach to get it better handled. Thank you for making the changes I requested, however there is still an issue: + + ret = request_irq(IRQ_GPIO0, +

Re: [PATCH] HP Jornada 7xx keyboard support

2007-07-20 Thread Dmitry Torokhov
On 7/21/07, Kristoffer Ericson <[EMAIL PROTECTED]> wrote: Greetings, Ive added it to free IRQ as you said, a minor change is also that jornada720.h defines are set in CAPS (just changed that for Russell). Ive also added the Kconfig and Makefile. Btw, do you keep patchtracker (like Russell) or

Re: [PATCH] HP Jornada 7xx keyboard support

2007-07-20 Thread Kristoffer Ericson
Greetings, Ive added it to free IRQ as you said, a minor change is also that jornada720.h defines are set in CAPS (just changed that for Russell). Ive also added the Kconfig and Makefile. Btw, do you keep patchtracker (like Russell) or drag from mail (like Paul)? Best wishes Kristoffer diff

Re: [PATCH] HP Jornada 7xx keyboard support

2007-07-18 Thread Dmitry Torokhov
Hi Kristoffer, On 7/18/07, Kristoffer Ericson <[EMAIL PROTECTED]> wrote: Greetings, Thank you for your patch, I have a couple of comments. Couldnt find any mailinglist, but please CC this there if there is one. CCing linus-input... + /* Lets drag them out one at a time */ +