Re: [PATCH 0/2] wistron_btns: More keymaps

2007-03-19 Thread Éric Piel
19.03.2007 22:28, Dmitry Torokhov wrote/a écrit: On 3/15/07, Éric Piel <[EMAIL PROTECTED]> wrote: Ok, so let me summarize: There are two kinds of keys on those laptops (for which we are not sure about the keycode that it should generate): * Laptop screen on/off * Display output selection (for

Re: [PATCH 0/2] wistron_btns: More keymaps

2007-03-19 Thread Dmitry Torokhov
On 3/15/07, Éric Piel <[EMAIL PROTECTED]> wrote: 03/14/2007 08:02 PM, Vojtech Pavlik wrote/a écrit: > On Wed, Mar 14, 2007 at 02:58:49PM -0400, Dmitry Torokhov wrote: > 2. I also have a concern about using KEY_SCREEN to signal toggling display on and off. I am CCing Vojtech - he must kn

Re: [PATCH 0/2] wistron_btns: More keymaps

2007-03-15 Thread Éric Piel
03/14/2007 08:02 PM, Vojtech Pavlik wrote/a écrit: On Wed, Mar 14, 2007 at 02:58:49PM -0400, Dmitry Torokhov wrote: 2. I also have a concern about using KEY_SCREEN to signal toggling display on and off. I am CCing Vojtech - he must know what the original intent of this key code was. BTW, when u

Re: [PATCH 0/2] wistron_btns: More keymaps

2007-03-14 Thread Éric Piel
03/14/2007 08:02 PM, Dmitry Torokhov wrote/a écrit: On 3/14/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: On 3/14/07, Vojtech Pavlik <[EMAIL PROTECTED]> wrote: > On Wed, Mar 14, 2007 at 09:54:27AM -0400, Dmitry Torokhov wrote: > > Hi Eric, > > > > 2. I also have a concern about using KEY_SCREEN

Re: [PATCH 0/2] wistron_btns: More keymaps

2007-03-14 Thread Vojtech Pavlik
On Wed, Mar 14, 2007 at 02:58:49PM -0400, Dmitry Torokhov wrote: > >> I have couple of comments/requests: > >> > >> 1. KEY_OPEN and KEY_CLOSE should not be used to signal state of the > >> lid, they correspond to Accpication Control Open and Close keys from > >> USB HID HUT spec: > >> > >> htt

Re: [PATCH 0/2] wistron_btns: More keymaps

2007-03-14 Thread Dmitry Torokhov
On 3/14/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: On 3/14/07, Vojtech Pavlik <[EMAIL PROTECTED]> wrote: > On Wed, Mar 14, 2007 at 09:54:27AM -0400, Dmitry Torokhov wrote: > > Hi Eric, > > > > On 3/13/07, Eric Piel <[EMAIL PROTECTED]> wrote: > > >Hello, > > > > > >As a sequel to my patch "Wis

Re: [PATCH 0/2] wistron_btns: More keymaps

2007-03-14 Thread Dmitry Torokhov
On 3/14/07, Vojtech Pavlik <[EMAIL PROTECTED]> wrote: On Wed, Mar 14, 2007 at 09:54:27AM -0400, Dmitry Torokhov wrote: > Hi Eric, > > On 3/13/07, Eric Piel <[EMAIL PROTECTED]> wrote: > >Hello, > > > >As a sequel to my patch "Wistron button support for TravelMate 610" of > >last week, here is a bi

Re: [PATCH 0/2] wistron_btns: More keymaps

2007-03-14 Thread Vojtech Pavlik
On Wed, Mar 14, 2007 at 09:54:27AM -0400, Dmitry Torokhov wrote: > Hi Eric, > > On 3/13/07, Eric Piel <[EMAIL PROTECTED]> wrote: > >Hello, > > > >As a sequel to my patch "Wistron button support for TravelMate 610" of > >last week, here is a bigger addition of keymaps for the wistron_btns. > > > >P

Re: [PATCH 0/2] wistron_btns: More keymaps

2007-03-14 Thread Dmitry Torokhov
On 3/14/07, Éric Piel <[EMAIL PROTECTED]> wrote: 03/14/2007 02:54 PM, Dmitry Torokhov wrote/a écrit: > Hi Eric, > : > I have couple of comments/requests: > > 1. KEY_OPEN and KEY_CLOSE should not be used to signal state of the > lid, they correspond to Accpication Control Open and Close keys from

Re: [PATCH 0/2] wistron_btns: More keymaps

2007-03-14 Thread Éric Piel
03/14/2007 02:54 PM, Dmitry Torokhov wrote/a écrit: Hi Eric, : I have couple of comments/requests: 1. KEY_OPEN and KEY_CLOSE should not be used to signal state of the lid, they correspond to Accpication Control Open and Close keys from USB HID HUT spec: http://www.usb.org/developers/devc

Re: [PATCH 0/2] wistron_btns: More keymaps

2007-03-14 Thread Dmitry Torokhov
Hi Eric, On 3/13/07, Eric Piel <[EMAIL PROTECTED]> wrote: Hello, As a sequel to my patch "Wistron button support for TravelMate 610" of last week, here is a bigger addition of keymaps for the wistron_btns. Patch 1 adds all the database of acerhk which fits this driver (about 25 more laptops).