Re: [PATCH 1/1] gpio_mouse driver (rewritten to GIT kernel)

2007-06-05 Thread Hans-Christian Egtvedt
On Sat, 2007-06-02 at 00:24 -0400, Dmitry Torokhov wrote: > Hi, > > On Thursday 31 May 2007 07:38, Hans-Christian Egtvedt wrote: > > This patch adds support for simulating a mouse using GPIO lines. > > > > Thank you for updating the patch. It looks much better now, I see only > couple of issues:

Re: [PATCH 1/1] gpio_mouse driver (rewritten to GIT kernel)

2007-06-01 Thread Dmitry Torokhov
Hi, On Thursday 31 May 2007 07:38, Hans-Christian Egtvedt wrote: > This patch adds support for simulating a mouse using GPIO lines. > Thank you for updating the patch. It looks much better now, I see only couple of issues: > + > + if (!pdata) { > + dev_dbg(&pdev->dev, "no platfo

[PATCH 1/1] gpio_mouse driver (rewritten to GIT kernel)

2007-05-31 Thread Hans-Christian Egtvedt
This patch adds support for simulating a mouse using GPIO lines. The driver needs a platform_data struct to be defined and registered with the appropriate platform_device. The driver has been tested on AT32AP7000 microprocessor using the ATSTK1000 development board. Signed-off-by: Hans-Christian

Re: [PATCH 1/1] gpio_mouse driver

2007-05-30 Thread Dmitry Torokhov
On 5/30/07, Hans-Christian Egtvedt <[EMAIL PROTECTED]> wrote: Ok, I will pull your GIT tree sometime soon(tm), and update the patch to match the new standard. A bit unsure about when, but in good time before 2.6.23. Thank you. A couple of things to remember - the merge window for new code is

Re: [PATCH 1/1] gpio_mouse driver

2007-05-30 Thread Hans-Christian Egtvedt
On Wed, 2007-05-30 at 08:30 -0400, Dmitry Torokhov wrote: > On 5/30/07, Hans-Christian Egtvedt <[EMAIL PROTECTED]> wrote: > > On Tue, 2007-05-29 at 11:36 -0400, Dmitry Torokhov wrote: > > > Hi, > > > > > > On 5/29/07, Hans-Christian Egtvedt <[EMAIL PROTECTED]> wrote: > > > > This patch adds support

Re: [PATCH 1/1] gpio_mouse driver

2007-05-30 Thread Dmitry Torokhov
On 5/30/07, Hans-Christian Egtvedt <[EMAIL PROTECTED]> wrote: On Tue, 2007-05-29 at 11:36 -0400, Dmitry Torokhov wrote: > Hi, > > On 5/29/07, Hans-Christian Egtvedt <[EMAIL PROTECTED]> wrote: > > This patch adds support for simulating a mouse using GPIO lines. > > > > The driver needs a platform_

Re: [PATCH 1/1] gpio_mouse driver

2007-05-30 Thread Hans-Christian Egtvedt
On Wed, 2007-05-30 at 08:23 +0200, Hans-Christian Egtvedt wrote: > On Tue, 2007-05-29 at 11:36 -0400, Dmitry Torokhov wrote: > > I don't think it is a good idea to have timer structure in platform > > data which should really be constant. Timer shoudl be part of the > > stucture created when dri

Re: [PATCH 1/1] gpio_mouse driver

2007-05-29 Thread Hans-Christian Egtvedt
On Tue, 2007-05-29 at 11:36 -0400, Dmitry Torokhov wrote: > Hi, > > On 5/29/07, Hans-Christian Egtvedt <[EMAIL PROTECTED]> wrote: > > This patch adds support for simulating a mouse using GPIO lines. > > > > The driver needs a platform_data struct to be defined and registered with > > the > > appr

Re: [PATCH 1/1] gpio_mouse driver

2007-05-29 Thread Dmitry Torokhov
Hi, On 5/29/07, Hans-Christian Egtvedt <[EMAIL PROTECTED]> wrote: This patch adds support for simulating a mouse using GPIO lines. The driver needs a platform_data struct to be defined and registered with the appropriate platform_device. The driver has been tested on AT32AP7000 microprocessor

[PATCH 1/1] gpio_mouse driver

2007-05-29 Thread Hans-Christian Egtvedt
This patch adds support for simulating a mouse using GPIO lines. The driver needs a platform_data struct to be defined and registered with the appropriate platform_device. The driver has been tested on AT32AP7000 microprocessor using the ATSTK1000 development board. Signed-off-by: Hans-Christian

[PATCH 1/1] gpio_mouse driver

2007-05-29 Thread Hans-Christian Egtvedt
From: Hans-Christian Egtvedt <[EMAIL PROTECTED]> This patch adds support for simulating a mouse using GPIO lines. The driver needs a platform_data struct to be defined and registered with the appropriate platform_device. The driver has been tested on AT32AP7000 microprocessor using the ATSTK1000