Re: [PATCH 1/2] HID: wacom: Use half of brightness for low state

2012-08-03 Thread Ping Cheng
On Tue, Jul 31, 2012 at 10:27 AM, Przemo Firszt wrote: > Intuos4 WL leds have 2 states: high and low. With no activity tablet > uses low state; using pen triggers high state. Both can be set > independently, but it would require setting another led device to > control them separately. This patch u

Re: [RFC ebeam PATCH v2 3/3] input: misc: New USB eBeam input driver.

2012-08-03 Thread Yann Cantin
Hi, >> +#include > > As this driver is not a HID bus driver, why do you need this include? Cinder, removed >> +#define DRIVER_VERSION "v0.7" > > I don't think we need to be tracking driver versions for newly submitted > drivers, git is much better at tracking changes. Old habit, remove

[PATCH] Input: gpio_keys - fix NULL pointer dereference for dt case

2012-08-03 Thread Fabio Estevam
Commit 30161f6b2e7d1 (Input: gpio_keys - clean up device tree parser) introduced the following kernel crash for a dt based kernel: .. Unable to handle kernel NULL pointer dereference at virtual address 0004 pgd = 80004000 [0004] *pgd= Internal error: Oops: 805 [#1] ARM Modules link

Re: [RFC ebeam PATCH v2 3/3] input: misc: New USB eBeam input driver.

2012-08-03 Thread Jiri Kosina
On Thu, 2 Aug 2012, Yann Cantin wrote: > Signed-off-by: Yann Cantin > --- > drivers/input/misc/Kconfig | 16 + > drivers/input/misc/Makefile |1 + > drivers/input/misc/ebeam.c | 760 > +++ > 3 files changed, 777 insertions(+) > create mode 10064

Re: [RFC ebeam PATCH v2 0/3] new USB eBeam input driver

2012-08-03 Thread Yann Cantin
Hi, Le 02/08/2012 16:16, Jiri Kosina a écrit : >> Patch 1 and 2 are here to let the ebeam driver be choose to handle >> the device instead of the generic-usb hid one (totally useless). > > Just merge 1 and 2 together, not necessary to have two commits because of > that. Ok, will do that for the

Re: [PATCH 1/1]hid:hid-multitouch: add mt_resume for ELAN's production

2012-08-03 Thread Jian-Jhong Ding
Hi Scott, 劉嘉駿 writes: > Some of ELAN’s production need to issue set_idle when resume. > > Signed-off-by: Scott Liu You might want to add a From: line at the top of mail body to make your name go along with the SoB line. > --- > drivers/hid/hid-ids.h|3 +++ > drivers/hid/hid-multit

[PATCH 1/1]hid:hid-multitouch: add mt_resume for ELAN's production

2012-08-03 Thread 劉嘉駿
Some of ELAN’s production need to issue set_idle when resume. Signed-off-by: Scott Liu --- drivers/hid/hid-ids.h|3 +++ drivers/hid/hid-multitouch.c | 27 +++ 2 files changed, 30 insertions(+) mode change 100644 => 100755 drivers/hid/hid-ids.h mode change

Re: [PATCH 1/1]hid:hid-multitouch: add mt_resume for ELAN's production

2012-08-03 Thread Jiri Kosina
On Fri, 3 Aug 2012, 劉嘉駿 wrote: > Some of ELAN’s production need to issue set_idle when resume. Scott, your e-mail client broke the patch in a way that it's not only impossible to apply it using standard tools, but it's also unreadable by eyes (a lot of whitespaces, broken lines, every second l