Re: [PATCH 1/4] Input: cyttsp4 - bus driver for Cypress TMA4XX touchscreen devices

2012-08-07 Thread Ferruh Yigit
Hello Javier, We needed a new modular driver mechanism so that we can handle the very flexible new generation of Cypress multi-touch devices (TMA4XX and TMA5XX). With this initial set of patches we are providing the primary function of multi-touch processing, according to protocol B, as the foun

Re: [PATCH 1/2] Input: egalax_ts: get gpio from devicetree node

2012-08-07 Thread Hui Wang
OK, will add it in the V2. Thanks, Hui. Zhang Jiejing-B33651 wrote: > Hi Hui, > > You patch looks good to me, but can you add a check when it calling the > egalax_wake_up_device() function in egalax_ts_probe() ? If some configure > gose wrong, the probe of driver will exit, rather than the susp

Re: [PATCH 1/2] Input: egalax_ts: get gpio from devicetree node

2012-08-07 Thread Zhang Jiejing-B33651
Hi Hui, You patch looks good to me, but can you add a check when it calling the egalax_wake_up_device() function in egalax_ts_probe() ? If some configure gose wrong, the probe of driver will exit, rather than the suspend failure every time. BR, Jiejing 在 2012-8-7,下午5:39,Hui Wang 写道: > The ir

Re: [PATCH] Input: omap4-keypad - don't leak in omap4_keypad_probe()

2012-08-07 Thread Sachin Kamat
On 7 August 2012 23:46, Jesper Juhl wrote: > If omap4_keypad_parse_dt() does not return 0 (zero) in > omap4_keypad_probe() we will leak the memory we allocated for > 'keypad_data' with kzalloc() when we return and the variable goes out > of scope. How about using devm_kzalloc() instead which will

[PATCH] hid:hid-multitouch: add mt_resume for ELAN's production

2012-08-07 Thread Scott Liu
Some of ELAN’s production need to issue set_idle when resume. Signed-off-by: Scott Liu --- drivers/hid/hid-ids.h|3 +++ drivers/hid/hid-multitouch.c | 26 ++ 2 files changed, 29 insertions(+) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index

Re: [PATCH 1/4] Input: cyttsp4 - bus driver for Cypress TMA4XX touchscreen devices

2012-08-07 Thread Javier Martinez Canillas
On Tue, Aug 7, 2012 at 3:09 PM, Ferruh Yigit wrote: > From: Ferruh YIGIT > > This driver is for Cypress TrueTouch(tm) Standard Product controllers, > Generation4 devices. > > Driver consist of four main modules: > > Bus driver: Linux bus driver implementation, binds other modules. > Core driver:

[PATCH] Input: omap4-keypad - don't leak in omap4_keypad_probe()

2012-08-07 Thread Jesper Juhl
If omap4_keypad_parse_dt() does not return 0 (zero) in omap4_keypad_probe() we will leak the memory we allocated for 'keypad_data' with kzalloc() when we return and the variable goes out of scope. Fix the leak by jumping to the 'err_free_keypad' label where we properly free the allocated memory, in

Re: [PATCH 1/1] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots

2012-08-07 Thread Mark Brown
On Tue, Aug 07, 2012 at 06:01:30PM +0100, Lee Jones wrote: > Okay, so I've just spent a small amount of time looking at this. I think > the best place for this would be in *_get_virq(), using the same logic that > selected a *_legacy or *_linear domain in the first place. The only thing > the dom

Re: [PATCH 1/1] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots

2012-08-07 Thread Lee Jones
On Mon, Aug 06, 2012 at 05:02:26PM +0100, Mark Brown wrote: > On Mon, Aug 06, 2012 at 04:37:52PM +0100, Lee Jones wrote: > > On Mon, Aug 06, 2012 at 01:19:15AM -0700, Dmitry Torokhov wrote: > > > > > + ponkey->irq_dbf = (np) ? ab8500_irq_get_virq(ab8500, irq_dbf) : > > > > irq_dbf; > > > >

Re: Emulating level IRQs

2012-08-07 Thread Daniel Mack
On 06.08.2012 18:36, Mark Brown wrote: > On Mon, Aug 06, 2012 at 09:45:13AM +0800, Eric Miao wrote: > >> So my understanding, if it's correct, that we can treat the EETI chip as >> having >> two separate inputs: one IRQ line (for the event notification) and one GPIO >> line >> (for a condition w

[PATCH 4/4] Input: cyttsp4 - I2C driver for Cypress TMA4XX touchscreen devices

2012-08-07 Thread Ferruh Yigit
From: Ferruh YIGIT Cypress TrueTouch(tm) Standard Product controllers, Generation4 devices, I2C adapter module. This driver adds communication support with TTSP controller using I2C bus. Signed-off-by: Ferruh YIGIT --- drivers/input/touchscreen/Kconfig | 13 ++ drivers/input/touchscre

[PATCH 3/4] Input: cyttsp4 - MultiTouch driver for Cypress TMA4XX touchscreen devices

2012-08-07 Thread Ferruh Yigit
From: Ferruh YIGIT Cypress TrueTouch(tm) Standard Product controllers, Generetion4 devices, MutliTouch driver. Subscribes to core driver and converts touch information to OS specific touch events. This module is supports multi-touch protocol type B reports. Signed-off-by: Ferruh YIGIT --- dr

[PATCH 1/4] Input: cyttsp4 - bus driver for Cypress TMA4XX touchscreen devices

2012-08-07 Thread Ferruh Yigit
From: Ferruh YIGIT This driver is for Cypress TrueTouch(tm) Standard Product controllers, Generation4 devices. Driver consist of four main modules: Bus driver: Linux bus driver implementation, binds other modules. Core driver: Core module that communicate with TTSP controller. MT driver: MultiT

[PATCH] Input: twl6040-vibra: Code cleanup in probe with devm_* conversion

2012-08-07 Thread Peter Ujfalusi
Convert the probe to use devm_*. At the same time reorder the calls so we will register the input device as the last step when the driver is loaded. Signed-off-by: Peter Ujfalusi --- drivers/input/misc/twl6040-vibra.c | 99 --- 1 files changed, 45 insertions(+),

Re: [PATCH] Input: Fix edt-ft5x06 build error seen if CONFIG_DEBUG_FS is not defined

2012-08-07 Thread Simon Budig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/07/2012 05:02 AM, Guenter Roeck wrote: > Fix: > > edt-ft5x06.c: In function edt_ft5x06_ts_remove: > edt-ft5x06.c:846:14: error: struct edt_ft5x06_ts_data has no member > named raw_buffer Oops sorry, forgot to test compiling the driver without

[PATCH 2/2] Input: add devicetree binding note for egalax_ts

2012-08-07 Thread Hui Wang
The egalax_ts driver needs to get the gpio number of the irq pin, and use this gpio to wake up the controller. So add a note for this change. Signed-off-by: Hui Wang --- .../bindings/input/touchscreen/egalax-ts.txt | 17 + 1 files changed, 17 insertions(+), 0 deletions(-)

[PATCH 1/2] Input: egalax_ts: get gpio from devicetree node

2012-08-07 Thread Hui Wang
The irq_to_gpio() is old, most platforms use GENERIC_GPIO framework and don't support this API anymore. The i.MX6q sabrelite platform equips an egalax touchscreen controller, and this platform already transfered to GENERIC_GPIO framework, to support this driver, we use a more generic way to get gp

[PATCH 0/2] Input: egalax_ts: parse devicetree to get gpio

2012-08-07 Thread Hui Wang
eeti touch screen controller is an external chip for most platforms, it connect to CPU via i2c bus, and it has a irq request pin need to be connected to a gpio of the CPU, this irq request pin also act as a wake up signal for touch screen controller, we need to get this gpio number and operate it t

Re: [RFC ebeam PATCH v3 1/2] hid: Blacklist new eBeam classic device

2012-08-07 Thread Yann Cantin
Le 07/08/2012 03:45, Dmitry Torokhov a écrit : > On Tue, Aug 07, 2012 at 03:21:45AM +0200, Yann Cantin wrote: >> Le 07/08/2012 00:07, Dmitry Torokhov a écrit : >>> On Monday, August 06, 2012 02:43:40 PM Greg KH wrote: On Mon, Aug 06, 2012 at 11:21:43PM +0200, Yann Cantin wrote: > Signed-of

Re: [RFC ebeam PATCH v3 2/2] input: misc: New USB eBeam input driver.

2012-08-07 Thread Yann Cantin
Le 07/08/2012 03:43, Dmitry Torokhov a écrit : > On Tue, Aug 07, 2012 at 02:56:40AM +0200, Yann Cantin wrote: >> Hi, >> >> Le 06/08/2012 23:43, Greg KH a écrit : >>> On Mon, Aug 06, 2012 at 11:21:44PM +0200, Yann Cantin wrote: Signed-off-by: Yann Cantin --- drivers/input/misc/