[PATCH/RFC] HID: roccat: removing devices from blacklist

2012-09-17 Thread Stefan Achatz
I would suggest to remove the Roccat devices from generic drivers blacklist. Some Distros tend to have kernels without the special modules compiled, which prevents users of these devices to work with live images or installers. The Roccat devices work flawlessly with generic drivers (except the

Re: [PATCH] HID: wacom: Fix wacom_probe error handling

2012-09-17 Thread Przemo Firszt
Dnia 17 Września 2012, 3:29 am, Pn, Axel Lin napisał(a): In the case of goto destroy_leds, we also need to call hid_hw_stop(hdev) and remove sysfs attribute files we created for speed and oleds. Signed-off-by: Axel Lin axel@gmail.com --- drivers/hid/hid-wacom.c | 12 ++-- 1

Re: [PATCH] HID: wacom: Fix wacom_probe error handling

2012-09-17 Thread Axel Lin
2012/9/17 Przemo Firszt prz...@firszt.eu: Dnia 17 Września 2012, 3:29 am, Pn, Axel Lin napisał(a): In the case of goto destroy_leds, we also need to call hid_hw_stop(hdev) and remove sysfs attribute files we created for speed and oleds. Signed-off-by: Axel Lin axel@gmail.com ---

[PATCH v2] HID: wacom: Fix wacom_probe error handling

2012-09-17 Thread Axel Lin
OLEDs/LED are not critical for tablet functioning thus ignore OLED/LED initialisation failures. This patch does clean up all the sysfs attribute files in error paths. Signed-off-by: Axel Lin axel@gmail.com --- drivers/hid/hid-wacom.c | 23 ++- 1 file changed, 14

Re: [PATCH v3] input: qt1070: Add device tree support

2012-09-17 Thread Nicolas Ferre
On 09/11/2012 12:14 PM, Bo Shen : Add qt1070 device tree support Using device node to parse irq Test this on at91sam9x5ek board Signed-off-by: Bo Shen voice.s...@atmel.com --- change since v2 Using device node to parse irq, Remove gpio relative stuff change since v1 Add gpio

[PATCH 2/2] HID: wiimote: Parse calibration data of balance boards

2012-09-17 Thread David Herrmann
From: Florian Echtler f...@butterbrot.org The raw pressure-data that is reported by balance-boards is pretty useless unless calibration data is applied. Therefore, we read the full calibration data on extension initialization and apply it to every reported data. Signed-off-by: David Herrmann

Re: [PATCH] HID: lenovo-tpkbd: Fix memory leak in tpkbd_remove_tp()

2012-09-17 Thread Jiri Kosina
On Fri, 14 Sep 2012, Bernhard Seibold wrote: On Thu, 13 Sep 2012 13:25:12 +0800 Axel Lin axel@gmail.com wrote: We need to kfree names for led_mute and led_micmute in tpkbd_remove_tp(). Signed-off-by: Axel Lin axel@gmail.com Acked-by: Bernhard Seibold

RE: [PATCH 3/3] HID: hid-sensor-hub: Call hid_hw_close() before hid_hw_stop()

2012-09-17 Thread Jiri Kosina
On Thu, 13 Sep 2012, Pandruvada, Srinivas wrote: I think you can merge this patch with your patch 2/3 as both are addressing hid_hw_close and hid_hw_stop. Agreed. In addition to that, I am fine with the changes. As this whole lot is going through Jonathan to Greg, I just add my

Re: [patch 1/2] HID: sensors: use GFP_ATOMIC under spinlock

2012-09-17 Thread Jiri Kosina
On Fri, 14 Sep 2012, Dan Carpenter wrote: We're holding a spinlock here so we can't call kmalloc() with GFP_KERNEL. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Jiri Kosina jkos...@suse.cz Jonathan, could you please take this one as well, as it depends on the

Re: [PATCH] HID: Fix return value in hid-core.c

2012-09-17 Thread Jiri Kosina
On Fri, 14 Sep 2012, Sachin Kamat wrote: Return -ENOMEM instead of -1 if memory allocation fails. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/hid/hid-core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/hid/hid-core.c

Re: [PATCH/RFC] HID: roccat: removing devices from blacklist

2012-09-17 Thread Jiri Kosina
On Mon, 17 Sep 2012, Stefan Achatz wrote: I would suggest to remove the Roccat devices from generic drivers blacklist. Some Distros tend to have kernels without the special modules compiled, which prevents users of these devices to work with live images or installers. The Roccat devices

Re: [PATCH 1/4] HID: lg: Remove unnecessary casts of void pointers

2012-09-17 Thread Jiri Kosina
On Thu, 13 Sep 2012, Axel Lin wrote: Signed-off-by: Axel Lin axel@gmail.com --- drivers/hid/hid-lg.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in

Re: [PATCH 2/4] HID: lg4ff: Remove unnecessary casts of void pointers

2012-09-17 Thread Jiri Kosina
On Thu, 13 Sep 2012, Axel Lin wrote: Signed-off-by: Axel Lin axel@gmail.com --- drivers/hid/hid-lg4ff.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c index f3390ee..da23c6b 100644 ---

Re: [PATCH 3/4] HID: prodikeys: Remove unnecessary casts of void pointers

2012-09-17 Thread Jiri Kosina
On Thu, 13 Sep 2012, Axel Lin wrote: Signed-off-by: Axel Lin axel@gmail.com --- drivers/hid/hid-prodikeys.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) Applied, thanks Axel. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: [PATCH] HID: Fix return value in hid-core.c

2012-09-17 Thread Sachin Kamat
On 17 September 2012 16:32, Jiri Kosina jkos...@suse.cz wrote: On Fri, 14 Sep 2012, Sachin Kamat wrote: Return -ENOMEM instead of -1 if memory allocation fails. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/hid/hid-core.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH Resend] HID: Fix return values in hid-core.c

2012-09-17 Thread Sachin Kamat
Return -ENOMEM instead of -1 if memory allocation fails. Return -EINVAL instead of -1 for stack overflow and underflow errors. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/hid/hid-core.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH Resend] HID: Fix return values in hid-core.c

2012-09-17 Thread Jiri Kosina
On Mon, 17 Sep 2012, Sachin Kamat wrote: Return -ENOMEM instead of -1 if memory allocation fails. Return -EINVAL instead of -1 for stack overflow and underflow errors. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/hid/hid-core.c |6 +++--- 1 files changed, 3

Re: [Patch v1 7/7] DA9055 Onkey driver

2012-09-17 Thread Ashish Jangam
On Mon, 2012-09-17 at 16:28 +0530, Ashish Jangam wrote: -Original Message- From: Laxman Dewangan [mailto:ldewan...@nvidia.com] Sent: Friday, September 14, 2012 6:48 PM To: Ashish Jangam Cc: Liam Girdwood; Samuel Ortiz; linux-input@vger.kernel.org; David Dajun Chen Subject: Re:

[PATCH] HID: cypress: Use swap macro

2012-09-17 Thread Axel Lin
This simplify the implementation. Signed-off-by: Axel Lin axel@gmail.com --- drivers/hid/hid-cypress.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/hid/hid-cypress.c b/drivers/hid/hid-cypress.c index 3e159a5..3b795a2 100644 ---

[PATCH v2] HID: roccat: conditional blacklisting of Roccat modules

2012-09-17 Thread Stefan Achatz
Roccat devices are standard compatible, specific drivers are only needed for extended functionality. If Roccat drivers are not configured, hid-generic binds these devices now. Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net --- drivers/hid/hid-core.c |2 ++ 1 files changed, 2

[PATCH 0/2] input: convert to c99 format

2012-09-17 Thread Shubhrajyoti D
The series tries to convert the i2c_msg to c99 struct. This may avoid issues like below if someone tries to add an element to the structure. http://www.mail-archive.com/linux-i2c@vger.kernel.org/msg08972.html Special thanks to Julia Lawall for helping it automate. By the below script.

[PATCH 2/2] input: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- drivers/input/touchscreen/cy8ctmg110_ts.c

[PATCH 1/2] input: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- drivers/input/joystick/as5011.c |6

Re: [PATCH 1/2] HID: wiimote: Add Nintendo Balance-Board support

2012-09-17 Thread Florian Echtler
Tested-by: Florian Echtler f...@butterbrot.org On 17.09.2012 12:31, David Herrmann wrote: The Nintendo Balance-Board is a controller which behaves exactly like the Wii Remote but reports all its data through a special extension device. Hence, we can simply add the Balance-Board as extension

Re: [PATCH 2/2] HID: wiimote: Parse calibration data of balance boards

2012-09-17 Thread Florian Echtler
Signed-off-by: Florian Echtler f...@butterbrot.org On 17.09.2012 12:31, David Herrmann wrote: From: Florian Echtler f...@butterbrot.org The raw pressure-data that is reported by balance-boards is pretty useless unless calibration data is applied. Therefore, we read the full calibration data on

RE: [PATCH 3/3] HID: hid-sensor-hub: Call hid_hw_close() before hid_hw_stop()

2012-09-17 Thread Pandruvada, Srinivas
Hi Alex, Can you resubmit your patches merging 2/3 and 3/3? Thanks, Srinivas -Original Message- From: Jiri Kosina [mailto:jkos...@suse.cz] Sent: Monday, September 17, 2012 3:58 AM To: Pandruvada, Srinivas Cc: Axel Lin; Jonathan Cameron; linux-input@vger.kernel.org Subject: RE: [PATCH

Re: [PATCH 2/2] HID: wiimote: Parse calibration data of balance boards

2012-09-17 Thread Florian Echtler
Darn, I just realized there may be an error here: On 17.09.2012 12:31, David Herrmann wrote: drivers/hid/hid-wiimote-ext.c | 39 ++- 1 file changed, 38 insertions(+), 1 deletion(-) + /* apply calibration data */ + for (i = 0; i 4; i++) { +

RE: [patch 1/2] HID: sensors: use GFP_ATOMIC under spinlock

2012-09-17 Thread Pandruvada, Srinivas
Tested this and works. -Original Message- From: Jiri Kosina [mailto:jkos...@suse.cz] Sent: Monday, September 17, 2012 3:59 AM To: Dan Carpenter Cc: Pandruvada, Srinivas; linux-input@vger.kernel.org; kernel-janit...@vger.kernel.org; Jonathan Cameron Subject: Re: [patch 1/2] HID:

RE: [patch 2/2] HID: sensors: remove some unneeded checks

2012-09-17 Thread Pandruvada, Srinivas
Tested this and it works. -Original Message- From: Jiri Kosina [mailto:jkos...@suse.cz] Sent: Monday, September 17, 2012 4:00 AM To: Dan Carpenter Cc: Pandruvada, Srinivas; linux-input@vger.kernel.org; kernel-janit...@vger.kernel.org; Jonathan Cameron Subject: Re: [patch 2/2] HID:

Re: [PATCH 1/2] HID: wiimote: Add Nintendo Balance-Board support

2012-09-17 Thread Jiri Kosina
On Mon, 17 Sep 2012, Florian Echtler wrote: Tested-by: Florian Echtler f...@butterbrot.org Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 2/2] HID: wiimote: Parse calibration data of balance boards

2012-09-17 Thread Jiri Kosina
On Mon, 17 Sep 2012, Florian Echtler wrote: Darn, I just realized there may be an error here: On 17.09.2012 12:31, David Herrmann wrote: drivers/hid/hid-wiimote-ext.c | 39 ++- 1 file changed, 38 insertions(+), 1 deletion(-) + /* apply

Re: [PATCH v2] HID: roccat: conditional blacklisting of Roccat modules

2012-09-17 Thread Jiri Kosina
On Mon, 17 Sep 2012, Stefan Achatz wrote: Roccat devices are standard compatible, specific drivers are only needed for extended functionality. If Roccat drivers are not configured, hid-generic binds these devices now. Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net Applied,

Re: [PATCH] HID: picolcd_core: Remove setting hdev-claimed before calling hid_hw_start()

2012-09-17 Thread Bruno Prémont
On Fri, 14 September 2012 Axel Lin axel@gmail.com wrote: Current implementation of hid_hw_start() allows connect_mask to be 0. Setting hdev-claimed = HID_CLAIMED_INPUT before calling hid_hw_start() is not necessary. Remove it. Signed-off-by: Axel Lin axel@gmail.com Acked-By: Bruno

[PATCH] HID: wiimote: fix weight conversion error for values 17kg

2012-09-17 Thread Florian Echtler
Signed-Off-By: Florian Echtler f...@butterbrot.org --- drivers/hid/hid-wiimote-ext.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-wiimote-ext.c b/drivers/hid/hid-wiimote-ext.c index fc98cc9..bc85bf2 100644 --- a/drivers/hid/hid-wiimote-ext.c +++

[PATCH] usbhid: call report_fixup before comparing descriptors

2012-09-17 Thread Kevin Daughtridge
hid_post_reset checks the stored report descriptor against what is currently returned by the device. An HID driver's report_fixup method may have changed the stored descriptor, however, creating false positives. These leave some devices nonfunctional after a resume, with a reset_resume error 1

RE: [PATCH v2] HID: wacom: Fix wacom_probe error handling

2012-09-17 Thread Ping Cheng
If device_remove_file is needed for hid-wacom.c, it should be considered for wacm_sys.c as well. Eduard, what do you think? Ping -Original Message- From: Axel Lin [mailto:axel@gmail.com] Sent: Monday, September 17, 2012 1:54 AM To: Jiri Kosina Cc: Przemo Firszt; Ping Cheng;

Re: [patch] HID: picoLCD: off by one in dump_buff_as_hex()

2012-09-17 Thread Bruno Prémont
Hi Dan, On Fri, 14 September 2012 Dan Carpenter dan.carpen...@oracle.com wrote: We're placing the NUL terminator one character beyond the end of the buffer here. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- This change obviously don't make the code worse, but I'm not positive

Re: [PATCH] HID: wiimote: fix weight conversion error for values 17kg

2012-09-17 Thread David Herrmann
On Mon, Sep 17, 2012 at 9:15 PM, Florian Echtler f...@butterbrot.org wrote: Signed-Off-By: Florian Echtler f...@butterbrot.org --- drivers/hid/hid-wiimote-ext.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-wiimote-ext.c

[PATCH RESEND 1/2] HID: hid-sensor-hub: Remove setting hdev-claimed before calling hid_hw_start()

2012-09-17 Thread Axel Lin
Current implementation of hid_hw_start() allows connect_mask to be 0. Setting hdev-claimed = HID_CLAIMED_INPUT before calling hid_hw_start() is not necessary. Remove it. Signed-off-by: Axel Lin axel@gmail.com --- drivers/hid/hid-sensor-hub.c |2 -- 1 file changed, 2 deletions(-) diff

[PATCH v2 2/2] HID: hid-sensor-hub: Fix sensor_hub_probe error handling

2012-09-17 Thread Axel Lin
Fix below issues: 1. In the case of goto err_close, hid_hw_stop(hdev) is called twice. Fix it. 2. If fails to allocate MFD device name, we also need to free all successfully allocated names in previous iterations. 3. In sensor_hub_remove(), Call hid_hw_close() before hid_hw_stop(). 4. Adjust

[PATCH v2] HID: Add support for Sony PS3 BD Remote Control

2012-09-17 Thread David Dillow
The Sony PS3 Blue-ray Disc Remote Control used to be supported by the BlueZ project's user space, but the code that handled it was recently removed as its functionality conflicted with a real HSP implementation and the mapping was thought to be better handled in the kernel. This is a port of the

Re: [PATCH v3] input: qt1070: Add device tree support

2012-09-17 Thread Bo Shen
Hi Nicolas, On 9/17/2012 17:20, Nicolas Ferre wrote: On 09/11/2012 12:14 PM, Bo Shen : Add qt1070 device tree support Using device node to parse irq Test this on at91sam9x5ek board Signed-off-by: Bo Shen voice.s...@atmel.com --- change since v2 Using device node to parse irq, Remove