This is unneeded, only a bound driver can use driver data and a driver
relying on the state prior to probe() is buggy.
Signed-off-by: Mark Brown
---
drivers/input/touchscreen/wm831x-ts.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/touchscreen/wm831x-ts.c
b/drivers/input/
Saves a small amount of code and reduces the potential for leaks.
Signed-off-by: Mark Brown
---
drivers/input/misc/wm831x-on.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/input/misc/wm831x-on.c b/drivers/input/misc/wm831x-on.c
index 6790a81..fa8b390 100644
Saves a little code and eliminates the possibility of introducing some
leaks.
Signed-off-by: Mark Brown
---
drivers/input/touchscreen/wm831x-ts.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/input/touchscreen/wm831x-ts.c
b/drivers/input/touchscreen/wm831x-
On Wed, Oct 10, 2012 at 10:20:35PM +0900, Mark Brown wrote:
> Saves a little code and eliminates the possibility of introducing some
> leaks.
>
*sigh* OK, I guess devm_* is here to stay and I have to get on with the
program. I am still unhappy that half of the patches converting/using
devm_* APIs
On Thu, Oct 11, 2012 at 12:39:55AM -0700, Dmitry Torokhov wrote:
> On Wed, Oct 10, 2012 at 10:20:35PM +0900, Mark Brown wrote:
> > Saves a little code and eliminates the possibility of introducing some
> > leaks.
> *sigh* OK, I guess devm_* is here to stay and I have to get on with the
> program.
On Wed, 10 Oct 2012, Dmitry Torokhov wrote:
> Hi Lee,
>
> On Fri, Oct 05, 2012 at 04:31:43PM +0100, Lee Jones wrote:
> > This patch allows the STMPE driver to be successfully probed and
> > initialised when Device Tree support is enabled. Besides the usual
> > platform data changes, we also separ
On Thu, Oct 11, 2012 at 04:15:56AM +, Christopher Heiny wrote:
> On Thursday, October 11, 2012 02:21:53 AM you wrote:
> > On Sat, Oct 6, 2012 at 6:09 AM, Christopher Heiny
> > wrote:
>
> >
> > > +
> > > +/** This is here because all those casts made for some ugly code.
> > > + */
> > > +sta
On Fri, Oct 05, 2012 at 09:09:58PM -0700, Christopher Heiny wrote:
> +
> + int (*write_block)(struct rmi_phys_device *phys, u16 addr, u8 *buf,
> +int len);
> + int (*read_block)(struct rmi_phys_device *phys, u16 addr, u8 *buf,
> + int len);
> +
On Thu, Oct 11, 2012 at 03:41:41AM +, Christopher Heiny wrote:
> Linus Walleij wrote:
> > On Sat, Oct 6, 2012 at 6:09 AM, Christopher Heiny
> > wrote:
> >
> > > +#ifdef CONFIG_RMI4_DEBUG
> > > +/**
> > > + * Utility routine to handle writes to read-only attributes. Hopefully
> > > + * this
On Thu, Oct 11, 2012 at 05:07:24PM +0900, Mark Brown wrote:
> On Thu, Oct 11, 2012 at 12:39:55AM -0700, Dmitry Torokhov wrote:
> > On Wed, Oct 10, 2012 at 10:20:35PM +0900, Mark Brown wrote:
> > > Saves a little code and eliminates the possibility of introducing some
> > > leaks.
>
> > *sigh* OK,
On Thu, Oct 11, 2012 at 01:27:49AM -0700, Dmitry Torokhov wrote:
> On Thu, Oct 11, 2012 at 05:07:24PM +0900, Mark Brown wrote:
> >
> > What's the error pattern you're seeing? I've not noticed much of an
> > issue here, but if there is one perhaps we can do something to make the
> > error more ob
Add LAKML ...
On Wed, Oct 10, 2012 at 09:30:36AM -0700, Dmitry Torokhov wrote:
> Hi Hui,
>
> On Wed, Oct 10, 2012 at 05:12:01PM +0800, Hui Wang wrote:
> > The irq_to_gpio() is old, most platforms use GENERIC_GPIO framework
> > and don't support this API anymore.
> >
> > The i.MX6q sabrelite plat
Shawn Guo wrote:
Add LAKML ...
On Wed, Oct 10, 2012 at 09:30:36AM -0700, Dmitry Torokhov wrote:
Hi Hui,
On Wed, Oct 10, 2012 at 05:12:01PM +0800, Hui Wang wrote:
The irq_to_gpio() is old, most platforms use GENERIC_GPIO framework
and don't support this API anymore.
The i.MX6q sabreli
On Thu, Oct 11, 2012 at 04:55:40PM +0800, Shawn Guo wrote:
> Add LAKML ...
>
> On Wed, Oct 10, 2012 at 09:30:36AM -0700, Dmitry Torokhov wrote:
> > Hi Hui,
> >
> > On Wed, Oct 10, 2012 at 05:12:01PM +0800, Hui Wang wrote:
> > > The irq_to_gpio() is old, most platforms use GENERIC_GPIO framework
>
On Wednesday 10 October 2012, Dmitry Torokhov wrote:
> On Wed, Oct 10, 2012 at 05:12:01PM +0800, Hui Wang wrote:
> > The irq_to_gpio() is old, most platforms use GENERIC_GPIO framework
> > and don't support this API anymore.
> >
> > The i.MX6q sabrelite platform equips an egalax touchscreen contro
This is the ONKEY driver of the Dialog DA9055 PMIC and depends on the DA9055 MFD
core driver.
This patch is functionally tested on SMDK6410 board.
Signed-off-by: David Dajun Chen
Signed-off-by: Ashish Jangam
---
changes since v3:
- used of module_platform_driver macro
- add regmap virtual irq f
From: Jonas Aaberg
Disable hardware if active when suspending if the hw can not
wake the system from suspend.
Cc: Dmitry Torokhov
Cc: linux-input@vger.kernel.org
Acked-by: Lee Jones
Signed-off-by: Jonas Aaberg
Signed-off-by: Philippe Langlais
Reviewed-by: Bengt Jonsson
---
drivers/input/ke
From: Jonas Aaberg
Cc: Dmitry Torokhov
Cc: linux-input@vger.kernel.org
Acked-by: Lee Jones
Signed-off-by: Jonas Aaberg
Signed-off-by: Philippe Langlais
Reviewed-by: Bengt Jonsson
---
drivers/input/keyboard/gpio_keys.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
On Thu, Oct 11, 2012 at 7:45 PM, Lee Jones wrote:
> From: Jonas Aaberg
Some change logs would have helped.
>
> Cc: Dmitry Torokhov
> Cc: linux-input@vger.kernel.org
> Acked-by: Lee Jones
> Signed-off-by: Jonas Aaberg
> Signed-off-by: Philippe Langlais
> Reviewed-by: Bengt Jonsson
> ---
> d
> > From: Jonas Aaberg
> Some change logs would have helped.
Granted.
Hopefully Jonas will be happy to step forward and answer any of
your following questions.
> > Cc: Dmitry Torokhov
> > Cc: linux-input@vger.kernel.org
> > Acked-by: Lee Jones
> > Signed-off-by: Jonas Aaberg
> > Signed-off-b
On Thu, Oct 11, 2012 at 5:41 AM, Christopher Heiny wrote:
> Linus Walleij wrote:
>> On Sat, Oct 6, 2012 at 6:09 AM, Christopher Heiny
>> wrote:
>> > + chargerinput ... (rw) User space programs can use this to tell
>> > the + sensor that the system is plugged into an ex
On Thu, Oct 11, 2012 at 5:41 AM, Christopher Heiny wrote:
> Linus Walleij wrote:
>> But please use arithmetic operators (I think I said this on the last
>> review):
>>
>> dest[0] = src & 0xFF;
>> dest[1] = src >> 8;
>>
>> Doing it the above way makes artithmetic look like maths, and it isn't.
>>
On Thu, Oct 11, 2012 at 6:15 AM, Christopher Heiny wrote:
> On Thursday, October 11, 2012 02:21:53 AM I wrote:
>> > +union pdt_properties {
>> > + struct {
>> > + u8 reserved_1:6;
>> > + u8 has_bsr:1;
>> > + u8 reserved_2:1;
>> > + } __attribu
On Thu, Oct 11, 2012 at 05:33:24PM +0900, Mark Brown wrote:
> On Thu, Oct 11, 2012 at 01:27:49AM -0700, Dmitry Torokhov wrote:
> > On Thu, Oct 11, 2012 at 05:07:24PM +0900, Mark Brown wrote:
>
> > >
> > > What's the error pattern you're seeing? I've not noticed much of an
> > > issue here, but i
Hi Ashish,
On Thu, Oct 11, 2012 at 04:15:16PM +0530, Ashish Jangam wrote:
> This is the ONKEY driver of the Dialog DA9055 PMIC and depends on the DA9055
> MFD
> core driver.
>
> This patch is functionally tested on SMDK6410 board.
>
> Signed-off-by: David Dajun Chen
> Signed-off-by: Ashish Jan
On Thu, Oct 11, 2012 at 03:56:22AM +, Christopher Heiny wrote:
Fix your mailer to word wrap within paragraphs.
> If this feature is a deal-breaker, we can take it out. In the absence
> of a generic GPIO implementation for CS, though, I'd much rather leave
> it in. Once generic GPIO CS arriv
On Thu, 2012-10-11 at 09:28 -0700, Dmitry Torokhov wrote:
> Hi Ashish,
>
> On Thu, Oct 11, 2012 at 04:15:16PM +0530, Ashish Jangam wrote:
> > This is the ONKEY driver of the Dialog DA9055 PMIC and depends on the
> > DA9055 MFD
> > core driver.
> >
> > This patch is functionally tested on SMDK641
27 matches
Mail list logo
