Hi Henrik, Kamal,
Thanks for your review.
And I add some comments in below.
Thanks.
Dudley Du
d...@cypress.com
> Hi Henrik-
>
> Thanks again for your review. The forthcoming PATCH v4 includes the majority
> of your change requests, except where noted below (and considering my email
> "Subject
This patch brings wacom driver in-sync with input-mt changes
made in release 3.7.
Signed-off-by: Ping Cheng
Reviewed-by: Henrik Rydberg
---
drivers/input/tablet/wacom_wac.c | 82 ++
drivers/input/tablet/wacom_wac.h |1 -
2 files changed, 22 insertions(+
Henrik added new MT routines in release 3.7. This patch is to
prepare for the use of new MT routines.
In the newly added wacom_abs_set_axis() function, the first
if-statement assigns ABS_X/Y for number of contacts less or
equal to 2. So, it is single and 2 finger touch devices. Two
finger touch de
From: Dudley Du
Input/mouse driver for Cypress PS/2 Trackpad.
Original code contributed by Dudley Du (Cypress Semiconductor Corporation),
modified by Kamal Mostafa and Kyle Fazzari.
BugLink: http://launchpad.net/bugs/978807
Signed-off-by: Dudley Du
Signed-off-by: Kamal Mostafa
Signed-off-by:
This driver, submitted on behalf of Cypress Semiconductor Corporation and
additional contributors, provides support for the Cypress PS/2 Trackpad.
This [PATCH v4] version differs from my previous submitted version[2]:
Patch #1 (cmdbuf to 8 bytes) and #3 (link in driver) are unchanged.
Patch
Cypress PS/2 Trackpad (drivers/input/mouse/cypress_ps2.c) needs
this larger cmdbuf[] to handle 8-byte packet responses.
Signed-off-by: Kamal Mostafa
---
include/linux/libps2.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/libps2.h b/include/linux/libps2.h
i
From: Dudley Du
Original code contributed by Dudley Du (Cypress Semiconductor Corporation),
modified by Kamal Mostafa.
BugLink: http://launchpad.net/bugs/978807
Signed-off-by: Dudley Du
Signed-off-by: Kamal Mostafa
Signed-off-by: Mario Limonciello
Signed-off-by: Tim Gardner
---
drivers/inp
This feature is disabled by default; enable with CYPRESS_SIMULATED_MT.
Instead of SEMI_MT, present a full mt interface with simulated contact
positions for >=3 fingers. Enables e.g. multi-finger tap and drag for
old userspace applications which only count the contact positions.
Signed-off-by: Ka
Hi Henrik-
Thanks again for your review. The forthcoming PATCH v4 includes the
majority of your change requests, except where noted below (and
considering my email "Subject: SEMI_MT vs. simulated mt")...
On Mon, 2012-12-03 at 08:45 +0100, Henrik Rydberg wrote:
> > + /*
> > +
Hi Dmitry and Henrik-
Regarding SEMI_MT vs. "simulated multitouch" . . .
> >
> > Patch #4 (new) reintroduces simulated multitouch for up to 5 fingers
> > (#if CYPRESS_SIMULATE_MT), disabling SEMI_MT again.
> >
> > If that functionality (support for >2 fingers) can be acheived in some
> >
On Tuesday, December 04, 2012 11:11:27 PM Jan-Matthias Braun wrote:
> Hi Rafael,
>
> Am Donnerstag 29. November 2012, 23:28:55 schrieb Rafael J. Wysocki:
> > On Thursday, November 29, 2012 03:03:04 PM Jan-Matthias Braun wrote:
> > > Am Donnerstag, 29. November 2012, 01:20:04 schrieb Rafael J. Wyso
Hi Rafael,
Am Donnerstag 29. November 2012, 23:28:55 schrieb Rafael J. Wysocki:
> On Thursday, November 29, 2012 03:03:04 PM Jan-Matthias Braun wrote:
> > Am Donnerstag, 29. November 2012, 01:20:04 schrieb Rafael J. Wysocki:
> > > On Tuesday, November 27, 2012 09:26:11 PM Jiri Kosina wrote:
> > >
Hi,
unfortunately the problem is still there with linux 3.6.8 and using
any of available calibration tools (jstest, jstest-gtk) won't fix the
issue with the 0 axis. Please help me with this issue, thank you very
much.
Greetings,
Arthur
2012/11/23 Arthur Skowronek :
> Dear List,
>
> I have 4 of
On Tue, 4 Dec 2012 16:27:47 +0100, Benjamin Tissoires wrote:
> These definitions are not used here, but are defined by the specification.
> Keeping some of them for documentation purposes.
>
> Signed-off-by: Benjamin Tissoires
> ---
> drivers/hid/i2c-hid/i2c-hid.c | 25 ++---
On Tue, 4 Dec 2012 16:27:46 +0100, Benjamin Tissoires wrote:
> This avoids the problematic case:
>
> if (condition)
> i2c_hid_dbg(ihid, "Blah blah %d\n", i);
> else
> do_something_very_important();
>
> Which looks correct, however with the previous macro definition,
> this expands to
On Tue, 4 Dec 2012 16:27:45 +0100, Benjamin Tissoires wrote:
> We should not initialize to 0 static declarations.
>
> Signed-off-by: Benjamin Tissoires
> ---
> drivers/hid/i2c-hid/i2c-hid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/i2c-hid/i2c-hid.c b
On Tue, 4 Dec 2012 16:27:44 +0100, Benjamin Tissoires wrote:
> The "comment" part can never be displayed, so we can remove it.
>
> Signed-off-by: Benjamin Tissoires
> ---
> drivers/hid/i2c-hid/Kconfig | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/hid/i
On Tue, 4 Dec 2012 16:27:43 +0100, Benjamin Tissoires wrote:
> HID descriptors contains 4 bytes of reserved field.
> The previous implementation was overriding the next fields in struct i2c_hid.
>
> Signed-off-by: Benjamin Tissoires
> ---
> drivers/hid/i2c-hid/i2c-hid.c | 3 ++-
> 1 file change
Hi,
On Tue, Dec 04, 2012 at 11:10:42AM -0800, Dmitry Torokhov wrote:
> Hi Li,
>
> On Tue, Dec 04, 2012 at 06:26:29AM -0500, Li Wu wrote:
> > +STM FTK TOUCHSCREEN DRIVER
> > +M: Li Wu
> > +L: device-drivers-de...@blackfin.uclinux.org
> > +W: http://www.st.com
> > +S: Supported
On Mon, Dec 03, 2012 at 11:28:36PM -0800, Guillermo A. Amaral wrote:
> On Mon, Dec 03, 2012 at 09:24:00PM -0800, Dmitry Torokhov wrote:
> > On Sat, Dec 01, 2012 at 11:36:19PM -0800, Guillermo A. Amaral wrote:
> > > From: "Guillermo A. Amaral"
> > >
> > > Fixed a few minor coding style issues in x
On Tue, Dec 4, 2012 at 11:16 AM, Dmitry Torokhov
wrote:
> On Tue, Dec 04, 2012 at 10:22:24AM -0800, Ping Cheng wrote:
>>
>> However, for this particular one (and maybe 2 below), we do need to
>> remove it. 24hdt is a touchscren device, which should not emulate
>> pointer events. I will make a sepa
On Tue, Dec 04, 2012 at 10:22:24AM -0800, Ping Cheng wrote:
>
> However, for this particular one (and maybe 2 below), we do need to
> remove it. 24hdt is a touchscren device, which should not emulate
> pointer events. I will make a separate patch for this change.
Why not? Legacy clients should be
Hi Li,
On Tue, Dec 04, 2012 at 06:26:29AM -0500, Li Wu wrote:
> +STM FTK TOUCHSCREEN DRIVER
> +M: Li Wu
> +L: device-drivers-de...@blackfin.uclinux.org
> +W: http://www.st.com
> +S: Supported
> +F: drivers/input/touchscreen/ftk.c
> +
> +
You have an extra blank line here
> > So the (touch_max > 1) logic replaces the branching on features and device
> > type?
>
> There are only two types of devices defined for features->device_type:
> BTN_TOOL_PEN and BTN_TOOL_FINGER.
>
> Once we come to !BTN_TOOL_PEN, we are dealing with touch devices.
>
> The first if-statement
On Tue, Dec 4, 2012 at 8:13 AM, Henrik Rydberg wrote:
> Hi Ping,
>
>> This patch brings wacom driver in-sync with input-mt changes
>> made in release 3.7.
>>
>> Signed-off-by: Ping Cheng
>> ---
>> drivers/input/tablet/wacom_wac.c | 84
>> ++
>> drivers/inpu
Hi Henrik,
Thank you for your review. Please see my reply inline.
Ping
On Tue, Dec 4, 2012 at 8:10 AM, Henrik Rydberg wrote:
>
> Hi Ping,
>
> > Henrik added new MT routines in release 3.7. This patch is to prepare
> > for the use of new MT routines.
> >
> > Signed-off-by: Ping Cheng
> > ---
>
Hi Ping,
> This patch brings wacom driver in-sync with input-mt changes
> made in release 3.7.
>
> Signed-off-by: Ping Cheng
> ---
> drivers/input/tablet/wacom_wac.c | 84
> ++
> drivers/input/tablet/wacom_wac.h |1 -
> 2 files changed, 21 insertions(+
Hi Ping,
> Henrik added new MT routines in release 3.7. This patch is to prepare
> for the use of new MT routines.
>
> Signed-off-by: Ping Cheng
> ---
> drivers/input/tablet/wacom_wac.c | 85
> --
> 1 file changed, 45 insertions(+), 40 deletions(-)
>
> di
On Tue, 4 Dec 2012 16:27:42 +0100, Benjamin Tissoires wrote:
> no I2C driver has "i2c" in its name. It makes more sense to call this
> i2c driver "hid".
>
> Signed-off-by: Benjamin Tissoires
> ---
> drivers/hid/i2c-hid/i2c-hid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff
Signed-off-by: Benjamin Tissoires
---
drivers/hid/i2c-hid/i2c-hid.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
index d6fdb3e..da04948 100644
--- a/drivers/hid/i2c-hid/i2c-hid.c
+++ b/drivers/hid/i2c
Hi guys,
Jean made a recent review of i2c-hid, and before this driver goes into
Linus' tree, here are some cleanups.
Patch 2 has not been detected by Jean, but it appeared while playing with
buffers allocation. So this is the only change not asked by the previous
review.
I still need to work on
On Tue, Dec 4, 2012 at 11:31 AM, Jiri Kosina wrote:
> On Mon, 3 Dec 2012, Benjamin Tissoires wrote:
>
>> >> I know that it already have been used by one Nvidia team and by Elan
>> >> for internal tests. So I don't know if it's possible to change it now
>> >> (though it's not a big deal).
>> >
>> >
This is a initial driver for STMicroelectronics multi touch
capacitive touchscren FingertipK. It supports maximum 10 fingers,
based on I2C interface.
STMicroelectronics will maintain and update this driver regularly.
Tested on Beagleboard, Android ICS.
Suggested by Dmitry, rebase and squash 2 co
On Mon, 3 Dec 2012, Benjamin Tissoires wrote:
> >> I know that it already have been used by one Nvidia team and by Elan
> >> for internal tests. So I don't know if it's possible to change it now
> >> (though it's not a big deal).
> >
> > Yes it is possible, as long as the code isn't in Linus' tree
> This is known to be broken in X (and should be reported [again] there) but
> if you can provide scenario to break it in VT I'd love to know it.
Ding ding ding, you win the prize! Yes, I was in X at the time.
Me dumbshit; I should have realized that this was relevant and mentioned
it. My apolog
On Mon, 26 Nov 2012, David Herrmann wrote:
> The fix you are proposing actually looks pretty nice, although it puts
> the burden of locking to the hid-driver instead of the hid-core. So
> every .probe function must go sure that the lock is held when
> returning. This means if you unlock the input-
36 matches
Mail list logo
