Hi all,
Sorry it took me some time to answer.
I extended the Logitech HIDPP10 specification here:
https://drive.google.com/folderview?id=0BxbRzx7vEV7eWmgwazJ3NUFfQ28&usp=sharing
The document
"Logitech_hidpp10_specification_draft_Unifying_devices_receivers.doc"
now contains most of the relevant
On 07/03/2013 12:41 AM, Dan Carpenter wrote:
If "cd" were NULL then we would dereference it when we print the error
message. Fortunately enough, it can't ever be NULL so we can remove
those lines.
Signed-off-by: Dan Carpenter
diff --git a/drivers/input/touchscreen/cyttsp4_core.c
b/drivers/in
On 07/03/2013 12:44 AM, Dan Carpenter wrote:
We leak "cd" if the cd->xfer_buf allocation fails. It was weird to
"goto error_gpio_irq" so I changed the label name. (Label names should
reflect the label location not the goto location otherwise you get an
"all roads lead to Rome problem").
Signed
On 07/03/2013 12:47 AM, Dan Carpenter wrote:
Hello Ferruh Yigit,
The patch 67bf12ca50d5: "Input: cyttsp4 - SPI driver for Cypress
TMA4XX touchscreen devices" from Jun 30, 2013, leads to the following
Smatch warning:
"drivers/input/touchscreen/cyttsp4_spi.c:66 cyttsp_spi_xfer()
warn: impos
On Wed, Jul 03, 2013 at 04:24:18PM +0300, Ferruh Yigit wrote:
> I have a patch for this, but should I create it against previous patch I
> have sent or against latest next tree?
>
Latest linux-next.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-input"
On 07/03/2013 04:50 PM, Dan Carpenter wrote:
On Wed, Jul 03, 2013 at 04:12:48PM +0300, Ferruh Yigit wrote:
On 07/03/2013 12:44 AM, Dan Carpenter wrote:
We leak "cd" if the cd->xfer_buf allocation fails. It was weird to
"goto error_gpio_irq" so I changed the label name. (Label names should
ref
On Wed, Jul 03, 2013 at 04:12:48PM +0300, Ferruh Yigit wrote:
> On 07/03/2013 12:44 AM, Dan Carpenter wrote:
> >We leak "cd" if the cd->xfer_buf allocation fails. It was weird to
> >"goto error_gpio_irq" so I changed the label name. (Label names should
> >reflect the label location not the goto l
On Tue, 2 Jul 2013, Benjamin Tissoires wrote:
> Genius Gila Gaming Mouse presents an obviously wrong report descriptor.
> the Consumer control (report ID 3) is the following:
> 0x05, 0x0c,// Usage Page (Consumer Devices) 105
> 0x09, 0x01,// Usage (Cons
On Wed, 3 Jul 2013, Linus G Thiel wrote:
> Hi,
>
> Please see attached a patch for the MacBook Air 6,2 keyboard.
>
> Changelog:
>
> * add definitions for new MacBook Air 6,2 keyboard with device id
> 0x05ac:0x0291
>
> I'm not sure about the name I chose for the keyboard -- I just made it the
>
On Wed, 3 Jul 2013, Peter Chen wrote:
> Hi Jiri and Alan,
>
> I have run below below at 3.5.7 kernel, but after checking upstream
> kernel, it may also be existed.
>
> 1. evtest /dev/input/event1 &
> 2. Let mouse auto suspend, enable mouse as wakeup source, and let
> the system enters suspend.
>
If probe() fails after cd->xfer_buf allocated, it will not freed.
Added kfree(cd->xfer_buf) with and error label.
Signed-off-by: Ferruh Yigit
---
drivers/input/touchscreen/cyttsp4_core.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/cyttsp4_c
In TSG4, register map is 512bytes long and to access all of it,
one bit from address byte is used (which bit to use differs for
I2C and SPI);
Since common code used for TSG3 and TSG4 for I2C, this parameter
wrongly used as u8. TSG3 does not access beyond 255 bytes
but TSG4 may.
Signed-off-by: Fer
12 matches
Mail list logo
