Mark Brown wrote:
> On Fri, Jun 21, 2013 at 09:16:16AM -0700, Nick Dyer wrote:
>> Mark Brown wrote:
>>> Yes, to be honest. I'd hope it wouldn't be increasing the number of
>>> read/write operations...
>
>> For some operations it does. For example updating the whole chip config
>> (which is a comm
On Thu, Jul 11, 2013 at 3:01 AM, Alan Stern wrote:
> On Thu, 11 Jul 2013, Arnd Bergmann wrote:
>
>> On Wednesday 10 July 2013, Alan Stern wrote:
>> > This isn't right. There are USB host controllers that use PIO, not
>> > DMA. The HAS_DMA dependency should go with the controller driver, not
>> >
Hi,
As we are going to run URB->complete() in tasklet context[1][2], and
hard interrupt may be enabled when running URB completion handler[3],
so we might need to disable interrupt when acquiring one lock in
the completion handler for the below reasons:
- URB->complete() holds a subsystem wide lo
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Juergen Stuber
Signed-off-by: Ming Lei
---
drivers/usb/misc/legousbtower.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbt
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: net...@vger.kernel.org
Signed-off-by: Ming Lei
---
drivers/net/usb/kaweth.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c
index
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Johan Hovold
Signed-off-by: Ming Lei
---
drivers/usb/serial/quatech2.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/quatech2.c b/drivers/usb/serial/quatech2.c
i
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Johan Hovold
Signed-off-by: Ming Lei
---
drivers/usb/serial/usb_wwan.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/usb_wwan.c b/drivers/usb/serial/usb_wwan.c
i
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: "John W. Linville"
Cc: libertas-...@lists.infradead.org
Cc: linux-wirel...@vger.kernel.org
Cc: net...@vger.kernel.org
Signed-off-by: Ming Lei
---
drivers/net/wireless/libertas/if_usb.c |5 +++--
1 file chan
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Cc: Clemens Ladisch
Cc: alsa-de...@alsa-project.org
Signed-off-by: Ming Lei
---
sound/usb/midi.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/so
Complete() will be run with interrupt enabled, so add local_irq_save()
before acquiring the lock without irqsave().
Cc: Mauro Carvalho Chehab
Cc: linux-me...@vger.kernel.org
Signed-off-by: Ming Lei
---
drivers/media/usb/em28xx/em28xx-audio.c |3 +++
1 file changed, 3 insertions(+)
diff --g
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: de...@driverdev.osuosl.org
Signed-off-by: Ming Lei
---
drivers/staging/btmtk_usb/btmtk_usb.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/btmtk_usb/btmtk_usb.c
b/d
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Cc: linux-me...@vger.kernel.org
Signed-off-by: Ming Lei
---
drivers/media/usb/cx231xx/cx231xx-audio.c |6 ++
drivers/media/usb/cx231xx/cx231xx-core.c | 10
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Karsten Keil
Cc: "David S. Miller"
Cc: net...@vger.kernel.org
Signed-off-by: Ming Lei
---
drivers/isdn/hardware/mISDN/hfcsusb.c | 36 ++---
1 file changed, 20 insertions(+), 16 de
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Johan Hovold
Signed-off-by: Ming Lei
---
drivers/usb/serial/ti_usb_3410_5052.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/us
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Jiri Kosina
Cc: linux-input@vger.kernel.org
Signed-off-by: Ming Lei
---
drivers/hid/usbhid/hid-core.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/usbhid/hid-core.c b/
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: "Luis R. Rodriguez"
Cc: "John W. Linville"
Cc: linux-wirel...@vger.kernel.org
Cc: net...@vger.kernel.org
Signed-off-by: Ming Lei
---
drivers/net/wireless/ath/ath9k/hif_usb.c | 29 ++-
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: net...@vger.kernel.org
Signed-off-by: Ming Lei
---
drivers/net/usb/rtl8150.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
inde
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: net...@vger.kernel.org
Signed-off-by: Ming Lei
---
drivers/net/usb/cdc-phonet.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/usb/cdc-phonet.c b/drivers/net/usb/cdc-phon
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Johan Hovold
Signed-off-by: Ming Lei
---
drivers/usb/serial/symbolserial.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/symbolserial.c
b/drivers/usb/serial/sym
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Christian Lamparter
Cc: "John W. Linville"
Cc: linux-wirel...@vger.kernel.org
Cc: net...@vger.kernel.org
Signed-off-by: Ming Lei
---
drivers/net/wireless/ath/carl9170/rx.c |5 +++--
1 file changed, 3 inser
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Johan Hovold
Signed-off-by: Ming Lei
---
drivers/usb/serial/mos7720.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c
inde
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Johan Hovold
Signed-off-by: Ming Lei
---
drivers/usb/serial/mos7840.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
inde
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Johan Hovold
Signed-off-by: Ming Lei
---
drivers/usb/serial/io_ti.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c
index 6005
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Peter Berger
Cc: Al Borchers
Signed-off-by: Ming Lei
---
drivers/usb/serial/digi_acceleport.c | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/serial/
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Mauro Carvalho Chehab
Cc: linux-me...@vger.kernel.org
Signed-off-by: Ming Lei
---
drivers/media/usb/tlg2300/pd-video.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/u
Complete() will be run with interrupt enabled, so disable local
interrupt before holding a global lock which is held without irqsave.
Cc: Clemens Ladisch
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Cc: alsa-de...@alsa-project.org
Signed-off-by: Ming Lei
---
sound/usb/misc/ua101.c | 14
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: net...@vger.kernel.org
Signed-off-by: Ming Lei
---
drivers/net/usb/hso.c | 38 ++
1 file changed, 22 insertions(+), 16 deletions(-)
diff --git a/drivers/net/usb/hso.c b/dri
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Mauro Carvalho Chehab
Cc: linux-me...@vger.kernel.org
Signed-off-by: Ming Lei
---
drivers/media/usb/tm6000/tm6000-video.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/medi
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Dmitry Torokhov
Cc: linux-input@vger.kernel.org
Signed-off-by: Ming Lei
---
drivers/input/misc/cm109.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/input/misc/cm109.c
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Marcel Holtmann
Cc: Gustavo Padovan
Cc: Johan Hedberg
Cc: linux-blueto...@vger.kernel.org
Signed-off-by: Ming Lei
---
drivers/bluetooth/btusb.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
d
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
These functions may be called inside URB->complete(), so use
spin_lock_irqsave().
Cc: Mauro Carvalho Chehab
Cc: linux-me...@vger.kernel.org
Signed-off-by: Ming Lei
---
drivers/media/dvb-core/dvb_demux.c | 17 +++
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Cc: alsa-de...@alsa-project.org
Signed-off-by: Ming Lei
---
sound/usb/usx2y/usbusx2yaudio.c |4
1 file changed, 4 insertions(+)
diff --git a/sound/usb/usx2y/usbusx2ya
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Daniel Drake
Cc: Ulrich Kunitz
Cc: "John W. Linville"
Cc: linux-wirel...@vger.kernel.org
Cc: net...@vger.kernel.org
Signed-off-by: Ming Lei
---
drivers/net/wireless/zd1211rw/zd_usb.c | 21 --
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Mauro Carvalho Chehab
Cc: linux-me...@vger.kernel.org
Signed-off-by: Ming Lei
---
drivers/media/usb/sn9c102/sn9c102_core.c |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/m
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Daniel Mack
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Cc: alsa-de...@alsa-project.org
Signed-off-by: Ming Lei
---
sound/usb/caiaq/audio.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Signed-off-by: Ming Lei
---
drivers/usb/misc/uss720.c |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c
index e129cf6..f7d15e8 100644
-
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Mauro Carvalho Chehab
Cc: linux-me...@vger.kernel.org
Signed-off-by: Ming Lei
---
drivers/media/usb/em28xx/em28xx-core.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Johan Hovold
Signed-off-by: Ming Lei
---
drivers/usb/serial/io_edgeport.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/serial/io_edgeport.c b/drivers/usb/seri
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: "John W. Linville"
Cc: libertas-...@lists.infradead.org
Cc: linux-wirel...@vger.kernel.org
Cc: net...@vger.kernel.org
Signed-off-by: Ming Lei
---
drivers/net/wireless/libertas_tf/if_usb.c |6 --
1 file
Complete() will be run with interrupt enabled, so disable local
interrupt before holding a global lock which is held without
irqsave.
Cc: Mauro Carvalho Chehab
Cc: linux-me...@vger.kernel.org
Signed-off-by: Ming Lei
---
drivers/media/usb/tlg2300/pd-alsa.c |3 +++
1 file changed, 3 insertion
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: de...@driverdev.osuosl.org
Signed-off-by: Ming Lei
---
drivers/staging/vt6656/usbpipe.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: de...@driverdev.osuosl.org
Signed-off-by: Ming Lei
---
drivers/staging/bcm/InterfaceRx.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceRx.c
b/drivers/s
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: de...@driverdev.osuosl.org
Signed-off-by: Ming Lei
---
drivers/staging/ced1401/usb1401.c | 35 +++
1 file changed, 19 insertions(+), 16 deletions(-)
diff --git a/drivers/stagin
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Johan Hovold
Signed-off-by: Ming Lei
---
drivers/usb/serial/sierra.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
ind
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Signed-off-by: Ming Lei
---
drivers/usb/misc/usbtest.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c
index 8b4ca1c..5c73df5
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Matthias Bruestle and Harald Welte
Signed-off-by: Ming Lei
---
drivers/usb/serial/cyberjack.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/serial/cyberjack.c
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Signed-off-by: Ming Lei
---
drivers/usb/misc/iowarrior.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c
index d36f34e..010ed6d
Complete() will be run with interrupt enabled, so change to
read_lock_irqsave().
Cc: Marcel Holtmann
Cc: Gustavo Padovan
Cc: Johan Hedberg
Cc: linux-blueto...@vger.kernel.org
Signed-off-by: Ming Lei
---
drivers/bluetooth/bfusb.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletion
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Lisa Nguyen
Signed-off-by: Ming Lei
---
drivers/usb/misc/adutux.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/misc/adutux.c b/drivers/usb/misc/adutux.c
index eb3
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Signed-off-by: Ming Lei
---
drivers/usb/misc/ldusb.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/misc/ldusb.c b/drivers/usb/misc/ldusb.c
index ac76229..8bae18e 100644
--
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Pete Zaitcev
Signed-off-by: Ming Lei
---
drivers/usb/class/usblp.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/class/usblp.c b/drivers/usb/class/usblp.c
index d4
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Alan Stern
Signed-off-by: Ming Lei
---
drivers/usb/core/devio.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index 0598650..21e
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Oliver Neukum
Signed-off-by: Ming Lei
---
drivers/usb/class/cdc-wdm.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-
On Tue, Jul 9, 2013 at 10:41 PM, Jiri Kosina wrote:
> On Tue, 9 Jul 2013, Benjamin Tissoires wrote:
>
>> For those who wants to try, I have set up a project [1] to implement
>> part of the spec Nestor released. I implemented various features: list
>> devices paired to a receiver, pair/unpair a dev
On Thu, Jul 11, 2013 at 08:41:41AM +0100, Nick Dyer wrote:
> Mark Brown wrote:
> > On Fri, Jun 21, 2013 at 09:16:16AM -0700, Nick Dyer wrote:
> >> For some operations it does. For example updating the whole chip config
> >> (which is a common thing to want to do), it would turn a couple of write
>
Hello.
On 11-07-2013 13:05, Ming Lei wrote:
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Signed-off-by: Ming Lei
---
drivers/usb/misc/uss720.c |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/misc/uss720.c b/dri
Hello.
On 11-07-2013 13:05, Ming Lei wrote:
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Juergen Stuber
Signed-off-by: Ming Lei
---
drivers/usb/misc/legousbtower.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drive
On Thursday 11 July 2013 16:18:17 Sergei Shtylyov wrote:
> I don't think this patch passes checkpatch.pl.
This series is a mechanical replacement in dozens of drivers.
We cannot demand nice formatting. If you want to do something
productive, check the locking in the driver.
Regards
On Thu, Jul 11, 2013 at 5:05 AM, Ming Lei wrote:
> Complete() will be run with interrupt enabled, so change to
> spin_lock_irqsave().
>
> Cc: Mauro Carvalho Chehab
> Cc: linux-me...@vger.kernel.org
> Signed-off-by: Ming Lei
> ---
> drivers/media/usb/em28xx/em28xx-core.c |5 +++--
> 1 file c
On Thu, Jul 11, 2013 at 8:18 PM, Sergei Shtylyov
wrote:
> Hello.
>
>
> On 11-07-2013 13:05, Ming Lei wrote:
>
>> Complete() will be run with interrupt enabled, so change to
>> spin_lock_irqsave().
>
>
>> Cc: Juergen Stuber
>> Signed-off-by: Ming Lei
>> ---
>> drivers/usb/misc/legousbtower.c |
Hello.
On 11-07-2013 13:05, Ming Lei wrote:
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Johan Hovold
Signed-off-by: Ming Lei
---
drivers/usb/serial/sierra.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers
On 11-07-2013 13:06, Ming Lei wrote:
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Changelog doesn't match the patch.
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Cc: alsa-de...@alsa-project.org
Signed-off-by: Ming Lei
---
sound/usb/usx2y/usbusx2yaudio.c |
On 11-07-2013 13:06, Ming Lei wrote:
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Daniel Mack
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Cc: alsa-de...@alsa-project.org
Signed-off-by: Ming Lei
---
sound/usb/caiaq/audio.c |5 +++--
1 file changed, 3
On 11-07-2013 13:06, Ming Lei wrote:
Here the subject doesn't match the patch.
Complete() will be run with interrupt enabled, so disable local
interrupt before holding a global lock which is held without irqsave.
Cc: Clemens Ladisch
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Cc: alsa-de...@a
On 11-07-2013 13:06, Ming Lei wrote:
Subject doesn't match the patch.
Complete() will be run with interrupt enabled, so disable local
interrupt before holding a global lock which is held without
irqsave.
Cc: Mauro Carvalho Chehab
Cc: linux-me...@vger.kernel.org
Signed-off-by: Ming Lei
--
Hi guys,
These two patches enhance a little bit the HIDp driver:
- the first one re-implement in a safer way the callback hidinput_input_event,
allowing keyboards leds to be set over bluetooth
- the second one disable the send_report commands called during init, which
are not part of the spec
The USB hid implementation does retrieve the reports during the start.
However, this implementation does not call the HID command GET_REPORT
(which would fetch the current status of each report), but use the
DATA command, which is an Output Report (so transmitting data from the
host to the device).
We can re-enable hidinput_input_event to allow the leds of bluetooth
keyboards to be set.
Now the callbacks uses hid core to retrieve the right HID report to
send, so this version is safer.
Signed-off-by: Benjamin Tissoires
---
net/bluetooth/hidp/core.c | 26 ++
1 file ch
Hello.
On 11-07-2013 16:36, Oliver Neukum wrote:
I don't think this patch passes checkpatch.pl.
This series is a mechanical replacement in dozens of drivers.
That mechanicity shows too much in some patches.
We cannot demand nice formatting. If you want to do something
productive
At Thu, 11 Jul 2013 17:08:30 +0400,
Sergei Shtylyov wrote:
>
> On 11-07-2013 13:06, Ming Lei wrote:
>
> > Complete() will be run with interrupt enabled, so change to
> > spin_lock_irqsave().
>
> Changelog doesn't match the patch.
Yep, but moreover...
> > Cc: Jaroslav Kysela
> > Cc: Takash
Hi
On Thu, Jul 11, 2013 at 3:41 PM, Benjamin Tissoires
wrote:
> The USB hid implementation does retrieve the reports during the start.
> However, this implementation does not call the HID command GET_REPORT
> (which would fetch the current status of each report), but use the
> DATA command, which
Hi
On Thu, Jul 11, 2013 at 3:41 PM, Benjamin Tissoires
wrote:
> We can re-enable hidinput_input_event to allow the leds of bluetooth
> keyboards to be set.
> Now the callbacks uses hid core to retrieve the right HID report to
> send, so this version is safer.
>
> Signed-off-by: Benjamin Tissoires
On 11.07.2013 11:06, Ming Lei wrote:
> Complete() will be run with interrupt enabled, so change to
> spin_lock_irqsave().
>
> Cc: Daniel Mack
> Cc: Jaroslav Kysela
> Cc: Takashi Iwai
> Cc: alsa-de...@alsa-project.org
> Signed-off-by: Ming Lei
Sound right to me, thanks.
Acked-by: Daniel Mack
Hi David,
On Thu, Jul 11, 2013 at 4:02 PM, David Herrmann wrote:
> Hi
>
>> +static int hidp_hidinput_event(struct input_dev *dev, unsigned int type,
>> + unsigned int code, int value)
>> +{
>> + struct hid_device *hid = input_get_drvdata(dev);
>
> I dislike that
On Thu, Jul 11, 2013 at 9:50 PM, Takashi Iwai wrote:
> At Thu, 11 Jul 2013 17:08:30 +0400,
> Sergei Shtylyov wrote:
>>
>> On 11-07-2013 13:06, Ming Lei wrote:
>>
>> > Complete() will be run with interrupt enabled, so change to
>> > spin_lock_irqsave().
>>
>> Changelog doesn't match the patch.
At Thu, 11 Jul 2013 22:13:35 +0800,
Ming Lei wrote:
>
> On Thu, Jul 11, 2013 at 9:50 PM, Takashi Iwai wrote:
> > At Thu, 11 Jul 2013 17:08:30 +0400,
> > Sergei Shtylyov wrote:
> >>
> >> On 11-07-2013 13:06, Ming Lei wrote:
> >>
> >> > Complete() will be run with interrupt enabled, so change to
>
On Thu, Jul 11, 2013 at 10:34 PM, Takashi Iwai wrote:
> At Thu, 11 Jul 2013 22:13:35 +0800,
> Ming Lei wrote:
>>
>> On Thu, Jul 11, 2013 at 9:50 PM, Takashi Iwai wrote:
>> > At Thu, 11 Jul 2013 17:08:30 +0400,
>> > Sergei Shtylyov wrote:
>> >>
>> >> On 11-07-2013 13:06, Ming Lei wrote:
>> >>
>> >
On Thu, 11 Jul 2013, Geert Uytterhoeven wrote:
> On Thu, Jul 11, 2013 at 3:01 AM, Alan Stern wrote:
> > On Thu, 11 Jul 2013, Arnd Bergmann wrote:
> >
> >> On Wednesday 10 July 2013, Alan Stern wrote:
> >> > This isn't right. There are USB host controllers that use PIO, not
> >> > DMA. The HAS_D
Hi
On Thu, Jul 11, 2013 at 4:10 PM, Benjamin Tissoires
wrote:
> Hi David,
>
> On Thu, Jul 11, 2013 at 4:02 PM, David Herrmann wrote:
>> Hi
>>
>>> +static int hidp_hidinput_event(struct input_dev *dev, unsigned int type,
>>> + unsigned int code, int value)
>>> +{
>>>
On Thu, 11 Jul 2013, Benjamin Tissoires wrote:
> We can re-enable hidinput_input_event to allow the leds of bluetooth
> keyboards to be set.
> Now the callbacks uses hid core to retrieve the right HID report to
> send, so this version is safer.
>
> Signed-off-by: Benjamin Tissoires
Acked-by: Ji
On Thu, 11 Jul 2013, Benjamin Tissoires wrote:
> The USB hid implementation does retrieve the reports during the start.
> However, this implementation does not call the HID command GET_REPORT
> (which would fetch the current status of each report), but use the
> DATA command, which is an Output Re
81 matches
Mail list logo
