Re: [PATCH 1/4] hid-sensor-hub: fix style of comments

2013-08-19 Thread Andy Shevchenko
On Wed, 2013-08-14 at 11:07 +0300, Andy Shevchenko wrote: > This patch fixes the style of the comments to be like following > /* The commentary */ > > There is no functional change. > > Signed-off-by: Andy Shevchenko Jiri, Srinivas, any comments on this? > --- > drivers/hid/hid-sensor-

Re: Atmel updates to atmel_mxt_ts touch controller driver - v6

2013-08-19 Thread Nick Dyer
Dmitry Torokhov wrote: > On Thu, Aug 15, 2013 at 04:55:57PM +0100, Nick Dyer wrote: >> rydb...@euromail.se wrote: >>> **Do not send more than 15 patches at once to the vger mailing lists!!!*** >>> >>> One reason that should be obvious by now is that your work will be >>> attended to much quicker. O

Re: [PATCH 1/2] include: dt-binding: input: create a DT header defining key codes.

2013-08-19 Thread Laxman Dewangan
On Monday 12 August 2013 11:29 PM, Stephen Warren wrote: On 08/12/2013 11:15 AM, Dmitry Torokhov wrote: Device tree files can only include headers in include/dt-bindings. Eventually/soon, all the DT files and the headers in the dt-bindings/ directory will be split out into a separate git tree,

Re: [PATCH] usb: USB host support should depend on HAS_DMA

2013-08-19 Thread Alan Stern
On Sun, 18 Aug 2013, Geert Uytterhoeven wrote: > On Thu, Jul 11, 2013 at 1:12 AM, Arnd Bergmann wrote: > > On Wednesday 10 July 2013, Alan Stern wrote: > >> This isn't right. There are USB host controllers that use PIO, not > >> DMA. The HAS_DMA dependency should go with the controller driver,

Re: [PATCH 1/4] hid-sensor-hub: fix style of comments

2013-08-19 Thread Srinivas Pandruvada
On 08/19/2013 01:48 AM, Andy Shevchenko wrote: On Wed, 2013-08-14 at 11:07 +0300, Andy Shevchenko wrote: This patch fixes the style of the comments to be like following /* The commentary */ There is no functional change. Signed-off-by: Andy Shevchenko Jiri, Srinivas, any comments on

Re: [PATCH 2/4] hid-sensor-hub: fix indentation accross the code

2013-08-19 Thread Srinivas Pandruvada
On 08/14/2013 01:07 AM, Andy Shevchenko wrote: Patch just rearranges lines to be more compact and/or readable. Additionally it converts double space to one in several places. There is no functional change. Signed-off-by: Andy Shevchenko --- drivers/hid/hid-sensor-hub.c | 31 +++--

Re: [PATCH 3/4] hid-sensor-hub: move to devm_kzalloc

2013-08-19 Thread Srinivas Pandruvada
On 08/14/2013 01:07 AM, Andy Shevchenko wrote: devm_kzalloc() will manage resources freeing and allows to make error path smaller and nicer. Signed-off-by: Andy Shevchenko --- drivers/hid/hid-sensor-hub.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/

Re: [PATCH 4/4] hid-sensor-hub: change kmalloc + memcpy by kmemdup

2013-08-19 Thread Srinivas Pandruvada
On 08/14/2013 01:07 AM, Andy Shevchenko wrote: The patch substitutes kmemdup for kmalloc followed by memcpy. Signed-off-by: Andy Shevchenko --- drivers/hid/hid-sensor-hub.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/h

Re: [PATCH 1/2] include: dt-binding: input: create a DT header defining key codes.

2013-08-19 Thread Stephen Warren
On 08/19/2013 08:53 AM, Laxman Dewangan wrote: > On Monday 12 August 2013 11:29 PM, Stephen Warren wrote: >> On 08/12/2013 11:15 AM, Dmitry Torokhov wrote: Device tree files can only include headers in include/dt-bindings. Eventually/soon, all the DT files and the headers in the dt-b

Re: [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support

2013-08-19 Thread Sebastian Andrzej Siewior
* Zubair Lutfullah | 2013-08-13 21:05:03 [+0100]: >diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c >index 3ceac3e..0d7e313 100644 >--- a/drivers/iio/adc/ti_am335x_adc.c >+++ b/drivers/iio/adc/ti_am335x_adc.c … >+static irqreturn_t tiadc_irq(int irq, void *private) >+

Re: [PATCH 1/2] include: dt-binding: input: create a DT header defining key codes.

2013-08-19 Thread Rob Herring
On Mon, Aug 19, 2013 at 11:24 AM, Stephen Warren wrote: > On 08/19/2013 08:53 AM, Laxman Dewangan wrote: >> On Monday 12 August 2013 11:29 PM, Stephen Warren wrote: >>> On 08/12/2013 11:15 AM, Dmitry Torokhov wrote: > > Device tree files can only include headers in include/dt-bindings. >>>

Re: [PATCH] mc13xxx-ts: use zero as default value if no pdata was defined

2013-08-19 Thread Samuel Ortiz
Hi Michael, On Tue, Aug 13, 2013 at 02:14:30PM +0200, Michael Grzeschik wrote: > In case of devicetree, we currently don't have a way to append pdata for > the touchscreen. The current approach is to bail out in that case. > This patch makes it possible to probe the touchscreen without pdata > and

Aw: Re: [PATCH 35/36] hid: roccat: convert class code to use bin_attrs in groups

2013-08-19 Thread screamingfist
- Original Nachricht Von: Greg Kroah-Hartman An: Stefan Achatz Datum: 15.08.2013 18:40 Betreff: Re: [PATCH 35/36] hid: roccat: convert class code to use bin_attrs in groups > On Thu, Aug 15, 2013 at 06:03:46PM +0200, Stefan Achatz wrote: > > Hello Greg, > > looking through t

Re: [PATCH V3 1/2] tps6507x-ts: Add DT support

2013-08-19 Thread Prabhakar Lad
Hi Manish, Thanks for the patch. On Tue, May 21, 2013 at 2:24 PM, Vishwanathrao Badarkhe, Manish wrote: > Add device tree based support for TI's tps6507x touchscreen. > > Tested on da850-evm. > > Signed-off-by: Vishwanathrao Badarkhe, Manish > --- > Changes since V2: > - Removed unnecessary co

Re: [PATCH V3 1/2] tps6507x-ts: Add DT support

2013-08-19 Thread Manish Badarkhe
Hi Prabhakar, On Tue, Aug 20, 2013 at 11:44 AM, Prabhakar Lad wrote: > Hi Manish, > > Thanks for the patch. > > On Tue, May 21, 2013 at 2:24 PM, Vishwanathrao Badarkhe, Manish > wrote: >> Add device tree based support for TI's tps6507x touchscreen. >> >> Tested on da850-evm. >> >> Signed-off-by: