Re: [PATCH] HID: roccat: Fix "cannot create duplicate filename" problems

2013-09-27 Thread Greg KH
On Sat, Sep 28, 2013 at 05:57:46AM +0200, Stefan Achatz wrote: > Fixing some wrong macro stringification/concatenation. > > Cc: Greg Kroah-Hartman > Signed-off-by: Stefan Achatz > --- > drivers/hid/hid-roccat-kone.c |2 +- > drivers/hid/hid-roccat-koneplus.c |4 ++-- > drivers/hid/h

[PATCH] HID: roccat: Fix "cannot create duplicate filename" problems

2013-09-27 Thread Stefan Achatz
Fixing some wrong macro stringification/concatenation. Cc: Greg Kroah-Hartman Signed-off-by: Stefan Achatz --- drivers/hid/hid-roccat-kone.c |2 +- drivers/hid/hid-roccat-koneplus.c |4 ++-- drivers/hid/hid-roccat-kovaplus.c |4 ++-- drivers/hid/hid-roccat-pyra.c |4 ++--

Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup

2013-09-27 Thread Dan Carpenter
On Fri, Sep 27, 2013 at 06:24:12PM +0300, Dan Carpenter wrote: > > It looks like magicmouse_raw_event() returns 1 on success and 0 on > failure. Fixing the return codes is a good idea but it won't fix the oops. What's the point of returning 1 and 0? In the current code no one cares and both are

Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup

2013-09-27 Thread Dan Carpenter
On Fri, Sep 27, 2013 at 10:42:10AM -0400, Joseph Salisbury wrote: > On 09/27/2013 06:50 AM, Jiri Kosina wrote: > > On Wed, 25 Sep 2013, Joseph Salisbury wrote: > > > >> After further testing reverting the following commit does in fact > >> resolve the bug: > >> > >> commit b1a1442a23776756b254b6978

Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup

2013-09-27 Thread Joseph Salisbury
On 09/27/2013 06:50 AM, Jiri Kosina wrote: > On Wed, 25 Sep 2013, Joseph Salisbury wrote: > >> After further testing reverting the following commit does in fact >> resolve the bug: >> >> commit b1a1442a23776756b254b69786848a94d92445ba >> Author: Jiri Kosina >> Date: Mon Jun 3 11:27:48 2013 +0200 >

[PATCH 7/7] Input: st1232 - Include linux/of.h header

2013-09-27 Thread Sachin Kamat
'of_match_ptr' is defined in linux/of.h. Include it explicitly. Signed-off-by: Sachin Kamat --- drivers/input/touchscreen/st1232.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/touchscreen/st1232.c b/drivers/input/touchscreen/st1232.c index 1740a24..2f03b2f 100644 --- a/d

[PATCH 6/7] Input: egalax_ts - Include linux/of.h header

2013-09-27 Thread Sachin Kamat
'of_match_ptr' is defined in linux/of.h. Include it explicitly. Signed-off-by: Sachin Kamat --- drivers/input/touchscreen/egalax_ts.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/touchscreen/egalax_ts.c b/drivers/input/touchscreen/egalax_ts.c index ef5fcb0..c856fbc 10064

[PATCH 1/7] Input: gpio_keys - Include linux/of.h header

2013-09-27 Thread Sachin Kamat
'of_match_ptr' is defined in linux/of.h. Include it explicitly. Signed-off-by: Sachin Kamat --- drivers/input/keyboard/gpio_keys.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c index 440ce32..2db1324 100644 --- a/d

[PATCH 2/7] Input: gpio_keys_polled - Include linux/of.h header

2013-09-27 Thread Sachin Kamat
'of_match_ptr' is defined in linux/of.h. Include it explicitly. Signed-off-by: Sachin Kamat --- drivers/input/keyboard/gpio_keys_polled.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/keyboard/gpio_keys_polled.c b/drivers/input/keyboard/gpio_keys_polled.c index cd5ed9e..4

[PATCH 4/7] Input: pwm-beeper - Include linux/of.h header

2013-09-27 Thread Sachin Kamat
'of_match_ptr' is defined in linux/of.h. Include it explicitly. Signed-off-by: Sachin Kamat --- drivers/input/misc/pwm-beeper.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c index 2ff4d1c..940566e 100644 --- a/drivers/inp

[PATCH 5/7] Input: rotary_encoder - Include linux/of.h header

2013-09-27 Thread Sachin Kamat
'of_match_ptr' is defined in linux/of.h. Include it explicitly. Signed-off-by: Sachin Kamat --- drivers/input/misc/rotary_encoder.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/misc/rotary_encoder.c b/drivers/input/misc/rotary_encoder.c index 5b1aff8..f920ba7 100644 ---

[PATCH 3/7] Input: pxa27x_keypad - Include linux/of.h header

2013-09-27 Thread Sachin Kamat
'of_match_ptr' is defined in linux/of.h. Include it explicitly. Signed-off-by: Sachin Kamat --- drivers/input/keyboard/pxa27x_keypad.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/keyboard/pxa27x_keypad.c b/drivers/input/keyboard/pxa27x_keypad.c index a2e758d..186138c 10

Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup

2013-09-27 Thread Jiri Kosina
On Wed, 25 Sep 2013, Joseph Salisbury wrote: > After further testing reverting the following commit does in fact > resolve the bug: > > commit b1a1442a23776756b254b69786848a94d92445ba > Author: Jiri Kosina > Date: Mon Jun 3 11:27:48 2013 +0200 > > HID: core: fix reporting of raw events > >