Re: [PATCHv7][ 1/4] Input: tsc2007: Add device tree support.

2013-10-24 Thread Lothar Waßmann
Hi, Thierry Reding wrote: > On Thu, Oct 24, 2013 at 02:42:13PM +0200, Denis Carikli wrote: > > Cc: Rob Herring > > Cc: Pawel Moll > > Cc: Mark Rutland > > Cc: Stephen Warren > > Cc: Ian Campbell > > Cc: devicet...@vger.kernel.org > > Cc: Dmitry Torokhov > > Cc: linux-input@vger.kernel.org >

[PATCH v4] Input: add regulator haptic driver

2013-10-24 Thread Hyunhee Kim
From: Hyunhee Kim Date: Wed, 9 Oct 2013 16:21:36 +0900 Subject: [PATCH] Input: add regulator haptic driver Signed-off-by: Hyunhee Kim Signed-off-by: Kyungmin Park Acked-by: Aristeu Rozanski --- drivers/input/misc/Kconfig| 10 ++ drivers/input/misc/Makefile |1 + d

Re: [PATCHv7][ 1/4] Input: tsc2007: Add device tree support.

2013-10-24 Thread Lothar Waßmann
Hi, Grant Likely wrote: > On Thu, 24 Oct 2013 14:42:13 +0200, Denis Carikli wrote: > > Cc: Rob Herring > > Cc: Pawel Moll > > Cc: Mark Rutland > > Cc: Stephen Warren > > Cc: Ian Campbell > > Cc: devicet...@vger.kernel.org > > Cc: Dmitry Torokhov > > Cc: linux-input@vger.kernel.org > > Cc: S

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Joe Perches
On Thu, 2013-10-24 at 12:10 -0700, Dmitry Torokhov wrote: > On Thu, Oct 24, 2013 at 11:45:39AM -0700, Joe Perches wrote: > > On Thu, 2013-10-24 at 11:37 -0700, Dmitry Torokhov wrote: > > > Hi Joe, > > > > > > On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: > > > > Emitting an OOM mess

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Uwe Kleine-König
On Thu, Oct 24, 2013 at 11:48:48AM -0700, Joe Perches wrote: > On Thu, 2013-10-24 at 20:46 +0200, Uwe Kleine-König wrote: > > On Thu, Oct 24, 2013 at 11:43:38AM -0700, Joe Perches wrote: > [] > > > Any k.alloc without __GFP_NOWARN does a generic OOM message > > > and a dump_stack() so there could a

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Dmitry Torokhov
On Thu, Oct 24, 2013 at 11:45:39AM -0700, Joe Perches wrote: > On Thu, 2013-10-24 at 11:37 -0700, Dmitry Torokhov wrote: > > Hi Joe, > > > > On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: > > > Emitting an OOM message isn't necessary after input_allocate_device > > > as there's a gen

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Joe Perches
On Thu, 2013-10-24 at 20:46 +0200, Uwe Kleine-König wrote: > On Thu, Oct 24, 2013 at 11:43:38AM -0700, Joe Perches wrote: [] > > Any k.alloc without __GFP_NOWARN does a generic OOM message > > and a dump_stack() so there could already be 2 messages anyway. > Then mention that in the commit log if y

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Uwe Kleine-König
On Thu, Oct 24, 2013 at 11:43:38AM -0700, Joe Perches wrote: > On Thu, 2013-10-24 at 20:26 +0200, Uwe Kleine-König wrote: > > Hello Joe, > > > > On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: > > > Emitting an OOM message isn't necessary after input_allocate_device > > > as there's a

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Joe Perches
On Thu, 2013-10-24 at 11:37 -0700, Dmitry Torokhov wrote: > Hi Joe, > > On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: > > Emitting an OOM message isn't necessary after input_allocate_device > > as there's a generic OOM and a dump_stack already done. > > No, please don't. The kzallo

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Joe Perches
On Thu, 2013-10-24 at 20:26 +0200, Uwe Kleine-König wrote: > Hello Joe, > > On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: > > Emitting an OOM message isn't necessary after input_allocate_device > > as there's a generic OOM and a dump_stack already done. > > > > [...] > > Signed-off

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Dmitry Torokhov
Hi Joe, On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: > Emitting an OOM message isn't necessary after input_allocate_device > as there's a generic OOM and a dump_stack already done. No, please don't. The kzalloc may get changed in the future to not dump stack (that was added origin

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Uwe Kleine-König
Hello Joe, On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: > Emitting an OOM message isn't necessary after input_allocate_device > as there's a generic OOM and a dump_stack already done. > > [...] > Signed-off-by: Joe Perches > diff --git a/drivers/input/joystick/as5011.c b/drivers/

Re: [PATCH V4 1/2] tps6507x-ts: Add DT support

2013-10-24 Thread Mark Rutland
On Thu, Oct 24, 2013 at 06:05:53PM +0100, Manish Badarkhe wrote: > Hi Mark, > > Thank you for your reply. > > On Wed, Oct 23, 2013 at 10:15 PM, Mark Rutland wrote: > > On Wed, Oct 23, 2013 at 05:28:52PM +0100, Manish Badarkhe wrote: > > Add device tree based support for TI's tps6507x to

Re: [PATCHv7][ 1/4] Input: tsc2007: Add device tree support.

2013-10-24 Thread Eric Bénard
Hi Thierry, Le Thu, 24 Oct 2013 17:17:37 +0200, Thierry Reding a écrit : > > +- ti,max-rt: maximum pressure. > > +- ti,fuzzy: specifies the absolute input fuzz value. > > + If set, it will permit noise in the data up to +- the value given to the > > fuzz > > + parameter, that is used to filter

Re: [PATCHv7][ 1/4] Input: tsc2007: Add device tree support.

2013-10-24 Thread Thierry Reding
On Thu, Oct 24, 2013 at 02:42:13PM +0200, Denis Carikli wrote: > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Cc: Stephen Warren > Cc: Ian Campbell > Cc: devicet...@vger.kernel.org > Cc: Dmitry Torokhov > Cc: linux-input@vger.kernel.org > Cc: Sascha Hauer > Cc: linux-arm-ker...@list

[PATCHv6 0/3] DT Support for TWL4030 power button

2013-10-24 Thread Sebastian Reichel
Hi, This is the sixth iteration of DT support for the TWL4030 power button. Changes since v5 [0]: * Updated documentation [0] https://lkml.org/lkml/2013/10/23/416 -- Sebastian Sebastian Reichel (3): Input: twl4030-pwrbutton - add device tree support Input: twl4030-pwrbutton: use dev_err fo

[PATCHv6 1/3] Input: twl4030-pwrbutton - add device tree support

2013-10-24 Thread Sebastian Reichel
Add device tree support for twl4030 power button driver. Signed-off-by: Sebastian Reichel --- .../devicetree/bindings/input/twl4030-pwrbutton.txt | 21 + drivers/input/misc/twl4030-pwrbutton.c | 16 2 files changed, 33 insertions(+), 4 deletions(

[PATCHv6 2/3] Input: twl4030-pwrbutton: use dev_err for errors

2013-10-24 Thread Sebastian Reichel
Use dev_err() to output errors instead of dev_dbg(). Signed-off-by: Sebastian Reichel --- drivers/input/misc/twl4030-pwrbutton.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c index a3a0fe3.

[PATCHv6 3/3] Input: twl4030-pwrbutton: simplify driver using devm_*

2013-10-24 Thread Sebastian Reichel
Use managed irq resource to simplify the driver. Signed-off-by: Sebastian Reichel --- drivers/input/misc/twl4030-pwrbutton.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbut

Re: [PATCH] Input: add regulator haptic driver

2013-10-24 Thread Mark Brown
On Fri, Oct 11, 2013 at 11:22:00AM +0900, hyunhee.kim wrote: > + if (enable && !haptic->enabled) { > + haptic->enabled = true; > + ret = regulator_enable(haptic->regulator); > + if (ret) > + pr_err("haptic: %s failed to enable regulator\n

[PATCHv7][ 3/4] ARM: dts: cpuimx35 Add touchscreen support.

2013-10-24 Thread Denis Carikli
Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Stephen Warren Cc: Ian Campbell Cc: devicet...@vger.kernel.org Cc: Dmitry Torokhov Cc: linux-input@vger.kernel.org Cc: Sascha Hauer Cc: linux-arm-ker...@lists.infradead.org Cc: Lothar Waßmann Cc: Eric Bénard Signed-off-by: Denis Carikli

[PATCHv7][ 1/4] Input: tsc2007: Add device tree support.

2013-10-24 Thread Denis Carikli
Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Stephen Warren Cc: Ian Campbell Cc: devicet...@vger.kernel.org Cc: Dmitry Torokhov Cc: linux-input@vger.kernel.org Cc: Sascha Hauer Cc: linux-arm-ker...@lists.infradead.org Cc: Lothar Waßmann Cc: Eric Bénard Signed-off-by: Denis Carikli

[PATCHv7][ 4/4] ARM: imx_v6_v7_defconfig: Enable tsc2007 support.

2013-10-24 Thread Denis Carikli
The eukrea cpuimx35 and cpuimx51 have a tsc2007 touchscreen controller, so we turn it on. Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Stephen Warren Cc: Ian Campbell Cc: devicet...@vger.kernel.org Cc: Dmitry Torokhov Cc: linux-input@vger.kernel.org Cc: Sascha Hauer Cc: linux-arm-k

[PATCHv7][ 2/4] ARM: dts: cpuimx51 Add touchscreen support.

2013-10-24 Thread Denis Carikli
Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Stephen Warren Cc: Ian Campbell Cc: devicet...@vger.kernel.org Cc: Dmitry Torokhov Cc: linux-input@vger.kernel.org Cc: Sascha Hauer Cc: linux-arm-ker...@lists.infradead.org Cc: Lothar Waßmann Cc: Eric Bénard Signed-off-by: Denis Carikli

Re: [PATCHv6][ 1/4] Input: tsc2007: Add device tree support.

2013-10-24 Thread Rob Herring
On Thu, Oct 24, 2013 at 5:16 AM, Grant Likely wrote: > On Thu, 24 Oct 2013 10:38:50 +0200, Denis Carikli wrote: >> Cc: Rob Herring >> Cc: Pawel Moll >> Cc: Mark Rutland >> Cc: Stephen Warren >> Cc: Ian Campbell >> Cc: devicet...@vger.kernel.org >> Cc: Dmitry Torokhov >> Cc: linux-input@vger

Re: [PATCH v2] Input: add regulator haptic driver

2013-10-24 Thread Oliver Neukum
On Thu, 2013-10-24 at 18:26 +0900, hyunhee.kim wrote: > Hi, > > Thanks for your review. > I resent patch v3 after removing wrong wrapping. > > I made one toggle function because enable/disable functions have redundant > codes and another reviewer suggested it. > Is it better to separate it into

RE: [PATCH v2] Input: add regulator haptic driver

2013-10-24 Thread hyunhee.kim
Hi, Thanks for your review. I resent patch v3 after removing wrong wrapping. I made one toggle function because enable/disable functions have redundant codes and another reviewer suggested it. Is it better to separate it into two functions? Thanks, Hyunhee Kim. -Original Message- From

[PATCH v3] Input: add regulator haptic driver

2013-10-24 Thread hyunhee.kim
From: Hyunhee Kim Date: Wed, 9 Oct 2013 16:21:36 +0900 Subject: [PATCH] Input: add regulator haptic driver Signed-off-by: Hyunhee Kim Signed-off-by: Kyungmin Park Acked-by: Aristeu Rozanski --- drivers/input/misc/Kconfig| 10 ++ drivers/input/misc/Makefile |1 + d

Re: [PATCHv4 1/3] Input: twl4030-pwrbutton - add device tree support

2013-10-24 Thread Florian Vaussard
Hello, On 10/24/2013 10:38 AM, Sebastian Reichel wrote: > Hi Florian, > > On Thu, Oct 24, 2013 at 09:47:33AM +0200, Florian Vaussard wrote: >>> +Required SoC Specific Properties: >>> +- compatible: should be one of the following >>> + - "ti,twl4030-pwrbutton": For controllers compatible with twl

[PATCHv6][ 4/4] ARM: imx_v6_v7_defconfig: Enable tsc2007 support.

2013-10-24 Thread Denis Carikli
The eukrea cpuimx35 and cpuimx51 have a tsc2007 touchscreen controller, so we turn it on. Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Stephen Warren Cc: Ian Campbell Cc: devicet...@vger.kernel.org Cc: Dmitry Torokhov Cc: linux-input@vger.kernel.org Cc: Sascha Hauer Cc: linux-arm-k

[PATCHv6][ 3/4] ARM: dts: cpuimx35 Add touchscreen support.

2013-10-24 Thread Denis Carikli
Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Stephen Warren Cc: Ian Campbell Cc: devicet...@vger.kernel.org Cc: Dmitry Torokhov Cc: linux-input@vger.kernel.org Cc: Sascha Hauer Cc: linux-arm-ker...@lists.infradead.org Cc: Lothar Waßmann Cc: Eric Bénard Signed-off-by: Denis Carikli

Re: [PATCHv4 1/3] Input: twl4030-pwrbutton - add device tree support

2013-10-24 Thread Sebastian Reichel
Hi Florian, On Thu, Oct 24, 2013 at 09:47:33AM +0200, Florian Vaussard wrote: > > +Required SoC Specific Properties: > > +- compatible: should be one of the following > > + - "ti,twl4030-pwrbutton": For controllers compatible with twl4030 > > +- interrupt: should be one of the following > > +

[PATCHv6][ 2/4] ARM: dts: cpuimx51 Add touchscreen support.

2013-10-24 Thread Denis Carikli
Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Stephen Warren Cc: Ian Campbell Cc: devicet...@vger.kernel.org Cc: Dmitry Torokhov Cc: linux-input@vger.kernel.org Cc: Sascha Hauer Cc: linux-arm-ker...@lists.infradead.org Cc: Lothar Waßmann Cc: Eric Bénard Signed-off-by: Denis Carikli

[PATCHv6][ 1/4] Input: tsc2007: Add device tree support.

2013-10-24 Thread Denis Carikli
Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Stephen Warren Cc: Ian Campbell Cc: devicet...@vger.kernel.org Cc: Dmitry Torokhov Cc: linux-input@vger.kernel.org Cc: Sascha Hauer Cc: linux-arm-ker...@lists.infradead.org Cc: Lothar Waßmann Cc: Eric Bénard Signed-off-by: Denis Carikli

Re: [PATCH v2] Input: add regulator haptic driver

2013-10-24 Thread Oliver Neukum
On Thu, 2013-10-24 at 15:35 +0900, hyunhee.kim wrote: Hi, first of all your mail client mangled the patch. > +static void regulator_haptic_toggle(struct regulator_haptic *haptic, bool > enable) > +{ > + int ret; > + > + mutex_lock(&haptic->mutex); > + if (enable && !haptic->enabled)

Re: [PATCHv4 1/3] Input: twl4030-pwrbutton - add device tree support

2013-10-24 Thread Florian Vaussard
Hello Sebastian, On 10/23/2013 07:54 PM, Sebastian Reichel wrote: > Add device tree support for twl4030 power button driver. > > Signed-off-by: Sebastian Reichel > --- > .../devicetree/bindings/input/twl4030-pwrbutton.txt | 13 + > drivers/input/misc/twl4030-pwrbutton.c

Re: [PATCHv5][ 1/4] Input: tsc2007: Add device tree support.

2013-10-24 Thread Thierry Reding
On Thu, Oct 24, 2013 at 08:51:50AM +0200, Lothar Waßmann wrote: > Hi, > > Rob Herring wrote: > > On 10/23/2013 07:10 AM, Denis Carikli wrote: > [...] > > > diff --git > a/Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt > b/Documentation/devicetree/bindings/input/touchscreen/tsc2007

[PATCH v2] Input: add regulator haptic driver

2013-10-24 Thread hyunhee.kim
From: Hyunhee Kim Date: Wed, 9 Oct 2013 16:21:36 +0900 Subject: [PATCH] Input: add regulator haptic driver Signed-off-by: Hyunhee Kim Signed-off-by: Kyungmin Park Acked-by: Aristeu Rozanski --- drivers/input/misc/Kconfig| 10 ++ drivers/input/misc/Makefile |1 + d