Re: [PATCHv4 0/5] HID: sony: Dualshock3 USB and LED support

2013-11-26 Thread Jiri Kosina
On Fri, 22 Nov 2013, si...@mungewell.org wrote: > I'm a little confused about which kernel this should be in. I believe the > first in this patch series is required for 3.13 (but does not seemed to be > included (1)). > > Without this, the kernel will be subject to lockups if anyone actually > us

Re: [PATCH] uhid: Pad short UHID_CREATE writes from compat tasks

2013-11-26 Thread David Herrmann
Hi On Tue, Nov 26, 2013 at 8:02 AM, Ben Hutchings wrote: > Short event writes are normally padded with zeroes, but the compat > fixup for UHID_CREATE didn't ensure this. This appears to allow an > information leak. > > Compile-tested only. > > Fixes: befde0226a59 ('HID: uhid: make creating devic

[PATCH v2] HID: uhid: fix leak for 64/32 UHID_CREATE

2013-11-26 Thread David Herrmann
UHID allows short writes so user-space can omit unused fields. We automatically set them to 0 in the kernel. However, the 64/32 bit compat-handler didn't do that in the UHID_CREATE fallback. This will reveal random kernel heap data (of random size, even) to user-space. Reported-by: Ben Hutchings

[PATCH] input: ixp4xx-beeper: don't use symbols from

2013-11-26 Thread Uwe Kleine-König
mach/timex.h is about to be dropped so don't use symbols defined in there. For ixp4xx there is a suitable substitute for IXP4XX_TIMER_FREQ, i.e. a global and exported variable that holds the same value. Signed-off-by: Uwe Kleine-König --- Hello, I'd like to keep that patch in a series for the a

Re: [PATCH v2] HID: uhid: fix leak for 64/32 UHID_CREATE

2013-11-26 Thread Ben Hutchings
On Tue, 2013-11-26 at 13:58 +0100, David Herrmann wrote: > UHID allows short writes so user-space can omit unused fields. We > automatically set them to 0 in the kernel. However, the 64/32 bit > compat-handler didn't do that in the UHID_CREATE fallback. This will > reveal random kernel heap data (o

Re: [PATCH] input: ixp4xx-beeper: don't use symbols from

2013-11-26 Thread Dmitry Torokhov
On Tue, Nov 26, 2013 at 03:29:01PM +0100, Uwe Kleine-König wrote: > mach/timex.h is about to be dropped so don't use symbols defined in > there. For ixp4xx there is a suitable substitute for IXP4XX_TIMER_FREQ, > i.e. a global and exported variable that holds the same value. > > Signed-off-by: Uwe

Re: [PATCH v2] Input: ads7846: Convert to hwmon_device_register_with_groups

2013-11-26 Thread Dmitry Torokhov
Hi Guenter, On Mon, Nov 25, 2013 at 08:39:04PM -0800, Guenter Roeck wrote: > Simplify the code and create mandatory 'name' attribute by using > new hwmon API. So this moves hwmon attributes from the parent i2c device to the hwmon device, right? Would not that break userspace which expects to find

[PATCH] Input: sur40 - suppress false uninitialized variable warning

2013-11-26 Thread Dmitry Torokhov
We will never use packet_id before initializing it as we start with "need_blobs == -1" and will set packet_id there. Also use le32_to_cpu when fetching header->packet_id. Signed-off-by: Dmitry Torokhov --- drivers/input/touchscreen/sur40.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

Re: [PATCH] input: Add support for MMA7455L/MMA7456L 3-Axis Accelerometer

2013-11-26 Thread Dmitry Torokhov
Hi Alexander, On Fri, Nov 22, 2013 at 07:53:35PM +0400, Alexander Shiyan wrote: > This patch adds support for Freescale MMA7455L/MMA7456L 3-Axis > Accelerometer connected to I2C bus. Driver can be loaded ether > with or without DT support. The basic parameters of the driver > can be changed throug

Re: input question: ambient light sensor button

2013-11-26 Thread Dmitry Torokhov
On Fri, Nov 22, 2013 at 12:13:49PM +0100, Pali Rohár wrote: > On Wednesday 20 November 2013 16:59:42 Benjamin Tissoires wrote: > > Hi, > > > > On Wed, Nov 20, 2013 at 9:50 AM, Pali Rohár wrote: > > >> > > I guess we need patch adding > > >> > > > > >> > > #define KEY_ALS_TOGGLE 0x230 > > >> >

Re: [lm-sensors] [PATCH v2] Input: ads7846: Convert to hwmon_device_register_with_groups

2013-11-26 Thread Jean Delvare
Hi Dmitry, On Tue, 26 Nov 2013 10:58:46 -0800, Dmitry Torokhov wrote: > On Mon, Nov 25, 2013 at 08:39:04PM -0800, Guenter Roeck wrote: > > Simplify the code and create mandatory 'name' attribute by using > > new hwmon API. > > So this moves hwmon attributes from the parent i2c device to the hwmon

Re: [PATCH 4/4 v3] Input: wacom - add SW_TOUCH to include/uapi/linux/input.h

2013-11-26 Thread Ping Cheng
On Mon, Nov 25, 2013 at 6:59 PM, Dmitry Torokhov wrote: > Hi Ping, > > On Fri, Nov 15, 2013 at 12:00:02PM -0800, Ping Cheng wrote: >>> @@ -856,6 +856,7 @@ struct input_keymap_entry { >> #define SW_FRONT_PROXIMITY 0x0b /* set = front proximity sensor active */ >> #define SW_ROTATE_LOCK

[PATCH 02/15] input: sh_keysc: Restrict non-COMPILE_TEST compilation

2013-11-26 Thread Laurent Pinchart
Hardware supported by the driver is only found on SUPERH or ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST compilation to them. Cc: Dmitry Torokhov Cc: linux-input@vger.kernel.org Signed-off-by: Laurent Pinchart --- drivers/input/keyboard/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 de

Re: [PATCH v2] Input: ads7846: Convert to hwmon_device_register_with_groups

2013-11-26 Thread Guenter Roeck
On 11/26/2013 10:58 AM, Dmitry Torokhov wrote: Hi Guenter, On Mon, Nov 25, 2013 at 08:39:04PM -0800, Guenter Roeck wrote: Simplify the code and create mandatory 'name' attribute by using new hwmon API. So this moves hwmon attributes from the parent i2c device to the hwmon device, right? Would

[PATCH] drivers: input: touchscreen: sur40: use static variable instead of stack varialbe for 'packet_id'

2013-11-26 Thread Chen Gang
'packet_id' is used for checking sequence whether in order, it need be static variable independent from sur40_poll(). The related warning (with allmodconfig under hexagon): drivers/input/touchscreen/sur40.c: In function 'sur40_poll': drivers/input/touchscreen/sur40.c:297:6: warning: 'packet_i

Re: [PATCH v2] Input:Add support for DualPoint device on Dell XT2 model

2013-11-26 Thread Dmitry Torokhov
Hi Yunkang, On Fri, Nov 15, 2013 at 10:11:42PM +0800, Yunkang Tang wrote: > Hi all, > >Here is the 2nd version for supporting DualPoint device on Dell XT2 model > > Changelist: > - Bugfix for trackpoint's behavior was abnormal in v1. > [Root Cause] >Because of the special MPU controll

Re: [PATCH] input: Add support for MMA7455L/MMA7456L 3-Axis Accelerometer

2013-11-26 Thread Alexander Shiyan
Hello. > On Fri, Nov 22, 2013 at 07:53:35PM +0400, Alexander Shiyan wrote: > > This patch adds support for Freescale MMA7455L/MMA7456L 3-Axis > > Accelerometer connected to I2C bus. Driver can be loaded ether > > with or without DT support. The basic parameters of the driver > > can be changed thr