Re: [PATCH 02/15] input: sh_keysc: Restrict non-COMPILE_TEST compilation

2013-11-27 Thread Simon Horman
On Wed, Nov 27, 2013 at 02:18:24AM +0100, Laurent Pinchart wrote: > Hardware supported by the driver is only found on SUPERH or > ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST compilation to them. > > Cc: Dmitry Torokhov > Cc: linux-input@vger.kernel.org > Signed-off-by: Laurent Pinchart A

Re: [PATCH 3/3] Input: pcips2 - use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Dmitry Torokhov
On Thu, Nov 28, 2013 at 01:32:31PM +0900, Jingoo Han wrote: > On Thursday, November 28, 2013 12:57 PM, Dmitry Torokhov wrote: > > On Thu, Nov 28, 2013 at 11:21:12AM +0900, Jingoo Han wrote: > > > This macro is used to create a struct pci_device_id array. > > > > Applied all 3, thank you. > > Plea

Re: [PATCH 3/3] Input: pcips2 - use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Jingoo Han
On Thursday, November 28, 2013 12:57 PM, Dmitry Torokhov wrote: > On Thu, Nov 28, 2013 at 11:21:12AM +0900, Jingoo Han wrote: > > This macro is used to create a struct pci_device_id array. > > Applied all 3, thank you. Please, drop these patches. According to the Greg Kroah-Hartman, "Yeah, and

[PATCH v2] drivers: input: touchscreen: sur40: remove stack variable 'packet_id' from sur40_poll()

2013-11-27 Thread Chen Gang
The drivers process all blobs in one pass, so there is no need to preserve value of packet_id between calls to sur40_poll(). And the original implementation may cause 'packet_id' uninitialized, the related warning (with allmodconfig under hexagon): drivers/input/touchscreen/sur40.c: In function

Re: [PATCH] drivers: input: touchscreen: sur40: use static variable instead of stack varialbe for 'packet_id'

2013-11-27 Thread Chen Gang
On 11/28/2013 12:07 PM, Dmitry Torokhov wrote: > Hi Chen, > > On Wed, Nov 27, 2013 at 10:15:33AM +0800, Chen Gang wrote: >> > 'packet_id' is used for checking sequence whether in order, it need be >> > static variable independent from sur40_poll(). >> > >> > The related warning (with allmodconfig

Re: [PATCH v2] Input: ads7846: Convert to hwmon_device_register_with_groups

2013-11-27 Thread Dmitry Torokhov
On Tue, Nov 26, 2013 at 05:20:13PM -0800, Guenter Roeck wrote: > On 11/26/2013 10:58 AM, Dmitry Torokhov wrote: > >Hi Guenter, > > > >On Mon, Nov 25, 2013 at 08:39:04PM -0800, Guenter Roeck wrote: > >>Simplify the code and create mandatory 'name' attribute by using > >>new hwmon API. > > > >So this

Re: [PATCH] drivers: input: touchscreen: sur40: use static variable instead of stack varialbe for 'packet_id'

2013-11-27 Thread Dmitry Torokhov
Hi Chen, On Wed, Nov 27, 2013 at 10:15:33AM +0800, Chen Gang wrote: > 'packet_id' is used for checking sequence whether in order, it need be > static variable independent from sur40_poll(). > > The related warning (with allmodconfig under hexagon): > > drivers/input/touchscreen/sur40.c: In fun

Re: [PATCH 3/3] Input: pcips2 - use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Dmitry Torokhov
On Thu, Nov 28, 2013 at 11:21:12AM +0900, Jingoo Han wrote: > This macro is used to create a struct pci_device_id array. Applied all 3, thank you. > > Signed-off-by: Jingoo Han > --- > drivers/input/serio/pcips2.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dri

[PATCH 3/3] Input: pcips2 - use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Jingoo Han
This macro is used to create a struct pci_device_id array. Signed-off-by: Jingoo Han --- drivers/input/serio/pcips2.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/serio/pcips2.c b/drivers/input/serio/pcips2.c index 13062f6..2fff5d4 100644 --- a/drivers/inp

[PATCH 2/3] Input: fm801-gp - use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Jingoo Han
This macro is used to create a struct pci_device_id array. Signed-off-by: Jingoo Han --- drivers/input/gameport/fm801-gp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/gameport/fm801-gp.c b/drivers/input/gameport/fm801-gp.c index ae912d3..5ace35bf 100644

[PATCH 1/3] Input: emu10k1 - use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Jingoo Han
This macro is used to create a struct pci_device_id array. Signed-off-by: Jingoo Han --- drivers/input/gameport/emu10k1-gp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/gameport/emu10k1-gp.c b/drivers/input/gameport/emu10k1-gp.c index fa7a95c..72a7213 10

RE: [PATCH 00/04] input: RMI4 Synaptics RMI4 Touchscreen Driver

2013-11-27 Thread Christopher Heiny
[sorry for top posting - I'm out of the office today, and restricted to the feeble webmail interface.] Benjamin made some excellent points in our off-line conversation. Please disregard this particular patchset. We'll work on doing the same thing in a series of smaller, more manageable steps.

Re: [PATCH 00/04] input: RMI4 Synaptics RMI4 Touchscreen Driver

2013-11-27 Thread Benjamin Tissoires
On Wed, Nov 13, 2013 at 6:39 PM, Christopher Heiny wrote: > This patchset implements changes to the synaptics-rmi4 branch of > Dmitry's input tree. The base for the patchset is Dmitry's commit > 4a695a01fba9bf467b3b52e124ccee6cef73b323 from 2013-01-31. > > > > Overall this patchset implements the

[PATCH 2/2] iio: hid-sensors: Fix power and report state

2013-11-27 Thread Srinivas Pandruvada
In the original HID sensor hub firmwares all Named array enums were to 0-based. But the most recent hub implemented as 1-based, because of the implementation by one of the major OS vendor. Using logical minimum for the field as the base of enum. So we add logical minimum to the selector values befo

[PATCH 1/2] HID: hid-sensor-hub: Add logical min and max

2013-11-27 Thread Srinivas Pandruvada
Exporting logical minimum and maximum of HID fields as part of the hid sensor attribute info. This can be used for range checking and to calculate enumeration base for NAry fields of HID sensor hub. Signed-off-by: Srinivas Pandruvada --- drivers/hid/hid-sensor-hub.c | 20

Re: [PATCH v2] HID: uhid: fix leak for 64/32 UHID_CREATE

2013-11-27 Thread Jiri Kosina
On Tue, 26 Nov 2013, Ben Hutchings wrote: > On Tue, 2013-11-26 at 13:58 +0100, David Herrmann wrote: > > UHID allows short writes so user-space can omit unused fields. We > > automatically set them to 0 in the kernel. However, the 64/32 bit > > compat-handler didn't do that in the UHID_CREATE fall

Re: [PATCH v2] Input:Add support for DualPoint device on Dell XT2 model

2013-11-27 Thread Tommy Will
Hi Dmitry, Thanks for your reply. > > It would help greatly if you could document what parameters the new > initialization routine sets. > Ok, please let me explain what I did in initialization. >+static int alps_hw_init_v6(struct psmouse *psmouse) >+{ >+ unsigned char param[2] = {0xC8, 0x14