On Thu, Dec 19, 2013 at 04:28:31PM +0100, Sebastian Andrzej Siewior wrote:
> The ADC driver always programs all possible ADC values and discards
> them except for the value IIO asked for. On the am335x-evm the driver
> programs four values and it takes 500us to gather them. Reducing the number
> of
The mkbp code (post 3.4) has an issue where it can't deal with two
keys on the keyboard having the same keycode. When this happens it
will get confused about whether the key is down or up and will cause
some screwy behavior.
We need to have two keys on the keyboard with the same keycode for UK
ke
On 12/19/2013 06:18 PM, Lee Jones wrote:
> Assuming nothing else has changed since the answers you gave me:
> Acked-by: Lee Jones
>
> Once we have the remaining Acks I'll happily apply this patch-set.
Thank you.
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-inp
On Thu, 19 Dec 2013, Sebastian Andrzej Siewior wrote:
> The ADC driver always programs all possible ADC values and discards
> them except for the value IIO asked for. On the am335x-evm the driver
> programs four values and it takes 500us to gather them. Reducing the number
> of conversations down
On Thu, 19 Dec 2013, Sebastian Andrzej Siewior wrote:
> Since the "recent" changes, am335x_tsc_se_update() has no longer any
> users outside of this file so make it local.
>
> Signed-off-by: Sebastian Andrzej Siewior
I'm pretty sure I Acked this already.
> ---
> drivers/mfd/ti_am335x_tscadc.c
> -Original Message-
> From: David Herrmann [mailto:dh.herrm...@gmail.com]
> Sent: Thursday, December 19, 2013 3:32 AM
> To: linux-input@vger.kernel.org
> Cc: Jiri Kosina; Dan Carpenter; Joseph Salisbury; KY Srinivasan; Haiyang
> Zhang;
> linux-ker...@vger.kernel.org; David Herrmann
> Su
Hi
On Thu, Dec 19, 2013 at 5:05 PM, Benjamin Tissoires
wrote:
> we used to set the parent of the input device as the parent of
> the hid bus. This was introduced when we created hid as a real bus, and
> to keep backward compatibility. Now, it's time to proper set the parent
> so that sysfs has an
most of the protocol callbacks used by the pen protocol are generic,
they just ask hid-input to treat the incoming data.
Introduce a generic protocol to avoid having to copy/paste the pens
callbacks for other kinds of input reports.
Tested-by: Edel Maks
Signed-off-by: Benjamin Tissoires
---
dri
we used to set the parent of the input device as the parent of
the hid bus. This was introduced when we created hid as a real bus, and
to keep backward compatibility. Now, it's time to proper set the parent
so that sysfs has an idea of which input device is attached to
which hid device.
Signed-off
The ANTEC Touch Pad is a device which can switch from a multitouch
touchpad to a mouse. It thus presents several generic collections which
are currently ignored by hid-multitouch. Enable them by using the generic
protocol. Adding also a suffix for them depending on their application.
Reported-by:
In kernel v3.10, we added the support of pen in addition to touch because
some devices presents both pen and touch on the same HID device.
Now, we are seeing at least one device (ANTON Touch Pad) which presents
a multitouch collection and a mouse collection which are both valid.
Instead of adding
Hi guys,
well, I have been reported a brand new device, which, as always presents a new
way of dealing with multitouch and mouse and soever.
The new fancy stuff is capable to report mouse and touch, whereas by default,
we consider mouse as garbage.
if you want to get an idea of the device:
http:/
The ADC driver always programs all possible ADC values and discards
them except for the value IIO asked for. On the am335x-evm the driver
programs four values and it takes 500us to gather them. Reducing the number
of conversations down to the (required) one also reduces the busy loop down
to 125us.
The update of the SE register in MFD doesn't look right as it has
nothing to do with it. The better place to do it is in TSC driver (which
is already doing it) and in the ADC driver which needs this only in the
continues mode.
Acked-by: Lee Jones [MFD part]
Signed-off-by: Sebastian Andrzej Siewi
It somehow looks like the ending bracket belongs to the if statement but
it does belong to the while loop. This patch moves the bracket where it
belongs.
Reviewed-by: Lee Jones
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/iio/adc/ti_am335x_adc.c | 2 +-
1 file changed, 1 insertion(+), 1
The purpose of reg_se_cache has been defeated. It should avoid the
read-back of the register to avoid the latency and the fact that the
bits are reset to 0 after the individual conversation took place.
The reason why this is required like this to work, is that read-back of
the register removes the
Since the "recent" changes, am335x_tsc_se_update() has no longer any
users outside of this file so make it local.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/mfd/ti_am335x_tscadc.c | 3 +--
include/linux/mfd/ti_am335x_tscadc.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
The two bigger issues here are fixed by the last patch incuding
- time outs on the iio/adc side while TSC&ADC is used together
- a lockup issue which occurs while TSC&ADC is used together.
v1…v2:
- spelled checked and re-read each commit message and formated to
subject line as Lee suggested.
On Thu, 19 Dec 2013, David Herrmann wrote:
> As this thread doesn't really contain any oops message nor the exact
> driver name (except mentioning hyperv and magicmouse),
FWIW I recall the oopses being present somewhere in the ubuntu bug
tracker, referenced in this thread.
Thanks,
--
Jiri Ko
Hi List,
may I ask for some (other) comments that actually help fix this bug?
Some vague concerns dont really help.
Thanks, Ben
2013/12/11 Benjamin Franzke :
> Gamepads like XInput devices have triggers with a range from
> e.g. 0 to 255.
> When the conventional joydev AXES correction/mapping m
Use helper functions to simplify _DSM related code in i2c-hid driver.
Signed-off-by: Jiang Liu
---
drivers/hid/i2c-hid/i2c-hid.c | 26 ++
1 file changed, 6 insertions(+), 20 deletions(-)
diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
index 5
We need at least HID_MAX_BUFFER_SIZE (4096) bytes as input buffer. HID
core depends on this as it requires every input report to be at least as
big as advertised.
Signed-off-by: David Herrmann
---
Hi
Same as for the HIDP patch, if there's a way to avoid the extra copy, please
provide a better pa
Hi
On Thu, Dec 19, 2013 at 11:08 AM, David Herrmann wrote:
> Hi
>
> On Thu, Dec 19, 2013 at 10:59 AM, Jiri Kosina wrote:
>> On Thu, 19 Dec 2013, David Herrmann wrote:
>>
>>> > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
>>> > index 253fe23..81eacd3 100644
>>> > --- a/drivers/hid
HID core expects the input buffers to be at least of size 4096
(HID_MAX_BUFFER_SIZE). Other sizes will result in buffer-overflows if an
input-report is smaller than advertised. We could, like i2c, compute the
biggest report-size instead of using HID_MAX_BUFFER_SIZE, but this will
blow up if report-
On 12/19/2013 09:42 AM, Lee Jones wrote:
> Spell check this entire block.
will do.
> Smileys in commit messages are generally a bad idea.
will drop.
> Please insert '\n's between paragraphs.
Okay.
> Proof read, as some of the sentences are not comprehensible.
I am going to retry.
> /* MFD P
Hi
On Thu, Dec 19, 2013 at 10:59 AM, Jiri Kosina wrote:
> On Thu, 19 Dec 2013, David Herrmann wrote:
>
>> > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
>> > index 253fe23..81eacd3 100644
>> > --- a/drivers/hid/hid-core.c
>> > +++ b/drivers/hid/hid-core.c
>> > @@ -1334,7 +1334,7 @
On Thu, 19 Dec 2013, David Herrmann wrote:
> > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> > index 253fe23..81eacd3 100644
> > --- a/drivers/hid/hid-core.c
> > +++ b/drivers/hid/hid-core.c
> > @@ -1334,7 +1334,7 @@ int hid_report_raw_event(struct hid_device *hid, int
> > type,
Hi
On Mon, Dec 16, 2013 at 2:01 PM, Jiri Kosina wrote:
> On Fri, 27 Sep 2013, Joseph Salisbury wrote:
>
>> >> commit b1a1442a23776756b254b69786848a94d92445ba
>> >> Author: Jiri Kosina
>> >> Date: Mon Jun 3 11:27:48 2013 +0200
>> >>
>> >> HID: core: fix reporting of raw events
>> >>
>> >> Rev
Hi
On Sat, Dec 14, 2013 at 8:14 AM, Reyad Attiyat wrote:
> I have a basic question about the way the linux kernel handles human
> input devices. I bought a Surface Pro 2 with a Type cover keyboard.
> This did not work out of the box with stock linux kernel 3.11. When I
> added the hardware id of
Hi
On Tue, Dec 10, 2013 at 4:27 AM, Zachary Lund wrote:
>
> On 12/08/13 00:18, Zachary Lund wrote:
>>
>> Secondly, the Xbox 360 controllers claim to be HID compliant... this is
>> not an HID driver. That's because the report descriptor is missing and I,
>> unfortunately, do not know what to do ab
> The update of the SE register in MFD doesn't look right as it has
> nothing to do with it. The better place to do it is in TSC driver (which
> is already doint it) and in the ADC driver which needs this only in the
> continues mode.
When you resubmit the patch-set complete with Acks, please ensu
On Wed, 18 Dec 2013, Sebastian Andrzej Siewior wrote:
> The purpose of reg_se_cache has been defeated. It should avoid the
> read-back of the register to avoid the latency and the fact that the
> bits are reset to 0 after the individual conversation took place.
>
> The reason why this is required
> since the "recent" changes, am335x_tsc_se_update() has no longer any
> users outside of this file so make it local.
Please use formatting dictated by the subsystem when providing
patches. For MFD we capitalise the first word after 'mfd: : ' and
the same for the first word in the commit body.
Pa
> >> Given timing I suspect that by the we have reviewed these will be too
> >late in this cycle so will hit in the merge window plus stable.
> >>
> >> Also some of these are cleanups rather than fixes so should normally
> >be separate from fixes and applied after them as they are not
> >> Stable
On Wed, 18 Dec 2013, Sebastian Andrzej Siewior wrote:
> It somehow looks like the ending bracket belongs to the if statement but
> it does belong to the while loop. This patch moves the bracket where it
> belongs.
>
> Signed-off-by: Sebastian Andrzej Siewior
> ---
> drivers/iio/adc/ti_am335x_ad
> The ADC driver always programms all possible ADC values and discards
> them except for the value IIO asked for. On the am335x-evm the driver
> programs four values and it takes 500us to gather them. Reducing the number
> of coversations down to (required) one also reduces the busy loop down to
>
36 matches
Mail list logo
