Re: [PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-03 Thread Dmitry Torokhov
On Fri, Jan 03, 2014 at 10:49:07PM -0800, Andrey Smirnov wrote: > On Fri, Jan 3, 2014 at 10:16 PM, Dmitry Torokhov > wrote: > > On Fri, Jan 03, 2014 at 09:52:25PM -0800, Andrey Smirnov wrote: > >> On Fri, Jan 3, 2014 at 9:28 PM, Dmitry Torokhov > >> wrote: > >> > pcu->cmd_buf[IMS_PCU_DATA_OFFSET]

Re: [PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-03 Thread Andrey Smirnov
On Fri, Jan 3, 2014 at 10:16 PM, Dmitry Torokhov wrote: > On Fri, Jan 03, 2014 at 09:52:25PM -0800, Andrey Smirnov wrote: >> On Fri, Jan 3, 2014 at 9:28 PM, Dmitry Torokhov >> wrote: >> > pcu->cmd_buf[IMS_PCU_DATA_OFFSET] is word aligned so we do not need to use >> > get_unaligned_le16 to access

Re: Another ALPS touchpad

2014-01-03 Thread Tommy Will
2014/1/4 Dmitry Torokhov : > On Sat, Jan 04, 2014 at 02:08:26PM +0800, Tommy Will wrote: >> Does X-server have already supported this feature? (I'm sorry I did >> not try the latest X-Server) > > It should as far as I know (I do not have any clickpad devices). > Got that, thanks! We would check t

Re: Another ALPS touchpad

2014-01-03 Thread Dmitry Torokhov
On Sat, Jan 04, 2014 at 02:08:26PM +0800, Tommy Will wrote: > 2014/1/4 Dmitry Torokhov : > > On Thursday, January 02, 2014 11:59:15 PM Dylan Paul Thurston wrote: > > >> Yes, it's an ALPS device and we're now preparing the patch for this new > >> one. > >> BTW, since it's a ClickPad without sepera

Re: [PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-03 Thread Dmitry Torokhov
On Fri, Jan 03, 2014 at 09:52:25PM -0800, Andrey Smirnov wrote: > On Fri, Jan 3, 2014 at 9:28 PM, Dmitry Torokhov > wrote: > > pcu->cmd_buf[IMS_PCU_DATA_OFFSET] is word aligned so we do not need to use > > get_unaligned_le16 to access it. > > > > Also let's add build time check to make sure it sta

Re: Another ALPS touchpad

2014-01-03 Thread Tommy Will
2014/1/4 Dmitry Torokhov : > On Thursday, January 02, 2014 11:59:15 PM Dylan Paul Thurston wrote: >> Yes, it's an ALPS device and we're now preparing the patch for this new one. >> BTW, since it's a ClickPad without seperate buttons, simple resting >> finger logic would be added. > > Hmm, what fin

Re: [PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-03 Thread Andrey Smirnov
On Fri, Jan 3, 2014 at 9:28 PM, Dmitry Torokhov wrote: > pcu->cmd_buf[IMS_PCU_DATA_OFFSET] is word aligned so we do not need to use > get_unaligned_le16 to access it. > > Also let's add build time check to make sure it stays aligned. - AFAIK, there's no guarantee the "pcu" itself is aligned - Thi

Re: [PATCH v2] ims-pcu: Add commands supported by the new version of the FW

2014-01-03 Thread Dmitry Torokhov
On Fri, Jan 03, 2014 at 09:03:11PM -0800, Andrey Smirnov wrote: > On Fri, Jan 3, 2014 at 8:44 PM, Dmitry Torokhov > wrote: > > On Fri, Jan 03, 2014 at 08:24:17PM -0800, Andrey Smirnov wrote: > >> On Fri, Jan 3, 2014 at 5:39 PM, Dmitry Torokhov > >> wrote: > >> > Hi Andrey, > >> > > >> > On Wed, J

Re: Another ALPS touchpad

2014-01-03 Thread Dmitry Torokhov
Hi Tommy, On Sat, Jan 04, 2014 at 01:27:24PM +0800, Tommy Will wrote: > Hi Dmitry, > > > Do you have anything in works to support this new model? Or it is > > not an ALPS device at all? > > Yes, it's an ALPS device and we're now preparing the patch for this new one. > BTW, since it's a ClickPad

Re: [PATCHv4 0/2] twl4030-keypad DT binding

2014-01-03 Thread Sebastian Reichel
Dmitry, What's the status of this patch? Can you queue this for 3.14? -- Sebastian signature.asc Description: Digital signature

Re: [PATCH] Input: ims-pcu - fix error unwinding path in application mode

2014-01-03 Thread Dmitry Torokhov
On Fri, Jan 03, 2014 at 09:13:10PM -0800, Andrey Smirnov wrote: > Dmitry, > > Do you want this patch to go separatly or do you want me to bundle it > with my other changes(probably the first one)? I'll apply it separately. > Also, offtopic, do you want me to backport this changes to 2.6 kernel >

[PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-03 Thread Dmitry Torokhov
pcu->cmd_buf[IMS_PCU_DATA_OFFSET] is word aligned so we do not need to use get_unaligned_le16 to access it. Also let's add build time check to make sure it stays aligned. Signed-off-by: Dmitry Torokhov --- drivers/input/misc/ims-pcu.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-

Re: Another ALPS touchpad

2014-01-03 Thread Tommy Will
Hi Dmitry, > Do you have anything in works to support this new model? Or it is > not an ALPS device at all? Yes, it's an ALPS device and we're now preparing the patch for this new one. BTW, since it's a ClickPad without seperate buttons, simple resting finger logic would be added. -- Best Rega

Re: [PATCH] Input: ims-pcu - fix error unwinding path in application mode

2014-01-03 Thread Andrey Smirnov
Dmitry, Do you want this patch to go separatly or do you want me to bundle it with my other changes(probably the first one)? Also, offtopic, do you want me to backport this changes to 2.6 kernel that IMS uses or would you do it? Thanks, On Fri, Jan 3, 2014 at 9:00 PM, Dmitry Torokhov wrote: > W

Re: [PATCH v2] ims-pcu: Add commands supported by the new version of the FW

2014-01-03 Thread Andrey Smirnov
On Fri, Jan 3, 2014 at 8:44 PM, Dmitry Torokhov wrote: > On Fri, Jan 03, 2014 at 08:24:17PM -0800, Andrey Smirnov wrote: >> On Fri, Jan 3, 2014 at 5:39 PM, Dmitry Torokhov >> wrote: >> > Hi Andrey, >> > >> > On Wed, Jan 01, 2014 at 04:47:01PM -0800, Andrey Smirnov wrote: >> >> New version of the

[PATCH] Input: ims-pcu - fix error unwinding path in application mode

2014-01-03 Thread Dmitry Torokhov
We first create backlight and then input devices so we shoudl destroy them in opposite order when handling errors. Signed-off-by: Dmitry Torokhov --- Andrey, this fixup was split off from the patch I sent earlier today. drivers/input/misc/ims-pcu.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH v2] ims-pcu: Add commands supported by the new version of the FW

2014-01-03 Thread Dmitry Torokhov
On Fri, Jan 03, 2014 at 08:24:17PM -0800, Andrey Smirnov wrote: > On Fri, Jan 3, 2014 at 5:39 PM, Dmitry Torokhov > wrote: > > Hi Andrey, > > > > On Wed, Jan 01, 2014 at 04:47:01PM -0800, Andrey Smirnov wrote: > >> New version of the PCU firmware supports two new commands: > >> - IMS_PCU_CMD_OFN

Re: [PATCH v2] ims-pcu: Add commands supported by the new version of the FW

2014-01-03 Thread Andrey Smirnov
On Fri, Jan 3, 2014 at 5:39 PM, Dmitry Torokhov wrote: > Hi Andrey, > > On Wed, Jan 01, 2014 at 04:47:01PM -0800, Andrey Smirnov wrote: >> New version of the PCU firmware supports two new commands: >> - IMS_PCU_CMD_OFN_SET_CONFIG which allows to write data to the >> registers of one finger nav

Re: [PATCH v2] ims-pcu: Add commands supported by the new version of the FW

2014-01-03 Thread Dmitry Torokhov
Hi Andrey, On Wed, Jan 01, 2014 at 04:47:01PM -0800, Andrey Smirnov wrote: > New version of the PCU firmware supports two new commands: > - IMS_PCU_CMD_OFN_SET_CONFIG which allows to write data to the > registers of one finger navigation(OFN) chip present on the device > - IMS_PCU_CMD_OFN_GE

Re: Another ALPS touchpad

2014-01-03 Thread Dmitry Torokhov
On Thursday, January 02, 2014 11:59:15 PM Dylan Paul Thurston wrote: > I just bought a HP Revolve 810 G1 laptop. (This is a convertible > ultrabook, normally sold with Windows 8.) The touchpad seems to be > another ALPS touchpad, not yet recognized by the kernel; I tried the > Debian package of 3.1

Re: [PATCH 1/4] input: Add new sun4i-lradc-keys drivers

2014-01-03 Thread Dmitry Torokhov
On Fri, Jan 03, 2014 at 06:36:05PM +0100, Maxime Ripard wrote: > On Thu, Jan 02, 2014 at 11:36:33PM +0100, Hans de Goede wrote: > > Hi, > > > > On 01/02/2014 09:20 PM, Maxime Ripard wrote: > > >On Thu, Jan 02, 2014 at 02:45:29PM +0100, Hans de Goede wrote: > > >>>Also, instead of inventing yet ano

[PATCH 1/2] HID: sony: Add force feedback for the Dualshock 4

2014-01-03 Thread Frank Praznik
This patch adds force feedback support for Sony's Dualshock 4 controller. It does this by adding a device ID for the new controller and creating a new dualshock4_worker function to send data commands formatted for the controller. Unlike the Sixaxis, the Dualshock 4 requires a magnitude value

[PATCH 2/2] HID: sony: Add LED controls for Dualshock 4

2014-01-03 Thread Frank Praznik
This patch builds on the previous patch and adds controls for the light bar on the Dualshock 4. The light bar contains a red, green and blue LED that can independently vary in brightness from 0 to 255. The LED system in the module had to be extended to support a full byte per led for storing

Re: [PATCH 1/4] input: Add new sun4i-lradc-keys drivers

2014-01-03 Thread Maxime Ripard
On Thu, Jan 02, 2014 at 11:36:33PM +0100, Hans de Goede wrote: > Hi, > > On 01/02/2014 09:20 PM, Maxime Ripard wrote: > >On Thu, Jan 02, 2014 at 02:45:29PM +0100, Hans de Goede wrote: > >>>Also, instead of inventing yet another vendor-specific property, why not > >>>re-use > >>>a button binding s

Re: [PATCH 1/4] input: Add new sun4i-lradc-keys drivers

2014-01-03 Thread Maxime Ripard
On Thu, Jan 02, 2014 at 12:38:31PM -0800, Dmitry Torokhov wrote: > On Thu, Jan 02, 2014 at 09:20:22PM +0100, Maxime Ripard wrote: > > On Thu, Jan 02, 2014 at 02:45:29PM +0100, Hans de Goede wrote: > > > >Also, instead of inventing yet another vendor-specific property, why not > > > >re-use > > > >

Re: [patch 3/3] HID: multitouch: add support of other generic collections in hid-mt

2014-01-03 Thread Jiri Kosina
On Sat, 21 Dec 2013, Henrik Rydberg wrote: > > The ANTEC Touch Pad is a device which can switch from a multitouch > > touchpad to a mouse. It thus presents several generic collections which > > are currently ignored by hid-multitouch. Enable them by using the generic > > protocol. Adding also a su