In some report descriptors, they leave holes in the selectors. In
this case if we use hardcoded selector values, this will result
in invalid values. For example, if there is selectors defined for
Power State from OFF to D0 to D3. We can't use indexes of these states
if some states are not implement
Remove the hard coded indexes, instead search for usage id and
use the index to set the power and report state.
This will fix issue, where the report descriptor doesn't contain
the full list of possible selector for power and report state.
Signed-off-by: Srinivas Pandruvada
---
.../iio/common/hi
On Fri, Jan 24, 2014 at 01:00:08AM +0100, Courtney Cavin wrote:
> This is an attempt to get this driver closer to being in an upstream-able
> form.
> In the process, this drops legacy callback methods for managing power and GPIO
> configuration, in favor of the already existing frameworks. Most o
Cc: Christopher Heiny
Cc: Dmitry Torokhov
Signed-off-by: Courtney Cavin
---
drivers/input/rmi4/rmi_driver.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c
index 52345ae..9d8d6ec 100644
--- a/drivers/input/rmi4/rmi_driver.c
Cc: Christopher Heiny
Cc: Dmitry Torokhov
Signed-off-by: Courtney Cavin
---
drivers/input/rmi4/rmi_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c
index 9d8d6ec..9d845a4 100644
--- a/drivers/input/rmi
Since at the point of I2C probe, we cannot know if the voltage
regulators are on, wait until the physical driver requests a read before
setting the page.
Cc: Christopher Heiny
Cc: Dmitry Torokhov
Signed-off-by: Courtney Cavin
---
drivers/input/rmi4/rmi_i2c.c | 11 ++-
1 file changed, 2
Cc: Christopher Heiny
Cc: Dmitry Torokhov
Signed-off-by: Courtney Cavin
---
drivers/input/rmi4/rmi_f01.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/input/rmi4/rmi_f01.c b/drivers/input/rmi4/rmi_f01.c
index 22b57f2..06fc5bc 100644
--- a/drivers/i
Add support for VDD and VIO power supplies. Since we may need a delay
after turning on the chip, adjust code to manage that. This removes the
scanning for active interrupts on resume, as we should get an interrupt
when the chip is ready.
Cc: Christopher Heiny
Cc: Dmitry Torokhov
Signed-off-by:
Cc: Christopher Heiny
Cc: Dmitry Torokhov
Signed-off-by: Courtney Cavin
---
Documentation/devicetree/bindings/input/rmi4.txt | 107 +
.../devicetree/bindings/vendor-prefixes.txt| 1 +
drivers/input/rmi4/rmi_bus.c | 12 +-
drivers/input/rmi4/rmi
This is neither a library nor documentation, so it doesn't need to
contain all of the information available. Remove most of the unused
struct members and defines. If they are need to implement some
functionality at a later point, they can be added back at that point.
Cc: Christopher Heiny
Cc: D
As most of this code was already removed, the remainder does nothing.
Remove it.
Cc: Christopher Heiny
Cc: Dmitry Torokhov
Signed-off-by: Courtney Cavin
---
drivers/input/rmi4/Kconfig | 1 -
drivers/input/rmi4/rmi_bus.c| 103
drivers/input/rm
Update platform data documentation and remove unneeded/unused stuff in
platform data.
If these items are needed at some later point, they should be added
then. Until that point, we should unclutter the code.
Cc: Christopher Heiny
Cc: Dmitry Torokhov
Signed-off-by: Courtney Cavin
---
drivers/
These are unnecessary and ugly. Remove them, and all related code.
Cc: Christopher Heiny
Cc: Dmitry Torokhov
Signed-off-by: Courtney Cavin
---
drivers/input/rmi4/rmi_driver.c | 57 ++---
drivers/input/rmi4/rmi_driver.h | 10
include/linux/rmi.h
The driver/device already has a name, no need for another one.
Cc: Christopher Heiny
Cc: Dmitry Torokhov
Signed-off-by: Courtney Cavin
---
drivers/input/rmi4/rmi_bus.c| 4 ++--
drivers/input/rmi4/rmi_driver.c | 7 ++-
drivers/input/rmi4/rmi_f11.c| 3 +--
drivers/input/rmi4/rmi_i2c.
Since all the configuration needed for an irq can be provided in other
ways, remove all gpio->irq functionality. This cleans up the code quite
a bit.
This also gets rid of polling functionality, as this should be done
elsewhere if absolutely needed.
Cc: Christopher Heiny
Cc: Dmitry Torokhov
Sig
Devices use a kobject to manage references, do not delete the memory
while still referenced. Instead, call put_device() to release the
reference.
Cc: Christopher Heiny
Cc: Dmitry Torokhov
Signed-off-by: Courtney Cavin
---
drivers/input/rmi4/rmi_bus.c| 8 +---
drivers/input/rmi4/rmi_dr
Cc: Christopher Heiny
Cc: Dmitry Torokhov
Signed-off-by: Courtney Cavin
---
drivers/input/rmi4/rmi_bus.c| 4 ++--
drivers/input/rmi4/rmi_bus.h| 2 +-
drivers/input/rmi4/rmi_driver.c | 17 -
drivers/input/rmi4/rmi_f11.c| 4 +++-
4 files changed, 18 insertions(+), 9
Cc: Christopher Heiny
Cc: Dmitry Torokhov
Signed-off-by: Courtney Cavin
---
drivers/input/rmi4/rmi_f01.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/rmi4/rmi_f01.c b/drivers/input/rmi4/rmi_f01.c
index cf1081f..98bc65a9 100644
--- a/drivers/input/rmi4/rmi_f0
This is an attempt to get this driver closer to being in an upstream-able form.
In the process, this drops legacy callback methods for managing power and GPIO
configuration, in favor of the already existing frameworks. Most of this
series is cleanup, but there are a few intermixed bug fixes to mak
This is a Win7 device which does not work correctly with the default
settings (not the previous default BT).
However, the quirk ALWAYS_TRUE makes it working like a charm.
Signed-off-by: Benjamin Tissoires
---
Hi Jiri,
well, it's been a long time since I did not add those kind of small patches.
> > Patch looks good to me. Is there any reason why we should rush this in
> > for v3.14, or is it okay to go to -next?
>
> No rush, but it's been on review like forever so unless there is
> some noise from the DT people at -rc1 I'd be very happy if you
> could apply patches 1 & 2 by then.
I'm ju
On Thu, Jan 23, 2014 at 2:31 PM, Lee Jones wrote:
> Patch looks good to me. Is there any reason why we should rush this in
> for v3.14, or is it okay to go to -next?
No rush, but it's been on review like forever so unless there is
some noise from the DT people at -rc1 I'd be very happy if you
co
Hi Dmitry
ping?
David
On Mon, Dec 16, 2013 at 4:23 PM, David Herrmann wrote:
> We must not reassign those axes or we will break backwards-compat. Add a
> small note for that so we don't accidentally some day reuse these.
>
> Signed-off-by: David Herrmann
> ---
> include/uapi/linux/input.h | 4
Hi Benjamin
On Wed, Jan 22, 2014 at 6:24 PM, Benjamin Tissoires
wrote:
> uinput is used in the xorg-integration-tests suite and in the wayland
> test suite. These automated tests suites create many virtual input
> devices and then hook something to read these newly created devices.
>
> Currently,
Hi Benjamin
On Wed, Jan 22, 2014 at 6:23 PM, Benjamin Tissoires
wrote:
> From: Benjamin Tisssoires
>
> The current implementation prevents us to add variable-length ioctl.
> Use a bunch of gotos instead of break to allow us to do so.
>
> No functional changes.
Looks good.
Reviewed-by: David He
> This changes the following mechanisms in the TC3589x device tree
> probing path:
>
> - Use the .of_match_table in struct device_driver to match the
> device in the device tree.
> - Add matches for the proper compatible strings "toshiba,..."
> and all sub-variants, just as is done for the .id
This changes the following mechanisms in the TC3589x device tree
probing path:
- Use the .of_match_table in struct device_driver to match the
device in the device tree.
- Add matches for the proper compatible strings "toshiba,..."
and all sub-variants, just as is done for the .id matches.
- Mo
Implement device tree probing for the tc3589x keypad driver.
This is modeled on the STMPE keypad driver and tested on the
Ux500 TVK1281618 UIB.
Signed-off-by: Linus Walleij
---
ChangeLog v2->v3:
- Use two local u32 variables to avoid weirdness in u8 casting
of the resulting values to the pointe
This defines the device tree bindings for the Toshiba TC3589x
series of multi-purpose expanders. Only the stuff I can test
is defined: GPIO and keypad. Others may implement more
subdevices further down the road.
This is to complement
commit a435ae1d51e2f18414f2a87219fdbe068231e692
"mfd: Enable the
29 matches
Mail list logo