Re: [PATCH] Input: i8042-io - Exclude mips platforms when allocating/deallocating IO regions.

2014-01-26 Thread Dmitry Torokhov
On Mon, Jan 27, 2014 at 12:32:36AM +, Raghu Gandham wrote: > Hi Dmitry, > > > > > On Sat, Jan 25, 2014 at 11:01:54AM -0800, Raghu Gandham wrote: > > > The standard IO regions are already reserved by the platform code on > > > most MIPS devices(malta, cobalt, sni). The Commit > > > 197a1e96c8

Re: [PATCH] USB: input: gtco.c: fix usb_dev leak

2014-01-26 Thread Dmitry Torokhov
Hi Alexey, On Mon, Jan 27, 2014 at 10:31:36AM +0400, Alexey Khoroshilov wrote: > On 21.01.2014 23:59, Dmitry Torokhov wrote: > > On Sun, Jan 19, 2014 at 03:24:26AM +0400, Alexey Khoroshilov wrote: > >> There is usb_get_dev() in gtco_probe(), but there is no usb_put_dev() > >> anywhere in the drive

Re: [PATCH] input: synaptics-rmi4 - Count IRQs before creating functions; save F01 container.

2014-01-26 Thread Dmitry Torokhov
Hi Christopher, On Fri, Jan 10, 2014 at 01:53:34PM -0800, Christopher Heiny wrote: > > err_free_data: > + rmi_free_function_list(rmi_dev); > + if (gpio_is_valid(pdata->attn_gpio)) > + gpio_free(pdata->attn_gpio); > + devm_kfree(&rmi_dev->dev, data->irq_status); > +

Re: [PATCH] USB: input: gtco.c: fix usb_dev leak

2014-01-26 Thread Alexey Khoroshilov
On 21.01.2014 23:59, Dmitry Torokhov wrote: > On Sun, Jan 19, 2014 at 03:24:26AM +0400, Alexey Khoroshilov wrote: >> There is usb_get_dev() in gtco_probe(), but there is no usb_put_dev() >> anywhere in the driver. >> >> The patch adds usb_get_dev() to failure handling code of gtco_probe() >> and to

Re: [PATCH v2] input synaptics-rmi4: PDT scan cleanup

2014-01-26 Thread Dmitry Torokhov
Hi Christopher, On Wed, Jan 22, 2014 at 04:56:09PM -0800, Christopher Heiny wrote: > Eliminates copy-paste code that handled scans of the Page Descriptor > Table, replacing it with a single PDT scan routine that invokes a > callback function. The scan routine is not static so that it can be > us

[PATCH] input: pxa27x-keypad: bug fix of getting scan code

2014-01-26 Thread Chao Xie
From: Chao Xie The rows of pxa27x-keypad used by each boards are not fixed. So in the driver, it will get the rows from DT and register the keymap as: matrix_keypad_build_keymap(keymap_data, NULL, pdata->matrix_key_rows, pdata->matrix_key_cols

RE: [PATCH] Input: i8042-io - Exclude mips platforms when allocating/deallocating IO regions.

2014-01-26 Thread Raghu Gandham
Hi Dmitry, > > On Sat, Jan 25, 2014 at 11:01:54AM -0800, Raghu Gandham wrote: > > The standard IO regions are already reserved by the platform code on > > most MIPS devices(malta, cobalt, sni). The Commit > > 197a1e96c8be5b6005145af3a4c0e45e2d651444 > > ("Input: i8042-io - fix up region handling

[PATCH] Input: xpad - do not map the DPAD to buttons with xbox 360 wireless controllers

2014-01-26 Thread Petr Ĺ ebor
Having the DPAD mapped to buttons makes the wireless gamepad behave differently from the wired counterpart. Given the MAP_DPAD_TO_BUTTONS flag is typically used for dance pads, this was probably added by a mistake. Not specifying the flag makes the controller's hat switch behave as expected. Sign

Re: [PATCH] Input: i8042-io - Exclude mips platforms when allocating/deallocating IO regions.

2014-01-26 Thread Dmitry Torokhov
Hi Raghu, On Sat, Jan 25, 2014 at 11:01:54AM -0800, Raghu Gandham wrote: > The standard IO regions are already reserved by the platform code on most MIPS > devices(malta, cobalt, sni). The Commit > 197a1e96c8be5b6005145af3a4c0e45e2d651444 > ("Input: i8042-io - fix up region handling on MIPS") int

[RFC][PATCH] Input: i8042 - fix PNP modaliases when both aux and kdb are enabled

2014-01-26 Thread Tom Gundersen
Commit 78551277e4 exposed the PNP modaliases for the i8042 module. However, the aux entries overrode the kbd ones. Refactor the device_id lists to expose both the aux and the kbd modaliases. Cc: Dmitry Torokhov Signed-off-by: Tom Gundersen --- Hi Dmitry, I don't know if there is a better way t