Hi Heiko,
On Thu, Jan 09, 2014 at 10:19:15PM +0100, Heiko Stübner wrote:
> This adds the binding documentation and necessary parsing code to make
> zforce based touchscreen usable on devicetree platforms.
>
> Heiko Stuebner (3):
> dt-bindings: bindings for zforce touchscreens
> Input: zforce:
On Mon, Jan 27, 2014 at 07:46:09PM +0100, Luis Ortega wrote:
> As a kernel newbie and owner of a Barnes & Noble e-reader I was
> curious to review this driver to learn more about the touchscreen.
>
> The first two patches are fairly innocuous whereas the last two
> slightly modify the code to fix
Hi Aaro,
>
> On Sun, Jan 26, 2014 at 10:56:38PM -0800, Dmitry Torokhov wrote:
> > On Mon, Jan 27, 2014 at 12:32:36AM +, Raghu Gandham wrote:
> > > > On Sat, Jan 25, 2014 at 11:01:54AM -0800, Raghu Gandham wrote:
> > > > > The standard IO regions are already reserved by the platform
> > > > >
On Tue, Jan 14, 2014 at 5:13 AM, Mika Westerberg
wrote:
> This patch adds runtime PM support for the HID over I2C driver. When the
> i2c-hid device is first opened we power it on and on the last close we
> power it off.
>
> The implementation is not the most power efficient because it needs some
>
Hi,
On Mon, Jan 27, 2014 at 6:02 PM, Yufeng Shen wrote:
> There is timeout error during initialization:
> kernel: [ 11.733104] hid-multitouch 0003:1870:0110.0001:
> usb_submit_urb(ctrl) failed: -1
> kernel: [ 11.734093] hid-multitouch 0003:1870:0110.0001: timeout
> initializing reports
>
>
On 01/26/2014 10:30 PM, Dmitry Torokhov wrote:> Hi Christopher,
Hi Dmitry,
Sorry if this reply is oddly formatted - I'm having some trouble with my
Thunderbird settings today.
>
> On Wed, Jan 22, 2014 at 04:56:09PM -0800, Christopher Heiny wrote:
>> Eliminates copy-paste code that handled sca
Tom Gundersen writes:
> Commit 78551277e4df5: "Input: i8042 - add PNP modaliases" had a bug, where the
> second call to MODULE_DEVICE_TABLE() overrode the first resulting in not all
> the modaliases being exposed.
No Signed-off-by?
Thanks,
Rusty.
>
> This fixes the problem by including the name
Greg Kroah-Hartman writes:
> On Mon, Jan 27, 2014 at 08:09:55PM +0100, Tom Gundersen wrote:
>> Commit 78551277e4df5: "Input: i8042 - add PNP modaliases" had a bug, where
>> the
>> second call to MODULE_DEVICE_TABLE() overrode the first resulting in not all
>> the modaliases being exposed.
>>
>>
There is timeout error during initialization:
kernel: [ 11.733104] hid-multitouch 0003:1870:0110.0001: usb_submit_urb(ctrl)
failed: -1
kernel: [ 11.734093] hid-multitouch 0003:1870:0110.0001: timeout initializing
reports
Adding quirk HID_QUIRK_NO_INIT_REPORTS can solve the problem.
Signed-o
Having the DPAD mapped to buttons makes the wireless gamepad behave
differently from the wired counterpart. Given the MAP_DPAD_TO_BUTTONS
flag is typically used for dance pads, this was probably added by
a mistake. Not specifying the flag makes the controller's hat switch
behave as expected.
Signe
On 1/27/2014 12:47, si...@mungewell.org wrote:
+
+ /* The Dualshock 4 multi-touch trackpad data starts at offset 35 on USB.
+* The first 7 bits of the first byte is a counter and bit 8 is a touch
+* indicator that is 0 when pressed and 1 when not pressed.
+* The next
On 1/27/2014 15:40, si...@mungewell.org wrote:
+ for (n = 0; n < 2; n++) {
+ __u16 x, y;
+
+ x = rd[offset+1] | ((rd[offset+2] & 0xF) << 8);
+ y = ((rd[offset+2] & 0xF0) >> 4) | (rd[offset+3] << 4);
+
+ input_mt_slot(input_dev, n);
+
> + for (n = 0; n < 2; n++) {
> + __u16 x, y;
> +
> + x = rd[offset+1] | ((rd[offset+2] & 0xF) << 8);
> + y = ((rd[offset+2] & 0xF0) >> 4) | (rd[offset+3] << 4);
> +
> + input_mt_slot(input_dev, n);
> + input_mt_report_slot_state(inpu
On Mon, Jan 27, 2014 at 11:54:22AM -0800, Greg Kroah-Hartman wrote:
> On Mon, Jan 27, 2014 at 08:09:55PM +0100, Tom Gundersen wrote:
> > Commit 78551277e4df5: "Input: i8042 - add PNP modaliases" had a bug, where
> > the
> > second call to MODULE_DEVICE_TABLE() overrode the first resulting in not a
Hi,
On Sun, Jan 26, 2014 at 10:56:38PM -0800, Dmitry Torokhov wrote:
> On Mon, Jan 27, 2014 at 12:32:36AM +, Raghu Gandham wrote:
> > > On Sat, Jan 25, 2014 at 11:01:54AM -0800, Raghu Gandham wrote:
> > > > The standard IO regions are already reserved by the platform code on
> > > > most MIPS
On Tue, Jan 28, 2014 at 12:10:54AM +0400, Alexey Khoroshilov wrote:
> There is usb_get_dev() in gtco_probe(), but there is no usb_put_dev()
> anywhere in the driver.
>
> As pointed out by Dmitry Torokhov:
> The lifetime of gtco structure is already directly tied to lifetime of
> usb_dev: when dest
On Monday, 27. January 2014 19:46:13 Luis Ortega wrote:
> A frame is a u8 array with the following structure:
> [PAYLOAD_HEADER, PAYLOAD_LENGTH, ...PAYLOAD_BODY...]
>
> PAYLOAD_BODY can be at most 255 bytes long, as it's size is represented
> by PAYLOAD_LENGTH. Therefore we can reduce the stack me
On Monday, 27. January 2014 19:46:12 Luis Ortega wrote:
> The function zforce_read_packet() reads 2 values (bytes) of payload
> header, validates them and then proceeds to read the payload body.
> The function stores all these in a u8 buffer.
>
> The PAYLOAD_LENGTH check seems to be trying to dete
There is usb_get_dev() in gtco_probe(), but there is no usb_put_dev()
anywhere in the driver.
As pointed out by Dmitry Torokhov:
The lifetime of gtco structure is already directly tied to lifetime of
usb_dev: when destroying usb_dev driver core will call remove() function
of currently bound driver
On Mon, Jan 27, 2014 at 08:09:55PM +0100, Tom Gundersen wrote:
> Commit 78551277e4df5: "Input: i8042 - add PNP modaliases" had a bug, where the
> second call to MODULE_DEVICE_TABLE() overrode the first resulting in not all
> the modaliases being exposed.
>
> This fixes the problem by including the
Hi.
I'm making some enhancements to hid/usbhid/hid-pidff.c to support more
force feedback devices, but I've encountered some weird behaviour. I'm
not sure whether it's a bug or something else.
My changes depend on knowing some device information (like memory) in
the initialization phase, and luck
Yeah, I also ran checkpatch on the file and it had nothing to report.
Unfortunately those lines are slightly long and got word wrapped in my
editor, disrupting the flow of text. I thought fixing them wouldn't hurt.
On Mon, Jan 27, 2014 at 8:12 PM, Heiko Stübner wrote:
> On Monday, 27. January 201
On Monday, 27. January 2014 19:46:11 Luis Ortega wrote:
> Fixed lines exceeding 80 characters long wherever possible,
> as per the coding style.
>
> Signed-off-by: Luis Ortega
checkpatch did not complain on the initial submission, so I guess it's more an
issue of taste. Nevertheless I don't hav
Commit 78551277e4df5: "Input: i8042 - add PNP modaliases" had a bug, where the
second call to MODULE_DEVICE_TABLE() overrode the first resulting in not all
the modaliases being exposed.
This fixes the problem by including the name of the device_id table in the
__mod_*_device_table alias, allowing
On Monday, 27. January 2014 19:46:10 Luis Ortega wrote:
> Fixed a few spelling errors.
>
> Signed-off-by: Luis Ortega
Acked-by: Heiko Stuebner
> ---
> drivers/input/touchscreen/zforce_ts.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/input/touch
As a kernel newbie and owner of a Barnes & Noble e-reader I was
curious to review this driver to learn more about the touchscreen.
The first two patches are fairly innocuous whereas the last two
slightly modify the code to fix two small issues I discovered.
I don't have the setup to test them but
> +
> + /* The Dualshock 4 multi-touch trackpad data starts at offset 35 on USB.
> + * The first 7 bits of the first byte is a counter and bit 8 is a touch
> + * indicator that is 0 when pressed and 1 when not pressed.
> + * The next 3 bytes are two 12 bit touch coordinates, X a
Fixed a few spelling errors.
Signed-off-by: Luis Ortega
---
drivers/input/touchscreen/zforce_ts.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/input/touchscreen/zforce_ts.c
b/drivers/input/touchscreen/zforce_ts.c
index 2175f34..c145c1d 100644
--- a/driv
Fixed lines exceeding 80 characters long wherever possible,
as per the coding style.
Signed-off-by: Luis Ortega
---
drivers/input/touchscreen/zforce_ts.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/input/touchscreen/zforce_ts.c
b/drivers/inpu
A frame is a u8 array with the following structure:
[PAYLOAD_HEADER, PAYLOAD_LENGTH, ...PAYLOAD_BODY...]
PAYLOAD_BODY can be at most 255 bytes long, as it's size is represented
by PAYLOAD_LENGTH. Therefore we can reduce the stack memory allocated to
payload_buffer[] roughly by half, from 512 to 25
The function zforce_read_packet() reads 2 values (bytes) of payload
header, validates them and then proceeds to read the payload body.
The function stores all these in a u8 buffer.
The PAYLOAD_LENGTH check seems to be trying to detect an overflow error.
However, since we are just reading a u8 valu
Hi,
I've reported the problem I'm having in more detail here:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1258837
In summary - I keep suffering from the mouse pointer jumping around
erratically, with the following messages output to syslog:
psmouse serio1: DualPoint TouchPad at isa0060/
Add output events for the multi-touch pad on the Dualshock 4.
The touchpad has a resolution of 1920x940 and is capable of 2 simultaneous
touches. A 'Type B' stateful slot protocol is implemented as defined in
Documentation/input/multi-touch-protocol.txt
Applications can use the touchpad data by p
Add battery status reporting for the Sixaxis and Dualshock 4 controllers.
Signed-off-by: Frank Praznik
---
v2 of the patch fixes a small logic error where the battery_charging flag was
flipped on the Sixaxis.
The line: battery_charging = rd[30] & 0x01;
should be: battery_charging = !(rd[3
On Sun, Jan 26, 2014 at 10:00 PM, Tom Gundersen wrote:
> Commit 78551277e4 exposed the PNP modaliases for the i8042 module. However,
> the aux entries overrode the kbd ones.
>
> Refactor the device_id lists to expose both the aux and the kbd modaliases.
>
> Cc: Dmitry Torokhov
> Signed-off-by: To
On Mon, Jan 27, 2014 at 02:29:23PM +0400, Alexey Khoroshilov wrote:
> On 27.01.2014 10:54, Dmitry Torokhov wrote:
> > Hi Alexey,
> >
> > On Mon, Jan 27, 2014 at 10:31:36AM +0400, Alexey Khoroshilov wrote:
> >> On 21.01.2014 23:59, Dmitry Torokhov wrote:
> >>> On Sun, Jan 19, 2014 at 03:24:26AM +040
On 27.01.2014 10:54, Dmitry Torokhov wrote:
> Hi Alexey,
>
> On Mon, Jan 27, 2014 at 10:31:36AM +0400, Alexey Khoroshilov wrote:
>> On 21.01.2014 23:59, Dmitry Torokhov wrote:
>>> On Sun, Jan 19, 2014 at 03:24:26AM +0400, Alexey Khoroshilov wrote:
There is usb_get_dev() in gtco_probe(), but th
37 matches
Mail list logo
