Re: [patch] Input: remove a duplicative NULL test

2014-03-12 Thread Benson Leung
On Fri, Feb 21, 2014 at 1:14 AM, fugang.d...@freescale.com wrote: > > Agree, it is redundant. And if you have free time, you can convert the driver > to support devicetree. Please check with Nick Dyer before you convert this driver to support devicetree. Much of the platform data this driver use

Re: [PATCH v2 2/3] mfd: max8997: handle IRQs using regmap

2014-03-12 Thread Chanwoo Choi
Hi Robert, On 03/12/2014 10:37 PM, Robert Baldyga wrote: > This patch modifies mfd driver to use regmap for handling interrupts. > It allows to simplify irq handling process. This modifications needed > to make small changes in function drivers, which use interrupts. > > Signed-off-by: Robert Bal

[PATCH v2 03/06] input synaptics-rmi4: rmi_f01 - Fix a comment, add a diagnostic message.

2014-03-12 Thread Christopher Heiny
In debugging certain touch sensor failures, it's useful to know whether the device is stuck in bootloader, so print a message to that effect. Also, point to the actual location of the defs for the F01 CTRL0 bitfields. Signed-off-by: Christopher Heiny Cc: Dmitry Torokhov Cc: Benjamin Tissoires

[PATCH v2 05/06] input synaptics-rmi4: Add firmware update support

2014-03-12 Thread Christopher Heiny
Add support for updating firmware on RMI4 devices with V5 bootloader. Signed-off-by: Christopher Heiny Signed-off-by: Vincent Huang Cc: Dmitry Torokhov Cc: Benjamin Tissoires Cc: Linux Walleij Cc: David Herrmann Cc: Jiri Kosina --- The next patch in this series converts this code to use

[PATCH v2 02/06] input synaptics-rmi4: Add some more F01 properties

2014-03-12 Thread Christopher Heiny
The firmware update code will need access to the firmware build ID and some other info. As long as we're taking the scenic route to the firmware build ID, we remember a number of other interesting settings for use by diagnostic modules. Signed-off-by: Christopher Heiny Cc: Dmitry Torokhov Cc: B

[PATCH v2 06/06] input synaptics-rmi4: Use request_firmware_nowait

2014-03-12 Thread Christopher Heiny
Replace request_firmware() and our own work_queue entry, and use request_firmware_nowait() instead. Suggested-by: Courtney Cavin Signed-off-by: Christopher Heiny Signed-off-by: Vincent Huang Cc: Dmitry Torokhov Cc: Benjamin Tissoires Cc: Linux Walleij Cc: David Herrmann Cc: Jiri Kosina --

[PATCH v2 04/06] input synaptics-rmi4: rmi_driver - Export some symbols and functions

2014-03-12 Thread Christopher Heiny
Firmware update functionality will need to unload the existing functions and rescan the PDT before starting the update process; then reload the functions afterwards. Signed-off-by: Christopher Heiny Signed-off-by: Vincent Huang Cc: Dmitry Torokhov Cc: Benjamin Tissoires Cc: Linux Walleij Cc:

[PATCH v2 01/06] input synaptics-rmi4: Split F01 definitions into header file

2014-03-12 Thread Christopher Heiny
Creates rmi_f01.h for use by the firmware update code. Signed-off-by: Christopher Heiny Cc: Dmitry Torokhov Cc: Benjamin Tissoires Cc: Linux Walleij Cc: David Herrmann Cc: Jiri Kosina --- drivers/input/rmi4/rmi_f01.c | 96 ++--- drivers/input/rmi4/rmi_f01.

[PATCH v4 2/3] input: appletouch: implement sensor data smoothing

2014-03-12 Thread Clinton Sprain
input: appletouch: implement sensor data smoothing Use smoothed version of sensor array data to calculate movement and add weight to prior values when calculating average. This gives more granular and more predictable movement. Signed-off-by: Clinton Sprain --- drivers/input/mouse/appletouch.c

[PATCH v4 3/3] input: appletouch: fix jumps when additional fingers are detected

2014-03-12 Thread Clinton Sprain
input: appletouch: fix jumps when additional fingers are detected Addresses issues related to when a second finger enters or leaves the field, causing the cursor to jump or the page to scroll unexpectedly; now, we discard any movement change that happens at the exact moment we detect a change in t

[PATCH v4 1/3] input: appletouch: dial back fuzz setting

2014-03-12 Thread Clinton Sprain
input: appletouch: dial back fuzz setting Dials back the default fuzz setting for most devices using this driver, based on values from user feedback from forums and bug reports. Signed-off-by: Clinton Sprain --- drivers/input/mouse/appletouch.c | 15 +-- 1 file changed, 9 insert

[PATCH v4 0/3] input: appletouch: fixes for jagged/uneven cursor movement

2014-03-12 Thread Clinton Sprain
input: appletouch: fixes for jagged/uneven cursor movement The appletouch driver can make some touchpads feel insensitive, with movement that tends to jerk in steps. This is particularly evident when moving diagonally. There is also undesirable movement when additional fingers enter or leave th

Re: [PATCH v2 3/3] mfd: max8997: move regmap handling to function drivers

2014-03-12 Thread Krzysztof Kozlowski
On Wed, 2014-03-12 at 14:37 +0100, Robert Baldyga wrote: > This patch moves code creating new i2c clients and regmaps to function > drivers which use them. It allows to avoid creating this instances when > individual function drivers are not enabled. > > Signed-off-by: Robert Baldyga > > Conflic

Re: [PATCH v2 2/3] mfd: max8997: handle IRQs using regmap

2014-03-12 Thread Krzysztof Kozlowski
On Wed, 2014-03-12 at 14:37 +0100, Robert Baldyga wrote: > This patch modifies mfd driver to use regmap for handling interrupts. > It allows to simplify irq handling process. This modifications needed > to make small changes in function drivers, which use interrupts. > > Signed-off-by: Robert Ba

Re: [PATCH v2 1/3] mfd: max8997: use regmap to access registers

2014-03-12 Thread Krzysztof Kozlowski
On Wed, 2014-03-12 at 14:37 +0100, Robert Baldyga wrote: > This patch modifies max8997 driver and each associated function driver, > to use regmap instead of operating directly on i2c bus. It will allow to > simplify IRQ handling using regmap-irq. > > Signed-off-by: Robert Baldyga > --- > driver

[PATCH v2 3/3] mfd: max8997: move regmap handling to function drivers

2014-03-12 Thread Robert Baldyga
This patch moves code creating new i2c clients and regmaps to function drivers which use them. It allows to avoid creating this instances when individual function drivers are not enabled. Signed-off-by: Robert Baldyga Conflicts: drivers/mfd/max8997.c --- drivers/extcon/extcon-max8997.c

[PATCH v2 2/3] mfd: max8997: handle IRQs using regmap

2014-03-12 Thread Robert Baldyga
This patch modifies mfd driver to use regmap for handling interrupts. It allows to simplify irq handling process. This modifications needed to make small changes in function drivers, which use interrupts. Signed-off-by: Robert Baldyga --- drivers/extcon/extcon-max8997.c | 35 ++-- drivers/

[PATCH v2 1/3] mfd: max8997: use regmap to access registers

2014-03-12 Thread Robert Baldyga
This patch modifies max8997 driver and each associated function driver, to use regmap instead of operating directly on i2c bus. It will allow to simplify IRQ handling using regmap-irq. Signed-off-by: Robert Baldyga --- drivers/extcon/extcon-max8997.c | 31 drivers/input/misc/max89

[PATCH v2 0/3] mfd: max8997: add regmap support

2014-03-12 Thread Robert Baldyga
Hi, This patchset modifies max8997 driver and associated function drivers to use register maps instead of operating directly on i2c bus. This change allowed to simplify irq handling, and to move some initializations to individual function drivers. Hence now when some functions are not enabled, the

Re: [PATCH] Input: fix dependencies of OLPC AP-SP driver

2014-03-12 Thread Jean Delvare
Hi Dmitry, On Tue, 11 Mar 2014 23:11:34 -0700, Dmitry Torokhov wrote: > On Tue, Mar 11, 2014 at 07:42:53PM +0100, Jean Delvare wrote: > > I don't think the OLPC AP-SP driver is generally useful without OLPC > > support. So make it depend on OLPC, unless build testing is enabled. > > > > Signed-of