Re: [linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC

2014-03-22 Thread Mark Brown
On Sat, Mar 22, 2014 at 08:08:03PM +0100, Carlo Caione wrote: > On Sat, Mar 22, 2014 at 11:42:01AM -0700, Dmitry Torokhov wrote: > > > drivers/mfd/axp20x.c:172:18: warning: assignment makes integer > > > frompointer without a cast [enabled by default] > > You need to cast to long, otherwise you w

Re: [linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC

2014-03-22 Thread Carlo Caione
On Sat, Mar 22, 2014 at 6:33 PM, Mark Brown wrote: > On Sat, Mar 22, 2014 at 05:51:32PM +0100, Carlo Caione wrote: >> On Tue, Mar 18, 2014 at 03:59:19PM +, Lee Jones wrote: > >> > > + of_id = of_match_device(axp20x_of_match, &i2c->dev); >> > > + if (!of_id) { >> > > + dev_err(&i2c->dev

Re: [linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC

2014-03-22 Thread Carlo Caione
On Sat, Mar 22, 2014 at 11:42:01AM -0700, Dmitry Torokhov wrote: > On Sat, Mar 22, 2014 at 07:13:36PM +0100, Carlo Caione wrote: > > On Sat, Mar 22, 2014 at 6:33 PM, Mark Brown wrote: > > > On Sat, Mar 22, 2014 at 05:51:32PM +0100, Carlo Caione wrote: > > >> On Tue, Mar 18, 2014 at 03:59:19PM +000

Re: [linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC

2014-03-22 Thread Dmitry Torokhov
On Sat, Mar 22, 2014 at 07:13:36PM +0100, Carlo Caione wrote: > On Sat, Mar 22, 2014 at 6:33 PM, Mark Brown wrote: > > On Sat, Mar 22, 2014 at 05:51:32PM +0100, Carlo Caione wrote: > >> On Tue, Mar 18, 2014 at 03:59:19PM +, Lee Jones wrote: > > > >> > > + of_id = of_match_device(axp20x_of_matc

Re: [linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC

2014-03-22 Thread Carlo Caione
On Sat, Mar 22, 2014 at 6:33 PM, Mark Brown wrote: > On Sat, Mar 22, 2014 at 05:51:32PM +0100, Carlo Caione wrote: >> On Tue, Mar 18, 2014 at 03:59:19PM +, Lee Jones wrote: > >> > > + of_id = of_match_device(axp20x_of_match, &i2c->dev); >> > > + if (!of_id) { >> > > + dev_err(&i2c->dev

Re: [linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC

2014-03-22 Thread Mark Brown
On Sat, Mar 22, 2014 at 05:51:32PM +0100, Carlo Caione wrote: > On Tue, Mar 18, 2014 at 03:59:19PM +, Lee Jones wrote: > > > + of_id = of_match_device(axp20x_of_match, &i2c->dev); > > > + if (!of_id) { > > > + dev_err(&i2c->dev, "Unable to setup AXP20X data\n"); > > > + return

Re: [linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC

2014-03-22 Thread Carlo Caione
On Tue, Mar 18, 2014 at 03:59:19PM +, Lee Jones wrote: > > +static struct mfd_cell axp20x_cells[] = { > > + { > > + .name = "axp20x-pek", > > + .num_resources = ARRAY_SIZE(axp20x_pek_resources), > > + .resources = axp20x_pek_resources, > > + },

Re: [linux-sunxi] Re: [PATCH v2 6/8] ARM: sunxi: dt: Add x-powers-axp209.dtsi file

2014-03-22 Thread Carlo Caione
On Tue, Mar 18, 2014 at 10:04:50AM +0100, Maxime Ripard wrote: > On Sat, Mar 15, 2014 at 04:43:43PM +0100, Carlo Caione wrote: > > This dtsi describes the axp209 PMIC, and is to be included from inside > > the i2c controller node to which the axp209 is connected. > > > > Signed-off-by: Hans de Goe

Re: [linux-sunxi] Re: [PATCH v2 2/8] mfd: AXP20x: Add bindings documentation

2014-03-22 Thread Carlo Caione
On Tue, Mar 18, 2014 at 09:45:05AM +0100, Maxime Ripard wrote: > On Sat, Mar 15, 2014 at 04:43:39PM +0100, Carlo Caione wrote: > > Bindings documentation for the AXP20x driver. In this file also two > > sub-nodes (PEK and regulators) are documented. > > PEK doesn't look to be documented, either in

Re: [PATCH v2 12/15] ARM: at91: remove atmel_tsadcc platform_data

2014-03-22 Thread Jonathan Cameron
On 17/03/14 13:57, Alexandre Belloni wrote: Signed-off-by: Alexandre Belloni See below. --- arch/arm/mach-at91/board.h | 3 --- include/linux/platform_data/atmel.h | 7 --- 2 files changed, 10 deletions(-) diff --git a/arch/arm/mach-at91/board.h b/arch/arm/mach-at91/board.h i

Re: [PATCH v2 08/15] ARM: at91: sam9rl: add at91_adc to support adc and touchscreen

2014-03-22 Thread Jonathan Cameron
On 17/03/14 13:57, Alexandre Belloni wrote: The ADC clock needs to be defined to enable the at91_adc driver. It is defined to the same speed that is used for atmel_tsadcc. Signed-off-by: Alexandre Belloni Looks good to me, but out of my area of expertise so I won't ack it. --- arch/arm/mach

Re: [PATCH v2 05/15] ARM: at91: sam9m10g45ek: Add touchscreen support through at91_adc

2014-03-22 Thread Jonathan Cameron
On 17/03/14 13:56, Alexandre Belloni wrote: at91_adc now supports reading a touchscreen for ADCs without a TSMR register. Enable touchscreen support through at91_adc. This allows to use both a touchscreen and the remaining ADC channel at the same time. Also, lower the clock for the ADC as it all

Re: [PATCH v2 06/15] iio: adc: at91: remove unused include from include/mach

2014-03-22 Thread Jonathan Cameron
On 17/03/14 13:56, Alexandre Belloni wrote: That include file is now only used by the at91_adc driver, remove it from include/mach for better driver separation. Signed-off-by: Alexandre Belloni Acked-by: Jonathan Cameron --- arch/arm/mach-at91/include/mach/at91_adc.h | 120

Re: [PATCH v2 07/15] iio: adc: at91: add sam9rl support

2014-03-22 Thread Jonathan Cameron
On 17/03/14 13:57, Alexandre Belloni wrote: Signed-off-by: Alexandre Belloni Acked-by: Jonathan Cameron --- drivers/iio/adc/at91_adc.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c index a51b8badbf8e..3b5bacd

Re: [PATCH v2 04/15] iio: adc: at91_adc: Add support for touchscreens without TSMR

2014-03-22 Thread Jonathan Cameron
On 17/03/14 13:56, Alexandre Belloni wrote: Old ADCs, as present on the sam9rl and the sam9g45 don't have a TSMR register and the touchscreen support should be handled differently. You cleared up my one query on this in response to the previous version. Signed-off-by: Alexandre Belloni Acked

Re: [PATCH 00/15] iio: adc: at91 cleanups and atmel_tsadcc removal

2014-03-22 Thread Jonathan Cameron
On 19/03/14 10:19, Nicolas Ferre wrote: On 16/03/2014 19:30, Jonathan Cameron : On 05/03/14 17:35, Alexandre Belloni wrote: This patch set is a followup of my previous series: iio: adc: at91 fixes I'm sorry it is so long, I made sure this is bissectable. It's a nice series, don't apologise fo

[PATCH] input: xpad - add queue for interrupt out transfers

2014-03-22 Thread Felix Rueegg
xpad_play_effect() directly calls usb_submit_urb() to send a force feedback command to the device. This causes the urb to fail with a warning (URB submitted while active) when xpad_play_effect() is called mutliple times in close succession. The issue also happens when a led command is sent at the s