Fwd: [PATCH 3/3] IO: hid-sensor-magn-3d: Add in support for True/Magnetic North HID usages

2014-05-28 Thread Reyad Attiyat
Forgot to forward to list -- Forwarded message -- From: Reyad Attiyat Date: Wed, May 28, 2014 at 4:57 PM Subject: Re: [PATCH 3/3] IO: hid-sensor-magn-3d: Add in support for True/Magnetic North HID usages To: Srinivas Pandruvada Hey Srinivas, > It shouldn't be an issue for few

Re: [PATCH 3/3] IO: hid-sensor-magn-3d: Add in support for True/Magnetic North HID usages

2014-05-28 Thread Srinivas Pandruvada
Hi Reyad, On 05/28/2014 02:35 PM, Reyad Attiyat wrote: Hey Srinivas, Well I could use sensor_hub_input_get_attribute_info() for each usage attribute. I was just thinking that since each usage attribute is found in a row, one for each field I think, it'd be easier to create iio channels that wa

Re: [PATCH 3/3] IO: hid-sensor-magn-3d: Add in support for True/Magnetic North HID usages

2014-05-28 Thread Reyad Attiyat
Hey Srinivas, Well I could use sensor_hub_input_get_attribute_info() for each usage attribute. I was just thinking that since each usage attribute is found in a row, one for each field I think, it'd be easier to create iio channels that way. This would eliminate running the for loop search for usa

Re: [PATCH 3/3] IO: hid-sensor-magn-3d: Add in support for True/Magnetic North HID usages

2014-05-28 Thread Srinivas Pandruvada
On 05/28/2014 02:15 PM, Reyad Attiyat wrote: +static void sensor_hub_fill_attr_info( + struct hid_sensor_hub_attribute_info *info, + s32 index, s32 report_id, struct hid_field *field) +{ + info->index = index; + info->report_id = report_id; + info->un

Re: [PATCH 3/3] IO: hid-sensor-magn-3d: Add in support for True/Magnetic North HID usages

2014-05-28 Thread Reyad Attiyat
> +static void sensor_hub_fill_attr_info( > + struct hid_sensor_hub_attribute_info *info, > + s32 index, s32 report_id, struct hid_field *field) > +{ > + info->index = index; > + info->report_id = report_id; > + info->units = field->unit; > + info

[PATCH 1/3] IIO: Add iio magn_north ABI documentation

2014-05-28 Thread Reyad Attiyat
Update documentation for HID compass true/magnetic north sensor. Signed-off-by: Reyad Attiyat --- Documentation/ABI/testing/sysfs-bus-iio | 76 + 1 file changed, 76 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sy

[PATCH 2/3] IIO: Add iio_chan modifier for True/Magnetic North HID usages

2014-05-28 Thread Reyad Attiyat
Updated iio_chan_info_enum for compass north sensor usages, including magnetic/true north and tilt compensation. Signed-off-by: Reyad Attiyat --- drivers/iio/industrialio-core.c | 4 include/linux/iio/types.h | 4 2 files changed, 8 insertions(+) diff --git a/drivers/iio/industr

[PATCH 3/3] IO: hid-sensor-magn-3d: Add in support for True/Magnetic North HID usages

2014-05-28 Thread Reyad Attiyat
Updated magn_3d_channel enum for all possible north channels Added functions to setup iio_chan_spec array depending on a hid usage report Renamed magn_val to iio_val to differentiate the index being used Updated magn_3d_state struct to hold pointer array (magn_val_addr[]) to iio_val and a count

[PATCH 0/3] IIO: hid-sensor-magn-3d: Add support for compass north usage attribute

2014-05-28 Thread Reyad Attiyat
Update hid-sensor-magn-3d to dynamically create IIO channels Update IIO to include modifiers for true/magnetic north and tilt compensation compass usages Signed-off-by: Reyad Attiyat Reyad Attiyat (3): IIO: Added iio magn_north ABI documentation IIO: Add iio_chan modifier for True/Magnetic

[PATCH] input: ab8500-ponkey: Allocate resources using managed interfaces

2014-05-28 Thread Himangi Saraogi
This patch moves most data allocated in the probe function from unmanaged interfaces to managed interfaces. The kfrees and error handling code is done away with. Also, the unnecesary labels are removed and the function ab8500_ponkey_remove is removed as it becomes empty after removing the no longer

[PATCH] Input: max8925_onkey :Allocate resources using managed interfaces

2014-05-28 Thread Himangi Saraogi
This patch moves most data allocated in the probe function from unmanaged interfaces to managed interfaces. The kfrees and error handling code is done away with. The unnecesary labels are removed and the function max8925_onkey_remove is removed as it becomes empty after removing the no longer requi

[PATCH] Input: 88pm860x-ts: Introduce the use of the managed version of kzalloc

2014-05-28 Thread Himangi Saraogi
This patch moves most data allocated in the probe function from unmanaged interfaces to managed interfaces. The kfrees and error handling code is done away with. Also, the unnecesary labels are removed and the function pm860x_touch_remove is removed as it becomes empty after removing the no longer

[PATCH] Input: 88pm860x_onkey : Introduce the use of the managed version of kzalloc

2014-05-28 Thread Himangi Saraogi
This patch moves most data allocated in the probe function from unmanaged interfaces to managed interfaces. The kfrees and error handling code is done away with. Also, the unnecesary labels are removed and the function pm860x_onkey_remove is removed as it becomes empty after removing the no longer

[PATCH] Input: touchscreen : Introduce the use of the managed version of kzalloc

2014-05-28 Thread Himangi Saraogi
This patch moves most data allocated in the probe function from unmanaged interfaces to managed interfaces. The kfrees and error handling code is done away with. Also, the unnecesary labels are removed and the function mrstouch_remove is removed as it becomes empty after removing the no longer requ

Re: [RESEND PATCH v4 1/2] Input: mcs_touchkey: use devm_* functions

2014-05-28 Thread Dmitry Torokhov
On Wed, May 28, 2014 at 06:13:15PM +0900, Beomho Seo wrote: > This patch use devm_* funtions in mcs_touchkey driver. > As a result, error path and remove() funtion is simplified. > > Signed-off-by: Beomho Seo > --- > Changes in v4: > - free_irq are back again for equivalent transformation. > Chan

Re: [PATCH 1/1] Input: soc_button_array - Remove duplicate inclusion of input.h

2014-05-28 Thread Dmitry Torokhov
On Wed, May 28, 2014 at 05:14:19PM +0530, Sachin Kamat wrote: > input.h was included twice. > > Signed-off-by: Sachin Kamat Applied, thank you. > --- > drivers/input/misc/soc_button_array.c |1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/input/misc/soc_button_array.c > b/d

Re: [PATCH] HID: hid-sensor-hub: Set report quirk for Microsoft Surface

2014-05-28 Thread Jiri Kosina
On Wed, 28 May 2014, Benjamin Tissoires wrote: > I guess this should be fine: > f3b0cbce01 has no more impact (there is no USB_DEVICE_ID_MS_*_2 > anymore) > > e24d0d399b2f will properly add the HID_GROUP_SENSOR_HUB to the sensors > if the report descriptor is properly set. > > Given that the gro

Re: [PATCH] HID: hid-sensor-hub: Set report quirk for Microsoft Surface

2014-05-28 Thread Benjamin Tissoires
On May 28 2014 or thereabouts, Jiri Kosina wrote: > On Tue, 27 May 2014, Reyad Attiyat wrote: > > > Add the Microsoft Surface Pro 2 Type/Touch and default device hardware ID's > > Set report quirk for the device in hid-sensor-hub > > > > Signed-off-by: Reyad Attiyat > > --- > > drivers/hid/hid-

Re: [PATCHv2] HID: Debug: Add labels for HID Sensor Usages

2014-05-28 Thread Jiri Kosina
On Tue, 27 May 2014, Reyad Attiyat wrote: > Add in debugfs report descriptor labels for HID Sensor Usages. Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [PATCH] HID: hid-sensor-hub: Set report quirk for Microsoft Surface

2014-05-28 Thread Jiri Kosina
On Tue, 27 May 2014, Reyad Attiyat wrote: > Add the Microsoft Surface Pro 2 Type/Touch and default device hardware ID's > Set report quirk for the device in hid-sensor-hub > > Signed-off-by: Reyad Attiyat > --- > drivers/hid/hid-ids.h| 3 +++ > drivers/hid/hid-sensor-hub.c | 9 +

[PATCH 1/1] Input: soc_button_array - Remove duplicate inclusion of input.h

2014-05-28 Thread Sachin Kamat
input.h was included twice. Signed-off-by: Sachin Kamat --- drivers/input/misc/soc_button_array.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c index 20c80f543d5e..5a6334be30b8 100644 --- a/drivers/input/misc/

[RESEND PATCH v4 2/2] Input: mcs5000_ts: use devm_* functions

2014-05-28 Thread Beomho Seo
This patch use devm_* functions in mcs5000_ts driver. As, a result, error patch and remove() function is simplified. Signed-off-by: Beomho Seo --- Changes in v4: - None. Changes in v3: - None. Changes in v2: - Additionally use devm_kzalloc for mcs_ts_data struct. --- drivers/input/touchscreen/mc

[RESEND PATCH v4 1/2] Input: mcs_touchkey: use devm_* functions

2014-05-28 Thread Beomho Seo
This patch use devm_* funtions in mcs_touchkey driver. As a result, error path and remove() funtion is simplified. Signed-off-by: Beomho Seo --- Changes in v4: - free_irq are back again for equivalent transformation. Changes in v3: - Some codes are back again. use fw_version, driver name and powe

[RESEND PATCH v4 0/2] Use devm_* functions for Melfas touch device

2014-05-28 Thread Beomho Seo
This patch set devm_* functions in Melfas touche device driver. As a result, error path and remove() function is simplified. Changes in v4: - mcs_touchkey: add free_irq for equivalent transformation. Changes in v3: - mcs_touchkey: Some codes are back again. Changes in v2: - Additionally use devm

Re: [PATCH v4 1/2] Input: mcs_touchkey: use devm_* functions

2014-05-28 Thread Beomho Seo
On 05/28/2014 05:41 PM, Beomho Seo wrote: > This patch use devm_* funtions in mcs_touchkey driver. > As a result, error path and remove() funtion is simplified. > > Signed-off-by: Beomho Seo > --- > Changes in v4: > - free_irq are back again for equivalent transformation. > Changes in v3: > - Som

[PATCH v4 0/2] Use devm_* functions for Melfas touch device

2014-05-28 Thread Beomho Seo
This patch set devm_* functions in Melfas touche device driver. As a result, error path and remove() function is simplified. Changes in v4: - mcs_touchkey: add free_irq for equivalent transformation. Changes in v3: - mcs_touchkey: Some codes are back again. Changes in v2: - Additionally use devm

[PATCH v4 2/2] Input: mcs5000_ts: use devm_* functions

2014-05-28 Thread Beomho Seo
This patch use devm_* functions in mcs5000_ts driver. As, a result, error patch and remove() function is simplified. Signed-off-by: Beomho Seo --- Changes in v4: - None. Changes in v3: - None. Changes in v2: - Additionally use devm_kzalloc for mcs_ts_data struct. --- drivers/input/touchscreen/mc

[PATCH v4 1/2] Input: mcs_touchkey: use devm_* functions

2014-05-28 Thread Beomho Seo
This patch use devm_* funtions in mcs_touchkey driver. As a result, error path and remove() funtion is simplified. Signed-off-by: Beomho Seo --- Changes in v4: - free_irq are back again for equivalent transformation. Changes in v3: - Some codes are back again. use fw_version, driver name and powe