Re: [PATCH 1/1] Input: max8997_haptic - Check return value of regulator_enable

2014-05-30 Thread Sachin Kamat
- Donggeun (as his mail bounces) Hi Dmitry, On 31 May 2014 01:35, Dmitry Torokhov wrote: > Hi Sachin, > > On Fri, May 30, 2014 at 04:06:13PM +0530, Sachin Kamat wrote: >> Fixes the following warning: >> drivers/input/misc/max8997_haptic.c:185:19: warning: ignoring return value >> of ‘regulator

Re: [PATCH 1/1] Input: max8997_haptic - Check return value of regulator_enable

2014-05-30 Thread Dmitry Torokhov
Hi Sachin, On Fri, May 30, 2014 at 04:06:13PM +0530, Sachin Kamat wrote: > Fixes the following warning: > drivers/input/misc/max8997_haptic.c:185:19: warning: ignoring return value of > ‘regulator_enable’, declared with attribute warn_unused_result > [-Wunused-result] > > Signed-off-by: Sachin

Re: [PATCHv4 0/4] tsc2005 DT binding

2014-05-30 Thread Dmitry Torokhov
On Thu, May 29, 2014 at 03:33:57PM +0200, Sebastian Reichel wrote: > On Wed, May 21, 2014 at 07:36:10PM +0200, Sebastian Reichel wrote: > > This adds device tree support for the tsc2005 touchscreen > > controller, which is currently only used by the Nokia N900 > > board. > > > > The patch does not

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-05-30 Thread Lars-Peter Clausen
On 05/30/2014 07:33 PM, David Daney wrote: On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote: On Fri, May 30, 2014 at 1:30 PM, abdoulaye berthe wrote: --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1263,10 +1263,9 @@ static void gpiochip_irqchip_remove(struct gpio_chip *gpiochip)

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-05-30 Thread David Daney
On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote: On Fri, May 30, 2014 at 1:30 PM, abdoulaye berthe wrote: --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1263,10 +1263,9 @@ static void gpiochip_irqchip_remove(struct gpio_chip *gpiochip); * * A gpio_chip with any GPIOs stil

writing a touchscreen device driver

2014-05-30 Thread Filippo Sironi
Hi everyone, I'm writing a touchscreen device driver for the PIXCIR Tango C series (http://www.pixcir.com.cn/english/products.asp?Action=Detail&ID=95) for Linux 4 Tegra 3.1.10 (I'm using a Tegra 2 series platform). I went through the documentation and I came up with the code you can find in th

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-05-30 Thread Ralf Baechle
On Fri, May 30, 2014 at 01:39:15PM +0200, Geert Uytterhoeven wrote: > > + if (test_bit(FLAG_REQUESTED, &chip->desc[id].flags)) > > + panic("gpio: removing gpiochip with gpios still > > requested\n"); > > panic? > > Is this likely to happen? And while we're a

[git pull] Input updates for 3.15-rc7

2014-05-30 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. You will get a couple of driver/build fixups and also redone quir

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-05-30 Thread Geert Uytterhoeven
On Fri, May 30, 2014 at 1:30 PM, abdoulaye berthe wrote: > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -1263,10 +1263,9 @@ static void gpiochip_irqchip_remove(struct gpio_chip > *gpiochip); > * > * A gpio_chip with any GPIOs still requested may not be removed. > */ > -i

[PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-05-30 Thread abdoulaye berthe
This avoids handling gpiochip remove error in device remove handler. Signed-off-by: abdoulaye berthe --- drivers/gpio/gpiolib.c | 24 +++- include/linux/gpio/driver.h | 2 +- 2 files changed, 8 insertions(+), 18 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/driver

[PATCH 1/1] Input: max8997_haptic - Check return value of regulator_enable

2014-05-30 Thread Sachin Kamat
Fixes the following warning: drivers/input/misc/max8997_haptic.c:185:19: warning: ignoring return value of ‘regulator_enable’, declared with attribute warn_unused_result [-Wunused-result] Signed-off-by: Sachin Kamat Cc: Donggeun Kim --- drivers/input/misc/max8997_haptic.c |6 +- 1 file