Re: [PATCH v2 2/2] Add support for Compact (Bluetooth|USB) keyboard with Trackpoint

2014-06-13 Thread Jiri Kosina
On Fri, 13 Jun 2014, Antonio Ospite wrote: > > Previously the tpkbd driver had various functions marked "_tp" to indicate > > that it's for the "mouse" half of the keyboard as the kernel sees it, > > however it does nothing special with the keyboard half. I was intending > > (somewhat sloppily)

Re: [PATCH] Input - wacom: put a flag when the led are initialized

2014-06-13 Thread Ping Cheng
Hi Benjamin, On Fri, Jun 13, 2014 at 1:29 PM, Benjamin Tissoires wrote: > This solves a bug with the wireless receiver: Your patch does get rid of the crash. But, it does not fix it at the root cause. > - at plug, the wireless receiver does not know which Wacom device it is > connected to, so

Re: [PATCH] input: touchscreen: ti_am335x_tsc: warn about incorrect spelling

2014-06-13 Thread Felipe Balbi
Hi, Here's another patch which has been pending for months. On Mon, Nov 18, 2013 at 09:29:01AM -0600, Felipe Balbi wrote: > In the hopes that people run new kernels on > their devices, let's add a warning message > asking users to have their DTS file fixed. > > The goal is that by Linux 4.0 we w

Re: [PATCH v2 2/2] Add support for Compact (Bluetooth|USB) keyboard with Trackpoint

2014-06-13 Thread Antonio Ospite
On Thu, 12 Jun 2014 09:56:41 +0100 (BST) Jamie Lentin wrote: > On Wed, 11 Jun 2014, Antonio Ospite wrote: > [...] > >> +static int tpcompactkbd_input_mapping(struct hid_device *hdev, > > > > Maybe name these functions like tpkbd_input_mapping_compact()? > > > > This way the namespace is more c

[PATCH v3 2/2] elantech: Call psmouse_reset when elantech probe fails

2014-06-13 Thread Ulrik De Bie
Signed-off-by: Ulrik De Bie --- drivers/input/mouse/elantech.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c index 0eb185b..fa150d9 100644 --- a/drivers/input/mouse/elantech.c +++ b/drivers/input/mouse/elantech.c @@ -1617,6 +16

[PATCH v3 1/2] elantech: Add support for trackpoint found on some v3 models

2014-06-13 Thread Ulrik De Bie
Some elantech v3 touchpad equipped laptops also have a trackpoint, before this commit, these give sync errors. With this patch, the trackpoint is provided as another input device: 'Elantech PS/2 TrackPoint' The patch will also output messages that do not follow the expected pattern. In the mean ti

[PATCH v3 0/2] Input: Support in the elantech driver of the trackpoint present on for instance Lenovo L530

2014-06-13 Thread Ulrik De Bie
Patch 1 adds support for trackpoint on elantech driver for v3 models. Patch 2 adds a psmouse_reset when the elantech probes fails. Patch 2 depends on Patch 1. Changes since v2: * psmouse_reset change is now moved to a separate patch * comments/white spaces/newlines cleanup * Unexpected trackpoi

Re: [PATCH] Input - wacom: remove phys field in struct wacom

2014-06-13 Thread Benjamin Tissoires
On Jun 13 2014 or thereabouts, Benjamin Tissoires wrote: > On Jun 13 2014 or thereabouts, Dmitry Torokhov wrote: > > On Fri, Jun 13, 2014 at 04:29:04PM -0400, Benjamin Tissoires wrote: > > > This field is not used, remove it. > > > > We must have lost the assignment, but it should be assigned to p

Re: [PATCH] Revert "Input: wacom - testing result shows get_report is unnecessary."

2014-06-13 Thread Aristeu Rozanski
On Fri, Jun 13, 2014 at 04:32:18PM -0400, Benjamin Tissoires wrote: > This reverts commit 1b2faaf7e219fc2905d75afcd4c815e5d39eda80. > > The Intuos4 series presents a bug in which it hangs if it receives > a set feature command while switching to the enhanced mode. > This bug is triggered when plug

Re: [PATCH] Input - wacom: remove phys field in struct wacom

2014-06-13 Thread Benjamin Tissoires
On Jun 13 2014 or thereabouts, Dmitry Torokhov wrote: > On Fri, Jun 13, 2014 at 04:29:04PM -0400, Benjamin Tissoires wrote: > > This field is not used, remove it. > > We must have lost the assignment, but it should be assigned to phys of > corresponding input device. hehe. Even in 2007, when the

Re: [PATCH] Input - wacom: remove phys field in struct wacom

2014-06-13 Thread Dmitry Torokhov
On Fri, Jun 13, 2014 at 04:29:04PM -0400, Benjamin Tissoires wrote: > This field is not used, remove it. We must have lost the assignment, but it should be assigned to phys of corresponding input device. > > Signed-off-by: Benjamin Tissoires > --- > drivers/input/tablet/wacom.h | 1 - > d

[PATCH] Revert "Input: wacom - testing result shows get_report is unnecessary."

2014-06-13 Thread Benjamin Tissoires
This reverts commit 1b2faaf7e219fc2905d75afcd4c815e5d39eda80. The Intuos4 series presents a bug in which it hangs if it receives a set feature command while switching to the enhanced mode. This bug is triggered when plugging an Intuos 4 while having a gnome user session up and running. Signed-off

[PATCH] Input - wacom: put a flag when the led are initialized

2014-06-13 Thread Benjamin Tissoires
This solves a bug with the wireless receiver: - at plug, the wireless receiver does not know which Wacom device it is connected to, so it does not actually creates all the LEDs - when the tablet connects, wacom->wacom_wac.features.type is set to the proper device so that wacom_wac can understan

[PATCH] Input - wacom: remove phys field in struct wacom

2014-06-13 Thread Benjamin Tissoires
This field is not used, remove it. Signed-off-by: Benjamin Tissoires --- drivers/input/tablet/wacom.h | 1 - drivers/input/tablet/wacom_sys.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/input/tablet/wacom.h b/drivers/input/tablet/wacom.h index 9ebf0ed..70b1e71 100644 --- a/

Re: [PATCH v2 3/6] iio: adc: fsl,imx25-gcq driver

2014-06-13 Thread Peter Meerwald
> This is a conversion queue driver for the mx25 SoC. It uses the central > ADC which is used by two seperate independent queues. This driver > prepares different conversion configurations for each possible input. > For a conversion it creates a conversionqueue of one item with the > correct confi

Re: [PATCH v5] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-13 Thread Janne Kanniainen
> Ok, so you decided to continue setting mode on every LED brightness > update. That should be fine, but you never answered my question about > whether it is necessary? I decided to do it that way because official driver did it as well. I can check if it is necessary. > You're almost done. One la

Re: [PATCH v2 5/6] ARM: dts: imx25: mbimxsd25: Add touchscreen support.

2014-06-13 Thread Fabio Estevam
Hi Denis, On Fri, Jun 13, 2014 at 12:21 PM, Denis Carikli wrote: > Signed-off-by: Denis Carikli > --- > .../imx25-eukrea-mbimxsd25-baseboard-cmo-qvga.dts | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-cmo-qvga.dts >

[PATCH v2 1/6] mfd: fsl imx25 Touchscreen ADC driver

2014-06-13 Thread Denis Carikli
From: Markus Pargmann This is the core driver for imx25 touchscreen/adc driver. The module has one shared ADC and two different conversion queues which use the ADC. The two queues are identical. Both can be used for general purpose ADC but one is meant to be used for touchscreens. This driver is

Dust off the "arm imx25 touchscreen/ADC drivers" patch serie.

2014-06-13 Thread Denis Carikli
Hi, I haven't seen any new comments on that serie since february, so I picked it again and I tried to address all remaining comments. To be able to test that patch, the following patch will need to be cherry-picked. http://lists.infradead.org/pipermail/linux-arm-kernel/2014-June/263494.html De

[PATCH v2 2/6] input: touchscreen: imx25 tcq driver

2014-06-13 Thread Denis Carikli
From: Markus Pargmann This is a driver for the imx25 ADC/TSC module. It controls the touchscreen conversion queue and creates a touchscreen input device. The driver currently only supports 4 wire touchscreens. The driver uses a simple conversion queue of precharge, touch detection, X measurement,

[PATCH v2 4/6] ARM: dts: imx25: Add touchscreen support

2014-06-13 Thread Denis Carikli
Signed-off-by: Denis Carikli --- arch/arm/boot/dts/imx25.dtsi | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi index 98783f5..5564167 100644 --- a/arch/arm/boot/dts/imx25.dtsi +++ b/arch/arm/boot/dts/imx2

[PATCH v2 6/6] ARM: imx_v4_v5_defconfig: Add I.MX25 Touchscreen controller support.

2014-06-13 Thread Denis Carikli
Signed-off-by: Denis Carikli --- arch/arm/configs/imx_v4_v5_defconfig |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/imx_v4_v5_defconfig b/arch/arm/configs/imx_v4_v5_defconfig index 397f43c..b6b3674 100644 --- a/arch/arm/configs/imx_v4_v5_defconfig +++ b/arch/arm/confi

[PATCH v2 3/6] iio: adc: fsl,imx25-gcq driver

2014-06-13 Thread Denis Carikli
From: Markus Pargmann This is a conversion queue driver for the mx25 SoC. It uses the central ADC which is used by two seperate independent queues. This driver prepares different conversion configurations for each possible input. For a conversion it creates a conversionqueue of one item with the

[PATCH v2 5/6] ARM: dts: imx25: mbimxsd25: Add touchscreen support.

2014-06-13 Thread Denis Carikli
Signed-off-by: Denis Carikli --- .../imx25-eukrea-mbimxsd25-baseboard-cmo-qvga.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-cmo-qvga.dts b/arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard-cmo-qvga.dts index 9797280

Re: [PATCH v5] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-13 Thread Johan Hovold
On Thu, Jun 12, 2014 at 11:34:12PM +0300, Janne Kanniainen wrote: > This driver adds support for USB controlled led panels that exists in > MSI GT683R laptop > > Signed-off-by: Janne Kanniainen > --- > Changes in v2: > - sorted headers to alphabetic order > - using devm_kzalloc >

Re: [PATCH v2 1/1] elantech: Add support for trackpoint found on some v3 models

2014-06-13 Thread David Herrmann
Hi On Fri, Jun 13, 2014 at 9:24 AM, Hans de Goede wrote: >> You rely on external data here, so please check for truncation. If >> anyone changes psmouse->ps2dev.serio->phys, they would not notice that >> you rely on it here. So I'd do sth like: >> >> size_t n = snprintf(etd->tp_phys, sizeof(etd->