Re: [PATCH v5] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-16 Thread Johan Hovold
On Sun, Jun 15, 2014 at 05:59:40PM +0300, Janne Kanniainen wrote: > >> Ok, so you decided to continue setting mode on every LED brightness > >> update. That should be fine, but you never answered my question about > >> whether it is necessary? > > > > I decided to do it that way because official dr

Re: [PATCH v5] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-16 Thread Johan Hovold
On Sun, Jun 15, 2014 at 02:23:25AM +0300, Janne Kanniainen wrote: > > Hi! > > Hi. > > >> --- /dev/null > >> +++ b/Documentation/ABI/testing/sysfs-class-hid-driver-gt683r > >> @@ -0,0 +1,10 @@ > >> +What:/sys/class/hidraw//device/state > >> +Date:Jun 2014 > >> +Kern

Re: [PATCH v3 1/2] elantech: Add support for trackpoint found on some v3 models

2014-06-16 Thread David Herrmann
Hi On Fri, Jun 13, 2014 at 11:21 PM, Ulrik De Bie wrote: > Some elantech v3 touchpad equipped laptops also have a trackpoint, before > this commit, these give sync errors. With this patch, the trackpoint is > provided as another input device: 'Elantech PS/2 TrackPoint' > > The patch will also out

Re: [PATCH v3 2/2] elantech: Call psmouse_reset when elantech probe fails

2014-06-16 Thread David Herrmann
Hi On Fri, Jun 13, 2014 at 11:21 PM, Ulrik De Bie wrote: > Signed-off-by: Ulrik De Bie This patch lacks _any_ explanation why this is done. Please always write commit-messages! It is totally unclear from the patch description why the device is reset. Thanks David > --- > drivers/input/mouse/

[PATCH v3 2/6] input: touchscreen: imx25 tcq driver

2014-06-16 Thread Denis Carikli
From: Markus Pargmann This is a driver for the imx25 ADC/TSC module. It controls the touchscreen conversion queue and creates a touchscreen input device. The driver currently only supports 4 wire touchscreens. The driver uses a simple conversion queue of precharge, touch detection, X measurement,

[PATCH v3 5/6] ARM: dts: imx25: mbimxsd25: Add touchscreen support.

2014-06-16 Thread Denis Carikli
Signed-off-by: Denis Carikli --- Changelog v2->v3: - Most of the non-board specific tsc and tscadc parts were moved to imx25.dtsi. So this patch was adapted to that. - Thanks to a fix in the tsc driver, the 'fsl,pen-debounce = <100>;' is not necessary anymore. --- .../imx25-eukrea-mbimxsd2

[PATCH v3 6/6] ARM: imx_v4_v5_defconfig: Add I.MX25 Touchscreen controller and ADC support.

2014-06-16 Thread Denis Carikli
Signed-off-by: Denis Carikli --- Changelog v2->v3: - Added ADC support, splitting it would be overkill. --- arch/arm/configs/imx_v4_v5_defconfig |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/configs/imx_v4_v5_defconfig b/arch/arm/configs/imx_v4_v5_defconfig index 397f43c..5

[PATCH v3 3/6] iio: adc: fsl,imx25-gcq driver

2014-06-16 Thread Denis Carikli
From: Markus Pargmann This is a conversion queue driver for the mx25 SoC. It uses the central ADC which is used by two seperate independent queues. This driver prepares different conversion configurations for each possible input. For a conversion it creates a conversionqueue of one item with the

[PATCH v3 1/6] mfd: fsl imx25 Touchscreen ADC driver

2014-06-16 Thread Denis Carikli
From: Markus Pargmann This is the core driver for imx25 touchscreen/adc driver. The module has one shared ADC and two different conversion queues which use the ADC. The two queues are identical. Both can be used for general purpose ADC but one is meant to be used for touchscreens. This driver is

[PATCH v3 4/6] ARM: dts: imx25: Add TSC and ADC support

2014-06-16 Thread Denis Carikli
Signed-off-by: Denis Carikli --- Changelog v2->v3: - Added ADC controller support: making a separate patch for it would have been overkill. - Moved the common TSC and ADC sub-nodes inside this patch instead of having a copy in each dts using it. --- arch/arm/boot/dts/imx25.dtsi | 30 +++

[PATCH v2] Input: evdev - add event-mask API

2014-06-16 Thread David Herrmann
Hardware manufacturers group keys in the weirdest way possible. This may cause a power-key to be grouped together with normal keyboard keys and thus be reported on the same kernel interface. However, user-space is often only interested in specific sets of events. For instance, daemons dealing with

Re: [PATCH v3 1/6] mfd: fsl imx25 Touchscreen ADC driver

2014-06-16 Thread Lee Jones
> From: Markus Pargmann > > This is the core driver for imx25 touchscreen/adc driver. The module > has one shared ADC and two different conversion queues which use the > ADC. The two queues are identical. Both can be used for general purpose > ADC but one is meant to be used for touchscreens. >

Re: [PATCH v3 1/2] Rename hid-lenovo-tpkbd to hid-lenovo, so we can add other keyboards

2014-06-16 Thread Jiri Kosina
On Sun, 15 Jun 2014, Jamie Lentin wrote: > Signed-off-by: Jamie Lentin > --- > drivers/hid/Kconfig | 14 +- > drivers/hid/Makefile | 2 +- > drivers/hid/hid-core.c | 2 +- > drivers/hid/{hid-lenovo-tpkbd.c =>

Re: [PATCH v3 1/6] mfd: fsl imx25 Touchscreen ADC driver

2014-06-16 Thread Denis Carikli
On 06/16/2014 01:26 PM, Lee Jones wrote: +static void mx25_tsadc_nop(struct irq_data *d) +{ +} Err, no, this is not required. Just don't populate the call-backs. +static int mx25_tsadc_set_wake_nop(struct irq_data *d, unsigned int state) +{ + return 0; +} + +static struct irq_chip mx

Re: [PATCH] Input - wacom: put a flag when the led are initialized

2014-06-16 Thread Benjamin Tissoires
Hi Ping, On Jun 13 2014 or thereabouts, Ping Cheng wrote: > Hi Benjamin, > > On Fri, Jun 13, 2014 at 1:29 PM, Benjamin Tissoires > wrote: > > This solves a bug with the wireless receiver: > > Your patch does get rid of the crash. But, it does not fix it at the > root cause. True, it fixes the

[PATCH v6] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-16 Thread Janne Kanniainen
This driver adds support for USB controlled led panels that exists in MSI GT683R laptop Signed-off-by: Janne Kanniainen --- Changes in v2: - sorted headers to alphabetic order - using devm_kzalloc - using BIT(n) - using usb_control_msg instead of usb_submit_urb

[PATCH 0/2] touchscreen: sun4i-ts: fix reported temperature on A10

2014-06-16 Thread Hans de Goede
Hi Dmitry and Maxime, I've learned today that the temperature reported on the A10 / sun4i SoC family is aprox twice too high, since the A10 rtp controller temperature register seems to have double the resolution (one bit more) then that of the A13 (sun5i) and later. Dmitry, can you please add the

[PATCH 1/2] touchscreen: sun4i-ts: A10 (sun4i) has double the temperature precision

2014-06-16 Thread Hans de Goede
Testing has revealed that the temperature in the rtp controller of the A10 (sun4i) SoC has a resolution of 50 milli degrees / step, where as the A13 (sun5i) and later models have 100 milli degrees / step. Add a new sun5i-a13-ts compatible to differentiate the newer models and set the resolution ba

[PATCH 2/2] ARM: dts: sunxi: Adjust touchscreen compatible for sun5i and later

2014-06-16 Thread Hans de Goede
The touchscreen controller in the A13 and later has a different temperature resulution compated to the one in the original A10, change the compatible for the A13 and later so that the kernel will use the correct resolution. Reported-by: Tong Zhang Signed-off-by: Hans de Goede --- arch/arm/boot/

Re: [PATCH v3 1/2] Rename hid-lenovo-tpkbd to hid-lenovo, so we can add other keyboards

2014-06-16 Thread Antonio Ospite
On Sun, 15 Jun 2014 21:39:49 +0100 Jamie Lentin wrote: Almost there :) > Signed-off-by: Jamie Lentin > --- > drivers/hid/Kconfig | 14 +- > drivers/hid/Makefile | 2 +- > drivers/hid/hid-core.c | 2 +- > dr

Re: [PATCH v3 2/2] Add support for Compact (Bluetooth|USB) keyboard with Trackpoint

2014-06-16 Thread Antonio Ospite
On Sun, 15 Jun 2014 21:39:50 +0100 Jamie Lentin wrote: This one does not compile on 3.15, see below. Maybe you can take the chance to split the series in 4 patches: 1. rename only 2. cleanup of already existing code 3. preparatory changes to support multiple devices (the

Re: [PATCH 1/2] touchscreen: sun4i-ts: A10 (sun4i) has double the temperature precision

2014-06-16 Thread Dmitry Torokhov
Hi Hans, On Mon, Jun 16, 2014 at 08:24:28PM +0200, Hans de Goede wrote: > Testing has revealed that the temperature in the rtp controller of the A10 > (sun4i) SoC has a resolution of 50 milli degrees / step, where as the > A13 (sun5i) and later models have 100 milli degrees / step. > > Add a new

[PATCH 0/10] Batch of cleanup patches for cros_ec

2014-06-16 Thread Doug Anderson
This is a batch of cleanup patches picked from the ChromeOS 3.8 kernel tree and applied to ToT. Most of these patches were authored by Bill Richardson (CCed). Where appropriate I've squashed patches together, though I have erred on the side of keeping patches logically distinct rather than squash

[PATCH 08/10] mfd: cros_ec: cleanup: Remove EC wrapper functions

2014-06-16 Thread Doug Anderson
From: Bill Richardson Remove the three wrapper functions that talk to the EC without passing all the desired arguments and just use the underlying communication function that passes everything in a struct intead. This is internal code refactoring only. Nothing should change. Signed-off-by: Bill

[PATCH v4 2/2] elantech: Call psmouse_reset when elantech probe fails

2014-06-16 Thread Ulrik De Bie
elantech_init() calls elantech_set_absolute_mode which sets the driver in an absolute mode. When after this the elantech_init fails, it is best to turn the ps/2 mouse emulation mode back on by calling psmouse_reset() so that it can work as a regular mouse. Signed-off-by: Ulrik De Bie --- drivers

[PATCH v4 1/2] elantech: Add support for trackpoint found on some v3 models

2014-06-16 Thread Ulrik De Bie
Some elantech v3 touchpad equipped laptops also have a trackpoint, before this commit, these give sync errors. With this patch, the trackpoint is provided as another input device: 'Elantech PS/2 TrackPoint' The patch will also output messages that do not follow the expected pattern. In the mean ti

[PATCH v4 0/2] Input: Support in the elantech driver of the trackpoint present on for instance Lenovo L530

2014-06-16 Thread Ulrik De Bie
Patch 1 adds support for trackpoint on elantech driver for v3 models. Patch 2 adds a psmouse_reset when the elantech probes fails. Patch 2 depends on Patch 1. Changes since v3: * Patch1: added (correct) error after input_allocate_device failure in elantech_init() * Patch2: added more explanation

[PATCH v6] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-16 Thread Janne Kanniainen
This driver adds support for USB controlled led panels that exists in MSI GT683R laptop Signed-off-by: Janne Kanniainen --- Changes in v2: - sorted headers to alphabetic order - using devm_kzalloc - using BIT(n) - using usb_control_msg instead of usb_submit_urb

Re: [PATCH v4 2/2] elantech: Call psmouse_reset when elantech probe fails

2014-06-16 Thread Hans de Goede
Hi, On 06/16/2014 11:53 PM, Ulrik De Bie wrote: > elantech_init() calls elantech_set_absolute_mode which sets the driver in > an absolute mode. When after this the elantech_init fails, it is best > to turn the ps/2 mouse emulation mode back on by calling psmouse_reset() > so that it can work as a

Re: [PATCH 1/2] touchscreen: sun4i-ts: A10 (sun4i) has double the temperature precision

2014-06-16 Thread Hans de Goede
Hi, On 06/16/2014 11:30 PM, Dmitry Torokhov wrote: > Hi Hans, > > On Mon, Jun 16, 2014 at 08:24:28PM +0200, Hans de Goede wrote: >> Testing has revealed that the temperature in the rtp controller of the A10 >> (sun4i) SoC has a resolution of 50 milli degrees / step, where as the >> A13 (sun5i) an