Re: Linux 3.16-rc6

2014-07-23 Thread Peter Zijlstra
On Wed, Jul 23, 2014 at 05:37:43PM -0700, Linus Torvalds wrote: > On Wed, Jul 23, 2014 at 2:53 AM, Borislav Petkov wrote: > > > > Well, it looks like we f*cked up something after -rc5 since I'm starting > > to see lockdep splats all over the place which I didn't see before. I'm > > running rc6 + t

Re: Linux 3.16-rc6

2014-07-23 Thread David Rientjes
On Wed, 23 Jul 2014, Linus Torvalds wrote: > > Well, it looks like we f*cked up something after -rc5 since I'm starting > > to see lockdep splats all over the place which I didn't see before. I'm > > running rc6 + tip/master. > > > > There was one in r8169 yesterday: > > > > https://lkml.kernel.or

Re: [PATCH] Input: synaptics-rmi4 - fix compiler warnings in F11

2014-07-23 Thread Christopher Heiny
On 07/22/2014 11:11 PM, Dmitry Torokhov wrote: Signed-off-by: Dmitry Torokhov I've reviewed this, and can say: Acked-by: Christopher Heiny but I haven't had a chance to apply it to my build tree. Andrew - I'll be OOO for a couple of days. Can you do that, and add a Tested-by: or rev the

Re: Linux 3.16-rc6

2014-07-23 Thread Linus Torvalds
On Wed, Jul 23, 2014 at 2:53 AM, Borislav Petkov wrote: > > Well, it looks like we f*cked up something after -rc5 since I'm starting > to see lockdep splats all over the place which I didn't see before. I'm > running rc6 + tip/master. > > There was one in r8169 yesterday: > > https://lkml.kernel.o

Re: [PATCH v5 3/4] HID: lenovo: Style fixes

2014-07-23 Thread Dmitry Torokhov
Hi Jamie, On Wed, Jul 23, 2014 at 11:30:47PM +0100, Jamie Lentin wrote: > Signed-off-by: Jamie Lentin > --- > drivers/hid/hid-lenovo.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c > index a56b9e7..6d55939 1006

[PATCH] Input: atmel_mxt_ts - split config update a bit

2014-07-23 Thread Dmitry Torokhov
Let's split config update code a bit so it is hopefully a bit easier to read. Also, the firmware update callback should be the entity releasing firmware blob, not lower layers. Signed-off-by: Dmitry Torokhov --- As always, not tested... drivers/input/touchscreen/atmel_mxt_ts.c | 270 ++

[PATCH v5 1/4] HID: lenovo: Rename hid-lenovo-tpkbd to hid-lenovo

2014-07-23 Thread Jamie Lentin
Rename module and all functions within so we can add support for other keyboards in the same file. Rename the _tp postfix to _tpkbd, to signify functions relevant to the TP USB keyboard. Signed-off-by: Jamie Lentin --- ...er-hid-lenovo-tpkbd => sysfs-driver-hid-lenovo} | 0 drivers/hid/Kconfig

[PATCH v5 0/4] HID: lenovo: Add support for Lenovo Compact Keyboard

2014-07-23 Thread Jamie Lentin
This patchset follows on from my previous attempts to add support for these keyboards from Lenovo. Antonio, I've used cptkbd_data and left data_pointer for now. It'd be an easy patch to change data_pointer to tpkbd_data, but is drifting away from what this patchset is supposed to do. Could send th

[PATCH v5 2/4] HID: lenovo: Prepare support for adding other devices

2014-07-23 Thread Jamie Lentin
Ensure all tpkbd specifics are within a postfixed function, the main functions for the driver should just switch to the appropriate function depending on product ID. Given this, we can add extra devices by including extra postfixed functions. Signed-off-by: Jamie Lentin --- drivers/hid/hid-lenov

[PATCH v5 3/4] HID: lenovo: Style fixes

2014-07-23 Thread Jamie Lentin
Signed-off-by: Jamie Lentin --- drivers/hid/hid-lenovo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c index a56b9e7..6d55939 100644 --- a/drivers/hid/hid-lenovo.c +++ b/drivers/hid/hid-lenovo.c @@ -350,6 +350,7 @@ st

[PATCH v5 4/4] HID: lenovo: Add support for Compact (BT|USB) keyboard

2014-07-23 Thread Jamie Lentin
Add support for both ThinkPad Compact Bluetooth Keyboard with TrackPoint and ThinkPad Compact USB Keyboard with TrackPoint. Signed-off-by: Jamie Lentin --- Documentation/ABI/testing/sysfs-driver-hid-lenovo | 12 ++ drivers/hid/Kconfig | 2 + drivers/hid/hid-core.

[PATCH] Input: atmel_mxt_ts - simplify mxt_initialize a bit

2014-07-23 Thread Dmitry Torokhov
I think having control flow with 2 goto/labels/flags is quite hard to read, this version is a bit more readable IMO. Signed-off-by: Dmitry Torokhov --- drivers/input/touchscreen/atmel_mxt_ts.c | 81 +--- 1 file changed, 42 insertions(+), 39 deletions(-) diff --git a/

Re: [PATCH 00/15] atmel_mxt_ts - device tree, bootloader, etc

2014-07-23 Thread Stephen Warren
On 07/23/2014 02:29 PM, Dmitry Torokhov wrote: > On Wed, Jul 23, 2014 at 11:22:54AM -0600, Stephen Warren wrote: >> On 07/23/2014 09:30 AM, Nick Dyer wrote: >>> On 22/07/14 21:34, Stephen Warren wrote: Unfortunately, I still can't get these to work on my system. Per your "Re: atmel_m

Re: [PATCH 04/15] Input: atmel_mxt_ts - implement device tree support

2014-07-23 Thread Stephen Warren
On 07/03/2014 09:01 AM, nick.d...@itdev.co.uk wrote: > From: Stephen Warren > > Signed-off-by: Stephen Warren > Signed-off-by: Nick Dyer Hmm. It looks like the version of this patch that was actually applied varies quite a bit from what was posted, in particular in the implementation and call

[PATCH] hid: hid-apple: Fixed 2 spacing style issues

2014-07-23 Thread Brad Slayter
Fixed a spacing issue in a struct def and a funcion call. Signed-off-by: Brad Slayter --- drivers/hid/hid-apple.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c index f822fd2..8e0a0a4 100644 --- a/drivers/hid/hid

Re: [PATCH 00/15] atmel_mxt_ts - device tree, bootloader, etc

2014-07-23 Thread Dmitry Torokhov
On Wed, Jul 23, 2014 at 11:22:54AM -0600, Stephen Warren wrote: > On 07/23/2014 09:30 AM, Nick Dyer wrote: > > On 22/07/14 21:34, Stephen Warren wrote: > >> Unfortunately, I still can't get these to work on my system. > >> > >> Per your "Re: atmel_mxt_ts: defaulting irqflags to > >> IRQF_TRIGGER_FA

[PATCH] Input: ipaq-micro-ts - introduce open/close

2014-07-23 Thread Dmitry Torokhov
Wire up open/close so we do not try to send events until someone uses them; this also allows us to remove micro_ts_remove() and rely fully on managed resources. Signed-off-by: Dmitry Torokhov --- drivers/input/touchscreen/ipaq-micro-ts.c | 88 --- 1 file changed, 56 i

Re: [PATCH v2] input: driver for touchscreen on iPaq h3xxx

2014-07-23 Thread Dmitry Torokhov
Hi Linus, On Wed, Jul 23, 2014 at 10:20:14AM +0200, Linus Walleij wrote: > From: Dmitry Artamonow > > This adds a driver for the touchscreen connected to the > Atmel microcontroller on the iPAQ h3xxx series. > > Based on a driver from handhelds.org 2.6.21 kernel, written > by Alessandro GARDICH

Re: [PATCH 00/15] atmel_mxt_ts - device tree, bootloader, etc

2014-07-23 Thread Stephen Warren
On 07/23/2014 09:30 AM, Nick Dyer wrote: > On 22/07/14 21:34, Stephen Warren wrote: >> Unfortunately, I still can't get these to work on my system. >> >> Per your "Re: atmel_mxt_ts: defaulting irqflags to >> IRQF_TRIGGER_FALLING", I set up the IRQ type in the Tegra DT file, and >> then applied this

[PATCHES v2] Add support for more Huion tablets

2014-07-23 Thread Nikolai Kondrashov
Hi everyone, This is the second version of the patch set adding support for more Huion tablets [1]. This version has the "hid: huion: Invert in-range on specific product" patch removed as requested by Benjamin Tissoires. Tested with Huion H610N. Nick [PATCH 1/4] hid: huion: Use "tablet" instea

[PATCH 3/4] hid: huion: Switch to generating report descriptor

2014-07-23 Thread Nikolai Kondrashov
Switch to generating tablet pen report descriptor from a template and parameters retrieved from string descriptor 0x64. Signed-off-by: Nikolai Kondrashov --- drivers/hid/hid-huion.c | 245 +--- 1 file changed, 167 insertions(+), 78 deletions(-) diff -

[PATCH 4/4] hid: huion: Handle tablets with UC-Logic vendor ID

2014-07-23 Thread Nikolai Kondrashov
Add handling of Huion tablets with UC-Logic vendor ID, but the same product ID to hid-huion driver. A Huion H580 was seen using it. Signed-off-by: Nikolai Kondrashov --- drivers/hid/hid-huion.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/hid-huion.c b/drivers/hid/hid-huion.c

[PATCH 1/4] hid: huion: Use "tablet" instead of specific model

2014-07-23 Thread Nikolai Kondrashov
Use word "tablet" in identifiers and comments instead of referring to specific Huion tablet model name, as the product ID is used by at least several tablet models. Signed-off-by: Nikolai Kondrashov --- drivers/hid/hid-core.c | 2 +- drivers/hid/hid-huion.c | 25 + driv

[PATCH 2/4] hid: huion: Don't ignore other interfaces

2014-07-23 Thread Nikolai Kondrashov
Don't ignore non pen-reporting interfaces as they may be used by some models reusing the same product ID. Signed-off-by: Nikolai Kondrashov --- drivers/hid/hid-huion.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/hid/hid-huion.c b/drivers/hid/

Re: [PATCH 00/15] atmel_mxt_ts - device tree, bootloader, etc

2014-07-23 Thread Nick Dyer
On 22/07/14 21:34, Stephen Warren wrote: > Unfortunately, I still can't get these to work on my system. > > Per your "Re: atmel_mxt_ts: defaulting irqflags to > IRQF_TRIGGER_FALLING", I set up the IRQ type in the Tegra DT file, and > then applied this series on top of next-20140721. The driver app

Re: [PATCH 04/15] Input: atmel_mxt_ts - implement device tree support

2014-07-23 Thread Nick Dyer
On 22/07/14 21:37, Stephen Warren wrote: > On 07/03/2014 09:01 AM, nick.d...@itdev.co.uk wrote: >> From: Stephen Warren > >> diff --git a/Documentation/devicetree/bindings/input/atmel,maxtouch.txt >> b/Documentation/devicetree/bindings/input/atmel,maxtouch.txt > >> +touch@4b { >> +

Re: [PATCH 4/5] hid: huion: Switch to generating report descriptor

2014-07-23 Thread Nikolai Kondrashov
On 07/23/2014 05:42 PM, Benjamin Tissoires wrote: On Wed, Jul 23, 2014 at 8:42 AM, Nikolai Kondrashov wrote: Switch to generating tablet pen report descriptor from a template and parameters retrieved from string descriptor 0x64. Signed-off-by: Nikolai Kondrashov --- This is a nice solution.

Re: [PATCH 5/5] hid: huion: Handle tablets with UC-Logic vendor ID

2014-07-23 Thread Benjamin Tissoires
On Wed, Jul 23, 2014 at 8:42 AM, Nikolai Kondrashov wrote: > Add handling of Huion tablets with UC-Logic vendor ID, but the same > product ID to hid-huion driver. A Huion H580 was seen using it. > > Signed-off-by: Nikolai Kondrashov > --- Reviewed-by: Benjamin Tissoires > drivers/hid/hid-huio

Re: [PATCH 3/5] hid: huion: Don't ignore other interfaces

2014-07-23 Thread Benjamin Tissoires
On Wed, Jul 23, 2014 at 8:42 AM, Nikolai Kondrashov wrote: > Don't ignore non pen-reporting interfaces as they may be used by some > models reusing the same product ID. > > Signed-off-by: Nikolai Kondrashov > --- Reviewed-by: Benjamin Tissoires > drivers/hid/hid-huion.c | 16

Re: [PATCH 4/5] hid: huion: Switch to generating report descriptor

2014-07-23 Thread Benjamin Tissoires
On Wed, Jul 23, 2014 at 8:42 AM, Nikolai Kondrashov wrote: > Switch to generating tablet pen report descriptor from a template and > parameters retrieved from string descriptor 0x64. > > Signed-off-by: Nikolai Kondrashov > --- This is a nice solution. I still have few remarks/questions inlined:

Re: [PATCH 2/5] hid: huion: Invert in-range on specific product

2014-07-23 Thread Nikolai Kondrashov
On 07/23/2014 05:34 PM, Benjamin Tissoires wrote: On Wed, Jul 23, 2014 at 8:42 AM, Nikolai Kondrashov wrote: Limit inverting the in-range bit in raw reports to tablet product ID only. This will make adding handling of other, non-tablet products, easier. Signed-off-by: Nikolai Kondrashov ---

Re: [PATCH 2/5] hid: huion: Invert in-range on specific product

2014-07-23 Thread Benjamin Tissoires
On Wed, Jul 23, 2014 at 8:42 AM, Nikolai Kondrashov wrote: > Limit inverting the in-range bit in raw reports to tablet product ID > only. This will make adding handling of other, non-tablet products, > easier. > > Signed-off-by: Nikolai Kondrashov > --- I am not particularly a big fan of this on

Re: [PATCH 1/5] hid: huion: Use "tablet" instead of specific model

2014-07-23 Thread Benjamin Tissoires
On Wed, Jul 23, 2014 at 8:42 AM, Nikolai Kondrashov wrote: > Use word "tablet" in identifiers and comments instead of referring to specific > Huion tablet model name, as the product ID is used by at least several tablet > models. > > Signed-off-by: Nikolai Kondrashov > --- Reviewed-by: Benjamin

Re: [PATCHES] hid: Add support for more Huion tablets

2014-07-23 Thread Nikolai Kondrashov
On 07/23/2014 03:42 PM, Nikolai Kondrashov wrote: The Huion tablets seem to all use a single product ID and the iProduct strings are inconsistent. So there isn't much to identify the models with so far, although the magic string descriptor containing tablet parameters has some internal model name

[PATCH 5/5] hid: huion: Handle tablets with UC-Logic vendor ID

2014-07-23 Thread Nikolai Kondrashov
Add handling of Huion tablets with UC-Logic vendor ID, but the same product ID to hid-huion driver. A Huion H580 was seen using it. Signed-off-by: Nikolai Kondrashov --- drivers/hid/hid-huion.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/hid-huion.c b/drivers/hid/hid-huion.c

[PATCH 4/5] hid: huion: Switch to generating report descriptor

2014-07-23 Thread Nikolai Kondrashov
Switch to generating tablet pen report descriptor from a template and parameters retrieved from string descriptor 0x64. Signed-off-by: Nikolai Kondrashov --- drivers/hid/hid-huion.c | 245 +--- 1 file changed, 167 insertions(+), 78 deletions(-) diff -

[PATCH 1/5] hid: huion: Use "tablet" instead of specific model

2014-07-23 Thread Nikolai Kondrashov
Use word "tablet" in identifiers and comments instead of referring to specific Huion tablet model name, as the product ID is used by at least several tablet models. Signed-off-by: Nikolai Kondrashov --- drivers/hid/hid-core.c | 2 +- drivers/hid/hid-huion.c | 25 + driv

[PATCHES] hid: Add support for more Huion tablets

2014-07-23 Thread Nikolai Kondrashov
Hi everyone, These patches add support for more Huion tablet models. At least five models were verified working with the out-of-tree driver [1] which these patches are based on. This in-tree driver was verified working with Huion H610N. The Huion tablets seem to all use a single product ID and th

[PATCH 2/5] hid: huion: Invert in-range on specific product

2014-07-23 Thread Nikolai Kondrashov
Limit inverting the in-range bit in raw reports to tablet product ID only. This will make adding handling of other, non-tablet products, easier. Signed-off-by: Nikolai Kondrashov --- drivers/hid/hid-huion.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/

[PATCH 3/5] hid: huion: Don't ignore other interfaces

2014-07-23 Thread Nikolai Kondrashov
Don't ignore non pen-reporting interfaces as they may be used by some models reusing the same product ID. Signed-off-by: Nikolai Kondrashov --- drivers/hid/hid-huion.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/hid/hid-huion.c b/drivers/hid/hid-

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-23 Thread Chen Gang
On 07/23/2014 07:30 PM, Dan Carpenter wrote: > On Wed, Jul 23, 2014 at 07:09:22PM +0800, Chen Gang wrote: >> >> >> On 07/17/2014 05:19 PM, Chen Gang wrote: >>> >>> >>> On 07/17/2014 05:16 PM, Dan Carpenter wrote: On Thu, Jul 17, 2014 at 04:59:09PM +0800, Chen Gang wrote: >>> + retu

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-23 Thread Dan Carpenter
On Wed, Jul 23, 2014 at 07:09:22PM +0800, Chen Gang wrote: > > > On 07/17/2014 05:19 PM, Chen Gang wrote: > > > > > > On 07/17/2014 05:16 PM, Dan Carpenter wrote: > >> On Thu, Jul 17, 2014 at 04:59:09PM +0800, Chen Gang wrote: > > + return (__force void __iomem *)ERR_PTR(-ENXIO); > >>

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-23 Thread Chen Gang
On 07/17/2014 05:19 PM, Chen Gang wrote: > > > On 07/17/2014 05:16 PM, Dan Carpenter wrote: >> On Thu, Jul 17, 2014 at 04:59:09PM +0800, Chen Gang wrote: > + return (__force void __iomem *)ERR_PTR(-ENXIO); There's apparently an IOMEM_ERR_PTR() for this nowadays... >>> >>> IOM

Re: Linux 3.16-rc6

2014-07-23 Thread Borislav Petkov
On Sun, Jul 20, 2014 at 09:22:52PM -0700, Linus Torvalds wrote: > So go get the latest rc and kick the tires, to see that nothing has > fallen through the cracks, ok? Well, it looks like we f*cked up something after -rc5 since I'm starting to see lockdep splats all over the place which I didn't se

[PATCH v2] input: driver for touchscreen on iPaq h3xxx

2014-07-23 Thread Linus Walleij
From: Dmitry Artamonow This adds a driver for the touchscreen connected to the Atmel microcontroller on the iPAQ h3xxx series. Based on a driver from handhelds.org 2.6.21 kernel, written by Alessandro GARDICH, with the bulk of the code for the new input architecture rewritten by Dmitry Atamonow,

Re: [PATCH] input: driver for touchscreen on iPaq h3xxx

2014-07-23 Thread Linus Walleij
On Sun, Jul 13, 2014 at 4:59 AM, Dmitry Torokhov wrote: > Hi Linus, Dmitry, > > On Sat, Jul 12, 2014 at 11:31:21AM +0200, Linus Walleij wrote: >> From: Dmitry Artamonow > > So is this Dmitry's or Alessandro's work? Multiple authors. Alessandro, Dmitry and me. In order of sign-off... The only via

Re: [PATCH] Input: s3c2410_ts: Move to clk_prepare_enable/clk_disable_unprepare

2014-07-23 Thread Vasily Khoruzhick
On 22 July 2014 23:09:14 Dmitry Torokhov wrote: > Hi Vasily, > > On Wed, Jul 09, 2014 at 12:13:41PM +0300, Vasily Khoruzhick wrote: > > On 8 July 2014 18:00:49 Dmitry Torokhov wrote: > > > > Hi Dmitry, > > > > > > - clk_disable(ts.clock); > > > > + clk_disable_unprepare(ts.clock); >