Re: [PATCH 00/14] alps: bugfixes, cleanups and new hardware support

2014-07-25 Thread Dmitry Torokhov
Hi Hans, On Wed, Jul 09, 2014 at 05:24:05PM +0200, Hans de Goede wrote: > Hi All, > > This series started out as a single patch to add support for a new model > of alps touchpad, called PROTO_V7 in this patchset. > > While working on this I ended up doing some refactoring as preparation, which >

Re: [PATCH 14/14] alps: Add support for v7 devices

2014-07-25 Thread Dmitry Torokhov
Hi Hans, On Wed, Jul 09, 2014 at 05:24:19PM +0200, Hans de Goede wrote: > From: Yunkang Tang > > Such as found on the new Toshiba Portégé Z30-A and Z40-A. > > Signed-off-by: Yunkang Tang > [hdego...@redhat.com: Remove softbutton handling, this is done in userspace] > [hdego...@redhat.com: Repo

Re: [PATCH v2 06/10] Input - wacom: prepare the driver to include BT devices

2014-07-25 Thread Dmitry Torokhov
On Fri, Jul 25, 2014 at 11:25:17PM -0400, Benjamin Tissoires wrote: > On Jul 25 2014 or thereabouts, Dmitry Torokhov wrote: > > Hi Benjamin, > > > > On Thu, Jul 24, 2014 at 02:14:01PM -0400, Benjamin Tissoires wrote: > > > Now that wacom is a hid driver, there is no point in having a separate > >

Re: [PATCH v2 00/10] Input - wacom: conversion to HID driver, series 2

2014-07-25 Thread Dmitry Torokhov
On Fri, Jul 25, 2014 at 11:21:27PM -0400, Benjamin Tissoires wrote: > On Jul 25 2014 or thereabouts, Dmitry Torokhov wrote: > > Hi Benjamin, > > > > On Thu, Jul 24, 2014 at 02:13:55PM -0400, Benjamin Tissoires wrote: > > > Hi Dmitry, > > > > > > this is the second series I told you about for waco

Re: [PATCH v2 06/10] Input - wacom: prepare the driver to include BT devices

2014-07-25 Thread Benjamin Tissoires
On Jul 25 2014 or thereabouts, Dmitry Torokhov wrote: > Hi Benjamin, > > On Thu, Jul 24, 2014 at 02:14:01PM -0400, Benjamin Tissoires wrote: > > Now that wacom is a hid driver, there is no point in having a separate > > driver for bluetooth devices. > > This patch prepares the common paths of Blue

Re: [PATCH v2 00/10] Input - wacom: conversion to HID driver, series 2

2014-07-25 Thread Benjamin Tissoires
On Jul 25 2014 or thereabouts, Dmitry Torokhov wrote: > Hi Benjamin, > > On Thu, Jul 24, 2014 at 02:13:55PM -0400, Benjamin Tissoires wrote: > > Hi Dmitry, > > > > this is the second series I told you about for wacom.ko. This series also > > have > > a good number of removed lines of code. \o/ >

Re: [PATCH v2 00/10] Input - wacom: conversion to HID driver, series 2

2014-07-25 Thread Dmitry Torokhov
Hi Benjamin, On Thu, Jul 24, 2014 at 02:13:55PM -0400, Benjamin Tissoires wrote: > Hi Dmitry, > > this is the second series I told you about for wacom.ko. This series also have > a good number of removed lines of code. \o/ > > The first patch is Jason's one that I finally decided to take with me

Re: [PATCH v2 06/10] Input - wacom: prepare the driver to include BT devices

2014-07-25 Thread Dmitry Torokhov
Hi Benjamin, On Thu, Jul 24, 2014 at 02:14:01PM -0400, Benjamin Tissoires wrote: > Now that wacom is a hid driver, there is no point in having a separate > driver for bluetooth devices. > This patch prepares the common paths of Bluetooth devices in the > common wacom driver. > It also adds the sys

[PATCH] Input: synaptics - properly initialize slots for semi-MT

2014-07-25 Thread Dmitry Torokhov
Semi-MT devices are pointers too, so let's tell that to input_mt_init_slots(), as well as let it set up the devices as semi-MT, instead of us doing it manually. Reviewed-by: Daniel Kurtz Reviewed-by: Benson Leung Signed-off-by: Dmitry Torokhov --- drivers/input/mouse/synaptics.c | 6 +++--- 1

[PATCH 11/10] Input - wacom: Check for bluetooth protocol while setting OLEDs

2014-07-25 Thread Benjamin Tissoires
Bluetooth Intuos 4 use 1-bit definition while the USB ones use a 4-bits definition. This changes the size of the raw image we receive, and thus the kernel will only accept 1-bit images for Bluetooth and 4-bits for USB. Signed-off-by: Benjamin Tissoires --- drivers/hid/wacom_sys.c | 15 +-

Re: [PATCH v2 00/10] Input - wacom: conversion to HID driver, series 2

2014-07-25 Thread Benjamin Tissoires
Hi Przemo, On Jul 25 2014 or thereabouts, Przemo Firszt wrote: > Dnia 2014-07-24, czw o godzinie 14:13 -0400, Benjamin Tissoires pisze: > [..] > Hi Benjamin, > I'm testing the whole series including the OLED patch that's not on the > list yet. > > Hardware: 2 x Intuos4 Wireless tested on usb and

Re: [PATCH v2 00/10] Input - wacom: conversion to HID driver, series 2

2014-07-25 Thread Przemo Firszt
Dnia 2014-07-24, czw o godzinie 14:13 -0400, Benjamin Tissoires pisze: [..] Hi Benjamin, I'm testing the whole series including the OLED patch that's not on the list yet. Hardware: 2 x Intuos4 Wireless tested on usb and bluetooth until noted otherwise. What works: 1. Tablet in general, pressure,

Re: [PATCH v2] Input: add i2c/smbus driver for elan touchpad

2014-07-25 Thread Dmitry Torokhov
On Fri, Jul 25, 2014 at 11:20:53AM -0700, Dmitry Torokhov wrote: > Hi Duson, > > On Sat, Jul 26, 2014 at 02:05:02AM +0800, cheng wei Lin wrote: > > Hi Dmitry, > > > > Sorry for late to reply you and thanks for your command > > > > Yes, I also agree, it looks great than my original code. > > Tha

Re: [PATCH 00/15] atmel_mxt_ts - device tree, bootloader, etc

2014-07-25 Thread Stephen Warren
On 07/25/2014 08:10 AM, Nick Dyer wrote: On 24/07/14 22:19, Stephen Warren wrote: ... I've uploaded 2 logs to: http://avon.wwwdotorg.org/downloads/mxt-logs/ (note there's no directory indexing, so manually add the filenames below to the URL) mxt-save-no-movement.xml This is with the whole se

Re: [PATCH] Input: wacom_serial4 - prepare for wacom USB moving to HID

2014-07-25 Thread Dmitry Torokhov
On Fri, Jul 25, 2014 at 09:06:28PM +0200, Hans de Goede wrote: > Hi, > > On 07/24/2014 10:31 PM, Dmitry Torokhov wrote: > > wacom_wac.h will be moving to drivers/hid. Since we only need 3 definitions > > from it let's simply copy them over. > > > > Signed-off-by: Dmitry Torokhov > > Ack, but yo

Re: [PATCH v2 00/10] Input - wacom: conversion to HID driver, series 2

2014-07-25 Thread Benjamin Tissoires
On Jul 25 2014 or thereabouts, Przemo Firszt wrote: > Dnia 2014-07-25, pią o godzinie 10:54 -0400, Benjamin Tissoires pisze: > > [..] > Hi Benjamin, > > > > > If I understand you correctly we cannot have the same entry point in > > > sysfs for OLEDs unless we can tell userspace somehow if the tab

Re: [PATCH v2 00/10] Input - wacom: conversion to HID driver, series 2

2014-07-25 Thread Przemo Firszt
Dnia 2014-07-25, pią o godzinie 10:54 -0400, Benjamin Tissoires pisze: > [..] Hi Benjamin, > > > If I understand you correctly we cannot have the same entry point in > > sysfs for OLEDs unless we can tell userspace somehow if the tablet is > > conected over USB or over bluetooth. The hardware of

Re: [PATCH] hid: usbhid: Use flag HID_DISCONNECTED when a usb device is removed

2014-07-25 Thread Reyad Attiyat
The kernel panic happened when the iio sensor hid usb device was removed. It tries to set the power state by calling hid_hw_request(). This was on kernel 3.16-rc6 https://gist.github.com/soda0289/2ff543d9cfff6f92c360#file-kernel-panic-when-iio-sensor-usb-device-is-removed On Fri, Jul 25, 2014 at 1

Re: [PATCH] Input: wacom_serial4 - prepare for wacom USB moving to HID

2014-07-25 Thread Hans de Goede
Hi, On 07/24/2014 10:31 PM, Dmitry Torokhov wrote: > wacom_wac.h will be moving to drivers/hid. Since we only need 3 definitions > from it let's simply copy them over. > > Signed-off-by: Dmitry Torokhov Ack, but you will want to drop the #include of wacom_wac.h yoo. Regards, Hans > --- > dr

Re: [PATCH v2] Input: add i2c/smbus driver for elan touchpad

2014-07-25 Thread Dmitry Torokhov
Hi Duson, On Sat, Jul 26, 2014 at 02:05:02AM +0800, cheng wei Lin wrote: > Hi Dmitry, > > Sorry for late to reply you and thanks for your command > > Yes, I also agree, it looks great than my original code. Thank you for confirming. > So, should I modify this and upstream v3 patch for you? No

Re: [PATCH] input: drv260x: Introduce TI drv260x haptics driver

2014-07-25 Thread Murphy, Dan
On 07/24/2014 02:07 PM, Murphy, Dan wrote: > Add the TI drv260x haptics/vibrator driver. > This device uses the input force feedback > to produce a wave form to driver an > ERM or LRA actuator device. > > The initial driver supports the devices > real time playback mode. But the device > has addit

Re: [PATCH v2] Input: add i2c/smbus driver for elan touchpad

2014-07-25 Thread cheng wei Lin
Hi Dmitry, Sorry for late to reply you and thanks for your command Yes, I also agree, it looks great than my original code. So, should I modify this and upstream v3 patch for you? thank you, duson Dmitry Torokhov 於 2014/7/25 上午2:05 寫道: > Hi, > > On Tue, Jan 07, 2014 at 11:08:03AM +0800, Dus

Re: Linux 3.16-rc6

2014-07-25 Thread Waiman Long
On 07/24/2014 05:45 PM, Borislav Petkov wrote: On Thu, Jul 24, 2014 at 04:38:28PM -0400, Waiman Long wrote: Borislav, can you apply the following patch on top of the lockdep patch to see if it can fix the problem? It is too late here for me to test anything but the ingridients to reproduce are

Re: [PATCH v2] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

2014-07-25 Thread Dmitry Torokhov
Hi Pramod, On Fri, Jul 25, 2014 at 05:04:34PM +0530, pramod.gurav@gmail.com wrote: > From: Pramod Gurav > > This patch does below: > - Removes kfree done on data allocated with devm_zalloc in probe > path of the driver. > - Adds a check on return value from devm_kzalloc which was missing >

Re: Linux 3.16-rc6

2014-07-25 Thread Peter Zijlstra
On Thu, Jul 24, 2014 at 04:38:28PM -0400, Waiman Long wrote: > Yes, I think I may have a solution for that. > > Borislav, can you apply the following patch on top of the lockdep patch to > see if it can fix the problem? > > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c > index

Re: [PATCH v2 00/10] Input - wacom: conversion to HID driver, series 2

2014-07-25 Thread Benjamin Tissoires
On Jul 25 2014 or thereabouts, Przemo Firszt wrote: > Dnia 2014-07-25, pią o godzinie 08:58 -0400, Benjamin Tissoires pisze: > > Hi Przemo, > Hi Benjamin, > > On Jul 25 2014 or thereabouts, Przemo Firszt wrote: > > > Dnia 2014-07-24, czw o godzinie 14:13 -0400, Benjamin Tissoires pisze: > > > [..]

Re: [PATCH 00/15] atmel_mxt_ts - device tree, bootloader, etc

2014-07-25 Thread Nick Dyer
On 24/07/14 22:19, Stephen Warren wrote: >> mxt-app [device] --save fail.xcfg > > That command always experiences a timeout error, but still seems to dump > something out. Is this timeout error an issue? I'm a little hesitant to > modify the COMMSCONFIG settings until I know load/save are really w

Re: [PATCH v5 0/4] HID: lenovo: Add support for Lenovo Compact Keyboard

2014-07-25 Thread Antonio Ospite
On Wed, 23 Jul 2014 23:30:44 +0100 Jamie Lentin wrote: > This patchset follows on from my previous attempts to add support for > these keyboards from Lenovo. > > Antonio, I've used cptkbd_data and left data_pointer for now. It'd be > an easy patch to change data_pointer to tpkbd_data, but is dri

Re: [PATCH v5 4/4] HID: lenovo: Add support for Compact (BT|USB) keyboard

2014-07-25 Thread Antonio Ospite
On Wed, 23 Jul 2014 23:30:48 +0100 Jamie Lentin wrote: > Add support for both ThinkPad Compact Bluetooth Keyboard with > TrackPoint and ThinkPad Compact USB Keyboard with TrackPoint. > > Signed-off-by: Jamie Lentin I think this version is OK, thanks. Reviewed-by: Antonio Ospite > --- > Doc

Re: [PATCH v5 3/4] HID: lenovo: Style fixes

2014-07-25 Thread Antonio Ospite
On Wed, 23 Jul 2014 23:30:47 +0100 Jamie Lentin wrote: > Signed-off-by: Jamie Lentin Jamie, please send a v6 of this patch alone[*], where you print the return value as Dmitry suggested . You do print it in a similar statement of the subsequent patch, so this makes even more sense. FWIW I'd al

Re: [PATCH v2 00/10] Input - wacom: conversion to HID driver, series 2

2014-07-25 Thread Przemo Firszt
Dnia 2014-07-25, pią o godzinie 08:58 -0400, Benjamin Tissoires pisze: > Hi Przemo, Hi Benjamin, > On Jul 25 2014 or thereabouts, Przemo Firszt wrote: > > Dnia 2014-07-24, czw o godzinie 14:13 -0400, Benjamin Tissoires pisze: > > [..] > > > Hi Przemo, > > Hi Benjamin, > > > Normally, this series co

Re: [PATCH v2 00/10] Input - wacom: conversion to HID driver, series 2

2014-07-25 Thread Benjamin Tissoires
Hi Przemo, On Jul 25 2014 or thereabouts, Przemo Firszt wrote: > Dnia 2014-07-24, czw o godzinie 14:13 -0400, Benjamin Tissoires pisze: > [..] > > Hi Przemo, > Hi Benjamin, > > Normally, this series contains all the bits of hid-wacom (except the custom > > LED/OLED API). Please tell me if I am mis

Re: [PATCH v5 2/4] HID: lenovo: Prepare support for adding other devices

2014-07-25 Thread Antonio Ospite
On Wed, 23 Jul 2014 23:30:46 +0100 Jamie Lentin wrote: > Ensure all tpkbd specifics are within a postfixed function, the > main functions for the driver should just switch to the appropriate > function depending on product ID. Given this, we can add extra devices > by including extra postfixed fu

Re: [PATCH v5 1/4] HID: lenovo: Rename hid-lenovo-tpkbd to hid-lenovo

2014-07-25 Thread Antonio Ospite
On Wed, 23 Jul 2014 23:30:45 +0100 Jamie Lentin wrote: > Rename module and all functions within so we can add support for other > keyboards in the same file. Rename the _tp postfix to _tpkbd, to > signify functions relevant to the TP USB keyboard. > > Signed-off-by: Jamie Lentin Reviewed-by: A

Re: [PATCH v2 00/10] Input - wacom: conversion to HID driver, series 2

2014-07-25 Thread Przemo Firszt
Dnia 2014-07-24, czw o godzinie 14:13 -0400, Benjamin Tissoires pisze: [..] > Hi Przemo, Hi Benjamin, > Normally, this series contains all the bits of hid-wacom (except the custom > LED/OLED API). Please tell me if I am missing anything and if you like the > change. I can't cleanly apply your set

re: Input: atmel_mxt_ts - initialise IRQ before probing

2014-07-25 Thread Dan Carpenter
Hello Nick Dyer, The patch dd24dcf566d0: "Input: atmel_mxt_ts - initialise IRQ before probing" from Jul 23, 2014, leads to the following static checker warning: drivers/input/touchscreen/atmel_mxt_ts.c:1701 mxt_initialize() warn: we tested 'error' before and it was 'false' drivers/input

[PATCH v2] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

2014-07-25 Thread pramod . gurav . etc
From: Pramod Gurav This patch does below: - Removes kfree done on data allocated with devm_zalloc in probe path of the driver. - Adds a check on return value from devm_kzalloc which was missing CC: Dmitry Torokhov CC: Lejun Zhu CC: Sachin Kamat Signed-off-by: Pramod Gurav --- drivers/inp

Re: [PATCH v2] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

2014-07-25 Thread pramod gurav
On Fri, Jul 25, 2014 at 3:59 PM, Sachin Kamat wrote: > Hi Pramod, > > > On Fri, Jul 25, 2014 at 2:42 PM, wrote: >> From: Pramod Gurav >> >> This patch does below: >> - Removes kfree done on data allocated with devm_zalloc in probe >> path of the driver. >> - Adds a check on return value from

Re: [PATCH v2] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

2014-07-25 Thread Sachin Kamat
Hi Pramod, On Fri, Jul 25, 2014 at 2:42 PM, wrote: > From: Pramod Gurav > > This patch does below: > - Removes kfree done on data allocated with devm_zalloc in probe > path of the driver. > - Adds a check on return value from devm_kzalloc which was missing > - Removes the error lables and in

[PATCH v2] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

2014-07-25 Thread pramod . gurav . etc
From: Pramod Gurav This patch does below: - Removes kfree done on data allocated with devm_zalloc in probe path of the driver. - Adds a check on return value from devm_kzalloc which was missing - Removes the error lables and instead releases resources and returns after failures CC: Dmitry To

Re: [PATCH] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

2014-07-25 Thread David Rientjes
On Fri, 25 Jul 2014, Sachin Kamat wrote: > On Fri, Jul 25, 2014 at 12:39 PM, wrote: > > From: Pramod Gurav > > > > This patch does below: > > - Removes kfree done on data allocated with devm_zalloc in probe > > path of the driver. > > - Adds a check on return value from devm_kzalloc which was

Re: [PATCH] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

2014-07-25 Thread pramod gurav
Thanks Sachin for the review. Will resend the patch addressing your review comments. On Fri, Jul 25, 2014 at 1:59 PM, Sachin Kamat wrote: > On Fri, Jul 25, 2014 at 12:39 PM, wrote: >> From: Pramod Gurav >> >> This patch does below: >> - Removes kfree done on data allocated with devm_zalloc in

Re: [PATCH] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

2014-07-25 Thread Sachin Kamat
On Fri, Jul 25, 2014 at 12:39 PM, wrote: > From: Pramod Gurav > > This patch does below: > - Removes kfree done on data allocated with devm_zalloc in probe > path of the driver. > - Adds a check on return value from devm_kzalloc which was missing > and renames a lable from err_free_mem to er

[PATCH] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

2014-07-25 Thread pramod . gurav . etc
From: Pramod Gurav This patch does below: - Removes kfree done on data allocated with devm_zalloc in probe path of the driver. - Adds a check on return value from devm_kzalloc which was missing and renames a lable from err_free_mem to err_mem. - Adds couple of dev_err on failure to allocate m