Re: [PATCH] Input: serio: make HYPERV_KEYBOARD depend on SERIO_I8042=y

2014-08-11 Thread Greg KH
On Tue, Aug 12, 2014 at 05:51:28AM +, Dexuan Cui wrote: > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > > Decoupling the dependency between hyperv_keyboard and i8042 needs > > > non-trivial efforts and is hence a long term goal. > > > > > > For now, let'

RE: [PATCH] Input: serio: make HYPERV_KEYBOARD depend on SERIO_I8042=y

2014-08-11 Thread Dexuan Cui
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Decoupling the dependency between hyperv_keyboard and i8042 needs > > non-trivial efforts and is hence a long term goal. > > > > For now, let's make the dependency explicit so people can beware of this. > > You did

Re: [PATCH] Input: serio: make HYPERV_KEYBOARD depend on SERIO_I8042=y

2014-08-11 Thread Greg KH
On Mon, Aug 11, 2014 at 08:30:40PM -0700, Dexuan Cui wrote: > hyperv_keyboard invokes serio_interrupt(), which needs a valid serio driver > like atkbd.c. > atkbd.c depends on libps2.c because it invokes ps2_command(). > libps2.c depends on i8042.c because it invokes i8042_check_port_owner(). > As a

[PATCH] Input: serio: make HYPERV_KEYBOARD depend on SERIO_I8042=y

2014-08-11 Thread Dexuan Cui
hyperv_keyboard invokes serio_interrupt(), which needs a valid serio driver like atkbd.c. atkbd.c depends on libps2.c because it invokes ps2_command(). libps2.c depends on i8042.c because it invokes i8042_check_port_owner(). As a result, hyperv_keyboard actually depends on i8042.c. For a Generatio

Re: HID: huion: Switch to generating report descriptor

2014-08-11 Thread Nikolai Kondrashov
Hi Dan, On 07/31/2014 12:40 PM, Dan Carpenter wrote: The patch f8dd5cb2c6d0: "HID: huion: Switch to generating report descriptor" from Jul 23, 2014, leads to the following static checker warning: drivers/hid/hid-huion.c:126 huion_tablet_enable() error: doing dma on the stack (bu

[PATCH] Input: atmel_mxt_ts - fix a few issues reported by Coverity

2014-08-11 Thread Dmitry Torokhov
This should fix the following issues reported by Coverity: *** CID 1230625: Logically dead code (DEADCODE) /drivers/input/touchscreen/atmel_mxt_ts.c: 1692 in mxt_initialize() *** CID 1230627: Missing break in switch (MISSING_BREAK) /drivers/input/touchscreen/atmel_mxt_ts.c: 1436 in mxt_get_ob

[PATCH 1/2] HID: huion: Fail on parameter retrieval errors

2014-08-11 Thread Nikolai Kondrashov
Fail Huion tablet interface enabling and probing, if parameter retrieval fails. Move the main code path out of the else block accordingly. This should prevent devices appearing in a half-working state due to original report descriptor being used, simplifying diagnostics. This also makes it easier

[PATCHES] HID: huion: Fix "doing dma on the stack"

2014-08-11 Thread Nikolai Kondrashov
Hi everyone, These two patches work towards fixing the "doing dma on the stack" reported by a static analyzer (I'm not sure which one) for my recent changes to hid-huion driver. The first one is easier to read with whitespace changes ingored (-w). Both patches were tested by me with a Huion H610

[PATCH 2/2] HID: huion: Use allocated buffer for DMA

2014-08-11 Thread Nikolai Kondrashov
Allocate a buffer with kmalloc for receiving the parameters string descriptor with usb_control_msg, instead of using a buffer on the stack, as the latter is unsafe. Use an enum for indices into the buffer to ensure the buffer size if sufficient. This fixes the static checker error "doing dma on th

[PATCH] input/joystick: use get_cycles on ARMv8

2014-08-11 Thread Mark Brown
From: Mark Brown As with ARM the ARMv8 architecture provides a cycle counter which can be used to provide a high resolution time for the joystick driver and silence the build warning that results from not having a precise timer on ARMv8, making allmodconfig and allyesconfig quieter. Signed-off-b

Re: [PATCH] Input: wacom - Fix compiler warning if !CONFIG_PM

2014-08-11 Thread Benjamin Tissoires
On Aug 09 2014 or thereabouts, Jiri Kosina wrote: > On Sat, 9 Aug 2014, Geert Uytterhoeven wrote: > > > If CONFIG_PM is not set: > > > > drivers/hid/wacom_sys.c:1436: warning: ‘wacom_reset_resume’ defined but > > not used > > > > Protect the unused functions by #ifdef CONFIG_PM to fix this. > >

autoloading of modules failes

2014-08-11 Thread Christian Gmeiner
Hi all. I finally want to mainline the ar1021 input driver but the only bit which is missing is autoloading via device-tree. I have sent an RFC [0] some long time ago for the driver and it looked okay. Maybe someone has time to help me to get automatic loading working so that I can send the fina

Re: [RFC RESEND 5/5] Input: evdev - add new EVIOCGABSRANGE ioctl

2014-08-11 Thread David Herrmann
Hi On Mon, Aug 11, 2014 at 4:13 AM, Peter Hutterer wrote: > On Sun, Aug 10, 2014 at 05:01:35PM -0700, Dmitry Torokhov wrote: > [...] >> > > >> > >is about handling corner-cases. If we make SYN_DROPPED >> > >handling cause SYN_DROPPED, we can just ignore it. >> > >> > yep, that too was my

Re: [RFC RESEND 5/5] Input: evdev - add new EVIOCGABSRANGE ioctl

2014-08-11 Thread David Herrmann
Hi >> > No, it is more like EVIOCRESYNC(void) which makes input core to dump all >> > existing state into the client's standard event queue so that here is no >> > need to reconcile/reconstruct anything. We could give a new SYN marker >> > to indicate end-of-state boundary. >> >> This doesn't make

Re: [PATCH v2 1/1] Input: atmel_mxt_ts - Get IRQ edge/level flags on DT booting

2014-08-11 Thread Javier Martinez Canillas
Hello Linus, On 08/11/2014 10:32 AM, Linus Walleij wrote: > I guess this discussion is about drivers/pinctrl/samsung/pinctrl-exynos.c? > > Or else I'm not really following this... $SUBJECT is a bit confusing. > Yes, the thing is that at the beginning I (wrongly) thought that the IRQ trigger typ

Re: [PATCH v2 1/1] Input: atmel_mxt_ts - Get IRQ edge/level flags on DT booting

2014-08-11 Thread Linus Walleij
I guess this discussion is about drivers/pinctrl/samsung/pinctrl-exynos.c? Or else I'm not really following this... $SUBJECT is a bit confusing. On Sat, Aug 9, 2014 at 12:26 AM, Javier Martinez Canillas wrote: > Regardless of this though I think that both the patch to move the IRQ > pinmux setu