RE: [PATCH] Input: serio: make HYPERV_KEYBOARD depend on SERIO_I8042=y

2014-08-13 Thread Dexuan Cui
> -Original Message- > From: Dmitry Torokhov > > How about this: > > in libps2.c let's add and export a function pointer > > i8042_lock_chip_if_port_owner: it is used to replace the current > > if (i8042_check_port_owner(ps2dev->serio)) > > i8042_lock_chip(); > > The functi

Re: [PATCH] Input: Remove superfluous assignment in edt_ft5x06_register_write()

2014-08-13 Thread Dmitry Torokhov
On Wed, Aug 13, 2014 at 01:00:05PM -0700, Maks Naumov wrote: > Signed-off-by: Maks Naumov Applied, thank you. > --- > drivers/input/touchscreen/edt-ft5x06.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/input/touchscreen/edt-ft5x06.c > b/drivers/input/touchscreen/edt-ft5x06.

[PATCH] Input: Remove superfluous assignment in edt_ft5x06_register_write()

2014-08-13 Thread Maks Naumov
Signed-off-by: Maks Naumov --- drivers/input/touchscreen/edt-ft5x06.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c index 5a6d50c..8857d5b 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/

Re: [Question: Drivers/input/evdev.c] What is the use of write function in evdev_fops?

2014-08-13 Thread Aniroop Mathur
On Thu, Aug 14, 2014 at 1:12 AM, Dmitry Torokhov wrote: > On August 13, 2014 12:28:46 PM PDT, Aniroop Mathur > wrote: >>On Thu, Aug 14, 2014 at 12:50 AM, Dmitry Torokhov >> wrote: >>> On August 13, 2014 12:10:16 PM PDT, Aniroop Mathur >> wrote: On Thu, Aug 14, 2014 at 12:28 AM, Dmitry Torokh

Re: [Question: Drivers/input/evdev.c] What is the use of write function in evdev_fops?

2014-08-13 Thread Dmitry Torokhov
On August 13, 2014 12:28:46 PM PDT, Aniroop Mathur wrote: >On Thu, Aug 14, 2014 at 12:50 AM, Dmitry Torokhov > wrote: >> On August 13, 2014 12:10:16 PM PDT, Aniroop Mathur > wrote: >>>On Thu, Aug 14, 2014 at 12:28 AM, Dmitry Torokhov >>> wrote: On Wed, Aug 13, 2014 at 11:41:20PM +0530, Aniro

Re: [Question: Drivers/input/evdev.c] What is the use of write function in evdev_fops?

2014-08-13 Thread Aniroop Mathur
On Thu, Aug 14, 2014 at 12:50 AM, Dmitry Torokhov wrote: > On August 13, 2014 12:10:16 PM PDT, Aniroop Mathur > wrote: >>On Thu, Aug 14, 2014 at 12:28 AM, Dmitry Torokhov >> wrote: >>> On Wed, Aug 13, 2014 at 11:41:20PM +0530, Aniroop Mathur wrote: Hello Mr. Torokhov :) On Wed, Au

Re: [Question: Drivers/input/evdev.c] What is the use of write function in evdev_fops?

2014-08-13 Thread Dmitry Torokhov
On August 13, 2014 12:10:16 PM PDT, Aniroop Mathur wrote: >On Thu, Aug 14, 2014 at 12:28 AM, Dmitry Torokhov > wrote: >> On Wed, Aug 13, 2014 at 11:41:20PM +0530, Aniroop Mathur wrote: >>> Hello Mr. Torokhov :) >>> >>> On Wed, Aug 13, 2014 at 10:36 PM, Dmitry Torokhov >>> wrote: >>> > Hi Aniroop

Re: [Question: Drivers/input/evdev.c] What is the use of write function in evdev_fops?

2014-08-13 Thread Aniroop Mathur
On Thu, Aug 14, 2014 at 12:28 AM, Dmitry Torokhov wrote: > On Wed, Aug 13, 2014 at 11:41:20PM +0530, Aniroop Mathur wrote: >> Hello Mr. Torokhov :) >> >> On Wed, Aug 13, 2014 at 10:36 PM, Dmitry Torokhov >> wrote: >> > Hi Aniroop, >> > >> > On Wed, Aug 13, 2014 at 10:16:34PM +0530, Aniroop Mathur

Re: [Question: Drivers/input/evdev.c] What is the use of write function in evdev_fops?

2014-08-13 Thread Dmitry Torokhov
On Wed, Aug 13, 2014 at 11:41:20PM +0530, Aniroop Mathur wrote: > Hello Mr. Torokhov :) > > On Wed, Aug 13, 2014 at 10:36 PM, Dmitry Torokhov > wrote: > > Hi Aniroop, > > > > On Wed, Aug 13, 2014 at 10:16:34PM +0530, Aniroop Mathur wrote: > >> Dear Mr. Torokhov and Linux-Input Community, > >> Gre

Re: [Question: Drivers/input/evdev.c] What is the use of write function in evdev_fops?

2014-08-13 Thread Aniroop Mathur
Hello Mr. Torokhov :) On Wed, Aug 13, 2014 at 10:36 PM, Dmitry Torokhov wrote: > Hi Aniroop, > > On Wed, Aug 13, 2014 at 10:16:34PM +0530, Aniroop Mathur wrote: >> Dear Mr. Torokhov and Linux-Input Community, >> Greetings of the day !! :) >> >> I have not seen some good use of write function in i

Re: [Question: Drivers/input/evdev.c] What is the use of write function in evdev_fops?

2014-08-13 Thread Dmitry Torokhov
Hi Aniroop, On Wed, Aug 13, 2014 at 10:16:34PM +0530, Aniroop Mathur wrote: > Dear Mr. Torokhov and Linux-Input Community, > Greetings of the day !! :) > > I have not seen some good use of write function in input subsystem. > I am trying find the good uses of write function in Input subsystem, >

[Question: Drivers/input/evdev.c] What is the use of write function in evdev_fops?

2014-08-13 Thread Aniroop Mathur
Dear Mr. Torokhov and Linux-Input Community, Greetings of the day !! :) I have not seen some good use of write function in input subsystem. I am trying find the good uses of write function in Input subsystem, but could not find the solution over internet. Can you please help in answering my query

Re: [PATCH] Input: atmel_mxt_ts - fix a few issues reported by Coverity

2014-08-13 Thread Dmitry Torokhov
On Tue, Aug 12, 2014 at 10:08:48PM +0100, Nick Dyer wrote: > On 12/08/14 17:41, Stephen Warren wrote: > >> I've reviewed these changes and they look correct to me. Apologies that > >> they slipped through, most of it is bad merging on my part I think. > >> > >> Signed-off-by: Nick Dyer > > > > Do

Re: [PATCH] Input: serio: make HYPERV_KEYBOARD depend on SERIO_I8042=y

2014-08-13 Thread Dmitry Torokhov
On Wed, Aug 13, 2014 at 05:24:35AM +, Dexuan Cui wrote: > > -Original Message- > > From: Dmitry Torokhov > > Sent: Wednesday, August 13, 2014 1:55 AM > > > > > To decouple the dependency between the hyperv-keyboard and i8042 > > > > > modules, I suppose we probably have to re-implement

Re: [PATCH v5] input: drv260x: Add TI drv260x haptics driver

2014-08-13 Thread Mark Rutland
Hi Dan, Apologies for the delay. On Thu, Jul 31, 2014 at 08:14:49PM +0100, Dan Murphy wrote: > Add the TI drv260x haptics/vibrator driver. > This device uses the input force feedback > to produce a wave form to driver an > ERM or LRA actuator device. > > The initial driver supports the devices >

Re: [PATCH] hid: Add mapping for special keys on compaq ku 0133 keyboard

2014-08-13 Thread Hans de Goede
Hi, On 08/13/2014 01:35 AM, Dmitry Torokhov wrote: > On Wed, Aug 13, 2014 at 01:14:50AM +0200, Hans de Goede wrote: >> The compaq ku 0133 keyboard has 8 special keys at the top: >> http://lackof.org/taggart/hacking/keyboard/cpqwireless.jpg >> >> 3 of these use standard HID usage codes from the con

Re: [RESEND: PATCH 1/2] mfd: tc3589x: Add device tree bindings

2014-08-13 Thread Lee Jones
On Tue, 12 Aug 2014, Linus Walleij wrote: > On Tue, Jun 17, 2014 at 10:23 PM, Lee Jones wrote: > > On Wed, 09 Apr 2014, Linus Walleij wrote: > > > >> This defines the device tree bindings for the Toshiba TC3589x > >> series of multi-purpose expanders. Only the stuff I can test > >> is defined: GP

[PATCH RESEND RESEND] Input: evdev - add event-mask API

2014-08-13 Thread David Herrmann
Hardware manufacturers group keys in the weirdest way possible. This may cause a power-key to be grouped together with normal keyboard keys and thus be reported on the same kernel interface. However, user-space is often only interested in specific sets of events. For instance, daemons dealing with