We can do once the test of the validity of the dj_device, which removes
some duplicated code in various functions.
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid-logitech-dj.c | 35 +++
1 file changed, 11 insertions(+), 24 deletions(-)
diff --git a/drivers
Commit "HID: logitech: perform bounds checking on device_id early
enough" unfortunately leaks some errors to dmesg which are not real
ones:
- if the report is not a DJ one, then there is not point in checking
the device_id
- the receiver (index 0) can also receive some notifications which
can b
On Sat, 23 Aug 2014, vichy wrote:
> from your patch, I have some questions:
> a. in Alan's version, if both HID_CLEAR_HALT and HID_RESET_PENDING are
> set, hid_reset will both "clear ep halt" and "reset devcie".
> But in original one, even HID_CLEAR_HALT and HID_RESET_PENDING are
> both set, hid_r
hi alan and all:
> I recently posted (but did not submit) a more comprehensive solution to
> this and other related problems. For example, HID devices typically
> run at low speed or full speed. When attached through a hub to an EHCI
> controller (very common on modern systems), unplugging the d
On Fri, Aug 22, 2014 at 12:12:19PM -0500, Dan Murphy wrote:
> Update the drv260x dt binding document:
> - Change the node name to the devices function not the
> device name.
> - Add vbat-supply to the example.
> - Fix indentation of the example.
>
> Signed-off-by: Dan Murphy
Reviewed-by: Felipe
Update the drv260x dt binding document:
- Change the node name to the devices function not the
device name.
- Add vbat-supply to the example.
- Fix indentation of the example.
Signed-off-by: Dan Murphy
---
v2 - Address comments on indentation, node declaration, add vbat-supply,
removed descripti
Felipe
On 08/22/2014 09:45 AM, Balbi, Felipe wrote:
> Hi,
>
> On Fri, Aug 22, 2014 at 09:25:13AM -0500, Murphy, Dan wrote:
>> Felipe
>>
>> On 08/22/2014 09:15 AM, Balbi, Felipe wrote:
>>> On Fri, Aug 22, 2014 at 09:12:21AM -0500, Dan Murphy wrote:
Update the drv260x dt binding document:
Hi,
On Fri, Aug 22, 2014 at 09:25:13AM -0500, Murphy, Dan wrote:
> Felipe
>
> On 08/22/2014 09:15 AM, Balbi, Felipe wrote:
> > On Fri, Aug 22, 2014 at 09:12:21AM -0500, Dan Murphy wrote:
> >> Update the drv260x dt binding document:
> >> - Change the node name to the devices function not the
> >>
On Aug 22 2014 or thereabouts, Markus Trippelsdorf wrote:
> On 2014.08.22 at 03:00 -0500, Jiri Kosina wrote:
> > On Fri, 22 Aug 2014, Markus Trippelsdorf wrote:
> >
> > > > HID: logitech: perform bounds checking on device_id early enough
> > >
> > > The commit above (ad3e14d7c5268c2e) cause
Felipe
On 08/22/2014 09:15 AM, Balbi, Felipe wrote:
> On Fri, Aug 22, 2014 at 09:12:21AM -0500, Dan Murphy wrote:
>> Update the drv260x dt binding document:
>> - Change the node name to the devices function not the
>> device name.
>> - Add vbat-supply to the example.
>> - Fix indentation of the ex
On Fri, Aug 22, 2014 at 09:12:21AM -0500, Dan Murphy wrote:
> Update the drv260x dt binding document:
> - Change the node name to the devices function not the
> device name.
> - Add vbat-supply to the example.
> - Fix indentation of the example.
>
> Signed-off-by: Dan Murphy
> ---
> .../devicetr
Add a check to ensure that LRA libraries are not mixed with
the ERM mode.
If ERM mode and the Library is empty "OR" the
LRA library then exit.
As the LRA and empty libraries are not applicable for
the ERM actuator.
Signed-off-by: Dan Murphy
---
drivers/input/misc/drv260x.c |8
1 f
Update the drv260x dt binding document:
- Change the node name to the devices function not the
device name.
- Add vbat-supply to the example.
- Fix indentation of the example.
Signed-off-by: Dan Murphy
---
.../devicetree/bindings/input/ti,drv260x.txt | 19 ++-
1 file chan
Removing some #defines that are not and should
never be used pertaining to I2C.
Removing:
define DRV260X_ALLOWED_R_BYTES 25
define DRV260X_ALLOWED_W_BYTES 2
define DRV260X_MAX_RW_RETRIES 5
define DRV260X_I2C_RETRY_DELAY 10
Signed-off-by: Dan Murphy
---
drivers/input/misc/drv260x.c |5 --
On Fri, 22 Aug 2014, vichy wrote:
> hi Jiri:
>
> 2014-08-22 15:45 GMT+08:00 Jiri Kosina :
> > On Fri, 22 Aug 2014, CheChun Kuo wrote:
> >
> >> HID IR device will not response to any command send from host when
> >> it is finishing paring and tring to reset itself. During this period of
> >>
Hello Lee,
On 08/21/2014 04:25 PM, Lee Jones wrote:
>>
>> static const struct mfd_cell cros_devs[] = {
>> -{
>> -.name = "cros-ec-keyb",
>> -.id = 1,
>> -.of_compatible = "google,cros-ec-keyb",
>> -},
>> -{
>> -.name = "cros-ec-i2c-tun
Hello Lee,
Thanks a lot for your feedback.
On 08/21/2014 04:21 PM, Lee Jones wrote:
> On Wed, 20 Aug 2014, Javier Martinez Canillas wrote:
>
>> From: Andrew Bresticker
>>
>> When an EC command returns EC_RES_IN_PROGRESS, we need to query
>> the state of the EC until it indicates that it is no
hi Jiri:
2014-08-22 15:45 GMT+08:00 Jiri Kosina :
> On Fri, 22 Aug 2014, CheChun Kuo wrote:
>
>> HID IR device will not response to any command send from host when
>> it is finishing paring and tring to reset itself. During this period of
>> time, usb_cleaer_halt will be fail and if hid_star
> -Original Message-
> From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com]
> Sent: Friday, August 22, 2014 2:29 AM
> To: Dudley Du
> Cc: Rafael J. Wysocki; Benson Leung; Patrik Fimml;
> linux-input@vger.kernel.org;
> linux-ker...@vger.kernel.org; Dudley Du
> Subject: Re: [PATCH v4 4
Dmitry,
Thanks for your feedback.
Thanks,
Dudley
> -Original Message-
> From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com]
> Sent: Friday, August 22, 2014 2:21 AM
> To: Dudley Du
> Cc: Rafael J. Wysocki; Benson Leung; Patrik Fimml;
> linux-input@vger.kernel.org;
> linux-ker...@vge
On 2014.08.22 at 03:00 -0500, Jiri Kosina wrote:
> On Fri, 22 Aug 2014, Markus Trippelsdorf wrote:
>
> > > HID: logitech: perform bounds checking on device_id early enough
> >
> > The commit above (ad3e14d7c5268c2e) causes the bounds checking to always
> > fail on my monolithic kernel (with
On Fri, 22 Aug 2014, Markus Trippelsdorf wrote:
> > HID: logitech: perform bounds checking on device_id early enough
>
> The commit above (ad3e14d7c5268c2e) causes the bounds checking to always
> fail on my monolithic kernel (without modules):
>
> ...
> [2.922617] usb 4-2: new full-spe
On 2014.08.21 at 12:43 -0500, Jiri Kosina wrote:
> HID: logitech: perform bounds checking on device_id early enough
The commit above (ad3e14d7c5268c2e) causes the bounds checking to always
fail on my monolithic kernel (without modules):
...
[2.922617] usb 4-2: new full-speed USB device
On Fri, 22 Aug 2014, CheChun Kuo wrote:
> HID IR device will not response to any command send from host when
> it is finishing paring and tring to reset itself. During this period of
> time, usb_cleaer_halt will be fail and if hid_start_in soon again, we
> has the possibility trap in infi
HID IR device will not response to any command send from host when it
is finishing paring and tring to reset itself.
During this period of time, usb_cleaer_halt will be fail and if hid_start_in
soon again, we has the possibility trap in infinite loop.
Signed-off-by: CheChun Kuo
---
dri
25 matches
Mail list logo
