Re: [PATCH 11/15] sound: soc: poodle: make use of new locomo GPIO interface

2014-10-31 Thread Alexandre Courbot
On Fri, Oct 31, 2014 at 6:58 PM, Dmitry Eremin-Solenikov wrote: > 2014-10-31 12:52 GMT+03:00 Linus Walleij : >> On Wed, Oct 29, 2014 at 4:03 AM, Alexandre Courbot wrote: >>> On Tue, Oct 28, 2014 at 11:58 PM, Mark Brown wrote: On Tue, Oct 28, 2014 at 03:02:04AM +0300, Dmitry Eremin-Solenikov

Re: [PATCH v2] Input: i8042 - add mux quirk for HP EliteBook

2014-10-31 Thread Dmitry Torokhov
On Tue, Oct 28, 2014 at 04:08:41PM -0700, Dmitry Torokhov wrote: > On Tue, Oct 28, 2014 at 10:27:12PM +, Luis Henriques wrote: > > This laptop requires active multiplexing to be enabled in order to be able > > to separate the PS/2 mouse and the touchpad. > > > > Signed-off-by: Luis Henriques

Re: [PATCH 1/2] Introduces Plantronics driver to fix errant mouse events.

2014-10-31 Thread Benjamin Tissoires
On Fri, Oct 31, 2014 at 3:20 PM, Cole, JD wrote: > This version of the driver prevents Telephony pages which are not > mapped as Consumer Control applications AND are not on the Consumer Page > from being registered by the hid-input driver. > > Signed-off-by: JD Cole > --- > drivers/hid/Kconfig

Re: [PATCH 2/2] Added missing HID Consumer Page identifiers, for completeness.

2014-10-31 Thread JD Cole
On Oct 31, 2014, at 12:23 PM, Cole, JD wrote: > Adds CA and NAry usage type identifiers. > > Signed-off-by: JD Cole > --- > include/linux/hid.h | 24 > 1 file changed, 24 insertions(+) > > diff --git a/include/linux/hid.h b/include/linux/hid.h Tabs fixed. Adds CA an

Re: [PATCH 1/2] Introduces Plantronics driver to fix errant mouse events.

2014-10-31 Thread Dmitry Torokhov
On Fri, Oct 31, 2014 at 05:34:42PM -0700, JD Cole wrote: > Dmitry, > > On Oct 31, 2014, at 4:53 PM, dmitry.torok...@gmail.com wrote: > > > Hi JD, > > > > On Fri, Oct 31, 2014 at 07:20:13PM +, Cole, JD wrote: > >> This version of the driver prevents Telephony pages which are not > >> mapped a

Re: [PATCH 1/2] Introduces Plantronics driver to fix errant mouse events.

2014-10-31 Thread JD Cole
Dmitry, On Oct 31, 2014, at 4:53 PM, dmitry.torok...@gmail.com wrote: > Hi JD, > > On Fri, Oct 31, 2014 at 07:20:13PM +, Cole, JD wrote: >> This version of the driver prevents Telephony pages which are not >> mapped as Consumer Control applications AND are not on the Consumer Page >> from be

Re: [PATCH 1/2] Introduces Plantronics driver to fix errant mouse events.

2014-10-31 Thread dmitry.torok...@gmail.com
Hi JD, On Fri, Oct 31, 2014 at 07:20:13PM +, Cole, JD wrote: > This version of the driver prevents Telephony pages which are not > mapped as Consumer Control applications AND are not on the Consumer Page > from being registered by the hid-input driver. > > Signed-off-by: JD Cole > --- > driv

[git pull] Input updates for 3.18-rc0

2014-10-31 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. You will get a bunch of fixes for minor defects reported by Cover

Re: Problems with Wacom Intuos PT M (CTH680) on FreeBSD

2014-10-31 Thread Ping Cheng
Hi Hans, On Wed, Oct 22, 2014 at 10:54 PM, Hans Petter Selasky wrote: > > On 10/23/14 06:54, Denis Akiyakov wrote: >> >> On 22.10.2014 05:33, Dmitry Torokhov wrote: >>> >>> Hi Denis, >>> >>> On Sat, Oct 18, 2014 at 05:56:48PM +0700, Denis Akiyakov wrote: Hello, I'm using FreeB

Re: [PATCH v3] psmouse: Add some support for the FocalTech PS/2 protocol extensions.

2014-10-31 Thread Mathias Gottschlag
Am 31.10.2014 um 14:29 schrieb Hans de Goede: > Hi Mathias, > > Thanks for your continued work on this. 3 remarks online + 1 at the bottom. > > On 10/30/2014 07:33 PM, Mathias Gottschlag wrote: >> Most of the protocol for these touchpads has been reverse engineered. This >> commit adds a basic mult

Re: [PATCH 3/4] arm: boot: dts: am335x-evm: Make charge delay a DT parameter for tsc

2014-10-31 Thread Hartmut Knaack
Vignesh R schrieb am 27.10.2014 12:08: > The charge delay value is by default 0xB000. But it can be set to lower > values on some boards as long as false pen-ups are avoided. Lowering the > value increases the sampling rate (though current sampling rate is > sufficient for tsc operation). Hence cha

Re: [PATCH 1/4] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps

2014-10-31 Thread Hartmut Knaack
Vignesh R schrieb am 27.10.2014 12:08: > From: Brad Griffis > > This patch makes the initial changes required to workaround TSC-false > pen-up interrupts. It is required to implement these changes in order to > remove udelay in the TSC interrupt handler and false pen-up events. > The charge step

[PATCH 2/2] Added missing HID Consumer Page identifiers, for completeness.

2014-10-31 Thread Cole, JD
Adds CA and NAry usage type identifiers. Signed-off-by: JD Cole --- include/linux/hid.h | 24 1 file changed, 24 insertions(+) diff --git a/include/linux/hid.h b/include/linux/hid.h index a63f2aa..58a89ed 100644 --- a/include/linux/hid.h +++ b/include/linux/hid.h @@ -23

[PATCH 1/2] Introduces Plantronics driver to fix errant mouse events.

2014-10-31 Thread Cole, JD
This version of the driver prevents Telephony pages which are not mapped as Consumer Control applications AND are not on the Consumer Page from being registered by the hid-input driver. Signed-off-by: JD Cole --- drivers/hid/Kconfig |7 drivers/hid/Makefile |1 + dri

RE: [PATCH] input: add gpio based irq support to Elan touchpad

2014-10-31 Thread Krishnamoorthy, Jagadish
Hello Dmitry, Ok. Agreed, we can't change all the drivers to accommodate gpio based irq option, will not promote this patch. Thanks for the review. -Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Thursday, October 30, 2014 3:12 PM To: Krishnamoorthy, Jag

ASUS X200MA Touchpad scrolling not working

2014-10-31 Thread Pilot6
[1.] [ASUS X200MA] Touchpad scrolling not working [2.] Touchpad is detected as a mouse. It works, but no multitouch, no scrolling. pilot6@X200MA:~$ xinput --list ⎡ Virtual core pointer id=2 [master pointer (3)] ⎜ ↳ Virtual core XTEST pointer id=4 [slave pointer (2)] ⎜ ↳ PS/2 Logitech Wheel Mou

Re: Problems with Elantech touchpad in 3.18-rc2

2014-10-31 Thread Dmitry Torokhov
On Fri, Oct 31, 2014 at 06:30:40PM +0100, Pavel Machek wrote: > On Fri 2014-10-31 09:24:36, Dmitry Torokhov wrote: > > On Thu, Oct 30, 2014 at 12:25:06PM -0700, Dmitry Torokhov wrote: > > > On Thu, Oct 30, 2014 at 12:06:03PM -0700, Linus Torvalds wrote: > > > > On Thu, Oct 30, 2014 at 11:03 AM, Dmi

Re: Problems with Elantech touchpad in 3.18-rc2

2014-10-31 Thread Pavel Machek
On Fri 2014-10-31 09:24:36, Dmitry Torokhov wrote: > On Thu, Oct 30, 2014 at 12:25:06PM -0700, Dmitry Torokhov wrote: > > On Thu, Oct 30, 2014 at 12:06:03PM -0700, Linus Torvalds wrote: > > > On Thu, Oct 30, 2014 at 11:03 AM, Dmitry Torokhov > > > wrote: > > > > > > > > Linus, any guidance here? C

Re: [PATCH 1/3] Input: altera_ps2 - write to correct register when disabling interrupts

2014-10-31 Thread Dmitry Torokhov
On Fri, Oct 31, 2014 at 01:41:29PM +0100, Tobias Klauser wrote: > In altera_ps2_close, the data register (offset 0) is written instead of > the control register (offset 4), leading to the RX interrupt not being > disabled. Fix this by calling writel() with the offset for the proper > register. > >

Re: [PATCH 2/2] Input: synaptics: remove duplicated code

2014-10-31 Thread Dmitry Torokhov
+ Daniel & Chung-yih On Thu, Oct 30, 2014 at 02:33:07PM -0400, Benjamin Tissoires wrote: > synaptics_profile_sensor_process() and synaptics_report_mt_data() now > share the exact same code. Remove one implementation and rely on the > other where it was used. > > Signed-off-by: Benjamin Tissoires

Re: [PATCH 1/2] Input: synaptics: Use in-kernel tracking for reporting mt data

2014-10-31 Thread Dmitry Torokhov
On Thu, Oct 30, 2014 at 02:33:06PM -0400, Benjamin Tissoires wrote: > The current code tries to consider all states and transitions to properly > detect which finger is attached to which slot. The code is quite huge > and difficult to read. > If the sensor manages to group the touch points but is n

Re: [PATCH] i8042: Add noloop quirk for Asus X750LN

2014-10-31 Thread Dmitry Torokhov
On Fri, Oct 31, 2014 at 09:21:53AM +0100, Hans de Goede wrote: > Hi, > > On 10/30/2014 07:34 PM, Dmitry Torokhov wrote: > > On Sat, Oct 11, 2014 at 11:35:23AM -0700, Dmitry Torokhov wrote: > >> On Sat, Oct 11, 2014 at 03:09:06PM +0200, Hans de Goede wrote: > >>> Without this the aux port does not

Re: [PATCH v3] Input: driver for the Goodix touchpanel

2014-10-31 Thread Dmitry Torokhov
On Wed, Oct 29, 2014 at 10:49:50AM -0400, Benjamin Tissoires wrote: > On Tue, Oct 28, 2014 at 8:54 PM, Bastien Nocera wrote: > > Add a driver for the Goodix touchscreen panel found in Onda v975w > > tablets. The driver is based off the Android driver gt9xx.c found > > in some Android code dumps, b

Re: Problems with Elantech touchpad in 3.18-rc2

2014-10-31 Thread Dmitry Torokhov
On Thu, Oct 30, 2014 at 12:25:06PM -0700, Dmitry Torokhov wrote: > On Thu, Oct 30, 2014 at 12:06:03PM -0700, Linus Torvalds wrote: > > On Thu, Oct 30, 2014 at 11:03 AM, Dmitry Torokhov > > wrote: > > > > > > Linus, any guidance here? Can we live with such regression? > > > > No. If people are alr

[PATCH 1/1] x86: Surface Pro 3 Type Cover 3

2014-10-31 Thread Alan Wu
From: alanwu Surface Pro 3 Type Cover that works with Ubuntu (and possibly Arch) from this thread. Both trackpad and keyboard work after compiling my own kernel. http://ubuntuforums.org/showthread.php?t=2231207&page=2&s=44910e0c56047e4f93dfd9fea58121ef Signed-off-by: alanwu --- drivers/hid/hi

Re: HID: Introduce hidpp, a module to handle Logitech hid++ devices

2014-10-31 Thread Benjamin Tissoires
Hi Dan, On Oct 31 2014 or thereabouts, Dan Carpenter wrote: > Hello Benjamin Tissoires, > > The patch 2f31c5252910: "HID: Introduce hidpp, a module to handle > Logitech hid++ devices" from Sep 30, 2014, leads to the following > static checker warning: > > drivers/hid/hid-logitech-hidpp.c:3

Re: [patch] HID: logitech-hidpp: leaks and NULL dereferences

2014-10-31 Thread Benjamin Tissoires
On Oct 31 2014 or thereabouts, Dan Carpenter wrote: > Shift the allocation down a few lines to avoid a memory leak and also > add a check for allocation failure. > > Fixes: 2f31c5252910 ('HID: Introduce hidpp, a module to handle Logitech hid++ > devices') > Signed-off-by: Dan Carpenter > Ouch,

Re: [PATCH v3] psmouse: Add some support for the FocalTech PS/2 protocol extensions.

2014-10-31 Thread Hans de Goede
Hi Mathias, Thanks for your continued work on this. 3 remarks online + 1 at the bottom. On 10/30/2014 07:33 PM, Mathias Gottschlag wrote: > Most of the protocol for these touchpads has been reverse engineered. This > commit adds a basic multitouch-capable driver. > > A lot of the protocol is sti

[PATCH 1/3] Input: altera_ps2 - write to correct register when disabling interrupts

2014-10-31 Thread Tobias Klauser
In altera_ps2_close, the data register (offset 0) is written instead of the control register (offset 4), leading to the RX interrupt not being disabled. Fix this by calling writel() with the offset for the proper register. Signed-off-by: Tobias Klauser --- drivers/input/serio/altera_ps2.c | 2 +-

[PATCH 2/3] Input: altera_ps2 - use correct type for irq return value

2014-10-31 Thread Tobias Klauser
The irq function altera_ps2_rxint returns an irqreturn_t, so use the same type for variable storing the return value. Signed-off-by: Tobias Klauser --- drivers/input/serio/altera_ps2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/serio/altera_ps2.c b/drivers/

[PATCH 3/3] Input: altera_ps2 - switch to using managed resources

2014-10-31 Thread Tobias Klauser
Use them devm_ managed resources API to simplify error handling in altera_ps2_probe() and to reduce the size of altera_ps2_remove() and the ps2if struct. Signed-off-by: Tobias Klauser --- drivers/input/serio/altera_ps2.c | 81 1 file changed, 24 insertion

Re: [PATCH 11/15] sound: soc: poodle: make use of new locomo GPIO interface

2014-10-31 Thread Dmitry Eremin-Solenikov
2014-10-31 12:52 GMT+03:00 Linus Walleij : > On Wed, Oct 29, 2014 at 4:03 AM, Alexandre Courbot wrote: >> On Tue, Oct 28, 2014 at 11:58 PM, Mark Brown wrote: >>> On Tue, Oct 28, 2014 at 03:02:04AM +0300, Dmitry Eremin-Solenikov wrote: Since LoCoMo driver has been converted to provide proper

Re: [PATCH 01/15] mfd: add new driver for Sharp LoCoMo

2014-10-31 Thread Dmitry Eremin-Solenikov
Hello, Thank you for the review of patches. 2014-10-31 10:42 GMT+03:00 Linus Walleij : > On Tue, Oct 28, 2014 at 1:01 AM, Dmitry Eremin-Solenikov > wrote: > >> LoCoMo is a GA used on Sharp Zaurus SL-5x00. Current driver does has >> several design issues (special bus instead of platform bus, does

Re: [PATCH 11/15] sound: soc: poodle: make use of new locomo GPIO interface

2014-10-31 Thread Linus Walleij
On Wed, Oct 29, 2014 at 4:03 AM, Alexandre Courbot wrote: > On Tue, Oct 28, 2014 at 11:58 PM, Mark Brown wrote: >> On Tue, Oct 28, 2014 at 03:02:04AM +0300, Dmitry Eremin-Solenikov wrote: >>> Since LoCoMo driver has been converted to provide proper gpiolib >>> interface, make poodle ASoC platform

Re: [PATCH 02/15] GPIO: port LoCoMo gpio support from old driver

2014-10-31 Thread Dmitry Eremin-Solenikov
2014-10-31 10:48 GMT+03:00 Linus Walleij : > On Tue, Oct 28, 2014 at 1:01 AM, Dmitry Eremin-Solenikov > wrote: > >> Add gpiolib driver for gpio pins placed on the LoCoMo GA. >> >> Signed-off-by: Dmitry Eremin-Solenikov > [skipped] > (etc, everywhere this pattern occurs). >> +static void locomo_

Re: [PATCH 14/15] gpio: locomo: implement per-pin irq handling

2014-10-31 Thread Dmitry Eremin-Solenikov
2014-10-31 11:00 GMT+03:00 Linus Walleij : > On Tue, Oct 28, 2014 at 1:02 AM, Dmitry Eremin-Solenikov > wrote: > >> LoCoMo has a possibility to generate per-GPIO edge irqs. Support for >> that was there in old locomo driver, got 'cleaned up' during old driver >> IRQ cascading cleanup and is now re

Re: [PATCH 09/15] ARM: sa1100: don't preallocate IRQ space for locomo

2014-10-31 Thread Dmitry Eremin-Solenikov
2014-10-31 10:50 GMT+03:00 Linus Walleij : > On Tue, Oct 28, 2014 at 1:02 AM, Dmitry Eremin-Solenikov > wrote: > >> As new locomo driver properly supports SPARSE_IRQ, stop playing with >> NR_IRQS on sa1100 (locomo was the last chip requiring NR_IRQ tricks). >> >> Signed-off-by: Dmitry Eremin-Solen

re: HID: Introduce hidpp, a module to handle Logitech hid++ devices

2014-10-31 Thread Dan Carpenter
Hello Benjamin Tissoires, The patch 2f31c5252910: "HID: Introduce hidpp, a module to handle Logitech hid++ devices" from Sep 30, 2014, leads to the following static checker warning: drivers/hid/hid-logitech-hidpp.c:359 hidpp_root_get_protocol_version() warn: should this return rea

[patch] HID: logitech-hidpp: leaks and NULL dereferences

2014-10-31 Thread Dan Carpenter
Shift the allocation down a few lines to avoid a memory leak and also add a check for allocation failure. Fixes: 2f31c5252910 ('HID: Introduce hidpp, a module to handle Logitech hid++ devices') Signed-off-by: Dan Carpenter diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech

Re: [PATCH] i8042: Add noloop quirk for Asus X750LN

2014-10-31 Thread Hans de Goede
Hi, On 10/31/2014 09:21 AM, Hans de Goede wrote: > Hi, > > On 10/30/2014 07:34 PM, Dmitry Torokhov wrote: >> On Sat, Oct 11, 2014 at 11:35:23AM -0700, Dmitry Torokhov wrote: >>> On Sat, Oct 11, 2014 at 03:09:06PM +0200, Hans de Goede wrote: Without this the aux port does not get detected, an

Re: [PATCH] i8042: Add noloop quirk for Asus X750LN

2014-10-31 Thread Hans de Goede
Hi, On 10/30/2014 07:34 PM, Dmitry Torokhov wrote: > On Sat, Oct 11, 2014 at 11:35:23AM -0700, Dmitry Torokhov wrote: >> On Sat, Oct 11, 2014 at 03:09:06PM +0200, Hans de Goede wrote: >>> Without this the aux port does not get detected, and consequently the >>> touchpad >>> will not work. >>> >>>

Re: [PATCH 14/15] gpio: locomo: implement per-pin irq handling

2014-10-31 Thread Linus Walleij
On Tue, Oct 28, 2014 at 1:02 AM, Dmitry Eremin-Solenikov wrote: > LoCoMo has a possibility to generate per-GPIO edge irqs. Support for > that was there in old locomo driver, got 'cleaned up' during old driver > IRQ cascading cleanup and is now reimplemented. It is expected that > SL-5500 (collie)

Re: [PATCH 09/15] ARM: sa1100: don't preallocate IRQ space for locomo

2014-10-31 Thread Linus Walleij
On Tue, Oct 28, 2014 at 1:02 AM, Dmitry Eremin-Solenikov wrote: > As new locomo driver properly supports SPARSE_IRQ, stop playing with > NR_IRQS on sa1100 (locomo was the last chip requiring NR_IRQ tricks). > > Signed-off-by: Dmitry Eremin-Solenikov That's right! By moving to irqdomain things g

Re: [PATCH 02/15] GPIO: port LoCoMo gpio support from old driver

2014-10-31 Thread Linus Walleij
On Tue, Oct 28, 2014 at 1:01 AM, Dmitry Eremin-Solenikov wrote: > Add gpiolib driver for gpio pins placed on the LoCoMo GA. > > Signed-off-by: Dmitry Eremin-Solenikov (...) > +static int locomo_gpio_get(struct gpio_chip *chip, > + unsigned offset) > +{ > + struct locomo_gpio

Re: [PATCH 01/15] mfd: add new driver for Sharp LoCoMo

2014-10-31 Thread Linus Walleij
On Tue, Oct 28, 2014 at 1:01 AM, Dmitry Eremin-Solenikov wrote: > LoCoMo is a GA used on Sharp Zaurus SL-5x00. Current driver does has > several design issues (special bus instead of platform bus, doesn't use > mfd-core, etc). > > Implement 'core' parts of locomo support as an mfd driver. > > Sig