Re: Problems with Wacom Intuos PT M (CTH680) on FreeBSD

2014-11-04 Thread Dmitry Torokhov
On Sat, Nov 01, 2014 at 08:40:19AM +0100, Hans Petter Selasky wrote: > On 11/01/14 00:27, Ping Cheng wrote: > >If touch_input is NULL on FreeBSD, you need to figure out the root > >cause. Checking on touch_input itself would not fix the root cause... > > Right. > > The root cause is that FreeBSD

Re: [PATCH v2 1/2] HID: logitech-hidpp: fix negated returns

2014-11-04 Thread Jiri Kosina
On Mon, 3 Nov 2014, Benjamin Tissoires wrote: > Reported by Dan Carpenter: > > drivers/hid/hid-logitech-hidpp.c:359 hidpp_root_get_protocol_version() warn: > should this return really be negated? > drivers/hid/hid-logitech-hidpp.c:398 hidpp_devicenametype_get_count() warn: > should this return

Re: [PATCH v2 2/2] HID: logitech-hidpp: 2 fixes in hidpp_root_get_protocol_version()

2014-11-04 Thread Jiri Kosina
On Mon, 3 Nov 2014, Benjamin Tissoires wrote: > - remove the constant '1' > - when the device is not connected, the protocol error > HIDPP_ERROR_RESOURCE_ERROR is raised. We should not warn the user about > it because it is somewhat expected as an answer when we check if the > device is conn

Re: [PATCH RESEND RESEND] Input: evdev - add event-mask API

2014-11-04 Thread David Herrmann
Hi Dmitry Sorry for the delay, back from holiday now. On Fri, Oct 10, 2014 at 12:52 AM, Dmitry Torokhov wrote: > diff -u b/include/uapi/linux/input.h b/include/uapi/linux/input.h > --- b/include/uapi/linux/input.h > +++ b/include/uapi/linux/input.h > @@ -161,53 +161,59 @@ > #define EVIOCREVOKE

Re: [PATCH 0/4] Touchscreen performance related fixes

2014-11-04 Thread Vignesh R
On Monday 03 November 2014 05:47 PM, Sebastian Andrzej Siewior wrote: > On 10/27/2014 08:02 PM, Griffis, Brad wrote: >> On 10/27/2014 12:34 PM, Sebastian Andrzej Siewior wrote: >>> Do we really need #3 (and then #4)? Given the complexity we have already, >>> is there any benefit by decreasing th

Re: [PATCH 0/4] Touchscreen performance related fixes

2014-11-04 Thread Sebastian Andrzej Siewior
On 11/04/2014 12:44 PM, Vignesh R wrote: > I ran following commands > $ evtest /dev/input/touchscreen0 & > (with heavy item on touchscreen) > and > $ cat /sys/bus/iio/devices/iio\:device0/scan_elements/in_voltage4_en > (in a busy loop) > I tried above experiment on my board but I didn't hit any p

[PATCH v3] Input: evdev - add event-mask API

2014-11-04 Thread David Herrmann
Hardware manufacturers group keys in the weirdest way possible. This may cause a power-key to be grouped together with normal keyboard keys and thus be reported on the same kernel interface. However, user-space is often only interested in specific sets of events. For instance, daemons dealing with

Re: Problems with Wacom Intuos PT M (CTH680) on FreeBSD

2014-11-04 Thread Ping Cheng
Hi Dmitry, On Tue, Nov 4, 2014 at 12:08 AM, Dmitry Torokhov wrote: > On Sat, Nov 01, 2014 at 08:40:19AM +0100, Hans Petter Selasky wrote: >> On 11/01/14 00:27, Ping Cheng wrote: >> >If touch_input is NULL on FreeBSD, you need to figure out the root >> >cause. Checking on touch_input itself would

Re: Problems with Wacom Intuos PT M (CTH680) on FreeBSD

2014-11-04 Thread Dmitry Torokhov
On Tue, Nov 04, 2014 at 09:38:38AM -0800, Ping Cheng wrote: > Hi Dmitry, > > On Tue, Nov 4, 2014 at 12:08 AM, Dmitry Torokhov > wrote: > > On Sat, Nov 01, 2014 at 08:40:19AM +0100, Hans Petter Selasky wrote: > >> On 11/01/14 00:27, Ping Cheng wrote: > >> >If touch_input is NULL on FreeBSD, you ne

Re: [PATCH RESEND RESEND] Input: evdev - add event-mask API

2014-11-04 Thread Dmitry Torokhov
On Tue, Nov 04, 2014 at 11:51:34AM +0100, David Herrmann wrote: > Hi Dmitry > > Sorry for the delay, back from holiday now. > > On Fri, Oct 10, 2014 at 12:52 AM, Dmitry Torokhov > wrote: > > diff -u b/include/uapi/linux/input.h b/include/uapi/linux/input.h > > --- b/include/uapi/linux/input.h >

[PATCH 1/1] hid-saitek: Quirk for Saitek R.A.T.7 works with R.A.T.9 too

2014-11-04 Thread Ville Aakko
From: Ville Aakko I have tested HID quirk for Saitek R.A.T.7 with my R.A.T. 9. It works fine for me. Attached patch makes the necessary changes to use the quirk on the R.A.T.9 too, and necessary Kconfig changes too. I have stylized the Kconfig option name to include Mad Catz in the option name

Re: [PATCH 1/1] hid-saitek: Quirk for Saitek R.A.T.7 works with R.A.T.9 too

2014-11-04 Thread Ville Aakko
From: Ville Aakko I have tested HID quirk for Saitek R.A.T.7 with my R.A.T. 9. It works fine for me. Attached patch makes the necessary changes to use the quirk on the R.A.T.9 too, and necessary Kconfig changes too. I have stylized the Kconfig option name to include Mad Catz in the option name

Re: About Dell Inspiron 3442 touchpad

2014-11-04 Thread Luiz Carlos Ramos
Hi, Benjamin, I think I just wrote the email below in a way it suggests everything had gone well and the issue was resolved... but unfortunately it's not the case. In my reply, I wrote some remarks in the text body in that email, but I think they weren't noticed at all given the first paragraph.

Re: About Dell Inspiron 3442 touchpad

2014-11-04 Thread Benjamin Tissoires
Hi Luiz, On Tue, Nov 4, 2014 at 8:11 PM, Luiz Carlos Ramos wrote: > Hi, Benjamin, > > I think I just wrote the email below in a way it suggests everything had > gone well and the issue was resolved... but unfortunately it's not the > case. In my reply, I wrote some remarks in the text body in tha