Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

2014-11-14 Thread Oliver Neukum
On Thu, 2014-11-13 at 12:16 -0800, Benson Leung wrote: > In usbhid_open, usb_autopm_get_interface is called > before setting the needs_remote_wakeup flag, and > usb_autopm_put_interface is called after hid_start_in. > > However, when the device is closed in usbhid_close, the same > protection isn

Re: [PATCH 02/15] GPIO: port LoCoMo gpio support from old driver

2014-11-14 Thread Linus Walleij
On Tue, Nov 11, 2014 at 2:16 PM, Dmitry Eremin-Solenikov wrote: > Just to better understand your suggestions: do you want me to convert > to regmap only gpio driver or do you suggest to convert all LoCoMo drivers? Um... I was just thinking about this one usecase. It's no big deal, the other rev

Re: [PATCH v3 4/4] input: alps: Fix trackstick detection

2014-11-14 Thread Pali Rohár
On Sunday 09 November 2014 12:30:03 Pali Rohár wrote: > On Sunday 09 November 2014 09:05:04 Dmitry Torokhov wrote: > > Hi Pali, > > > > On Sun, Nov 02, 2014 at 12:25:10AM +0100, Pali Rohár wrote: > > > int alps_detect(struct psmouse *psmouse, bool > > > set_properties) { > > > > > > - struct al

Re: [PATCH 01/15] mfd: add new driver for Sharp LoCoMo

2014-11-14 Thread Dmitry Eremin-Solenikov
Hello, 2014-11-05 23:24 GMT+03:00 Mark Brown : > On Thu, Nov 06, 2014 at 12:02:49AM +0400, Dmitry Eremin-Solenikov wrote: >> 2014-11-03 16:41 GMT+03:00 Linus Walleij : > >> > The point is still the same: no unrelated code in drivers/mfd, >> > then either use IIO DAC as a middle layer or sink the D

Re: [PATCH 02/15] GPIO: port LoCoMo gpio support from old driver

2014-11-14 Thread Dmitry Eremin-Solenikov
2014-11-14 13:11 GMT+03:00 Linus Walleij : > On Tue, Nov 11, 2014 at 2:16 PM, Dmitry Eremin-Solenikov > wrote: > >> Just to better understand your suggestions: do you want me to convert >> to regmap only gpio driver or do you suggest to convert all LoCoMo drivers? > > Um... I was just thinking abo

Re: [PATCH 01/15] mfd: add new driver for Sharp LoCoMo

2014-11-14 Thread Mark Brown
On Fri, Nov 14, 2014 at 04:47:00PM +0400, Dmitry Eremin-Solenikov wrote: > I'm actually looking at the regulator interface. Since this DAC serves mostly > like a (semi-)constant voltage interface, would it be rather logical to use > regulator subsystem to drive it? Possibly... it's mostly a func

Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

2014-11-14 Thread Alan Stern
On Thu, 13 Nov 2014, Benson Leung wrote: > Hi Alan, > > On Thu, Nov 13, 2014 at 2:11 PM, Alan Stern wrote: > > Wait a minute -- in your previous email you said this approach didn't > > work. So does it work or doesn't it? > > Sorry for the confusion. The approach *does* work. > > That was act

Re: [PATCH 01/15] mfd: add new driver for Sharp LoCoMo

2014-11-14 Thread Dmitry Eremin-Solenikov
2014-11-14 18:10 GMT+03:00 Mark Brown : > On Fri, Nov 14, 2014 at 04:47:00PM +0400, Dmitry Eremin-Solenikov wrote: > >> I'm actually looking at the regulator interface. Since this DAC serves mostly >> like a (semi-)constant voltage interface, would it be rather logical to use >> regulator subsystem

[PATCH 2/2] DT: i2c: Add more devices handled by the adxl34x-i2c driver

2014-11-14 Thread Geert Uytterhoeven
This allows checkpatch to validate more DTSes. Signed-off-by: Geert Uytterhoeven --- Documentation/devicetree/bindings/i2c/trivial-devices.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c

[PATCH 1/2] DT: i2c: Add more devices handled by the rtc-rs5c372 driver

2014-11-14 Thread Geert Uytterhoeven
This allows checkpatch to validate more DTSes. Signed-off-by: Geert Uytterhoeven --- Documentation/devicetree/bindings/i2c/trivial-devices.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i

Re: [PATCH] driver: input :touchscreen : add Raydium I2C touch driver

2014-11-14 Thread Benson Leung
Hi Jeffrey, On Thu, Nov 13, 2014 at 11:19 PM, jeffrey.lin wrote: > this patch is porting Raydium I2C touch driver. Developer can enable > Raydium touch driver by modifying define "CONFIG_TOUCHSCREEN_RM31100" > in config/base.config > > Change-Id: Idae54cc4bca17f321a1d0895a8b59680bf9af859 This

Re: [PATCH] driver: input :touchscreen : add Raydium I2C touch driver

2014-11-14 Thread Dmitry Torokhov
Hi Jeffrey, On Fri, Nov 14, 2014 at 03:19:22PM +0800, jeffrey.lin wrote: > From: "jeffrey.lin" > > this patch is porting Raydium I2C touch driver. Thank you for your submission. > Developer can enable > Raydium touch driver by modifying define "CONFIG_TOUCHSCREEN_RM31100" > in config/base.c

Re: [PATCH v4 4/6] ARM: dts: AM335x: Make charge delay a DT parameter for TSC

2014-11-14 Thread Tony Lindgren
* Vignesh R [141113 21:42]: > The charge delay value is by default 0x400. But it can be set to lower > values on some boards, as long as false pen-ups are avoided. Lowering the > value increases the sampling rate (though current sampling rate is > sufficient for TSC operation). In some boards, the

[PATCH 0/7] Fixes for ALPS trackstick

2014-11-14 Thread Pali Rohár
This patch series fix detection and identifying trackstick on machines with ALPS devices. Last patch split trackstick and bare PS/2 mouse packets between dev2 and dev3 input devices which make sure that driver will send only trackstick data to trackstick input device. Pali Rohár (7): input: alp

[PATCH 1/7] input: alps: Set correct name of psmouse device in alps_init()

2014-11-14 Thread Pali Rohár
On some laptops after starting them from off state (not after reboot), function alps_probe_trackstick_v3() (called from function alps_identify()) does not detect trackstick. To fix this problem we need to reset device. But function alps_identify() is called also from alps_detect() and we do not wan

[PATCH 6/7] input: alps: Add sanity checks for non DualPoint devices

2014-11-14 Thread Pali Rohár
This patch adds sanity checks and reject trackstick packets from ALPS devices which do not have trackstick present (those without ALPS_DUALPOINT flag). Make sure that driver does not process some bogus packets as trackstick data when there is no trackstick packet. Patch also write warning do dmesg

[PATCH 5/7] input: alps: Fix name, product and version of dev2 input device

2014-11-14 Thread Pali Rohár
This patch fix name, product and version of dev2 input device based on format used in function psmouse_switch_protocol() in file psmouse-base.c. Signed-off-by: Pali Rohár --- drivers/input/mouse/alps.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/driv

[PATCH 7/7] input: alps: Do not report both trackstick and external PS/2 mouse data to one input device

2014-11-14 Thread Pali Rohár
Before this patch dev2 device was used for both external PS/2 mouse and internal trackstick device (if available). This patch introduce dev3 device which is used for external PS/2 mouse data and dev2 is not used only for trackstick. In case that trackstick is not present dev2 is not created, so u

[PATCH 4/7] input: alps: Use NULL instead dummy argument for alps_identify

2014-11-14 Thread Pali Rohár
This patch change alps_identify() function code so it can be called also without priv parameter which is useful for alps_detect(). Instead passing dummy value now alps_identify() accept also NULL value and skip filling priv data. It is useless for alps_detect() and it will speed up detection of alp

[PATCH 3/7] input: alps: Move alps_dolphin_get_device_area into alps_hw_init_dolphin_v1

2014-11-14 Thread Pali Rohár
This patch moves function call alps_dolphin_get_device_area() from function alps_identify() to alps_hw_init_dolphin_v1() so alps_identify() will not call any other psmouse commands. Signed-off-by: Pali Rohár --- drivers/input/mouse/alps.c | 13 +++-- 1 file changed, 7 insertions(+), 6

[PATCH 2/7] input: alps: Move trackstick detection to alps_hw_init_*

2014-11-14 Thread Pali Rohár
Now when alps_identify() does not need do trackstick detection it is safe to move code init hw_init functions. This patch also fix trackstick detection in function alps_hw_init_v3() which remove ALPS_DUALPOINT flag when trackstick is not detected. Signed-off-by: Pali Rohár --- drivers/input/mou

Re: [PATCH v3 4/4] input: alps: Fix trackstick detection

2014-11-14 Thread Pali Rohár
On Friday 14 November 2014 12:22:33 Pali Rohár wrote: > On Sunday 09 November 2014 12:30:03 Pali Rohár wrote: > > On Sunday 09 November 2014 09:05:04 Dmitry Torokhov wrote: > > > Hi Pali, > > > > > > On Sun, Nov 02, 2014 at 12:25:10AM +0100, Pali Rohár wrote: > > > > int alps_detect(struct psmous

Re: [PATCH 0/7] Fixes for ALPS trackstick

2014-11-14 Thread Dmitry Torokhov
Hi Pali, On Friday, November 14, 2014 08:38:19 PM Pali Rohár wrote: > This patch series fix detection and identifying trackstick on machines with > ALPS devices. Last patch split trackstick and bare PS/2 mouse packets > between dev2 and dev3 input devices which make sure that driver will send > on

[git pull] Input updates for 3.18-rc4

2014-11-14 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. Mostly small fixups to PS/2 tochpad drivers (ALPS, Elantech, Syna