Re: [PATCH v5 2/4] ARM:sunxi:drivers:input Add support for A10/A20 PS2

2015-01-27 Thread Dmitry Torokhov
Hi Vishnu, On Sun, Jan 25, 2015 at 07:10:07PM +0530, Vishnu Patekar wrote: > Signed-off-by: VishnuPatekar > --- > drivers/input/serio/Kconfig | 11 ++ > drivers/input/serio/Makefile|1 + > drivers/input/serio/sun4i-ps2.c | 347 > +++ > 3 files

[PATCH v2 2/5] Input: synaptics - Log queried and quirked dimension values

2015-01-27 Thread Daniel Martin
From: Daniel Martin Logging the dimension values we queried (info) and the values we use from a quirk to overwrite (warn) can be helpful for debugging. This partly relates to bug: https://bugzilla.kernel.org/show_bug.cgi?id=91541 Signed-off-by: Daniel Martin --- drivers/input/mouse/synapt

[v2] synaptics: match PNP-Id is not sufficient for min/max quirks

2015-01-27 Thread Daniel Martin
Hi, this is the second version of my patches to address the problems described at: https://bugzilla.kernel.org/show_bug.cgi?id=91541 I have incorporated changes according to Hans comments. That means I removed the patch Input: synaptics - Add PnP id for X1 Carbon 1nd as the PnP id doesn't

[PATCH v2 3/5] Input: synaptics - Query min dimensions when safe firmware

2015-01-27 Thread Daniel Martin
From: Daniel Martin Query the min dimensions even if the check SYN_EXT_CAP_REQUESTS(priv->capabilities) >= 7 fails, but we know that the firmware version is safe. Atm. this is version 8.1 only. With that we don't need quirks for post-2013 models anymore as they expose correct min and max dim

[PATCH v2 1/5] Input: synaptics - Split synaptics_resolution(), query first

2015-01-27 Thread Daniel Martin
From: Daniel Martin Split the function synaptics_resolution() into synaptics_resolution() and synaptics_quirks(). synaptics_resolution() will be called before synaptics_quirks() to query dimensions and resolutions before overwriting them with quirks. v2: Removed SYN_ID_MAJOR() check from sy

[PATCH v2 5/5] Input: synaptics - Remove obsolete min/max quirk for X240

2015-01-27 Thread Daniel Martin
From: Daniel Martin The firmware of the X240 (LEN0035, 2013/12) exposes the same values x [1232..5710], y [1156..4696] as the quirk applies. Signed-off-by: Daniel Martin --- drivers/input/mouse/synaptics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/mo

[PATCH v2 4/5] Input: synaptics - Skip quirks when post-2013 dimensions

2015-01-27 Thread Daniel Martin
From: Daniel Martin If we queried min/max dimensions of x [1266..5674], y [1170..4684] we have post-2013 model and don't need to apply any quirk. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=91541 Signed-off-by: Daniel Martin --- drivers/input/mouse/synaptics.c | 5 + 1 file chang

input: elantech.c: adding more Fujtisu notebooks to force crc_enabled

2015-01-27 Thread Rainer Koenig
Extending the patch from November 2014 with two more Fujitsu LIFEBOOK models that also ship the Elantech touchpad and don't work with crc_disabled. Signed-off-by: Rainer Koenig --- My responsibility is enabling Linux on Fujitsu desktops and sometimes also notebooks. Stumbled into this issue duri

Re: [PATCH] arm: sunxi: input: RFC: Add sysfs voltage for sun4i-lradc driver

2015-01-27 Thread Maxime Ripard
Hi, On Mon, Jan 26, 2015 at 06:58:32PM +0200, Priit Laes wrote: > --- Like Hans was pointing out, commit log and signed-off-by please > .../ABI/testing/sysfs-driver-input-sun4i-lradc | 4 ++ > drivers/input/keyboard/sun4i-lradc-keys.c | 49 > +- > 2 files chan

Re: [linux-sunxi] Re: [PATCH] arm: sunxi: input: RFC: Add sysfs voltage for sun4i-lradc driver

2015-01-27 Thread Priit Laes
On Tue, 2015-01-27 at 10:18 +0100, Maxime Ripard wrote: > Hi, > > On Mon, Jan 26, 2015 at 06:58:32PM +0200, Priit Laes wrote: > > --- > > Like Hans was pointing out, commit log and signed-off-by please > > > .../ABI/testing/sysfs-driver-input-sun4i-lradc | 4 ++ > > drivers/input/keyboard

Re: Merging hid-huion into hid-uclogic

2015-01-27 Thread Jiri Kosina
On Sun, 25 Jan 2015, Nikolai Kondrashov wrote: > I'd like to have your opinion if it will be fine to merge hid-huion.c into > hid-uclogic.c, keeping tablet support intact, of course. huion driver module doesn't take any module parameters, so that should be fine (renaming modules that accept para

Re: [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts

2015-01-27 Thread Mika Westerberg
On Mon, Jan 26, 2015 at 04:39:30PM +, Mark Rutland wrote: > What I don't follow is why GpioInt seems to be translated as a GPIO > rather than as an interrupt which happens to be backed by a GPIO. Were > it not for that, the DT and ACPI cases would align better. Because it *is* a GPIO. In my e

Re: [PATCH] HID: Add driver for synaptics keybard with broken rdesc

2015-01-27 Thread Jiri Kosina
On Fri, 23 Jan 2015, Simon Wörner wrote: > From: Simon Wörner > Changelog is missing here. > Signed-off-by: Simon Wörner > --- > drivers/hid/Kconfig | 6 ++ > drivers/hid/Makefile| 1 + > drivers/hid/hid-ids.h | 1 + > drivers/hid/hid-synaptics.c | 190 >

Re: [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts

2015-01-27 Thread Mark Rutland
On Tue, Jan 27, 2015 at 10:16:10AM +, Mika Westerberg wrote: > On Mon, Jan 26, 2015 at 04:39:30PM +, Mark Rutland wrote: > > What I don't follow is why GpioInt seems to be translated as a GPIO > > rather than as an interrupt which happens to be backed by a GPIO. Were > > it not for that, th

Re: [linux-sunxi] Re: [PATCH] arm: sunxi: input: RFC: Add sysfs voltage for sun4i-lradc driver

2015-01-27 Thread Hans de Goede
Hi, On 27-01-15 10:49, Priit Laes wrote: On Tue, 2015-01-27 at 10:18 +0100, Maxime Ripard wrote: Hi, On Mon, Jan 26, 2015 at 06:58:32PM +0200, Priit Laes wrote: --- Like Hans was pointing out, commit log and signed-off-by please .../ABI/testing/sysfs-driver-input-sun4i-lradc | 4 +

Re: [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts

2015-01-27 Thread Mika Westerberg
On Tue, Jan 27, 2015 at 10:39:25AM +, Mark Rutland wrote: > > If the above is not the right way to use GPIOs as interrupt, can you > > please tell me how it is done then? > > > So lets say we have a device which generates an interrupt: > > device@f00 { > compatible = "som

Re: Merging hid-huion into hid-uclogic

2015-01-27 Thread Nikolai Kondrashov
On 01/27/2015 12:10 PM, Jiri Kosina wrote: On Sun, 25 Jan 2015, Nikolai Kondrashov wrote: I'd like to have your opinion if it will be fine to merge hid-huion.c into hid-uclogic.c, keeping tablet support intact, of course. huion driver module doesn't take any module parameters, so that should

Re: [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts

2015-01-27 Thread Mark Rutland
On Tue, Jan 27, 2015 at 10:59:31AM +, Mika Westerberg wrote: > On Tue, Jan 27, 2015 at 10:39:25AM +, Mark Rutland wrote: > > > If the above is not the right way to use GPIOs as interrupt, can you > > > please tell me how it is done then? > > > > > > So lets say we have a device which gene

Re: [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts

2015-01-27 Thread Mika Westerberg
On Tue, Jan 27, 2015 at 11:14:58AM +, Mark Rutland wrote: > On Tue, Jan 27, 2015 at 10:59:31AM +, Mika Westerberg wrote: > > On Tue, Jan 27, 2015 at 10:39:25AM +, Mark Rutland wrote: > > > > If the above is not the right way to use GPIOs as interrupt, can you > > > > please tell me how

[PATCH 2/2] Fix force effect modifications for the Microsoft Sidewinder Force Feedback Pro 2 joystick

2015-01-27 Thread Jim Keir
--- The FF2 driver (usbhid/hid-pidff.c) does not set the effect ID when uploading an effect. The result is that the initial upload works but subsequent uploads to modify effect parameters are all directed at the last-created effect. The targeted effect ID must be passed back to the device when eff

Re: [PATCH] HID: Add driver for synaptics keybard with broken rdesc

2015-01-27 Thread Benjamin Tissoires
On Fri, Jan 23, 2015 at 2:03 PM, Simon Wörner wrote: > From: Simon Wörner > > Signed-off-by: Simon Wörner > --- > drivers/hid/Kconfig | 6 ++ > drivers/hid/Makefile| 1 + > drivers/hid/hid-ids.h | 1 + > drivers/hid/hid-synaptics.c | 190 > ++

Re: [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts

2015-01-27 Thread Mark Rutland
On Tue, Jan 27, 2015 at 11:30:41AM +, Mika Westerberg wrote: > On Tue, Jan 27, 2015 at 11:14:58AM +, Mark Rutland wrote: > > On Tue, Jan 27, 2015 at 10:59:31AM +, Mika Westerberg wrote: > > > On Tue, Jan 27, 2015 at 10:39:25AM +, Mark Rutland wrote: > > > > > If the above is not the

Re: [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts

2015-01-27 Thread Mika Westerberg
On Tue, Jan 27, 2015 at 02:33:34PM +, Mark Rutland wrote: > Ok, that allays my fear w.r.t. ordering of the resources. > > As I see it, the fact that we convert GpioInt entries to GPIOs rather > than irqs when parsing _CRS is the issue here, and to me it makes no > sense that we do so. Were we

Re: About Goodix-TS on Bay Trail, and ACPI and interrupts

2015-01-27 Thread Antonio Ospite
On Wed, 21 Jan 2015 12:16:54 +0200 Mika Westerberg wrote: > On Tue, Jan 20, 2015 at 05:56:45PM +0100, Antonio Ospite wrote: > > Hi Mika, I tested the patch but I still can't get the IRQ. > > > > The new code in i2c-hid does more or less what I was trying to do in > > the goodix driver as proof o

Re: [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts

2015-01-27 Thread Mark Rutland
On Tue, Jan 27, 2015 at 02:41:27PM +, Mika Westerberg wrote: > On Tue, Jan 27, 2015 at 02:33:34PM +, Mark Rutland wrote: > > Ok, that allays my fear w.r.t. ordering of the resources. > > > > As I see it, the fact that we convert GpioInt entries to GPIOs rather > > than irqs when parsing _C

Re: [PATCH] HID: Add driver for synaptics keybard with broken rdesc

2015-01-27 Thread Simon Wörner
Thanks for the feedback, this is my first commit to the linux kernel so I don't know much about how the input / hid is working. I will add the changelog to the patch email, just need to find out how this works. Am 27.01.15 um 15:16 schrieb Benjamin Tissoires: > On Fri, Jan 23, 2015 at 2:03 PM, Si

Re: [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts

2015-01-27 Thread Mika Westerberg
On Tue, Jan 27, 2015 at 03:06:06PM +, Mark Rutland wrote: > On Tue, Jan 27, 2015 at 02:41:27PM +, Mika Westerberg wrote: > > On Tue, Jan 27, 2015 at 02:33:34PM +, Mark Rutland wrote: > > > Ok, that allays my fear w.r.t. ordering of the resources. > > > > > > As I see it, the fact that

Re: [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts

2015-01-27 Thread Mark Rutland
On Tue, Jan 27, 2015 at 03:21:27PM +, Mika Westerberg wrote: > On Tue, Jan 27, 2015 at 03:06:06PM +, Mark Rutland wrote: > > On Tue, Jan 27, 2015 at 02:41:27PM +, Mika Westerberg wrote: > > > On Tue, Jan 27, 2015 at 02:33:34PM +, Mark Rutland wrote: > > > > Ok, that allays my fear w

Re: [PATCH] HID: Add driver for synaptics keybard with broken rdesc

2015-01-27 Thread Benjamin Tissoires
On Tue, Jan 27, 2015 at 10:10 AM, Simon Wörner wrote: > Thanks for the feedback, this is my first commit to the linux kernel so > I don't know much about how the input / hid is working. > > I will add the changelog to the patch email, just need to find out how > this works. > > Am 27.01.15 um 15:1

Re: [v2] synaptics: match PNP-Id is not sufficient for min/max quirks

2015-01-27 Thread Hans de Goede
Hi, On 01/27/2015 09:34 AM, Daniel Martin wrote: Hi, this is the second version of my patches to address the problems described at: https://bugzilla.kernel.org/show_bug.cgi?id=91541 I have incorporated changes according to Hans comments. That means I removed the patch Input: synaptic

Re: [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts

2015-01-27 Thread Mika Westerberg
On Tue, Jan 27, 2015 at 03:57:47PM +, Mark Rutland wrote: > On Tue, Jan 27, 2015 at 03:21:27PM +, Mika Westerberg wrote: > > On Tue, Jan 27, 2015 at 03:06:06PM +, Mark Rutland wrote: > > > On Tue, Jan 27, 2015 at 02:41:27PM +, Mika Westerberg wrote: > > > > On Tue, Jan 27, 2015 at 0

Re: Input: atmel_mxt_ts - status of the for-dtor branch and sscanf issue

2015-01-27 Thread Nick Dyer
On 19/01/15 13:08, Dirk Behme wrote: > we have two questions regarding the atmel_mxt_ts driver: > > First, what's the status of your github 'for-dtor' branch [1]? Is this > subject to change? Or how stable is it? Will it go into mainline, soon? > > We've tested the patches in that branch on top o

Re: [linux-sunxi] Re: [PATCH] arm: sunxi: input: RFC: Add sysfs voltage for sun4i-lradc driver

2015-01-27 Thread Dmitry Torokhov
On Tue, Jan 27, 2015 at 11:49:49AM +0200, Priit Laes wrote: > > On Tue, 2015-01-27 at 10:18 +0100, Maxime Ripard wrote: > > Hi, > > > > On Mon, Jan 26, 2015 at 06:58:32PM +0200, Priit Laes wrote: > > > --- > > > > Like Hans was pointing out, commit log and signed-off-by please > > > > > .../AB

Re: [linux-sunxi] Re: [PATCH] arm: sunxi: input: RFC: Add sysfs voltage for sun4i-lradc driver

2015-01-27 Thread Maxime Ripard
On Tue, Jan 27, 2015 at 11:49:49AM +0200, Priit Laes wrote: > > On Tue, 2015-01-27 at 10:18 +0100, Maxime Ripard wrote: > > Hi, > > > > On Mon, Jan 26, 2015 at 06:58:32PM +0200, Priit Laes wrote: > > > --- > > > > Like Hans was pointing out, commit log and signed-off-by please > > > > > .../AB

Re: [linux-sunxi] Re: [PATCH] arm: sunxi: input: RFC: Add sysfs voltage for sun4i-lradc driver

2015-01-27 Thread Maxime Ripard
On Tue, Jan 27, 2015 at 11:52:34AM +0100, Hans de Goede wrote: > Hi, > > On 27-01-15 10:49, Priit Laes wrote: > > > >On Tue, 2015-01-27 at 10:18 +0100, Maxime Ripard wrote: > >>Hi, > >> > >>On Mon, Jan 26, 2015 at 06:58:32PM +0200, Priit Laes wrote: > >>>--- > >> > >>Like Hans was pointing out, co

Re: [PATCH v5 3/6] iio: adc: fsl,imx25-gcq driver

2015-01-27 Thread Jonathan Cameron
On 24/01/15 14:01, Markus Pargmann wrote: > This is a conversion queue driver for the mx25 SoC. It uses the central > ADC which is used by two seperate independent queues. This driver > prepares different conversion configurations for each possible input. > For a conversion it creates a conversionq

[PATCH 1/3] Make sure touch arbitration is applied consistently across devices

2015-01-27 Thread Ping Cheng
Signed-off-by: Ping Cheng --- drivers/hid/wacom_wac.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index f886149..6d490f6 100644 --- a/drivers/hid/wacom_wac.c +++ b/drivers/hid/wacom_wac.c @@ -1042,7 +1042,7 @@ static

[PATCH 2/3] Consolidate input capability settings for pen and touch

2015-01-27 Thread Ping Cheng
After PAD moved to its own interface, there were duplicated statements in wacom_setup_pentouch_input_capabilities. Merge them together to reduce future maintenance effort. Signed-off-by: Ping Cheng --- drivers/hid/wacom_wac.c | 67 - 1 file changed

[PATCH 3/3] Add support for Cintiq 27QHD and 27QHD touch

2015-01-27 Thread Ping Cheng
These devices have accelerometers. To report accelerometer coordinates, a new property, INPUT_PROP_ACCELEROMETER, is added. Signed-off-by: Ping Cheng --- drivers/hid/wacom_sys.c| 3 ++ drivers/hid/wacom_wac.c| 87 ++ drivers/hid/wacom_wac.h

Re: input: elantech.c: adding more Fujtisu notebooks to force crc_enabled

2015-01-27 Thread Dmitry Torokhov
On Tue, Jan 27, 2015 at 09:20:57AM +0100, Rainer Koenig wrote: > Extending the patch from November 2014 with two more Fujitsu LIFEBOOK > models that also ship the Elantech touchpad and don't work with > crc_disabled. > > Signed-off-by: Rainer Koenig Applied, thank you. However I am not happy wi

Re: [PATCH] HID: Add driver for synaptics keybard with broken rdesc

2015-01-27 Thread Andrew Duggan
On Tue, Jan 27, 2015 at 8:13 AM, Benjamin Tissoires wrote: > On Tue, Jan 27, 2015 at 10:10 AM, Simon Wörner wrote: >> Thanks for the feedback, this is my first commit to the linux kernel so >> I don't know much about how the input / hid is working. >> >> I will add the changelog to the patch emai

Re: [linux-sunxi] Re: [PATCH] arm: sunxi: input: RFC: Add sysfs voltage for sun4i-lradc driver

2015-01-27 Thread Dmitry Torokhov
On Tue, Jan 27, 2015 at 08:44:47PM +0100, Maxime Ripard wrote: > On Tue, Jan 27, 2015 at 11:52:34AM +0100, Hans de Goede wrote: > > Hi, > > > > On 27-01-15 10:49, Priit Laes wrote: > > > > > >On Tue, 2015-01-27 at 10:18 +0100, Maxime Ripard wrote: > > >>Hi, > > >> > > >>On Mon, Jan 26, 2015 at 06:

RE: input: elantech.c: adding more Fujtisu notebooks to force crc_enabled

2015-01-27 Thread duson
Loop Sam Hi Sam, Please help to take care this. Duson > -Original Message- > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] > Sent: Wednesday, January 28, 2015 7:28 AM > To: Rainer Koenig > Cc: linux-input@vger.kernel.org; jeff.chuang7...@gmail.com; > james.c...@emc.com.tw;

Re: [PATCH] HID: Add driver for synaptics keybard with broken rdesc

2015-01-27 Thread Simon Wörner
The new version is nearly finished, I will send it later today. See below for additional changes not in the other mails. Am 28.01.15 um 00:46 schrieb Andrew Duggan: > On Tue, Jan 27, 2015 at 8:13 AM, Benjamin Tissoires > wrote: >> On Tue, Jan 27, 2015 at 10:10 AM, Simon Wörner >> wrote: >>> Tha