> > +static int gpio_joy_probe(struct platform_device *pdev) {
> > + struct device *dev = &pdev->dev;
> > + struct input_dev *input;
> > + struct gpio_joy_drvdata *ddata;
> > + int i, err;
> > + unsigned int debounce_ms;
>
> This should be a u32 given you pass it to a function expecting
> The binding should be for a class of hardware, not for a driver. Please
> describe the class of hardware the binding represents, and remove
> references to the Linux driver.
Will do.
>
> > +Required properties:
> > + - compatible= "gpio-joy";
>
> That does not strike me as a very infor
Hi Dmitry,
> Why do we need this new driver when we have gpio-keys driver that can be
> configured to emit ABS_* events?
>
As far as I can tell, there is no way to specify values for ABS-"keys" in the
device tree binding.
While both the device tree binding and the gpio-keys driver could possib
On Fri, Jan 30, 2015 at 03:47:40PM +0100, Krzysztof Kozlowski wrote:
> Add new structure 'power_supply_config' for holding run-time
> initialization data like of_node, supplies and private driver data.
>
> The power_supply_register() function is changed so all power supply
> drivers need updating.
On Sat, Feb 07, 2015 at 12:41:24AM +0100, Michael Grzeschik wrote:
> On Fri, Feb 06, 2015 at 03:24:48PM -0800, Dmitry Torokhov wrote:
> > On Fri, Feb 06, 2015 at 12:05:48PM +0100, Michael Grzeschik wrote:
> > > With the datardy irq we get the information if the
> > > pen got pulled from the screen.
On Fri, Feb 06, 2015 at 03:24:48PM -0800, Dmitry Torokhov wrote:
> On Fri, Feb 06, 2015 at 12:05:48PM +0100, Michael Grzeschik wrote:
> > With the datardy irq we get the information if the
> > pen got pulled from the screen. This patch changes
> > the irq by checking this condition every time inste
On Fri, Feb 06, 2015 at 05:41:39PM +0800, Sonic Zhang wrote:
> From: Sonic Zhang
>
> Signed-off-by: Sonic Zhang
Reviewed-by: Dmitry Torokhov
I do not think arch changes shoudl go through my tree though...
> ---
> arch/blackfin/include/asm/portmux.h | 15 +++
> 1 file changed,
On Fri, Feb 06, 2015 at 12:05:48PM +0100, Michael Grzeschik wrote:
> With the datardy irq we get the information if the
> pen got pulled from the screen. This patch changes
> the irq by checking this condition every time instead
> of triggering the worker.
>
> Signed-off-by: Michael Grzeschik
> -
Hi,
This is the second episode of the Lenovo 2015 party :)
Thanks to Andrew, we now have an idea within the driver of what are the extra
buttons aimed for, and the patch series looks cleaner.
Many thanks for your help.
I marked only patches 1/7, 2/7 and 3/7 as stable because they are really
stab
Newer Synaptics touchpads need to get information from the query $10.
Retrieve it if available.
Signed-off-by: Benjamin Tissoires
---
v2:
- brand new
drivers/input/mouse/synaptics.c | 23 ---
drivers/input/mouse/synaptics.h | 23 +++
2 files changed, 43
The 2015 series of the Lenovo thinkpads added back the hardware buttons
on top of the touchpad for the trackstick.
Unfortunately, Lenovo used the PNPIDs that are supposed to be
"5 buttons" touchpads, so the new laptops also have the
INPUT_PROP_TOPBUTTONPAD. Yay!
Instead of manually removing each
The 2015 series of the Lenovo thinkpads added back the hardware buttons
on top of the touchpad for the trackstick.
Unfortunately, they are wired to the touchpad, and not the trackstick.
Thus, they are seen as extra buttons from the kernel point of view.
This leads to a problem in user space becau
Lenovo decided to switch back to physical buttons for the trackstick
on their latest series. The PNPId list was provided before they reverted
back to physical buttons, so it contains the new models too.
We can know from the touchpad capabilities that the touchpad has physical
buttons, so removing t
The Fimware 8.1 has a bug in which the extra buttons are only sent
when the ExtBit is 1.
This should be fixed in a future FW update which should have a bump
of the minor version.
Cc: sta...@vger.kernel.org
Signed-off-by: Benjamin Tissoires
---
v2:
- break out extra buttons reporting in its own f
From: Dmitry Torokhov
On the X1 Carbon 3rd gen (with a 2015 broadwell cpu), the physical middle
button of the trackstick (attached to the touchpad serio device, of course)
seems to get lost.
Actually, the touchpads reports 3 extra buttons, which falls in the switch
below to the '2' case. Let's h
The board id capability has been added in firmware 7.5.
Cc: sta...@vger.kernel.org
Signed-off-by: Benjamin Tissoires
---
v2:
- brand new
drivers/input/mouse/synaptics.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
ind
On 02/06/2015 10:44 AM, Benjamin Tissoires wrote:
From: Daniel Martin
Query the min dimensions even if the check
SYN_EXT_CAP_REQUESTS(priv->capabilities) >= 7
fails, but we know that the firmware version 8.1 is safe.
With that we don't need quirks for post-2013 models anymore as they
ex
> This patch series improves handling of various Logitech gaming wheels and
> allows switching between various compatibility modes which might be useful
> to improve compatibility with very old games and testing purposes.
Hi all,
We should note that part 1 performs a very important function of ide
Hi Roger,
On Fri, Feb 06, 2015 at 02:53:10PM +0200, Roger Quadros wrote:
> The controller has a RESET pin which is usually controlled over
> a GPIO line. If such a GPIO is provided, perform a RESET
> during probe.
>
> Signed-off-by: Roger Quadros
> ---
> .../bindings/input/touchscreen/pixcir_i2
Display the real wheel model and supported alternate modes through sysfs. This
applies only to multimode wheels.
Signed-off-by: Michal Malý
---
drivers/hid/hid-lg4ff.c | 209 ++--
1 file changed, 202 insertions(+), 7 deletions(-)
diff --git a/drivers
Identify Logitech gaming wheels in compatibility modes accordingly to Logitech
specifications.
Logitech specification contains a general method of identifying various
models of their gaming wheels while they are in "compatibility" mode.
This patch implements the method instead of checking against
Allow switching of Logitech gaming wheels between available compatibility modes
through sysfs. This only applies to multimode wheels.
Signed-off-by: Michal Malý
---
.../ABI/testing/sysfs-driver-hid-logitech-lg4ff| 45 +
drivers/hid/hid-lg4ff.c| 203 +
This patch series improves handling of various Logitech gaming wheels and
allows switching between various compatibility modes which might be useful
to improve compatibility with very old games and testing purposes.
Signed-off-by: Michal Malý
Michal Malý (4):
Identify Logitech gaming wheels i
Introduce a module parameter to disable automatic switch of Logitech gaming
wheels from compatibility to native mode. This only applies to multimode wheels.
Signed-off-by: Michal Malý
---
drivers/hid/hid-lg.c| 6 ++
drivers/hid/hid-lg4ff.c | 4 +++-
2 files changed, 9 insertions(+), 1 d
On Fri, Feb 06, 2015 at 02:51:13PM +0100, Rasmus Villemoes wrote:
> There's no %px extension. From the context I think the intention was
> to dump the five bytes which were not as expected, and for that one
> should use %ph.
>
> Signed-off-by: Rasmus Villemoes
Applied, thank you.
> ---
> I thin
From: Daniel Martin
Query the min dimensions even if the check
SYN_EXT_CAP_REQUESTS(priv->capabilities) >= 7
fails, but we know that the firmware version 8.1 is safe.
With that we don't need quirks for post-2013 models anymore as they
expose correct min and max dimensions.
Bugzilla: https:/
On Tue, 27 Jan 2015 15:45:59 +0100
Antonio Ospite wrote:
> On Wed, 21 Jan 2015 12:16:54 +0200
> Mika Westerberg wrote:
>
> > On Tue, Jan 20, 2015 at 05:56:45PM +0100, Antonio Ospite wrote:
[...]
> > > [9.056300] gpiochip_get_desc: hwnum: 68 chip->ngpio: 44
> > > [9.056303] acpi_find_gpi
From: Daniel Martin
Logging the dimension values we queried (info) and the values we use
from a quirk to overwrite (warn) can be helpful for debugging.
This partly relates to bug:
https://bugzilla.kernel.org/show_bug.cgi?id=91541
Cc: sta...@vger.kernel.org
Signed-off-by: Daniel Martin
---
From: Daniel Martin
Split the function synaptics_resolution() into
synaptics_resolution() and synaptics_quirks().
synaptics_resolution() will be called before synaptics_quirks() to query
dimensions and resolutions before overwriting them with quirks.
Cc: sta...@vger.kernel.org
Signed-off-by
From: Daniel Martin
Add a min/max range for board ids to the min/max coordinates quirk. This
makes it possible to restrict quirks to specific models based upon their
board id. The define ANY_BOARD_ID (0) serves as a wildcard.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=91541
Cc: sta..
From: Daniel Martin
The firmware of the X240 (LEN0035, 2013/12) exposes the same values
x [1232..5710], y [1156..4696]
as the quirk applies.
Cc: sta...@vger.kernel.org
Signed-off-by: Daniel Martin
---
drivers/input/mouse/synaptics.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
post-2013 Lenovo laptops provide correct min/max dimensions, which
are different with the ones currently quirked.
According to https://bugzilla.kernel.org/show_bug.cgi?id=91541
The following board ids are assigned in the post-2013 touchpads:
t440p/t440s: LEN0036 -> 2964/2962
t540p: LEN0034 -
Hi,
Here is the v4 of Daniel's patch series regarding
https://bugzilla.kernel.org/show_bug.cgi?id=91541
I am resending the whole series to add the "cc: stable@" flags and
to fix v3 5/5 which did not applied properly on top of input.git/for-next.
Cheers,
Benjamin
Benjamin Tissoires (1):
Input:
On Fri, Feb 6, 2015 at 10:06 AM, Sonic Zhang wrote:
>> static struct platform_driver bfin_rotary_device_driver = {
>> .probe = bfin_rotary_probe,
>> .remove = bfin_rotary_remove,
>> .driver = {
>> .name = "bfin-rotary",
>
> You mi
Hi Hans,
On February 6, 2015 1:32:00 AM PST, Hans Holmberg
wrote:
>This series adds a driver for digital joysticks connected
>via GPIOs.
Why do we need this new driver when we have gpio-keys driver that can be
configured to emit ABS_* events?
Thanks.
--
Dmitry
--
To unsubscribe from this li
On Fri 2015-02-06 15:43:08, Krzysztof Kozlowski wrote:
> On pią, 2015-02-06 at 14:49 +0100, Pavel Machek wrote:
> > On Fri 2015-01-30 15:47:58, Krzysztof Kozlowski wrote:
> > > Use power_supply_put() to decrement the power supply's device reference
> > > counter.
> > >
> > > Signed-off-by: Krzyszt
On pią, 2015-02-06 at 14:49 +0100, Pavel Machek wrote:
> On Fri 2015-01-30 15:47:58, Krzysztof Kozlowski wrote:
> > Use power_supply_put() to decrement the power supply's device reference
> > counter.
> >
> > Signed-off-by: Krzysztof Kozlowski
> > Reviewed-by: Bartlomiej Zolnierkiewicz
> > Revie
Again, Thanks for the respin.
On Fri, Feb 6, 2015 at 8:25 AM, Daniel Martin wrote:
> Hi folks,
>
> this is the third version of my patches to address the bug:
> https://bugzilla.kernel.org/show_bug.cgi?id=91541
>
> One task on top of patch 5 remains: Find suitable board id ranges.
> I.e. in t
Thanks Daniel for the respin.
On Fri, Feb 6, 2015 at 8:25 AM, Daniel Martin wrote:
> From: Daniel Martin
>
> Query the min dimensions even if the check
> SYN_EXT_CAP_REQUESTS(priv->capabilities) >= 7
> fails, but we know that the firmware version 8.1 is safe.
>
> With that we don't need quir
There's no %px extension. From the context I think the intention was
to dump the five bytes which were not as expected, and for that one
should use %ph.
Signed-off-by: Rasmus Villemoes
---
I think the bug is mostly harmless, since the unrecognized extension
is simply ignored (and skipped over), a
On Fri 2015-01-30 15:47:58, Krzysztof Kozlowski wrote:
> Use power_supply_put() to decrement the power supply's device reference
> counter.
>
> Signed-off-by: Krzysztof Kozlowski
> Reviewed-by: Bartlomiej Zolnierkiewicz
> Reviewed-by: Sebastian Reichel
11,13,20 nothing obviously wrong. But I'm
From: Daniel Martin
Split the function synaptics_resolution() into
synaptics_resolution() and synaptics_quirks().
synaptics_resolution() will be called before synaptics_quirks() to query
dimensions and resolutions before overwriting them with quirks.
v2: Removed SYN_ID_MAJOR() check from sy
From: Daniel Martin
Logging the dimension values we queried (info) and the values we use
from a quirk to overwrite (warn) can be helpful for debugging.
This partly relates to bug:
https://bugzilla.kernel.org/show_bug.cgi?id=91541
Signed-off-by: Daniel Martin
---
drivers/input/mouse/synapt
From: Daniel Martin
Query the min dimensions even if the check
SYN_EXT_CAP_REQUESTS(priv->capabilities) >= 7
fails, but we know that the firmware version 8.1 is safe.
With that we don't need quirks for post-2013 models anymore as they
expose correct min and max dimensions.
v2: Don't use a l
Add a min/max range for board ids to the min/max coordinates quirk. This
makes it possible to restrict quirks to specific models based upon their
board id. The define ANY_BOARD_ID (0) serves as a wildcard.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=91541
Signed-off-by: Daniel Martin
--
From: Daniel Martin
The firmware of the X240 (LEN0035, 2013/12) exposes the same values
x [1232..5710], y [1156..4696]
as the quirk applies.
Signed-off-by: Daniel Martin
---
drivers/input/mouse/synaptics.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/mo
Hi folks,
this is the third version of my patches to address the bug:
https://bugzilla.kernel.org/show_bug.cgi?id=91541
One task on top of patch 5 remains: Find suitable board id ranges.
I.e. in the first comment of the bug, the board id 2962 is the lowest
one that I know of for a post-2013 m
The controller has a RESET pin which is usually controlled over
a GPIO line. If such a GPIO is provided, perform a RESET
during probe.
Signed-off-by: Roger Quadros
---
.../bindings/input/touchscreen/pixcir_i2c_ts.txt | 3 ++
drivers/input/touchscreen/pixcir_i2c_ts.c | 37
With the datardy irq we get the information if the
pen got pulled from the screen. This patch changes
the irq by checking this condition every time instead
of triggering the worker.
Signed-off-by: Michael Grzeschik
---
v1 -> v2: - removed adc_on variable
- added locking for irq switch
On Fri, Feb 06, 2015 at 09:32:02AM +, Hans Holmberg wrote:
> This is an interrupt-driven driver for digital joysticks
> connected to GPIOs. Supports any digital joystick with
> signals for up, down, left, right and one signal for
> trigger button press, i.e. C64/Atari joysticks.
>
> Signed-off
On Fri, Feb 06, 2015 at 09:32:01AM +, Hans Holmberg wrote:
> This document describes the Device Tree bindings for the gpio-joy
> driver.
>
> Signed-off-by: Hans Holmberg
> ---
> .../devicetree/bindings/input/gpio-joy.txt | 29
> ++
> 1 file changed, 29 insertions
From: Sonic Zhang
Signed-off-by: Sonic Zhang
---
arch/blackfin/include/asm/portmux.h | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/arch/blackfin/include/asm/portmux.h
b/arch/blackfin/include/asm/portmux.h
index ccb96ca..2f6893e 100644
--- a/arch/blackfi
Hi Dmitry,
After apply your patch manually to my blackfin kernel tree, I got
kernel panic when probe the rotary.
NULL pointer access
Kernel OOPS in progress
Deferred Exception context
CURRENT PROCESS:
COMM=swapper PID=1 CPU=0
invalid mm
return address: [0x00167648]; contents of:
0x00167620: f00
This is an interrupt-driven driver for digital joysticks
connected to GPIOs. Supports any digital joystick with
signals for up, down, left, right and one signal for
trigger button press, i.e. C64/Atari joysticks.
Signed-off-by: Hans Holmberg
---
drivers/input/joystick/Kconfig| 10 ++
driver
This series adds a driver for digital joysticks connected
via GPIOs.
Tested on Rasperry Pi and Minnowboard MAX using evtest.
The DSDT AML-code snippet below illustrates how to configure a joystick
on the Minnowboard MAX, using the new _DSD support in the kernel.
Scope (_SB)
{
Device (JO
This document describes the Device Tree bindings for the gpio-joy
driver.
Signed-off-by: Hans Holmberg
---
.../devicetree/bindings/input/gpio-joy.txt | 29 ++
1 file changed, 29 insertions(+)
create mode 100644 Documentation/devicetree/bindings/input/gpio-joy.txt
di
Hi Dmitry,
On Fri, Feb 6, 2015 at 2:56 PM, Dmitry Torokhov
wrote:
> Introduce open and close methods for the input device to postpone enabling
> the device until it is needed.
>
> Signed-off-by: Dmitry Torokhov
> ---
>
> Hi Sonic,
>
> Could you please tell me if the driver still works with this
Hi Dmitry,
On Fri, Feb 6, 2015 at 2:09 PM, Dmitry Torokhov
wrote:
> Instead of using #ifdef to guard potentially unused suspend and resume code
> let's mark them as __maybe_unused so they still get discarded if they are
> not used but we do not get warning. This allows for better compile coverage
58 matches
Mail list logo
