Dear Sébastien SZYMANSKI,
On Fri, 27 Feb 2015 12:09:51 +0100, Sébastien SZYMANSKI wrote:
error = input_register_device(sx8654-input);
if (error)
return error;
Where is your -remove() function that unregisters the input device?
Best regards,
Thomas
--
Thomas
Hi Dan
The patch dc3c78e43469: HID: usbhid: Check HID report descriptor
contents after device reset from Apr 3, 2012, leads to the following
static checker warning:
drivers/hid/usbhid/hid-core.c:1591 hid_reset_resume()
warn: bool comparison is always 'true'
On Fri, Feb 27, 2015 at 08:59:44AM -0800, Dmitry Torokhov wrote:
On Fri, Feb 27, 2015 at 12:09:51PM +0100, Sébastien SZYMANSKI wrote:
Hi,
I am writing an I2C touchscreen driver for an i.MX6 based board. I
compiled it as a module and when I unload it, I get the following warning:
#
On Fri, Feb 27, 2015 at 07:29:30AM -0800, Dmitry Torokhov wrote:
On February 27, 2015 6:37:25 AM PST, Thomas Petazzoni
thomas.petazz...@free-electrons.com wrote:
Dear Sébastien SZYMANSKI,
On Fri, 27 Feb 2015 12:09:51 +0100, Sébastien SZYMANSKI wrote:
error =
On Thu, Feb 26, 2015 at 11:38 PM, Jiri Kosina jkos...@suse.cz wrote:
On Fri, 20 Feb 2015, Ping Cheng wrote:
Hi Jiri,
This set is based on your for-3.20/upstream-fixes branch.
If pen comes in proximity while touch is down, we force touch up
before sending pen events. This idea has been
On Thu, Feb 26, 2015 at 11:49:36AM +0900, Jaewon Kim wrote:
Hi Dmitry,
On 26/02/2015 10:23, Dmitry Torokhov wrote:
Hi Jaewon,
On Tue, Feb 24, 2015 at 10:29:07AM +0900, Jaewon Kim wrote:
+static void max77843_haptic_play_work(struct work_struct *work)
+{
+ struct max77843_haptic
On Fri, Feb 27, 2015 at 12:09:51PM +0100, Sébastien SZYMANSKI wrote:
Hi,
I am writing an I2C touchscreen driver for an i.MX6 based board. I
compiled it as a module and when I unload it, I get the following warning:
# modprobe sx8654
[ 46.261494] input: SX8654 I2C Touchscreen as
On Fri, Feb 27, 2015 at 06:05:45PM +0100, Uwe Kleine-König wrote:
On Fri, Feb 27, 2015 at 07:29:30AM -0800, Dmitry Torokhov wrote:
On February 27, 2015 6:37:25 AM PST, Thomas Petazzoni
thomas.petazz...@free-electrons.com wrote:
Dear Sébastien SZYMANSKI,
On Fri, 27 Feb 2015 12:09:51
[adding Florian to the thread, he is also affected by this]
On Tue, Feb 17, 2015 at 9:01 PM, Andrew Duggan adug...@synaptics.com wrote:
On 02/17/2015 04:30 AM, Jiri Kosina wrote:
On Thu, 29 Jan 2015, li...@simon-woerner.de wrote:
From: Simon Wörner m...@simon-woerner.de
HID: Add driver for
On Fri, Feb 27, 2015 at 6:25 AM, Florian Echtler f...@butterbrot.org wrote:
Hello Benjamin,
On 27.02.2015 01:46, Benjamin Tissoires wrote:
On Thu, Feb 26, 2015 at 6:18 PM, Florian Echtler f...@butterbrot.org wrote:
The device in question has two endpoints:
T: Bus=02 Lev=02 Prnt=04 Port=02
Just as a quick side note, Simon's hack compiled as a standalone
module fixes the issue for me on stock kernel 3.16.0 - keyboard works
perfectly now. So device 06CB:2991 has exactly the same broken
descriptor and should probably included in any future solution.
Many thanks to everyone involved!
On Mon 2015-02-23 13:03:17, Jiri Kosina wrote:
On Sun, 22 Feb 2015, Frank Praznik wrote:
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-sony.c
Hello,
On Fri, Feb 27, 2015 at 09:46:11AM -0800, Dmitry Torokhov wrote:
On Fri, Feb 27, 2015 at 06:05:45PM +0100, Uwe Kleine-König wrote:
On Fri, Feb 27, 2015 at 07:29:30AM -0800, Dmitry Torokhov wrote:
On February 27, 2015 6:37:25 AM PST, Thomas Petazzoni
On February 27, 2015 6:37:25 AM PST, Thomas Petazzoni
thomas.petazz...@free-electrons.com wrote:
Dear Sébastien SZYMANSKI,
On Fri, 27 Feb 2015 12:09:51 +0100, Sébastien SZYMANSKI wrote:
error = input_register_device(sx8654-input);
if (error)
return error;
Hi,
I am writing an I2C touchscreen driver for an i.MX6 based board. I
compiled it as a module and when I unload it, I get the following warning:
# modprobe sx8654
[ 46.261494] input: SX8654 I2C Touchscreen as
/devices/soc0/soc/210.aips-bus/21a.i2c/i2c-0/0-0048/input/input1
# rmmod
On Fri 2015-02-27 09:20:01, Krzysztof Kozlowski wrote:
Use power_supply_put() to decrement the power supply's device reference
counter.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Reviewed-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
Reviewed-by: Sebastian Reichel
On Fri, Feb 27, 2015 at 12:18 PM, Jiri Kosina jkos...@suse.cz wrote:
On Fri, 27 Feb 2015, Ping Cheng wrote:
before sending pen events. This idea has been implemented for
Tablet PCs. But other tablets that support both pen and touch are
not fully considered.
Ping Cheng (2):
HID:
On Fri, 27 Feb 2015, Ping Cheng wrote:
before sending pen events. This idea has been implemented for
Tablet PCs. But other tablets that support both pen and touch are
not fully considered.
Ping Cheng (2):
HID: wacom: do not send pen events before touch is up/forced out
HID:
According to [1], Windows Precision Touchpad devices must supply
a button type usage in the device capabilities feature report. A
value of 0 indicates that the device contains a depressible
button (i.e. it's a click-pad) whereas a value of 1 indicates
a non-depressible button. Add support for this
Use power_supply_put() to decrement the power supply's device reference
counter.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by: Pavel Machek pa...@ucw.cz
Reviewed-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
Reviewed-by: Sebastian Reichel s...@kernel.org
---
Use power_supply_put() to decrement the power supply's device reference
counter.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by: Pavel Machek pa...@ucw.cz
Reviewed-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
Reviewed-by: Sebastian Reichel s...@kernel.org
---
Use power_supply_put() to decrement the power supply's device reference
counter (increased by power_supply_get_by_name() or
power_supply_get_by_phandle()).
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by: Pavel Machek pa...@ucw.cz
Reviewed-by: Bartlomiej Zolnierkiewicz
Replace direct usage of put_device() with new API: power_supply_put().
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by: Pavel Machek pa...@ucw.cz
Reviewed-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
Reviewed-by: Sebastian Reichel s...@kernel.org
---
Use power_supply_put() to decrement the power supply's device reference
counter.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Reviewed-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
Reviewed-by: Sebastian Reichel s...@kernel.org
Acked-by: Robert Jarzmik
Use power_supply_put() to decrement the power supply's device reference
counter.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by: Pavel Machek pa...@ucw.cz
Acked-by: Linus Walleij linus.wall...@linaro.org
Acked-by: Lee Jones lee.jo...@linaro.org
Reviewed-by: Bartlomiej
Replace direct calls to power supply function attributes with wrappers.
Wrappers provide safe access in case of unregistering the power
supply (e.g. by removing the driver). Replace:
- get_property - power_supply_get_property
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by:
Replace direct calls to power supply function attributes with wrappers.
Wrappers provide safe access in case of unregistering the power
supply (e.g. by removing the driver). Replace:
- get_property - power_supply_get_property
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by:
Replace direct calls to power supply function attributes with wrappers.
Wrappers provide safe access in case of unregistering the power
supply (e.g. by removing the driver). Replace:
- get_property - power_supply_get_property
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by:
Add new structure 'power_supply_config' for holding run-time
initialization data like of_node, supplies and private driver data.
The power_supply_register() function is changed so all power supply
drivers need updating.
When registering the power supply this new 'power_supply_config' should be
Hi,
The patchset fixes invalid memory accesses in certain race scenarios by
moving ownership of struct power_supply to the core. All drivers are
modified.
TLDR for driver and subsystem maintainers
=
Two patches of patchset change power_supply_register()
Replace direct usage of put_device() with new API: power_supply_put().
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by: Pavel Machek pa...@ucw.cz
Reviewed-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
Reviewed-by: Sebastian Reichel s...@kernel.org
---
Replace direct calls to power supply function attributes with wrappers.
Wrappers provide safe access in case of unregistering the power
supply (e.g. by removing the driver). Replace:
- get_property - power_supply_get_property
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by:
Replace direct calls to power supply function attributes with wrappers.
Wrappers provide safe access in case of unregistering the power
supply (e.g. by removing the driver). Replace:
- get_property - power_supply_get_property
- set_property - power_supply_set_property
- property_is_writeable -
Replace direct calls to power supply function attributes with wrappers.
Wrappers provide safe access in case of unregistering the power
supply (e.g. by removing the driver). Replace:
- get_property - power_supply_get_property
- set_property - power_supply_set_property
Signed-off-by: Krzysztof
Add simple wrappers for accessing power supply's function attributes:
- get_property - power_supply_get_property
- set_property - power_supply_set_property
- property_is_writeable - power_supply_property_is_writeable
- external_power_changed - power_supply_external_power_changed
This API
On Thu, Feb 26, 2015, at 03:18, Darren Hart wrote:
On Fri, Feb 20, 2015 at 03:44:10PM +0100, Bastien Nocera wrote:
Rather than checking on each suspend and resume whether the laptop
has an adaptive keyboard, check when the driver is initialised.
Bastien, am I awaiting another version of
On Thu, Feb 26, 2015, at 08:22, Bastien Nocera wrote:
On Wed, 2015-02-25 at 22:18 -0800, Darren Hart wrote:
On Fri, Feb 20, 2015 at 03:44:10PM +0100, Bastien Nocera wrote:
Rather than checking on each suspend and resume whether the laptop
has an adaptive keyboard, check when the driver is
On Fri, Feb 27, 2015, at 08:05, Henrique de Moraes Holschuh wrote:
On Thu, Feb 26, 2015, at 03:18, Darren Hart wrote:
On Fri, Feb 20, 2015 at 03:44:10PM +0100, Bastien Nocera wrote:
Rather than checking on each suspend and resume whether the laptop
has an adaptive keyboard, check when the
This fixes memory leak introduced by commit
a09221e83e13e09a33109b9b037484eade901cea
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
drivers/input/mouse/alps.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/input/mouse/alps.c
PNP IDs are supposed to be case-insensitive and so we should compare
them as such.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
drivers/input/mouse/psmouse-base.c | 39 +++---
1 file changed, 32 insertions(+), 7 deletions(-)
diff --git
Hello Simon Haggett,
The patch dc3c78e43469: HID: usbhid: Check HID report descriptor
contents after device reset from Apr 3, 2012, leads to the following
static checker warning:
drivers/hid/usbhid/hid-core.c:1591 hid_reset_resume()
warn: bool comparison is always 'true'
On 12 February 2015 at 18:09, Benjamin Tissoires
benjamin.tissoi...@redhat.com wrote:
Lenovo X250 has a PnpID of LEN0046, but it does not have
the top software button requirement.
Confirmed.
For the record, Lenovo T450s and W541 have a PnpID of
LEN200f and LEN004a, so they are not on the top
Hello Benjamin,
On 27.02.2015 01:46, Benjamin Tissoires wrote:
On Thu, Feb 26, 2015 at 6:18 PM, Florian Echtler f...@butterbrot.org wrote:
The device in question has two endpoints:
T: Bus=02 Lev=02 Prnt=04 Port=02 Cnt=01 Dev#= 7 Spd=12 MxCh= 0
D: Ver= 2.00 Cls=00(ifc ) Sub=00 Prot=00
43 matches
Mail list logo
