Re: Input: atmel_mxt_ts - status of the for-dtor branch and sscanf issue

2015-03-03 Thread Dirk Behme
Hi Nick, On 04.02.2015 15:46, Dirk Behme wrote: On 27.01.2015 18:31, Nick Dyer wrote: On 19/01/15 13:08, Dirk Behme wrote: we have two questions regarding the atmel_mxt_ts driver: First, what's the status of your github 'for-dtor' branch [1]? Is this subject to change? Or how stable is it? Wi

Re: Bug in i2c-core?

2015-03-03 Thread Wolfram Sang
> > Yes, this commit breaks all drivers using devm* for IRQ management on > > OF-based systemsi because devm* cleanup happens in device code, after > > bus's remove() method returns. I'd recommend reverting and finding a > > better way (making cleanup a custom devm action as well?). > > Ouch, my

Re: [PATCH] HID: wacom: ask for a in-prox report when it was missed

2015-03-03 Thread Jason Gerecke
On 3/3/2015 9:20 AM, Benjamin Tissoires wrote: If noone listens to the input device when a tool comes in proximity, the tablet does not send the in-prox event when a client becomes available. That means that no events will be sent until the tool is taken out of proximity. In this situation, ask

Re: Bug in i2c-core?

2015-03-03 Thread Laurent Pinchart
Hi Dmitry, On Friday 27 February 2015 08:59:44 Dmitry Torokhov wrote: > On Fri, Feb 27, 2015 at 12:09:51PM +0100, Sébastien SZYMANSKI wrote: > > Hi, > > > > I am writing an I2C touchscreen driver for an i.MX6 based board. I > > compiled it as a module and when I unload it, I get the following war

Re: [PATCH] Add drivers for Logitech G110, G13, G15v2 and G19

2015-03-03 Thread Paul Bolle
On Mon, 2015-02-23 at 22:47 +0200, Ciprian Ciubotariu wrote: > On Saturday 21 February 2015 18:21:20 Paul Bolle wrote: > > Apparently Alistair Buxton, Rick L Vinyard Jr, and Thomas Berger were > > involved with this code too. There's no mention of them in the commit > > explanation. They're also no

Re: [PATCH v3 0/6] HID: huion/uclogic merge and few additions

2015-03-03 Thread Jiri Kosina
On Tue, 3 Mar 2015, Benjamin Tissoires wrote: > Resent the full series with Nick's Rev-by and fixes in 6/6. > > Again, this is the upstream patches, DIGImend-devel is just added > to inform of the progress. I finally got to go through this patchset, good work, thanks for pursuing it. Now appli

Re: [PATCH v3 6/6] HID: uclogic: actually invert the in-range bit for huion tablets only

2015-03-03 Thread Benjamin Tissoires
On Mar 03 2015 or thereabouts, Nikolai Kondrashov wrote: > On 03/03/2015 07:44 PM, Benjamin Tissoires wrote: > >This hack is only needed for Huion tablets. It does not seem to have > >any effect on the other tablets handled by this device right now, but > >it's better to check for the product id so

Re: [ibm-acpi-devel] [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-03-03 Thread Henrique de Moraes Holschuh
On Tue, Mar 3, 2015, at 13:52, Darren Hart wrote: > Henrique, I believe I may have overstepped with thinkpad-acpi and dealt > with it like the other drivers in platform/drivers/x86, when instead I should > have been leaving it to you. My apologies, it was not intentional. No harm done! And I did

Re: [PATCH v3 6/6] HID: uclogic: actually invert the in-range bit for huion tablets only

2015-03-03 Thread Nikolai Kondrashov
On 03/03/2015 07:44 PM, Benjamin Tissoires wrote: This hack is only needed for Huion tablets. It does not seem to have any effect on the other tablets handled by this device right now, but it's better to check for the product id sooner than discovering that we have messed up one tablet later. Si

[PATCH v3 4/6] HID: uclogic: apply quirk NO_EMPTY_INPUT

2015-03-03 Thread Benjamin Tissoires
NO_EMPTY_INPUT is useful when MULTI_INPUT is set. It prevents to create empty input nodes that user space does not know what to do with. It does not seem to be required at the moment, this is just a preventive patch. This check is only made during the plug of the device, so it does not hurt to hav

[PATCH v3 2/6] HID: uclogic: merge hid-huion driver in hid-uclogic

2015-03-03 Thread Benjamin Tissoires
From: Nikolai Kondrashov Merge the hid-huion driver into hid-uclogic as all the devices supported by hid-huion are in fact UC-Logic devices. Signed-off-by: Nikolai Kondrashov Signed-off-by: Benjamin Tissoires --- no changes in v3 no changes in v2 drivers/hid/Kconfig | 8 +- drivers/

[PATCH v3 0/6] HID: huion/uclogic merge and few additions

2015-03-03 Thread Benjamin Tissoires
Resent the full series with Nick's Rev-by and fixes in 6/6. Again, this is the upstream patches, DIGImend-devel is just added to inform of the progress. Cheers, Benjamin Benjamin Tissoires (6): HID: uclogic: Set quirks from inside the driver HID: uclogic: merge hid-huion driver in hid-uclogi

[PATCH v3 3/6] HID: uclogic: name the input nodes based on their tool

2015-03-03 Thread Benjamin Tissoires
We append "Pen", "Pad", "Mouse", "Keyboard", "Consumer Control" or "System Control" suffix to the appropriate input node to match what the Wacom driver does and be more convenient for the user to know which one is which. Reviewed-by: Nikolai Kondrashov Signed-off-by: Benjamin Tissoires --- no c

[PATCH v3 1/6] HID: uclogic: Set quirks from inside the driver

2015-03-03 Thread Benjamin Tissoires
Based on a patch from: Nikolai Kondrashov Most of the tablets handled by hid-uclogic already use MULTI_INPUT. For the ones which are not quirked in usbhid/hidquirks, they have a custom report descriptor which contains only one report per HID interface. For those tablets HID_QUIRK_MULTI_INPUT is t

[PATCH v3 5/6] HID: uclogic: discard the extra Pen input node on Huion tablets

2015-03-03 Thread Benjamin Tissoires
Some Huion tablets present 2 HID Pen interfaces. Only one is used, so we can drop the unused one. Reviewed-by: Nikolai Kondrashov Signed-off-by: Benjamin Tissoires --- no changes in v3 new in v2 drivers/hid/hid-uclogic.c | 20 1 file changed, 20 insertions(+) diff --git

[PATCH v3 6/6] HID: uclogic: actually invert the in-range bit for huion tablets only

2015-03-03 Thread Benjamin Tissoires
This hack is only needed for Huion tablets. It does not seem to have any effect on the other tablets handled by this device right now, but it's better to check for the product id sooner than discovering that we have messed up one tablet later. Signed-off-by: Benjamin Tissoires --- changes in v3:

[PATCH] HID: wacom: ask for a in-prox report when it was missed

2015-03-03 Thread Benjamin Tissoires
If noone listens to the input device when a tool comes in proximity, the tablet does not send the in-prox event when a client becomes available. That means that no events will be sent until the tool is taken out of proximity. In this situation, ask for the report WACOM_REPORT_INTUOSREAD which will

Re: [PATCH 4/4] thinkpad_acpi: Add support for more adaptive kbd buttons

2015-03-03 Thread Darren Hart
On Mon, Mar 02, 2015 at 02:17:01PM -0300, Henrique de Moraes Holschuh wrote: > On Mon, Mar 2, 2015, at 10:45, Bastien Nocera wrote: > > This commit adds new elements to the ThinkPad keymaps, and > > will send key events for keys for which an input.h declaration > > exists. > > > > Signed-off-by: B

Re: [ibm-acpi-devel] [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-03-03 Thread Darren Hart
On Fri, Feb 27, 2015 at 08:16:19AM -0300, Henrique de Moraes Holschuh wrote: > On Fri, Feb 27, 2015, at 08:05, Henrique de Moraes Holschuh wrote: > > On Thu, Feb 26, 2015, at 03:18, Darren Hart wrote: > > > On Fri, Feb 20, 2015 at 03:44:10PM +0100, Bastien Nocera wrote: > > > > Rather than checking

[PATCH v3 4/4] input: edt-ft5x06: Remove EV_SYN event report

2015-03-03 Thread Maxime Ripard
input_register_device already sets the EV_SYN event since all devices can generate them. Remove the redundant affectation. Signed-off-by: Maxime Ripard --- drivers/input/touchscreen/edt-ft5x06.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers

[PATCH v3 2/4] input: touchscreen: of: Register multitouch axes

2015-03-03 Thread Maxime Ripard
So far, the DT parsing code was only setting up the regular input axes, completely ignoring their multitouch counter parts. Fill them with the same parameters than the regular axes. Signed-off-by: Maxime Ripard --- drivers/input/touchscreen/of_touchscreen.c | 22 +- 1 file c

[PATCH v3 3/4] input: ft5x06: Allow to set the maximum axes value through the DT

2015-03-03 Thread Maxime Ripard
Currently the driver relies on some obscure and undocumented register to set the maximum axis value. The reported value is way too high to be meaningful, which confuses some userspace tools like QT's evdevtouch plugin which try to scale the reported events to the maximum values. Use the values fr

[PATCH v3 0/4] input: ft5x06: Fix userspace reported maximum value

2015-03-03 Thread Maxime Ripard
Hi, The current ft5x06 reports to the user-space that its maximum coordinates are, on both X and Y, way higher than what could be actually usable on the screen (in my case, 5759x1151 instead of 480x800). This causes trouble on some userspace stacks that then try to re-scale these coordinates back

[PATCH v3 1/4] input: touchscreen: of: Use input_set_abs_params

2015-03-03 Thread Maxime Ripard
Drivers are still required to call input_set_abs_params for their axes, as if they only use the touchscreen_parse_of_params function, the axis bit in absbit won't be set. Switch to using input_set_abs_params to fully setup each and every available axis so that drivers will be able to solely use th

Re: [PATCH v2 6/6] HID: uclogic: actually invert the in-range bit for huion tablets only

2015-03-03 Thread Nikolai Kondrashov
On 03/03/2015 12:25 AM, Benjamin Tissoires wrote: On Feb 28 2015 or thereabouts, Nikolai Kondrashov wrote: On 02/26/2015 08:57 PM, Benjamin Tissoires wrote: This hack is only needed for Huion tablets. It does not seem to have any effect on the other tablets handled by this device right now, but

Re: [PATCH v7 1/8] ARM: dt: Binding documentation for imx25 ADC/TSC

2015-03-03 Thread Arnd Bergmann
On Tuesday 03 March 2015 08:58:11 Markus Pargmann wrote: > +Example: > + tscadc: tscadc@5003 { > + compatible = "fsl,imx25-tsadc"; > + reg = <0x5003 0xc>; > + interrupts = <46>; > + clocks = <&clks 119>; > + clock-n