Re: [PATCH v2 2/2] Support-Alps-Touchpad-SS4-device

2015-03-27 Thread Dmitry Torokhov
On Fri, Mar 27, 2015 at 09:25:09AM +0100, Hans de Goede wrote: > Hi, > > On 27-03-15 21:29, Masaki Ota wrote: > >From: Masaki Ota > >-Support SS4 device > >-SS4 device supports 4Finger and real multi-touch. > > > >Signed-off-by: Masaki Ota > > Thanks looks good now: > > Acked-by: Hans de Goede

Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol

2015-03-27 Thread Dmitry Torokhov
On Sat, Mar 28, 2015 at 01:30:58AM +, Santiago Gala wrote: > The behaviour is the same with 3.19.1 as with 4.0.0-rc5 + the patched > psmouse you give me. The difference in lsinput is just name and current > position: > > $ diff -u alps06.txt alps11-new.txt > --- alps06.txt 2015-03-18 07:21:08

[PATCH 1/2] Input: Add binding document for a generic ADC keypad

2015-03-27 Thread Andrew Bresticker
Add a binding document for a generic ADC keypad. Buttons on an ADC keypad are connected in a resistor ladder to an ADC. The binding describes the mapping of ADC channel and voltage ranges to buttons. Signed-off-by: Andrew Bresticker Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Cam

[PATCH 2/2] Input: Add driver for a generic ADC keypad

2015-03-27 Thread Andrew Bresticker
Add a polled input driver for a keypad in which the buttons are connected in resistor ladders to an ADC. The IIO framework is used to claim and read the ADC channels. Signed-off-by: Andrew Bresticker --- drivers/input/keyboard/Kconfig| 13 ++ drivers/input/keyboard/Makefile | 1 + driv

Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol

2015-03-27 Thread Pali Rohár
On Friday 27 March 2015 21:32:12 Santiago Gala wrote: > I guess the difference is more due to new limits reported. > > Now I get only one device: > > /dev/input/event11 >bustype : BUS_I8042 >vendor : 0x2 >product : 0x8 >version : 1792 >name: "AlpsPS/2 ALPS GlidePoint" >

Re: [PATCH 0/2] Input: atmel_mxt_ts - Add support for T100 multi-touch

2015-03-27 Thread Javier Martinez Canillas
Hello Dmitry, On 03/17/2015 03:00 PM, Javier Martinez Canillas wrote: > > This is a resend of the T100 muli-touch object type support for the Atmel > maXTouch touchscreen driver. Old chips use the T9 multi-touch object type > while newer chips use this T100 multi-touch object type which is curren

Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol

2015-03-27 Thread Pali Rohár
Hello, there should no functional changes (e.g. acceleration speed, etc.). And if yes, there is probably some side effect which should be investigated. Please can you provide output from dmesg (grep for psmouse or input) and also output from lsinput? That changed acceleration/speed sounds lik

Re: [PATCH] Documentation: input - define INPUT_PROP_ACCELEROMETER behavior

2015-03-27 Thread Dmitry Torokhov
On Fri, Mar 27, 2015 at 01:17:20AM +0100, Jiri Kosina wrote: > On Fri, 27 Mar 2015, Peter Hutterer wrote: > > > Spell out what this property means to userspace. If the property is set, all > > directional axes must be accelerometer axes, any other axes are left as-is. > > This allows an accelerome

Re: [PATCH 0/2] tc3589x OF only enforcement

2015-03-27 Thread Dmitry Torokhov
On Fri, Mar 27, 2015 at 12:00:33PM +, Lee Jones wrote: > On Fri, 27 Mar 2015, Linus Walleij wrote: > > > On Thu, Mar 19, 2015 at 3:52 PM, Linus Walleij > > wrote: > > > > > These two patches removes the non-DT probe/config path from the > > > TC3589x driver. I suggest merging both through t

Re: [PATCH 1/2] input: keypad: tc3589x: localize platform data

2015-03-27 Thread Dmitry Torokhov
On Thu, Mar 19, 2015 at 09:38:56AM -0700, Dmitry Torokhov wrote: > Hi Linus, > > On Thu, Mar 19, 2015 at 03:52:44PM +0100, Linus Walleij wrote: > > This driver can only get its platform data from the device tree, > > and all platforms using it does that. Localize the platform data > > for the keyp

Re: quirk ALWAYS_POLL needed with an unexpectedly high number of mice

2015-03-27 Thread Jiri Kosina
On Fri, 27 Mar 2015, Benjamin Tissoires wrote: > Hmm... it looks like it's not host dependent unfortunately. We have a > (private) bug report for RHEL 6 where a customer wants to use the > following mouse: > http://www.compsource.com/pn/2MOUSEU1L/Keytronics-228/ > > I bought one and was able to r

Re: quirk ALWAYS_POLL needed with an unexpectedly high number of mice

2015-03-27 Thread Benjamin Tissoires
On Fri, Mar 27, 2015 at 11:59 AM, Jean Delvare wrote: > Le Friday 27 March 2015 à 16:10 +0100, Jiri Kosina a écrit : >> On Fri, 27 Mar 2015, Oliver Neukum wrote: >> > Keeping things as is is fine by me but then I will need to add a lot of >> > quirky devices. >> >> I am still surprised that all of

Re: quirk ALWAYS_POLL needed with an unexpectedly high number of mice

2015-03-27 Thread Jean Delvare
Le Friday 27 March 2015 à 16:10 +0100, Jiri Kosina a écrit : > On Fri, 27 Mar 2015, Oliver Neukum wrote: > > Keeping things as is is fine by me but then I will need to add a lot of > > quirky devices. > > I am still surprised that all of a sudden there is such a large flow of > new devices that

Re: quirk ALWAYS_POLL needed with an unexpectedly high number of mice

2015-03-27 Thread Jiri Kosina
On Fri, 27 Mar 2015, Oliver Neukum wrote: > > usbhid/hid-core.c already sets HID_QUIRK_NOGET for regular mice/keyboards > > [1]. > > Maybe adding ALLWAYS_POLL to those would make sense and solve your problem? > > It would solve my problem, but it would do so at the expense of hurting > devices

Re: proposal for deletion of drivers/hid/hid-ids.h

2015-03-27 Thread Jiri Kosina
On Thu, 26 Mar 2015, Oliver Neukum wrote: > I would like to kill drivers/hid/hid-ids.h and replace it > with numerical IDs in the files using it. > > There are two reasons for that. > > 1. It is a layering violation. There should not be a private > data base for USB IDs in HID. Not really; it's

Re: quirk ALWAYS_POLL needed with an unexpectedly high number of mice

2015-03-27 Thread Oliver Neukum
On Fri, 2015-03-27 at 09:18 -0400, Benjamin Tissoires wrote: > On Fri, Mar 27, 2015 at 5:29 AM, Oliver Neukum wrote: > > Hi, > > > > I am getting reports from a customer running an unintentional > > stress test for this quirk. I would have to add a dozen mice > > in the medium term. Is that desira

Re: quirk ALWAYS_POLL needed with an unexpectedly high number of mice

2015-03-27 Thread Benjamin Tissoires
On Fri, Mar 27, 2015 at 5:29 AM, Oliver Neukum wrote: > Hi, > > I am getting reports from a customer running an unintentional > stress test for this quirk. I would have to add a dozen mice > in the medium term. Is that desirable? > Should we make the quirk the default? Or add a module parameter >

Re: proposal for deletion of drivers/hid/hid-ids.h

2015-03-27 Thread Benjamin Tissoires
On Fri, Mar 27, 2015 at 5:39 AM, Oliver Neukum wrote: > On Fri, 2015-03-27 at 09:49 +0100, Oliver Neukum wrote: >> On Thu, 2015-03-26 at 10:06 -0400, Benjamin Tissoires wrote: > >> Well, yes, so you needed to grep for MULTI_INPUT. The entries would >> still have been present, just with nummerical

Re: proposal for deletion of drivers/hid/hid-ids.h

2015-03-27 Thread Benjamin Tissoires
On Fri, Mar 27, 2015 at 4:49 AM, Oliver Neukum wrote: > On Thu, 2015-03-26 at 10:06 -0400, Benjamin Tissoires wrote: >> On Thu, Mar 26, 2015 at 7:44 AM, Oliver Neukum wrote: >> > 2. It serves no purpose and adds work. Anyone who adds a quirk >> > or a special case for devices needs to operate on

Re: [PATCH 0/2] tc3589x OF only enforcement

2015-03-27 Thread Lee Jones
On Fri, 27 Mar 2015, Linus Walleij wrote: > On Thu, Mar 19, 2015 at 3:52 PM, Linus Walleij > wrote: > > > These two patches removes the non-DT probe/config path from the > > TC3589x driver. I suggest merging both through the MFD tree if > > Dmitry can ACK the input patch. > > Lee it seems Dmit

Re: [PATCH 2/2] mfd: tc3589x: enforce device-tree only mode

2015-03-27 Thread Lee Jones
On Thu, 19 Mar 2015, Linus Walleij wrote: > All systems using the TC3589x multifunction expander uses > devicetree, so don't clutter the place with a lot of > and assume it is there. > > Cc: Dmitry Torokhov > Cc: Lee Jones > Signed-off-by: Linus Walleij > --- > drivers/gpio/Kconfig

Re: [PATCH 1/2] input: keypad: tc3589x: localize platform data

2015-03-27 Thread Lee Jones
On Thu, 19 Mar 2015, Linus Walleij wrote: > This driver can only get its platform data from the device tree, > and all platforms using it does that. Localize the platform data > for the keypad. A later patch will enforce the device tree / OF > dependence. > > Cc: Dmitry Torokhov > Cc: Lee Jones

Re: [PATCH v7 2/5] power: max77843_charger: Add Max77843 charger device driver

2015-03-27 Thread Lee Jones
On Fri, 27 Mar 2015, Beomho Seo wrote: > On 03/27/2015 04:57 PM, Lee Jones wrote: > > On Fri, 27 Mar 2015, Beomho Seo wrote: > >> On 03/26/2015 10:54 PM, Lee Jones wrote: > >>> On Thu, 26 Mar 2015, Beomho Seo wrote: > On 03/24/2015 05:38 PM, Krzysztof Kozlowski wrote: > > 2015-03-24 9:01

Re: proposal for deletion of drivers/hid/hid-ids.h

2015-03-27 Thread Oliver Neukum
On Fri, 2015-03-27 at 09:49 +0100, Oliver Neukum wrote: > On Thu, 2015-03-26 at 10:06 -0400, Benjamin Tissoires wrote: > Well, yes, so you needed to grep for MULTI_INPUT. The entries would > still have been present, just with nummerical IDs. Especially as I see stuff like this: 0c3910c255 (Steph

quirk ALWAYS_POLL needed with an unexpectedly high number of mice

2015-03-27 Thread Oliver Neukum
Hi, I am getting reports from a customer running an unintentional stress test for this quirk. I would have to add a dozen mice in the medium term. Is that desirable? Should we make the quirk the default? Or add a module parameter to let the pessimistic users with multiple desktop rodents select th

Re: input_polldev interval (was Re: [sur40] Debugging a race condition)?

2015-03-27 Thread Florian Echtler
Hello Antonio, On 26.03.2015 22:10, Antonio Ospite wrote: > On Wed, 25 Mar 2015 15:10:44 +0100 > Florian Echtler wrote: >> >> Thanks - any other suggestions how to debug such a complete freeze? I >> have the following options enabled in my kernel config: >> >> Unfortunately, even after the system

Re: [PATCH 0/2] tc3589x OF only enforcement

2015-03-27 Thread Linus Walleij
On Thu, Mar 19, 2015 at 3:52 PM, Linus Walleij wrote: > These two patches removes the non-DT probe/config path from the > TC3589x driver. I suggest merging both through the MFD tree if > Dmitry can ACK the input patch. Lee it seems Dmitry ACKed these patches, can you merge those two patches into

Re: proposal for deletion of drivers/hid/hid-ids.h

2015-03-27 Thread Oliver Neukum
On Thu, 2015-03-26 at 10:06 -0400, Benjamin Tissoires wrote: > On Thu, Mar 26, 2015 at 7:44 AM, Oliver Neukum wrote: > > Hi, > > > > I would like to kill drivers/hid/hid-ids.h and replace it > > with numerical IDs in the files using it. > > > > There are two reasons for that. > > > > 1. It is a la

Re: [PATCH v7 2/5] power: max77843_charger: Add Max77843 charger device driver

2015-03-27 Thread Beomho Seo
On 03/27/2015 04:57 PM, Lee Jones wrote: > On Fri, 27 Mar 2015, Beomho Seo wrote: >> On 03/26/2015 10:54 PM, Lee Jones wrote: >>> On Thu, 26 Mar 2015, Beomho Seo wrote: On 03/24/2015 05:38 PM, Krzysztof Kozlowski wrote: > 2015-03-24 9:01 GMT+01:00 Beomho Seo : >> On 03/10/2015 10:44 PM

Re: [PATCH v2 2/2] Support-Alps-Touchpad-SS4-device

2015-03-27 Thread Hans de Goede
Hi, On 27-03-15 21:29, Masaki Ota wrote: From: Masaki Ota -Support SS4 device -SS4 device supports 4Finger and real multi-touch. Signed-off-by: Masaki Ota Thanks looks good now: Acked-by: Hans de Goede One remark though, you enable: BTN_TOOL_QUINTTAP for v7 touchpads in the alps_set_abs_

Re: [PATCH v7 2/5] power: max77843_charger: Add Max77843 charger device driver

2015-03-27 Thread Lee Jones
On Fri, 27 Mar 2015, Beomho Seo wrote: > On 03/26/2015 10:54 PM, Lee Jones wrote: > > On Thu, 26 Mar 2015, Beomho Seo wrote: > >> On 03/24/2015 05:38 PM, Krzysztof Kozlowski wrote: > >>> 2015-03-24 9:01 GMT+01:00 Beomho Seo : > On 03/10/2015 10:44 PM, Beomho Seo wrote: > > On 03/09/2015 09