Hi Dmitry,
I double check with our firmware team and the SPEC, it looks like the subtract
1 just a misunderstanding.
So, the correct should not subtract 1. For example, if the touchpad x
resolution is 2800 and x trace number is 20,
the pitch size of x should be 2800/20 = 140, not 2800/19 = 147.3
To determine if a touch is present in the single-touch case, we can
simply check if the BTN_TOUCH key is active or not. This will work for
both HID_GENERIC and other device types.
Signed-off-by: Jason Gerecke
---
drivers/hid/wacom_wac.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
1. cp2112_xfer() byte swaps smbus words incorrectly:
While i2c is by and large big endian, smbus transactions are
little endian. This only affects word operands. Essentially,
all occurences of be16 in cp2112_xfer() are now le16.
2. I2C_SMBUS_BYTE write in cp2112_xfer() should pass "command"
as
We use generic hid_report_len() to get individual packet length now.
Signed-off-by: Ping Cheng
---
drivers/hid/wacom_wac.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/hid/wacom_wac.h b/drivers/hid/wacom_wac.h
index 4700ac9..f5a5f68 100644
--- a/drivers/hid/wacom_wac.h
+++ b/
That is where they belong...
Signed-off-by: Ping Cheng
---
drivers/hid/wacom_sys.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
index ca30eab..855f3b3 100644
--- a/drivers/hid/wacom_sys.c
+++ b/drivers/hid/wa
It makes probe routine easy to follow.
Signed-off-by: Ping Cheng
---
drivers/hid/wacom.h | 2 +-
drivers/hid/wacom_sys.c | 39 +--
drivers/hid/wacom_wac.c | 30 +-
3 files changed, 31 insertions(+), 40 deletions(-)
diff --git
HID generic devices share the same default name, "Wacom HID". This
causes userland programs to show same device names for different
devices, which would confuse end users with same device names for
different devices too.
This patch uses name retrieved from HID descriptor, if a meaningful
name is r
On Wed, Apr 15, 2015 at 6:43 PM, Dmitry Torokhov
wrote:
> On Thu, Apr 16, 2015 at 12:23:03AM +0200, Javier Martinez Canillas wrote:
>> Hello Benjamin,
>>
>> On 04/15/2015 11:20 PM, Benjamin Tissoires wrote:
>> > Hi guys,
>> >
>> > On Wed, Apr 15, 2015 at 11:58 AM, Javier Martinez Canillas
>> > w
On Thu, Apr 16, 2015 at 12:23:03AM +0200, Javier Martinez Canillas wrote:
> Hello Benjamin,
>
> On 04/15/2015 11:20 PM, Benjamin Tissoires wrote:
> > Hi guys,
> >
> > On Wed, Apr 15, 2015 at 11:58 AM, Javier Martinez Canillas
> > wrote:
> >> Hello Dmitry,
> >>
> >> On 04/08/2015 02:26 AM, Dmitr
Hello Dmitry,
On Wednesday, April 15, 2015 18:35 BST, Dmitry Torokhov
wrote:
> On Wed, Apr 15, 2015 at 05:58:04PM +0200, Javier Martinez Canillas wrote:
> >
> > This is an unrelated cleanup so probably should had been a separate patch?
>
> Fair enough.
>
> --
> Dmitry
>
>
> Input: atmel_
Hello Benjamin,
On 04/15/2015 11:20 PM, Benjamin Tissoires wrote:
> Hi guys,
>
> On Wed, Apr 15, 2015 at 11:58 AM, Javier Martinez Canillas
> wrote:
>> Hello Dmitry,
>>
>> On 04/08/2015 02:26 AM, Dmitry Torokhov wrote:
>>> This change allows atmel_mxt_ts to bind to ACPI-enumerated devices in
>>
Hi guys,
On Wed, Apr 15, 2015 at 11:58 AM, Javier Martinez Canillas
wrote:
> Hello Dmitry,
>
> On 04/08/2015 02:26 AM, Dmitry Torokhov wrote:
>> This change allows atmel_mxt_ts to bind to ACPI-enumerated devices in
>> Google Pixel 2 (2015).
>>
>> While newer version of ACPI standard allow use of
On Wed, Apr 15, 2015 at 04:08:47PM +0200, Hans de Goede wrote:
> Non interleaved dualpoint v2 devices have separate pointstick button bits,
> document this.
>
> Signed-off-by: Hans de Goede
Applied, thank you.
> ---
> Changes in v2:
> -Document that the pointingstick packet button bits give the
On Wed, Apr 15, 2015 at 09:55:43AM +0800, DusonLin wrote:
> The trace number does not need to subtract 1 now.
Could you provide a bit more of background for this change? Why don't we
need to decrement the number returned by the firmware anymore? We have
been running with the old numbers for many y
On Wed, Apr 15, 2015 at 05:58:04PM +0200, Javier Martinez Canillas wrote:
> On 04/08/2015 02:26 AM, Dmitry Torokhov wrote:
> > @@ -724,15 +726,15 @@ static void mxt_input_button(struct mxt_data *data,
> > u8 *message)
> > {
> > struct input_dev *input = data->input_dev;
> > const struct m
On Wed, Apr 15, 2015 at 10:32:45AM +0100, Russell King - ARM Linux wrote:
> On Tue, Apr 14, 2015 at 04:58:22PM -0700, Dmitry Torokhov wrote:
> > On Tue, Apr 14, 2015 at 11:30:29PM +0100, Russell King - ARM Linux wrote:
> > > On Tue, Apr 14, 2015 at 09:22:10AM -0700, Dmitry Torokhov wrote:
> > > > O
Hello Randy,
On 15.04.2015 17:54, Randy Dunlap wrote:
> ---
> drivers/input/touchscreen/Kconfig |1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20150415.orig/drivers/input/touchscreen/Kconfig
> +++ linux-next-20150415/drivers/input/touchscreen/Kconfig
> @@ -9
Hello Dmitry,
On 04/08/2015 02:26 AM, Dmitry Torokhov wrote:
> Atmel controolers are very flexible and to function optimally require
> device-specific configuration to be loaded. While the configuration is
> stored in NVRAM and is normally persistent, sometimes it gets corrupted
> and needs to be
Hello Dmitry,
On 04/08/2015 02:26 AM, Dmitry Torokhov wrote:
> This change allows atmel_mxt_ts to bind to ACPI-enumerated devices in
> Google Pixel 2 (2015).
>
> While newer version of ACPI standard allow use of device-tree-like
> properties in device descriptions, the version of ACPI implemented
.o: In function `sur40_vidioc_querycap':
sur40.c:(.text+0x22ccb0): undefined reference to `video_devdata'
Signed-off-by: Randy Dunlap
Cc: Florian 'floe' Echtler
Cc: Dmitry Torokhov
Cc: linux-input@vger.kernel.org
---
drivers/input/touchscreen/Kconfig |1 +
1 file changed, 1 i
On Wed, 15 Apr 2015, Oliver Neukum wrote:
> Hi,
>
> I found a problem with the close() function of usbhid.
> It fails to properly suspend device that don't support
> remote wake-up. The power core does not retry an autosuspend
> that failed due to a lack of support for remote wake-up.
>
> So the
On Wed, 15 Apr 2015, Oliver Neukum wrote:
> When usbhid closes a device which was awake only because remote
> wakeup was required but not provided, the interface must go through
> a get/put cycle or the core will never reattempt to suspend the device.
> This brakes runtime PM for all joysticks.
>
Hi,
I found a problem with the close() function of usbhid.
It fails to properly suspend device that don't support
remote wake-up. The power core does not retry an autosuspend
that failed due to a lack of support for remote wake-up.
So there needs to be a _put() if the need for remote wake-up
is r
Non interleaved dualpoint v2 devices have separate pointstick button bits,
document this.
Signed-off-by: Hans de Goede
---
Changes in v2:
-Document that the pointingstick packet button bits give the combined
button status of both the stick and the touchpad buttons
---
Documentation/input/alps.t
When usbhid closes a device which was awake only because remote
wakeup was required but not provided, the interface must go through
a get/put cycle or the core will never reattempt to suspend the device.
This brakes runtime PM for all joysticks.
Signed-off-by: Oliver Neukum
---
drivers/hid/usbhi
[...]
>
> Had I not noticed your message, you would have probably ended up removing
> a driver which is very much in use, is functional, and therefore is not
> as broken as Ulf claims.
I claimed the system PM needed to be fixed, nothing else. :-)
>
> The other lesson to come away from this is th
On Tue, Apr 14, 2015 at 04:58:22PM -0700, Dmitry Torokhov wrote:
> On Tue, Apr 14, 2015 at 11:30:29PM +0100, Russell King - ARM Linux wrote:
> > On Tue, Apr 14, 2015 at 09:22:10AM -0700, Dmitry Torokhov wrote:
> > > On Tue, Apr 14, 2015 at 12:41:48PM +0200, Ulf Hansson wrote:
> > > > The legacy sys
27 matches
Mail list logo
