Re: ALPS DualPoint double click bug

2015-07-31 Thread Hans de Goede
Hi, On 31-07-15 23:17, Pali Rohár wrote: On Friday 31 July 2015 23:12:56 Douglas Christman wrote: On Thu, Jul 30, 2015 at 11:00 AM, Hans de Goede wrote: Hi, On 30-07-15 16:46, Pali Rohár wrote: What about introducing new flag ALPS_ instead calling dmi_name_in_vendors() function every time w

[PATCH] alps: Only Dell laptops have separate button bits for v2 dualpoint sticks

2015-07-31 Thread Hans de Goede
It turns out that only Dell laptops have the separate button bits for v2 dualpoint sticks and that commit 92bac83dd79e ("Input: alps - non interleaved V2 dualpoint has separate stick button bits") causes regressions on Toshiba laptops. This commit adds a check for Dell laptops to the code for hand

[PATCH] Input: Evdev - Avoid data loss when clock type is changed

2015-07-31 Thread Aniroop Mathur
When clock type is changed, previously stored data is flushed and therfore does not reach to upper layer or application. Data is critically important along with the timestamp. So to avoid data loss and send correct timestamp as well, lets not flush data upon clock type change and to send correct ti

Re: ALPS DualPoint double click bug

2015-07-31 Thread Pali Rohár
On Friday 31 July 2015 23:12:56 Douglas Christman wrote: > On Thu, Jul 30, 2015 at 11:00 AM, Hans de Goede > wrote: > > Hi, > > > > On 30-07-15 16:46, Pali Rohár wrote: > >> What about introducing new flag ALPS_ instead calling > >> dmi_name_in_vendors() function every time when we need to proces

Re: ALPS DualPoint double click bug

2015-07-31 Thread Douglas Christman
On Thu, Jul 30, 2015 at 11:00 AM, Hans de Goede wrote: > Hi, > > On 30-07-15 16:46, Pali Rohár wrote: >> What about introducing new flag ALPS_ instead calling >> dmi_name_in_vendors() function every time when we need to process >> packet? > > That is a good idea. Douglas can you test the attached

Re: [PATCH] Input: drivers/joystick: use parallel port device model

2015-07-31 Thread Dmitry Torokhov
On Fri, Jul 31, 2015 at 01:36:18PM -0700, Greg KH wrote: > On Fri, Jul 31, 2015 at 11:04:26PM +0530, Sudip Mukherjee wrote: > > On Fri, Jul 31, 2015 at 09:54:27AM -0700, Dmitry Torokhov wrote: > > > On Fri, Jul 31, 2015 at 03:45:25PM +0530, Sudip Mukherjee wrote: > > > > On Thu, Jul 30, 2015 at 09:

Re: [PATCH] Input: drivers/joystick: use parallel port device model

2015-07-31 Thread Greg KH
On Fri, Jul 31, 2015 at 11:04:26PM +0530, Sudip Mukherjee wrote: > On Fri, Jul 31, 2015 at 09:54:27AM -0700, Dmitry Torokhov wrote: > > On Fri, Jul 31, 2015 at 03:45:25PM +0530, Sudip Mukherjee wrote: > > > On Thu, Jul 30, 2015 at 09:53:23AM -0700, Dmitry Torokhov wrote: > > > > Hi Sudip, > > > Hi

Re: Initialization of TPPS/2 IBM TrackPoint in too slow

2015-07-31 Thread Pali Rohár
On Friday 31 July 2015 19:30:34 Dmitry Torokhov wrote: > On Fri, Jul 31, 2015 at 07:17:02PM +0200, Pali Rohár wrote: > > On Friday 31 July 2015 19:08:49 Dmitry Torokhov wrote: > > > On Fri, Jul 31, 2015 at 06:59:21PM +0200, Pali Rohár wrote: > > > > Hello, > > > > > > > > here is output from dmesg

[PATCH v4 1/8] Input: goodix - reset device at init

2015-07-31 Thread Irina Tirdea
After power on, it is recommended that the driver resets the device. The reset procedure timing is described in the datasheet and is used at device init (before writing device configuration) and for power management. It is a sequence of setting the interrupt and reset pins high/low at specific timi

[PATCH v4 0/8] Goodix touchscreen enhancements

2015-07-31 Thread Irina Tirdea
Add several enhancements to the Goodix touchscreen driver. I have added the esd_timeout DT property only for initialization to get more feedback on this variant of the ESD patch. Bastien, I have considered that both your boards (specified for rotated screen quirk) have the reset pin declared firs

[PATCH v4 6/8] Input: goodix - add support for ESD

2015-07-31 Thread Irina Tirdea
Add ESD (Electrostatic Discharge) protection mechanism. The driver enables ESD protection in HW and checks a register to determine if ESD occurred. If ESD is signalled by the HW, the driver will reset the device. The ESD poll time (in ms) can be set through the sysfs property esd_timeout. If it i

[PATCH v4 2/8] Input: goodix - use actual config length for each device type

2015-07-31 Thread Irina Tirdea
Each of the Goodix devices supported by this driver has a fixed size for the configuration information registers. The size varies depending on the device and is specified in the datasheet. Use the proper configuration length as specified in the datasheet for each device model, so we do not read mo

[PATCH v4 7/8] Input: goodix - add sysfs interface to dump config

2015-07-31 Thread Irina Tirdea
Goodix devices have a configuration information register area that specify various parameters for the device. The configuration information has a specific format described in the Goodix datasheet. It includes X/Y resolution, maximum supported touch points, interrupt flags, various sesitivity factor

[PATCH v4 8/8] DO NOT APPLY! goodix configuration update helper

2015-07-31 Thread Irina Tirdea
This patch is not meant to be applied. It can be used to test updates to the goodix touchscreen configuration. It provides a bash script to help generate a new configuration starting from the one read from the device. Below are instructions on how to test that the config is correctly updated for

[PATCH v4 5/8] Input: goodix - use goodix_i2c_write_u8 instead of i2c_master_send

2015-07-31 Thread Irina Tirdea
Use goodix_i2c_write_u8 instead of i2c_master_send to simplify code. Signed-off-by: Irina Tirdea --- drivers/input/touchscreen/goodix.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c index 8485293

[PATCH v4 4/8] Input: goodix - add power management support

2015-07-31 Thread Irina Tirdea
Implement suspend/resume for goodix driver. The suspend and resume process uses the gpio pins. If the device ACPI/DT information does not declare gpio pins, suspend/resume will not be available for these devices. This is based on Goodix datasheets for GT911 and GT9271 and on Goodix driver gt9xx.c

[PATCH v4 3/8] Input: goodix - write configuration data to device

2015-07-31 Thread Irina Tirdea
Goodix devices can be configured by writing custom data to the device at init. The configuration data is read with request_firmware from "goodix__cfg.bin", where is the product id read from the device (e.g.: goodix_911_cfg.bin for Goodix GT911, goodix_9271_cfg.bin for GT9271). The configuration i

Re: [PATCH] Input: drivers/joystick: use parallel port device model

2015-07-31 Thread Sudip Mukherjee
On Fri, Jul 31, 2015 at 09:54:27AM -0700, Dmitry Torokhov wrote: > On Fri, Jul 31, 2015 at 03:45:25PM +0530, Sudip Mukherjee wrote: > > On Thu, Jul 30, 2015 at 09:53:23AM -0700, Dmitry Torokhov wrote: > > > Hi Sudip, > > Hi Dmitry, > > > > > > On Thu, Jul 30, 2015 at 07:36:34PM +0530, Sudip Mukher

Re: Initialization of TPPS/2 IBM TrackPoint in too slow

2015-07-31 Thread Dmitry Torokhov
On Fri, Jul 31, 2015 at 07:17:02PM +0200, Pali Rohár wrote: > On Friday 31 July 2015 19:08:49 Dmitry Torokhov wrote: > > On Fri, Jul 31, 2015 at 06:59:21PM +0200, Pali Rohár wrote: > > > Hello, > > > > > > here is output from dmesg for psmouse.ko > > > > > > [ 266.378751] psmouse: calling psmous

Re: Initialization of TPPS/2 IBM TrackPoint in too slow

2015-07-31 Thread Pali Rohár
On Friday 31 July 2015 19:08:49 Dmitry Torokhov wrote: > On Fri, Jul 31, 2015 at 06:59:21PM +0200, Pali Rohár wrote: > > Hello, > > > > here is output from dmesg for psmouse.ko > > > > [ 266.378751] psmouse: calling psmouse_init() > > [ 267.167150] psmouse serio1: synaptics: queried max coordin

Re: Initialization of TPPS/2 IBM TrackPoint in too slow

2015-07-31 Thread Dmitry Torokhov
On Fri, Jul 31, 2015 at 06:59:21PM +0200, Pali Rohár wrote: > Hello, > > here is output from dmesg for psmouse.ko > > [ 266.378751] psmouse: calling psmouse_init() > [ 267.167150] psmouse serio1: synaptics: queried max coordinates: x > [..5676], y [..4758] > [ 267.198416] psmouse serio1: syna

Initialization of TPPS/2 IBM TrackPoint in too slow

2015-07-31 Thread Pali Rohár
Hello, here is output from dmesg for psmouse.ko [ 266.378751] psmouse: calling psmouse_init() [ 267.167150] psmouse serio1: synaptics: queried max coordinates: x [..5676], y [..4758] [ 267.198416] psmouse serio1: synaptics: queried min coordinates: x [1266..], y [1096..] [ 267.260402] psmou

Re: [PATCH 05/15] drivers: input: Drop unlikely before IS_ERR(_OR_NULL)

2015-07-31 Thread Dmitry Torokhov
On Fri, Jul 31, 2015 at 02:08:25PM +0530, Viresh Kumar wrote: > IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there > is no need to do that again from its callers. Drop it. I'd rather keep it as it documents the expected behavior and double unlikely should work just fine. > >

Re: [PATCH] Input: drivers/joystick: use parallel port device model

2015-07-31 Thread Dmitry Torokhov
On Fri, Jul 31, 2015 at 03:45:25PM +0530, Sudip Mukherjee wrote: > On Thu, Jul 30, 2015 at 09:53:23AM -0700, Dmitry Torokhov wrote: > > Hi Sudip, > Hi Dmitry, > > > > On Thu, Jul 30, 2015 at 07:36:34PM +0530, Sudip Mukherjee wrote: > > > Modify db9 driver to use the new Parallel Port device model.

Re: [PATCH 8/8] Input: xpad: do not submit active URBs

2015-07-31 Thread Pavel Rojtberg
2015-07-30 8:59 GMT+02:00 Dmitry Torokhov : > On Sat, Jul 11, 2015 at 01:47:48AM +0200, Pavel Rojtberg wrote: >> From: Pavel Rojtberg >> >> track the active status of the irq_out URB to prevent submission while >> it is active. Failure to do so results in the "URB submitted while >> active" warnin

Re: [PATCH 6/8] Input: xpad: use bitmask for finding the pad_nr

2015-07-31 Thread Pavel Rojtberg
Hi Dimitry, 2015-07-30 8:55 GMT+02:00 Dmitry Torokhov : > Hi Pavel, > > On Sat, Jul 11, 2015 at 01:47:46AM +0200, Pavel Rojtberg wrote: >> From: Pavel Rojtberg >> >> The pad_nr should be consistent after disconnecting/ reconnecting a >> xbox360 controllers. >> Use a bitmask to track connected pad

Re: [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-31 Thread Stefano Stabellini
On Tue, 28 Jul 2015, Julien Grall wrote: > Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN > is meant, I suspect this is because the first support for Xen was for > PV. This brough some misimplementation of helpers on ARM and make the > developper confused the expected behavio

Re: [PATCH] Input: drivers/joystick: use parallel port device model

2015-07-31 Thread Sudip Mukherjee
On Thu, Jul 30, 2015 at 09:53:23AM -0700, Dmitry Torokhov wrote: > Hi Sudip, Hi Dmitry, > > On Thu, Jul 30, 2015 at 07:36:34PM +0530, Sudip Mukherjee wrote: > > Modify db9 driver to use the new Parallel Port device model. > > > > Signed-off-by: Sudip Mukherjee > > --- > > > > It will generate a

[PATCH 05/15] drivers: input: Drop unlikely before IS_ERR(_OR_NULL)

2015-07-31 Thread Viresh Kumar
IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there is no need to do that again from its callers. Drop it. Signed-off-by: Viresh Kumar --- drivers/input/mouse/alps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/mouse/alps.c b/drivers/input/

Re: ALPS DualPoint double click bug

2015-07-31 Thread Hans de Goede
Hi, On 30-07-15 17:49, Pali Rohár wrote: On Thursday 30 July 2015 17:00:56 Hans de Goede wrote: Hi, On 30-07-15 16:46, Pali Rohár wrote: What about introducing new flag ALPS_ instead calling dmi_name_in_vendors() function every time when we need to process packet? That is a good idea. Dougl

Re: [PATCH] HID: hid-sony: Fix DS4 controller reporting rate issues

2015-07-31 Thread Jiri Kosina
On Wed, 29 Jul 2015, Frank Praznik wrote: > > > This commit removes the cap on the DualShock 4 controller reporting > > > rate when connected using Bluetooth. The previous value of '0xB0' > > > capped the rate to only 20.83 Hz which many userspace utilities > > > mistook as a sign of a bad signa