Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2015-09-29 Thread Sedat Dilek
> What shall I do... play with lockdep (print_irqtrace_events) in > del_timer_sync()? I recalled that when Jiri was thinking towards a "compiler bug" that the part in del_timer_sync() emebedded in the "ifdef CONFIG_LOCKDEP" is somehow "mis-compiled". Furthermore, I see that try_to_del_timer_sync()

Re: [PATCH v5 1/3] ARM: dts: vf500-colibri: Add device tree node for touchscreen support

2015-09-29 Thread Shawn Guo
On Tue, Sep 01, 2015 at 06:06:53PM +0530, Sanchayan Maity wrote: > Add device tree node for touchscreen support on Colibri VF50. The > touchscreen functionality on VF50 uses the ADC channels of Vybrid > and some GPIOs. Also add pinctrl nodes for proper pinmux. > > Signed-off-by: Sanchayan Maity

Re: [PATCH v5 1/3] ARM: dts: vf500-colibri: Add device tree node for touchscreen support

2015-09-29 Thread maitysanchayan
Hello Shawn, The driver has landed in your tree. Can you queue this DT change for the same? Thanks. - Sanchayan. On 15-09-01 18:06:53, Sanchayan Maity wrote: > Add device tree node for touchscreen support on Colibri VF50. The > touchscreen functionality on VF50 uses the ADC channels of Vybrid >

Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey

2015-09-29 Thread Dmitry Torokhov
On Mon, Sep 28, 2015 at 08:19:27AM +, Opensource [Steve Twiss] wrote: > > > Subject: Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings > > for DA9062 OnKey > > > > On Mon, Jul 27, 2015 at 03:43:00PM -0700, Dmitry Torokhov wrote: > > > On Thu, Jul 23, 2015 at 05:17:41PM +0100, S

Re: [patch] Input: ff-core - silence an underflow warning

2015-09-29 Thread Dmitry Torokhov
On Tue, Sep 29, 2015 at 04:12:58PM +0300, Dan Carpenter wrote: > On Mon, Sep 28, 2015 at 05:28:30PM -0700, Dmitry Torokhov wrote: > > On Tue, Sep 22, 2015 at 04:26:43PM +0300, Dan Carpenter wrote: > > > My static checker complains that "value" comes from the user in > > > evdev_do_ioctl() and we ch

[PATCH v2] HID: hid-input: allow input_configured callback return errors

2015-09-29 Thread Dmitry Torokhov
When configuring input device via input_configured callback we may encounter errors (for example input_mt_init_slots() may fail). Instead of continuing with half-initialized input device let's allow driver indicate failures. Signed-off-by: Jaikumar Ganesh Signed-off-by: Arve Hjønnevåg Reviewed-b

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2015-09-29 Thread Sedat Dilek
On Tue, Sep 29, 2015 at 9:08 PM, Steven Rostedt wrote: > On Tue, 29 Sep 2015 20:54:38 +0200 > Sedat Dilek wrote: > >> This breaks my build when CONFIG_USB_HID=m... >> >> find .tmp_versions -name '*.mod' | xargs -r grep -h '\.ko$' | sort >> -u | sed 's/\.ko$/.o/' | scripts/mod/modpost -m -a -o .

re: Input: edt-ft5x06 - switch to newer gpio framework

2015-09-29 Thread Dan Carpenter
Hello Franklin S Cooper Jr, This is a semi-automatic email about new static checker warnings. The patch 13c23cd18bd1: "Input: edt-ft5x06 - switch to newer gpio framework" from Sep 11, 2015, leads to the following Smatch complaint: drivers/input/touchscreen/edt-ft5x06.c:988 edt_ft5x06_ts_probe()

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2015-09-29 Thread Steven Rostedt
On Tue, 29 Sep 2015 20:54:38 +0200 Sedat Dilek wrote: > This breaks my build when CONFIG_USB_HID=m... > > find .tmp_versions -name '*.mod' | xargs -r grep -h '\.ko$' | sort > -u | sed 's/\.ko$/.o/' | scripts/mod/modpost -m -a -o ./Module.symvers >-S -s -T - > ERROR: "print_irqtrace_event

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2015-09-29 Thread Sedat Dilek
On Tue, Sep 29, 2015 at 11:27 AM, Jiri Kosina wrote: > On Tue, 29 Sep 2015, Sedat Dilek wrote: > >> Did you look at the step-by-step moving of trace_hardirqs_off() and >> the corresponding dmesg-logs? >> What helps is a trace_hardirqs_off() before spin_unlock_irq() in the >> if-statement. >> So, y

[PATCH] HID: hid-logitech-hidpp: driver for m545/m546 mouse

2015-09-29 Thread Goffredo Baroncelli
From: Goffredo Baroncelli Add support for the Logitech m545/m546 mouse. This mouse is designed for windows 8. So when the side buttons are pressed, it sends some keyboard keys instead of mouse buttons. Original-author: VRan Liu Signed-off-by: Goffredo Baroncelli --- In the comments of the cod

RE: [PATCH v3 1/5] Input: goodix - reset device at init

2015-09-29 Thread Tirdea, Irina
> -Original Message- > From: Bastien Nocera [mailto:had...@hadess.net] > Sent: 29 September, 2015 5:04 > To: Tirdea, Irina; linux-input@vger.kernel.org > Cc: linux-ker...@vger.kernel.org; Rob Herring; Pawel Moll; Ian Campbell; > Kumar Gala; Purdila, Octavian; Dmitry Torokhov; Mark > Rutl

[PATCH 0/4] Input: use parallel port device model

2015-09-29 Thread Sudip Mukherjee
Hi, This series will convert the other remaining drivers to use parallel port device model. Changes are similar to the changes done in db9.c regards sudip Sudip Mukherjee (4): Input: gamecon - use parallel port device model Input: turbografx - use parallel port device model Input: serio - u

[PATCH 1/4] Input: gamecon - use parallel port device model

2015-09-29 Thread Sudip Mukherjee
Modify gamecon driver to use the new Parallel Port device model. Signed-off-by: Sudip Mukherjee --- drivers/input/joystick/gamecon.c | 100 +-- 1 file changed, 53 insertions(+), 47 deletions(-) diff --git a/drivers/input/joystick/gamecon.c b/drivers/input/joy

[PATCH] Input: Add support for FocalTech FT6236 touchscreen controller

2015-09-29 Thread Noralf Trønnes
This adds support for the FT6x06 and the FT6x36 family of capacitive touch panel controllers, in particular the FT6236. Signed-off-by: Noralf Trønnes --- The driver is based on: https://github.com/adafruit/adafruit-raspberrypi-linux/blob/rpi-3.18.y/drivers/input/touchscreen/ft6x06_ts.c .../inp

[PATCH 2/4] Input: turbografx - use parallel port device model

2015-09-29 Thread Sudip Mukherjee
Modify turbografx driver to use the new Parallel Port device model. Signed-off-by: Sudip Mukherjee --- drivers/input/joystick/turbografx.c | 100 ++-- 1 file changed, 51 insertions(+), 49 deletions(-) diff --git a/drivers/input/joystick/turbografx.c b/drivers/in

[PATCH 4/4] Input: walkera0701 - use parallel port device model

2015-09-29 Thread Sudip Mukherjee
Modify walkera0701 driver to use the new Parallel Port device model. Signed-off-by: Sudip Mukherjee --- drivers/input/joystick/walkera0701.c | 64 +--- 1 file changed, 37 insertions(+), 27 deletions(-) diff --git a/drivers/input/joystick/walkera0701.c b/drivers/

[PATCH 3/4] Input: serio - use parallel port device model

2015-09-29 Thread Sudip Mukherjee
Modify parkbd driver to use the new Parallel Port device model. Signed-off-by: Sudip Mukherjee --- drivers/input/serio/parkbd.c | 55 +--- 1 file changed, 37 insertions(+), 18 deletions(-) diff --git a/drivers/input/serio/parkbd.c b/drivers/input/serio/pa

Re: [PATCH] HID: hid-multitouch.c: fix formatting warnings

2015-09-29 Thread Brent Adam
On 9/29/15, 6:59 AM, "Jiri Kosina" wrote: >On Mon, 28 Sep 2015, Brent Adam wrote: > >> Fixed the following checkpatch.pl warnings: >> WARNING: line over 80 characters: line 163 >> WARNING: Missing a blank line after declarations: line 359 >> WARNING: Missing a blank line after declarations: lin

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2015-09-29 Thread Steven Rostedt
On Tue, 29 Sep 2015 11:06:25 +0200 Sedat Dilek wrote: > > Is spin_lock_bh() not an appropriate replacement? I agree with Jiri, your patch makes no sense. It's strange that it would fix anything. > > Does it change code beaviour? Yes. > > Is it important to re-enable IRQs here - before hid_can

Re: [patch] Input: ff-core - silence an underflow warning

2015-09-29 Thread Dan Carpenter
On Mon, Sep 28, 2015 at 05:28:30PM -0700, Dmitry Torokhov wrote: > On Tue, Sep 22, 2015 at 04:26:43PM +0300, Dan Carpenter wrote: > > My static checker complains that "value" comes from the user in > > evdev_do_ioctl() and we check that it's not too large here but we don't > > check that it's negat

Re: [PATCH] HID: hid-multitouch.c: fix formatting warnings

2015-09-29 Thread Jiri Kosina
On Mon, 28 Sep 2015, Brent Adam wrote: > Fixed the following checkpatch.pl warnings: > WARNING: line over 80 characters: line 163 > WARNING: Missing a blank line after declarations: line 359 > WARNING: Missing a blank line after declarations: line 572 > WARNING: Missing a blank line after declarat

Re: [PATCH] HID: multitouch: Add suffix for HID_DG_TOUCHPAD

2015-09-29 Thread Jiri Kosina
On Mon, 28 Sep 2015, Mika Westerberg wrote: > Instead of printing "UNKNOWN" as device suffix for HID_DG_TOUCHPAD call > the device as "Touchpad". > > Signed-off-by: Mika Westerberg Applied to hid.git#for-4.4/multitouch. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: [PATCH 2/2] HID: i2c-hid: Fill in physical device providing HID functionality

2015-09-29 Thread Jiri Kosina
On Mon, 28 Sep 2015, Mika Westerberg wrote: > Currently hid_connect() prints out following when I2C connected HID devices > is connected: > > hid-multitouch 0018:03EB:2136.0001: ... [ATML3432:00 03EB:2136] on > > After "on " should read physical device name but it is left empty by the > driver

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2015-09-29 Thread Jiri Kosina
On Tue, 29 Sep 2015, Sedat Dilek wrote: > Did you look at the step-by-step moving of trace_hardirqs_off() and > the corresponding dmesg-logs? > What helps is a trace_hardirqs_off() before spin_unlock_irq() in the > if-statement. > So, yes "IRQs are enabled" but tracing does not like it. I so far

Re: [PATCH 2/2] HID: i2c-hid: Fill in physical device providing HID functionality

2015-09-29 Thread Benjamin Tissoires
On Sep 28 2015 or thereabouts, Mika Westerberg wrote: > Currently hid_connect() prints out following when I2C connected HID devices > is connected: > > hid-multitouch 0018:03EB:2136.0001: ... [ATML3432:00 03EB:2136] on > > After "on " should read physical device name but it is left empty by the

Re: [PATCH] HID: multitouch: Add suffix for HID_DG_TOUCHPAD

2015-09-29 Thread Benjamin Tissoires
On Sep 28 2015 or thereabouts, Mika Westerberg wrote: > Instead of printing "UNKNOWN" as device suffix for HID_DG_TOUCHPAD call > the device as "Touchpad". > > Signed-off-by: Mika Westerberg > --- Acked-by: Benjamin Tissoires Cheers, Benjamin > drivers/hid/hid-multitouch.c | 3 +++ > 1 file

Re: [PATCH] HID: multitouch: Fetch feature reports on demand for Win8 devices

2015-09-29 Thread Benjamin Tissoires
On Sep 28 2015 or thereabouts, Mika Westerberg wrote: > Some newer Intel Skylake based Dell laptops with Win8 precision touchpad > fail when initial feature reports are fetched from it. Below is an example > output with some additional debug included: > > i2c_hid i2c-DLL0704:01: Fetching the HID

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2015-09-29 Thread Sedat Dilek
On Mon, Sep 28, 2015 at 1:33 PM, Jiri Kosina wrote: > On Mon, 28 Sep 2015, Sedat Dilek wrote: > >> When compiling Linux v4.2+ and v4.3-rc2+ with a llvmlinux patchset >> and CLANG v3.7 I see a BUG line like this: >> >> [ 24.705463] BUG: sleeping function called from invalid context at >> kernel/

Re: [PATCH v2] Input: drivers/joystick: use parallel port device model

2015-09-29 Thread Sudip Mukherjee
On Mon, Sep 28, 2015 at 06:40:51PM +0200, Pali Rohár wrote: > On Friday 14 August 2015 08:55:42 Sudip Mukherjee wrote: > > > > Pali Rohár has the hardware and he is ready to test it. > > Tested-By: Pali Rohár Hi Pali, Thanks a lot for taking time to test this. regards sudip -- To unsubscribe fro