Re: Input: joydev - validate axis/button maps before clobbering current ones

2015-10-07 Thread Javier Martinez Canillas
Hello Dan, On 10/07/2015 07:46 AM, Dan Carpenter wrote: > Oh whoops, I sent this to the wrong person. Javier, you introduced a > bug with 570c9a7a ('Input: joydev - use memdup_user() to duplicate > memory from user-space') > > regards, > dan carpenter > Yes, thanks for reporting it but I've

Re: Input: joydev - validate axis/button maps before clobbering current ones

2015-10-07 Thread Dan Carpenter
Fantastic. Thanks! regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[RFC 0/4] Input: edt-ft5506 - Adding support for FT5506

2015-10-07 Thread fcooper
From: Franklin S Cooper Jr This series adds support for the FT5506 tsc. The biggest difference between this tsc vs the ones currently supported by the driver is the ability to handle upto 10 touch points. The FT5506 tsc that I currently have seems to be based on the M09 firmware which I have doc

[RFC 3/4] Input: edt-ft5x06 - Add support for FT5506

2015-10-07 Thread fcooper
From: Franklin S Cooper Jr FT5506 is essentially the same as other FT5x06 devices other than supporting 10 support points. Signed-off-by: Franklin S Cooper Jr --- Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt | 2 ++ drivers/input/touchscreen/edt-ft5x06.c

[RFC 4/4] Input: edt-ft5x06 - Work around FT5506 firmware bug

2015-10-07 Thread fcooper
From: Franklin S Cooper Jr In the touchscreen controller ISR, reading the tsc starting from register 0x2 causes the tsc to infrequently update the detected finger's x and y coordinate. The irq pin toggles at a fast rate to indicate touch events are happening. However, the tsc on average updates t

[RFC 2/4] Input: edt-ft5x06 - Add support for different max support points

2015-10-07 Thread fcooper
From: Franklin S Cooper Jr Update the code so that the maximum supported points aren't hard coded but can be changed. Set the maximum support points based on the data passed along side the compatible field. Signed-off-by: Franklin S Cooper Jr --- drivers/input/touchscreen/edt-ft5x06.c | 56 ++

[RFC 1/4] Input: edt-ft5x06 - Use max support points to determine how much to read

2015-10-07 Thread fcooper
From: Franklin S Cooper Jr Calculate the amount of data that needs to be read for the specified max number of support points. If the maximum number of support points changes then the amount that is read from the touch screen controller should reflect this. Signed-off-by: Franklin S Cooper Jr --

[PATCH v2] HID: multitouch: Fetch feature reports on demand for Win8 devices

2015-10-07 Thread Mika Westerberg
Some newer Intel Skylake based Dell laptops with Win8 precision touchpad fail when initial feature reports are fetched from it. Below is an example output with some additional debug included: i2c_hid i2c-DLL0704:01: Fetching the HID descriptor i2c_hid i2c-DLL0704:01: __i2c_hid_command: cmd=20 00

Re: [PATCH v2] HID: multitouch: Fetch feature reports on demand for Win8 devices

2015-10-07 Thread Benjamin Tissoires
[sorry for the late answer Jiri, I was on vacations last week] On Oct 07 2015 or thereabouts, Mika Westerberg wrote: > Some newer Intel Skylake based Dell laptops with Win8 precision touchpad > fail when initial feature reports are fetched from it. Below is an example > output with some additional

Re: [PATCH v2] HID: multitouch: Fetch feature reports on demand for Win8 devices

2015-10-07 Thread Seth Forshee
On Wed, Oct 07, 2015 at 09:34:10AM -0400, Benjamin Tissoires wrote: > [sorry for the late answer Jiri, I was on vacations last week] > > On Oct 07 2015 or thereabouts, Mika Westerberg wrote: > > Some newer Intel Skylake based Dell laptops with Win8 precision touchpad > > fail when initial feature

[PATCH 2/2] HID: wacom: Expect 'touch_max' touches if HID_DG_CONTACTCOUNT not present

2015-10-07 Thread Jason Gerecke
When introduced in commit 1b5d514, the check 'if (hid_data->cc_index >= 0)' in 'wacom_wac_finger_pre_report' was intended to switch where the driver got the expected number of contacts from: HID_DG_CONTACTCOUNT if the usage was present, or 'touch_max' otherwise. Unfortunately, an oversight worthy o

[PATCH 1/2] HID: wacom: Tie cached HID_DG_CONTACTCOUNT indices to report ID

2015-10-07 Thread Jason Gerecke
The cached indicies 'cc_index' and 'cc_value_index' introduced in 1b5d514 are only valid for a single report ID. If a touchscreen has multiple reports with a HID_DG_CONTACTCOUNT usage, its possible that the values will not be correct for the report we're handling, resulting in an incorrect value fo

[PATCH] HID: wacom: Add support for Cintiq Companion 2

2015-10-07 Thread Jason Gerecke
Signed-off-by: Jason Gerecke Signed-off-by: Clifford Jolly --- drivers/hid/wacom_sys.c | 2 +- drivers/hid/wacom_wac.c | 41 - drivers/hid/wacom_wac.h | 1 + 3 files changed, 42 insertions(+), 2 deletions(-) diff --git a/drivers/hid/wacom_sys.c b/driver

Re: [PATCH] HID: wacom: Add support for Cintiq Companion 2

2015-10-07 Thread Bastien Nocera
On Wed, 2015-10-07 at 16:55 -0700, Jason Gerecke wrote: > Signed-off-by: Jason Gerecke > Signed-off-by: Clifford Jolly Is that support for using the Cintiq Companion 2 as an accessory (eg. still running Windows on the machine, and plugging it in to a Linux machine), or for the Wacom device insid

Re: [PATCH v2] HID: multitouch: Fetch feature reports on demand for Win8 devices

2015-10-07 Thread Andrew Duggan
On 10/07/2015 08:56 AM, Seth Forshee wrote: On Wed, Oct 07, 2015 at 09:34:10AM -0400, Benjamin Tissoires wrote: [sorry for the late answer Jiri, I was on vacations last week] On Oct 07 2015 or thereabouts, Mika Westerberg wrote: Some newer Intel Skylake based Dell laptops with Win8 precision

Re: [PATCH] HID: wacom: Add support for Cintiq Companion 2

2015-10-07 Thread Cliff Jolly
This applies to both. When running as a standalone tablet, all the tablet input devices still go through the usb system. The different modes show the same usb vendor and product IDs and seem to behave identically in the testing I've done. Sorry for the multiple-message spam. On Wed, Oct 7, 2015 a