[PATCH v4 01/24] pwm: rcar: make use of pwm_is_enabled()

Commit 5c31252c4a86 ("pwm: Add the pwm_is_enabled() helper") introduced a new function to test whether a PWM device is enabled or not without manipulating PWM internal fields. Hiding this is necessary if we want to smoothly move to the atomic PWM config approach without impacting PWM drivers. Fix t

[PATCH v4 04/24] hwmon: pwm-fan: use pwm_get_xxx() helpers where appropriate

Use pwm_get_xxx() helpers instead of directly accessing the pwm->xxx field. Doing that will ease adaptation of the PWM framework to support atomic update. Signed-off-by: Boris Brezillon --- Patch generated with the following coccinelle script: --->8--- virtual patch @@ struct pwm_device *p; exp

[PATCH v4 20/24] pwm: add the core infrastructure to allow atomic update

Add an ->apply() method to the pwm_ops struct to allow PWM drivers to implement atomic update. This method will be preferred over the ->enable(), ->disable() and ->config() methods if available. Add the pwm_get_state(), pwm_get_default_state() and pwm_apply_state() functions for PWM users to be ab

[PATCH v4 23/24] pwm: rockchip: add support for atomic update

Implement the ->apply() function to add support for atomic update. Signed-off-by: Boris Brezillon Tested-by: Heiko Stuebner --- drivers/pwm/pwm-rockchip.c | 53 +- 1 file changed, 29 insertions(+), 24 deletions(-) diff --git a/drivers/pwm/pwm-rockchi

[PATCH v4 21/24] pwm: add information about polarity, duty cycle and period to debugfs

From: Heiko Stübner The pwm-states make it possible to also output the polarity, duty cycle and period information in the debugfs pwm summary-outout. This makes it easier to gather overview information about pwms without needing to walk through the sysfs attributes of every pwm. Signed-off-by: H

[PATCH v4 24/24] regulator: pwm: properly initialize the ->state field

The ->state field is currently initialized to 0, thus referencing the voltage selector at index 0, which might not reflect the current voltage value. If possible, retrieve the current voltage selector from the PWM state, else return -EINVAL. Signed-off-by: Boris Brezillon Tested-by: Heiko Stuebne

[PATCH v4 22/24] pwm: rockchip: add initial state retrieval

Implement the ->reset_state() function to expose initial state. Signed-off-by: Boris Brezillon Tested-by: Heiko Stuebner --- drivers/pwm/pwm-rockchip.c | 66 ++ 1 file changed, 66 insertions(+) diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pw

[PATCH v4 19/24] pwm: add the PWM initial state retrieval infra

Add a ->reset_state() function to the pwm_ops struct to let PWM drivers initialize the PWM state attached to a PWM device. Signed-off-by: Boris Brezillon Tested-by: Heiko Stuebner --- drivers/pwm/core.c | 3 +++ include/linux/pwm.h | 4 2 files changed, 7 insertions(+) diff --git a/drive

[PATCH v4 18/24] pwm: declare a default PWM state

Prepare the addition of the PWM initial state retrieval by adding a default state where all the parameters retrieved from DT, platform data or statically forced by the hardware will be stored. Once done we will be able to store the initial state in the ->state field without risking to loose the def

[PATCH v4 17/24] backlight: pwm_bl: remove useless call to pwm_set_period

The PWM period will be set when calling pwm_config. Remove this useless call to pwm_set_period, which might mess up with the initial PWM state once we have added proper support for PWM init state retrieval. Signed-off-by: Boris Brezillon Acked-by: Lee Jones --- drivers/video/backlight/pwm_bl.c

[PATCH v4 15/24] pwm: define a new pwm_state struct

The PWM state, represented by its period, duty_cycle and polarity, is currently directly stored in the PWM device. Declare a pwm_state structure embedding those field so that we can later use this struct to atomically update all the PWM parameters at once. Signed-off-by: Boris Brezillon --- driv

[PATCH v4 05/24] misc: max77693-haptic: use pwm_get_xxx() helpers where appropriate

Use pwm_get_xxx() helpers instead of directly accessing the pwm->xxx field. Doing that will ease adaptation of the PWM framework to support atomic update. Signed-off-by: Boris Brezillon --- Patch generated with the following coccinelle script: --->8--- virtual patch @@ struct pwm_device *p; exp

[PATCH v4 16/24] pwm: move the enabled/disabled info to pwm_state struct

Prepare the transition to PWM atomic update by moving the enabled/disabled state into the pwm_state struct. This way we can easily update the whole PWM state by copying the new state in the ->state field. Signed-off-by: Boris Brezillon Tested-by: Heiko Stuebner --- drivers/pwm/core.c | 17

[PATCH v4 14/24] clk: pwm: use pwm_get/set_default_xxx() helpers where appropriate

pwm_set/get_default_xxx() helpers have been introduced to differentiate the default PWM states (those retrieved through DT, PWM lookup table or statically assigned by the driver) and the current ones. Make use of those helpers where appropriate. Signed-off-by: Boris Brezillon --- drivers/clk/clk

[PATCH v4 13/24] hwmon: pwm-fan: use pwm_get/set_default_xxx() helpers where appropriate

pwm_set/get_default_xxx() helpers have been introduced to differentiate the default PWM states (those retrieved through DT, PWM lookup table or statically assigned by the driver) and the current ones. Make use of those helpers where appropriate. Signed-off-by: Boris Brezillon --- drivers/hwmon/p

[PATCH v4 06/24] pwm: introduce default period and polarity concepts

When requested by a user, the PWM is assigned a default period and polarity extracted from the DT, the platform data or statically set by the driver. Those default values are currently stored in the period and polarity fields of the pwm_device struct, but they will be stored somewhere else once we

[PATCH v4 02/24] pwm: use pwm_get_xxx() helpers where appropriate

Use pwm_get_xxx() helpers instead of directly accessing the pwm->xxx field. Doing that will ease adaptation of the PWM framework to support atomic update. Signed-off-by: Boris Brezillon --- Patch generated with the following coccinelle script: --->8--- virtual patch @@ struct pwm_device *p; exp

[PATCH v4 08/24] leds: pwm: use pwm_get/set_default_xxx() helpers where appropriate

pwm_set/get_default_xxx() helpers have been introduced to differentiate the default PWM states (those retrieved through DT, PWM lookup table or statically assigned by the driver) and the current ones. Make use of those helpers where appropriate. Signed-off-by: Boris Brezillon Acked-by: Jacek Anas

[PATCH v4 09/24] regulator: pwm: use pwm_get/set_default_xxx() helpers where appropriate

pwm_set/get_default_xxx() helpers have been introduced to differentiate the default PWM states (those retrieved through DT, PWM lookup table or statically assigned by the driver) and the current ones. Make use of those helpers where appropriate. Signed-off-by: Boris Brezillon Tested-by: Heiko Stu

[PATCH v4 12/24] misc: max77693: use pwm_get/set_default_xxx() helpers where appropriate

pwm_set/get_default_xxx() helpers have been introduced to differentiate the default PWM states (those retrieved through DT, PWM lookup table or statically assigned by the driver) and the current ones. Make use of those helpers where appropriate. Signed-off-by: Boris Brezillon --- drivers/input/m

[PATCH v4 10/24] backlight: pwm: use pwm_get/set_default_xxx() helpers where appropriate

pwm_set/get_default_xxx() helpers have been introduced to differentiate the default PWM states (those retrieved through DT, PWM lookup table or statically assigned by the driver) and the current ones. Make use of those helpers where appropriate. Signed-off-by: Boris Brezillon Acked-by: Lee Jones

[PATCH v4 11/24] fbdev: use pwm_get/set_default_xxx() helpers where appropriate

pwm_set/get_default_xxx() helpers have been introduced to differentiate the default PWM states (those retrieved through DT, PWM lookup table or statically assigned by the driver) and the current ones. Make use of those helpers where appropriate. Signed-off-by: Boris Brezillon --- drivers/video/f

[PATCH v4 07/24] pwm: use pwm_get/set_default_xxx() helpers where appropriate

pwm_set/get_default_xxx() helpers have been introduced to differentiate the default PWM states (those retrieved through DT, PWM lookup table or statically assigned by the driver) and the current PWM ones. Make use of those helpers where appropriate. Signed-off-by: Boris Brezillon Tested-by: Heiko

[PATCH v4 03/24] clk: pwm: use pwm_get_xxx() helpers where appropriate

Use pwm_get_xxx() helpers instead of directly accessing the pwm->xxx field. Doing that will ease adaptation of the PWM framework to support atomic update. Signed-off-by: Boris Brezillon --- Patch generated with the following coccinelle script: --->8--- virtual patch @@ struct pwm_device *p; exp

[PATCH v4 00/24] pwm: add support for atomic update

Hello, This series adds support for atomic PWM update, or IOW, the capability to update all the parameters of a PWM device (enabled/disabled, period, duty and polarity) in one go. Best Regards, Boris Changes since v3: - rebased on pwm/for-next after pulling 4.4-rc1 - replace direct access to pw

Re: [PATCH v4 09/24] regulator: pwm: use pwm_get/set_default_xxx() helpers where appropriate

On Mon, Nov 16, 2015 at 09:56:32AM +0100, Boris Brezillon wrote: > +++ b/drivers/regulator/pwm-regulator.c > @@ -56,7 +56,7 @@ static int pwm_regulator_set_voltage_sel(struct > regulator_dev *rdev, > int dutycycle; > int ret; > > - pwm_reg_period = pwm_get_period(drvdata->pwm);

[PATCH v8 7/8] ARM: dts: imx25: Add TSC and ADC support

From: Denis Carikli Signed-off-by: Denis Carikli Signed-off-by: Markus Pargmann --- arch/arm/boot/dts/imx25.dtsi | 30 +++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi index 677f81d9dcd5..7

[PATCH v8 2/8] ARM: dt: Binding documentation for imx25 GCQ

The documentation describes the bindings for the imx25 GCQ unit which is essentially a generic conversion queue using the imx25 ADC. Signed-off-by: Markus Pargmann --- Notes: Changes in v6: - Changed bindings to use adc-refp and adc-refn. Also a bit of cleanup in the setup routi

[PATCH v8 0/8] imx25 adc and touchscreen driver

Hi, welcome to the next round of the never ending series ;). The last version v7 was sent roughly 8 months ago. The first version at least 1.5 years ago. This series adds two drivers for ADC and TSC of the imx25 and a MFD driver to connect these. Due to the larger changes in this version I had t

[PATCH v8 4/8] mfd: fsl imx25 Touchscreen ADC driver

This is the core driver for imx25 touchscreen/adc driver. The module has one shared ADC and two different conversion queues which use the ADC. The two queues are identical. Both can be used for general purpose ADC but one is meant to be used for touchscreens. This driver is the core which manages

[PATCH v8 3/8] ARM: dt: Binding documentation for imx25 touchscreen controller

This is the touchscreen conversion queue binding documentation. It uses the shared imx25 ADC. Signed-off-by: Markus Pargmann --- Notes: Changes in v5: - Fix signed/unsigned comparison - Fix unused variable settling_time by putting it in the correct argument list - Use contino

[PATCH v8 8/8] ARM: imx_v4_v5_defconfig: Add I.MX25 Touchscreen controller and ADC support.

From: Denis Carikli Signed-off-by: Denis Carikli Signed-off-by: Markus Pargmann --- arch/arm/configs/imx_v4_v5_defconfig | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/configs/imx_v4_v5_defconfig b/arch/arm/configs/imx_v4_v5_defconfig index d3a8018639de..d6754ac47788 100644

[PATCH v8 6/8] input: touchscreen: imx25 tcq driver

This is a driver for the imx25 ADC/TSC module. It controls the touchscreen conversion queue and creates a touchscreen input device. The driver currently only supports 4 wire touchscreens. The driver uses a simple conversion queue of precharge, touch detection, X measurement, Y measurement, precharg

[PATCH v8 1/8] ARM: dt: Binding documentation for imx25 ADC/TSC

This documentation describes the devicetree bindings for the ADC/Touchscreen unit of the i.MX25 SoC. Signed-off-by: Markus Pargmann Acked-by: Jonathan Cameron --- Notes: Changes in v6: - Removed adc-ref property and replaced it with refp and refn for positive and negative refer

[PATCH v8 5/8] iio: adc: fsl,imx25-gcq driver

This is a conversion queue driver for the mx25 SoC. It uses the central ADC which is used by two seperate independent queues. This driver prepares different conversion configurations for each possible input. For a conversion it creates a conversionqueue of one item with the correct configuration fo

Re: [PATCH v4 09/24] regulator: pwm: use pwm_get/set_default_xxx() helpers where appropriate

Hi Mark, On Mon, 16 Nov 2015 10:55:58 + Mark Brown wrote: > On Mon, Nov 16, 2015 at 09:56:32AM +0100, Boris Brezillon wrote: > > > +++ b/drivers/regulator/pwm-regulator.c > > @@ -56,7 +56,7 @@ static int pwm_regulator_set_voltage_sel(struct > > regulator_dev *rdev, > > int dutycycle; >

Re: [PATCH v4 05/24] misc: max77693-haptic: use pwm_get_xxx() helpers where appropriate

W dniu 16.11.2015 o 17:56, Boris Brezillon pisze: > Use pwm_get_xxx() helpers instead of directly accessing the pwm->xxx field. > Doing that will ease adaptation of the PWM framework to support atomic > update. > > Signed-off-by: Boris Brezillon > --- > Patch generated with the following coccinel

Re: [PATCH v8 1/8] ARM: dt: Binding documentation for imx25 ADC/TSC

On Mon, Nov 16, 2015 at 01:01:02PM +0100, Markus Pargmann wrote: > This documentation describes the devicetree bindings for the > ADC/Touchscreen unit of the i.MX25 SoC. > > Signed-off-by: Markus Pargmann > Acked-by: Jonathan Cameron Acked-by: Rob Herring > --- > > Notes: > Changes in v6

Re: [PATCH v4 05/24] misc: max77693-haptic: use pwm_get_xxx() helpers where appropriate

Hi Krzysztof, On Mon, 16 Nov 2015 22:10:40 +0900 Krzysztof Kozlowski wrote: > W dniu 16.11.2015 o 17:56, Boris Brezillon pisze: > > Use pwm_get_xxx() helpers instead of directly accessing the pwm->xxx field. > > Doing that will ease adaptation of the PWM framework to support atomic > > update. >

Re: [PATCH v8 3/8] ARM: dt: Binding documentation for imx25 touchscreen controller

On Mon, Nov 16, 2015 at 01:01:04PM +0100, Markus Pargmann wrote: > This is the touchscreen conversion queue binding documentation. It uses > the shared imx25 ADC. > > Signed-off-by: Markus Pargmann > --- > > Notes: > Changes in v5: > - Fix signed/unsigned comparison > - Fix unused

Re: [PATCH v2 8/8] DT:omap3+ads7846: use new common touchscreen bindings

Hi, On Fri, Nov 13, 2015 at 10:35 PM, H. Nikolaus Schaller wrote: > The standard touch screen bindings [1] replace the private ti,swap-xy > with touchscreen-swaped-x-y. And for the Openpandora we use > touchscreen-size etc. to match the LCD screen size. > > [1]: Documentation/devicetree/bindings/

Re: [PATCH v4 00/24] pwm: add support for atomic update

Hi Boris, Am Montag, 16. November 2015, 09:56:23 schrieb Boris Brezillon: > Hello, > > This series adds support for atomic PWM update, or IOW, the capability > to update all the parameters of a PWM device (enabled/disabled, period, > duty and polarity) in one go. you already include my tested-by

Re: [PATCH v8 2/8] ARM: dt: Binding documentation for imx25 GCQ

On Mon, Nov 16, 2015 at 01:01:03PM +0100, Markus Pargmann wrote: > The documentation describes the bindings for the imx25 GCQ unit which is > essentially a generic conversion queue using the imx25 ADC. > > Signed-off-by: Markus Pargmann > --- > > Notes: > Changes in v6: > - Changed bind

Re: [PATCH v2] hid: enable hid device to suspend/resume asynchronously

Hi Jiri, Any comments about this patch? After enabling the HID devices suspend/resume asynchronously on ASUS T100TA(Baytrail-T platform), the system suspend-to-idle/resume time is reduced about 20ms. Although this improvement is not very significant. But, if the suspend/resume operation of HI

Re: [PATCH v2] hid: enable hid device to suspend/resume asynchronously

On Mon, 16 Nov 2015, Fu, Zhonghui wrote: > > Hi Jiri, > > Any comments about this patch? > > After enabling the HID devices suspend/resume asynchronously on ASUS > T100TA(Baytrail-T platform), the system suspend-to-idle/resume time is > reduced about 20ms. Although this improvement is not ver

Re: [PATCH v2 8/8] DT:omap3+ads7846: use new common touchscreen bindings

HI, Am 16.11.2015 um 15:37 schrieb Grazvydas Ignotas : > Hi, > > On Fri, Nov 13, 2015 at 10:35 PM, H. Nikolaus Schaller > wrote: >> The standard touch screen bindings [1] replace the private ti,swap-xy >> with touchscreen-swaped-x-y. And for the Openpandora we use >> touchscreen-size etc. to ma

Re: [PATCH] Input: pixcir_i2c_ts: add wake and enable gpios

On Sun, Nov 15, 2015 at 04:56:43PM +0100, Sander Vermin wrote: > This patch improves the pixcir_i2c_ts touchscreen controller which is used by > the POV PROTAB2 tablet. > > On POV PROTAB2 tablet the WAKE and ENABLE gpios are used, and the screen is > rotated, so touchscreen-inverted-x and touchs

Re: [PATCH] input: st1232.c: Add devicetree attributes

On Sun, Nov 15, 2015 at 05:20:47PM +0100, Sander Vermin wrote: > Add support for rotating and inverted axis for the Sitronix ST1232 > touchscreen controller. > > For the rotation of the touchscreen the devicetree resolution propteries are > requierd. For this purpose the following devicetree map

Re: [PATCH v4 05/24] misc: max77693-haptic: use pwm_get_xxx() helpers where appropriate

On 11/16/2015 05:55 AM, Boris Brezillon wrote: Hi Krzysztof, On Mon, 16 Nov 2015 22:10:40 +0900 Krzysztof Kozlowski wrote: W dniu 16.11.2015 o 17:56, Boris Brezillon pisze: Use pwm_get_xxx() helpers instead of directly accessing the pwm->xxx field. Doing that will ease adaptation of the PWM

Re: [PATCH v4 04/24] hwmon: pwm-fan: use pwm_get_xxx() helpers where appropriate

On 11/16/2015 12:56 AM, Boris Brezillon wrote: Use pwm_get_xxx() helpers instead of directly accessing the pwm->xxx field. Doing that will ease adaptation of the PWM framework to support atomic update. Signed-off-by: Boris Brezillon --- Patch generated with the following coccinelle script: ---

Re: [PATCH v4 05/24] misc: max77693-haptic: use pwm_get_xxx() helpers where appropriate

On Mon, 16 Nov 2015 07:55:33 -0800 Guenter Roeck wrote: > On 11/16/2015 05:55 AM, Boris Brezillon wrote: > > Hi Krzysztof, > > > > On Mon, 16 Nov 2015 22:10:40 +0900 > > Krzysztof Kozlowski wrote: > > > >> W dniu 16.11.2015 o 17:56, Boris Brezillon pisze: > >>> Use pwm_get_xxx() helpers instead

Re: [PATCH v4 13/24] hwmon: pwm-fan: use pwm_get/set_default_xxx() helpers where appropriate

On 11/16/2015 12:56 AM, Boris Brezillon wrote: pwm_set/get_default_xxx() helpers have been introduced to differentiate the default PWM states (those retrieved through DT, PWM lookup table or statically assigned by the driver) and the current ones. Make use of those helpers where appropriate. Sig

Re: [PATCH v4 04/24] hwmon: pwm-fan: use pwm_get_xxx() helpers where appropriate

On Mon, 16 Nov 2015 07:59:23 -0800 Guenter Roeck wrote: > On 11/16/2015 12:56 AM, Boris Brezillon wrote: > > Use pwm_get_xxx() helpers instead of directly accessing the pwm->xxx field. > > Doing that will ease adaptation of the PWM framework to support atomic > > update. > > > > Signed-off-by: Bo

Re: [PATCH v4 04/24] hwmon: pwm-fan: use pwm_get_xxx() helpers where appropriate

On 11/16/2015 08:53 AM, Boris Brezillon wrote: On Mon, 16 Nov 2015 07:59:23 -0800 Guenter Roeck wrote: On 11/16/2015 12:56 AM, Boris Brezillon wrote: Use pwm_get_xxx() helpers instead of directly accessing the pwm->xxx field. Doing that will ease adaptation of the PWM framework to support ato

Re: [PATCH v4 02/24] pwm: use pwm_get_xxx() helpers where appropriate

Hi Boris (Adding Ariel for pwm-lpc18xx-sct) On 16 November 2015 at 09:56, Boris Brezillon wrote: > Use pwm_get_xxx() helpers instead of directly accessing the pwm->xxx field. > Doing that will ease adaptation of the PWM framework to support atomic > update. > > Signed-off-by: Boris Brezillon >

Re: [PATCH v4 02/24] pwm: use pwm_get_xxx() helpers where appropriate

Hi Joachim, On Mon, 16 Nov 2015 18:46:44 +0100 Joachim Eastwood wrote: > Hi Boris > > (Adding Ariel for pwm-lpc18xx-sct) > > On 16 November 2015 at 09:56, Boris Brezillon > wrote: > > Use pwm_get_xxx() helpers instead of directly accessing the pwm->xxx field. > > Doing that will ease adaptat

Re: [PATCH v4 09/24] regulator: pwm: use pwm_get/set_default_xxx() helpers where appropriate

On Mon, Nov 16, 2015 at 01:23:59PM +0100, Boris Brezillon wrote: > Mark Brown wrote: > > On Mon, Nov 16, 2015 at 09:56:32AM +0100, Boris Brezillon wrote: > > > - pwm_reg_period = pwm_get_period(drvdata->pwm); > > > + pwm_reg_period = pwm_get_default_period(drvdata->pwm); > > It's not clear to me

Re: [PATCH v4 09/24] regulator: pwm: use pwm_get/set_default_xxx() helpers where appropriate

On Mon, 16 Nov 2015 18:42:38 + Mark Brown wrote: > On Mon, Nov 16, 2015 at 01:23:59PM +0100, Boris Brezillon wrote: > > Mark Brown wrote: > > > On Mon, Nov 16, 2015 at 09:56:32AM +0100, Boris Brezillon wrote: > > > > > - pwm_reg_period = pwm_get_period(drvdata->pwm); > > > > + p

Re: drivers/hid/wacom_wac.c:2484: bad if test ?

On Mon, 16 Nov 2015, David Binderman wrote: > Hello there, > > drivers/hid/wacom_wac.c:2484:35: warning: logical ‘or’ of collectively > exhaustive tests is always true [-Wlogical-op] > > Source code is > > if (features->type>= INTUOSHT || features->type <= BAMBOO_PT) Good catch, that code is

[PATCHv3] Input: xpad - Fix double URB submission races

The xpad driver has several races with respect to URB submission which make it easy to end up with submission while active: [ cut here ] WARNING: CPU: 3 PID: 3563 at drivers/usb/core/urb.c:339 usb_submit_urb+0x2ad/0x5a0() URB 8804078ac240 submitted while active CPU: 3 P

Re: drivers/hid/wacom_wac.c:2484: bad if test ?

Oh, boy! It should be: if (features->type>= INTUOSHT && features->type <= BAMBOO_PT) Thank you David for your sharp eyes ;-). Jiri, Can you fix it upstream or do you need a patch from me? Ping On Mon, Nov 16, 2015 at 2:39 PM, Jiri Kosina wrote: > On Mon, 16 Nov 2015, David Binderman wrote:

Re: drivers/hid/wacom_wac.c:2484: bad if test ?

On Mon, 16 Nov 2015, Ping Cheng wrote: > Oh, boy! It should be: > > if (features->type>= INTUOSHT && features->type <= BAMBOO_PT) > > Thank you David for your sharp eyes ;-). > > Jiri, > > Can you fix it upstream or do you need a patch from me? Yup, I have already comitted fix with David's R

Re: [PATCH v8 2/8] ARM: dt: Binding documentation for imx25 GCQ

On Monday 16 November 2015 09:12:55 Rob Herring wrote: > On Mon, Nov 16, 2015 at 01:01:03PM +0100, Markus Pargmann wrote: > > The documentation describes the bindings for the imx25 GCQ unit which is > > essentially a generic conversion queue using the imx25 ADC. > > > > Signed-off-by: Markus Pargm